vellum 0.2.7 → 0.2.9

package/src/calls/__tests__/twilio-webhook-urls.test.ts

@@ -1,162 +0,0 @@
-import { describe, test, expect, beforeEach, afterEach, mock } from 'bun:test';
-
-// ---------------------------------------------------------------------------
-// Mocks — silence logger output during tests
-// ---------------------------------------------------------------------------
-
-function makeLoggerStub(): Record<string, unknown> {
-  const stub: Record<string, unknown> = {};
-  for (const m of ['info', 'warn', 'error', 'debug', 'trace', 'fatal', 'silent', 'child']) {
-    stub[m] = m === 'child' ? () => makeLoggerStub() : () => {};
-  }
-  return stub;
-}
-
-mock.module('../../util/logger.js', () => ({
-  getLogger: () => makeLoggerStub(),
-}));
-
-import {
-  normalizeBaseUrl,
-  buildTwilioVoiceWebhookUrl,
-  buildTwilioStatusCallbackUrl,
-  getWebhookBaseUrl,
-} from '../twilio-webhook-urls.js';
-
-// ---------------------------------------------------------------------------
-// normalizeBaseUrl
-// ---------------------------------------------------------------------------
-
-describe('normalizeBaseUrl', () => {
-  test('returns already-clean URL unchanged', () => {
-    expect(normalizeBaseUrl('https://example.com')).toBe('https://example.com');
-  });
-
-  test('strips trailing slash', () => {
-    expect(normalizeBaseUrl('https://example.com/')).toBe('https://example.com');
-  });
-
-  test('strips multiple trailing slashes', () => {
-    expect(normalizeBaseUrl('https://example.com///')).toBe('https://example.com');
-  });
-
-  test('trims leading and trailing whitespace', () => {
-    expect(normalizeBaseUrl('  https://example.com  ')).toBe('https://example.com');
-  });
-
-  test('trims whitespace and strips trailing slash together', () => {
-    expect(normalizeBaseUrl('  https://example.com/  ')).toBe('https://example.com');
-  });
-});
-
-// ---------------------------------------------------------------------------
-// buildTwilioVoiceWebhookUrl
-// ---------------------------------------------------------------------------
-
-describe('buildTwilioVoiceWebhookUrl', () => {
-  test('returns correct URL with callSessionId', () => {
-    const url = buildTwilioVoiceWebhookUrl('https://example.com', 'session-123');
-    expect(url).toBe('https://example.com/webhooks/twilio/voice?callSessionId=session-123');
-  });
-
-  test('normalizes base URL before composing', () => {
-    const url = buildTwilioVoiceWebhookUrl('https://example.com/', 'abc');
-    expect(url).toBe('https://example.com/webhooks/twilio/voice?callSessionId=abc');
-  });
-});
-
-// ---------------------------------------------------------------------------
-// buildTwilioStatusCallbackUrl
-// ---------------------------------------------------------------------------
-
-describe('buildTwilioStatusCallbackUrl', () => {
-  test('returns correct URL', () => {
-    const url = buildTwilioStatusCallbackUrl('https://example.com');
-    expect(url).toBe('https://example.com/webhooks/twilio/status');
-  });
-
-  test('normalizes base URL before composing', () => {
-    const url = buildTwilioStatusCallbackUrl('https://example.com/');
-    expect(url).toBe('https://example.com/webhooks/twilio/status');
-  });
-});
-
-// ---------------------------------------------------------------------------
-// getWebhookBaseUrl
-// ---------------------------------------------------------------------------
-
-describe('getWebhookBaseUrl', () => {
-  let savedEnv: string | undefined;
-
-  beforeEach(() => {
-    savedEnv = process.env.TWILIO_WEBHOOK_BASE_URL;
-    delete process.env.TWILIO_WEBHOOK_BASE_URL;
-  });
-
-  afterEach(() => {
-    if (savedEnv !== undefined) {
-      process.env.TWILIO_WEBHOOK_BASE_URL = savedEnv;
-    } else {
-      delete process.env.TWILIO_WEBHOOK_BASE_URL;
-    }
-  });
-
-  test('uses config value when set', () => {
-    const result = getWebhookBaseUrl({ calls: { webhookBaseUrl: 'https://config.example.com/' } });
-    expect(result).toBe('https://config.example.com');
-  });
-
-  test('falls back to env var when config value is empty', () => {
-    process.env.TWILIO_WEBHOOK_BASE_URL = 'https://env.example.com/';
-    const result = getWebhookBaseUrl({ calls: { webhookBaseUrl: '' } });
-    expect(result).toBe('https://env.example.com');
-  });
-
-  test('falls back to env var when config value is undefined', () => {
-    process.env.TWILIO_WEBHOOK_BASE_URL = 'https://env.example.com';
-    const result = getWebhookBaseUrl({ calls: {} });
-    expect(result).toBe('https://env.example.com');
-  });
-
-  test('throws when neither config nor env var is set', () => {
-    expect(() => getWebhookBaseUrl({ calls: { webhookBaseUrl: '' } })).toThrow(
-      /No webhook base URL configured/,
-    );
-  });
-
-  test('throws when config is undefined and env var is unset', () => {
-    expect(() => getWebhookBaseUrl({ calls: {} })).toThrow(
-      /No webhook base URL configured/,
-    );
-  });
-
-  test('normalizes the returned URL', () => {
-    const result = getWebhookBaseUrl({ calls: { webhookBaseUrl: '  https://example.com/  ' } });
-    expect(result).toBe('https://example.com');
-  });
-
-  test('falls through when config value is whitespace-only', () => {
-    process.env.TWILIO_WEBHOOK_BASE_URL = 'https://env.example.com';
-    const result = getWebhookBaseUrl({ calls: { webhookBaseUrl: '   ' } });
-    expect(result).toBe('https://env.example.com');
-  });
-
-  test('falls through when config value is slash-only', () => {
-    process.env.TWILIO_WEBHOOK_BASE_URL = 'https://env.example.com';
-    const result = getWebhookBaseUrl({ calls: { webhookBaseUrl: '///' } });
-    expect(result).toBe('https://env.example.com');
-  });
-
-  test('throws when config is whitespace-only and env var is unset', () => {
-    expect(() => getWebhookBaseUrl({ calls: { webhookBaseUrl: '   ' } })).toThrow(
-      /No webhook base URL configured/,
-    );
-  });
-
-  test('throws when env var is whitespace-only and config is empty', () => {
-    process.env.TWILIO_WEBHOOK_BASE_URL = '   ';
-    expect(() => getWebhookBaseUrl({ calls: {} })).toThrow(
-      /No webhook base URL configured/,
-    );
-  });
-});

package/src/calls/twilio-webhook-urls.ts

@@ -1,50 +0,0 @@
-import { getLogger } from '../util/logger.js';
-
-const log = getLogger('twilio-webhook-urls');
-
-/**
- * Resolve the webhook base URL from config, falling back to the
- * TWILIO_WEBHOOK_BASE_URL environment variable with a deprecation warning.
- * Throws if neither source provides a value.
- */
-export function getWebhookBaseUrl(config: { calls: { webhookBaseUrl?: string } }): string {
-  const configValue = config.calls.webhookBaseUrl;
-  if (configValue) {
-    const normalized = normalizeBaseUrl(configValue);
-    if (normalized) return normalized;
-  }
-
-  const envValue = process.env.TWILIO_WEBHOOK_BASE_URL;
-  if (envValue) {
-    log.warn(
-      'TWILIO_WEBHOOK_BASE_URL env var is deprecated — set calls.webhookBaseUrl in config instead.',
-    );
-    const normalized = normalizeBaseUrl(envValue);
-    if (normalized) return normalized;
-  }
-
-  throw new Error(
-    'No webhook base URL configured. Set calls.webhookBaseUrl in config or TWILIO_WEBHOOK_BASE_URL env var.',
-  );
-}
-
-/**
- * Trim whitespace and strip trailing slash from a URL string.
- */
-export function normalizeBaseUrl(url: string): string {
-  return url.trim().replace(/\/+$/, '');
-}
-
-/**
- * Build the Twilio voice webhook URL for a given call session.
- */
-export function buildTwilioVoiceWebhookUrl(baseUrl: string, callSessionId: string): string {
-  return `${normalizeBaseUrl(baseUrl)}/webhooks/twilio/voice?callSessionId=${callSessionId}`;
-}
-
-/**
- * Build the Twilio status callback URL.
- */
-export function buildTwilioStatusCallbackUrl(baseUrl: string): string {
-  return `${normalizeBaseUrl(baseUrl)}/webhooks/twilio/status`;
-}