vantage-peers-mcp 2.3.3 → 2.3.4

package/CHANGELOG.md

@@ -1,26 +1,17 @@
 # Changelog
 
-## v2.3.3 — 2026-05-28
+## v2.3.4 — 2026-05-28
 
-**Follow-up to v2.3.2 (Day 84 scope élargi)** — Extend list queries with `createdBy` + `updatedSince` filters + auto-clamp safeguard.
+**Security fix** — DCR (Dynamic Client Registration) self-registration now defaults to tenant-scope only. Master scope requires explicit admin authorization (`ADMIN_DCR_TOKEN` / `BEARER_SECRET_MASTER` env var). Closes beta blocker for Marie/Iris RH onboarding identified in VP Cloud audit Day 84.
 
-Backend (Convex) :
-- `tasks.list` + `tasks.listByMission` : + `createdBy` (filter by task creator) + `updatedSince` (Unix ms window) + auto-clamp limit=30 when `fields="full"` and no explicit limit
-- `missions.list` : + `updatedSince` + auto-clamp (30)
-- `briefingNotes.list` : + `updatedSince` + auto-clamp (15 when fields=full)
+Changes:
+- `convex/oauth.ts`: `registerPublicClient` now explicitly rejects `scopeProfile="master"` with a `ScopeViolation` error. Previously only the HTTP server enforced this; the Convex-layer was bypassable via direct internal call.
+- `mcp-server/src/auth.ts`: bearer layer 3 (DCR token path) no longer maps `mcp:full` scope string to `scopeProfile="master"`. DCR tokens now always resolve to `client-generic` (deny-by-default). The `mcp:full` label in the legacy `oauthTokens` table was a scope label, not an authorization grant.
+- `convex/oauthDcr.ts`: added security documentation clarifying the legacy table is no longer an escalation path; the auth middleware fix is the primary gate.
 
-MCP wrapper :
-- 4 list tools forward the new params
-- New export `updatedSinceSchema` (positive integer ms)
-- `limit` `.default()` removed on the 4 list tools so absent limit flows to backend → enables auto-clamp
+Tests: 5 new Convex security tests (`convex/oauth-dcr-security.test.ts`) + 5 new MCP scope enforcement tests (`mcp-server/src/__tests__/dcr-scope-enforcement.test.ts`), 0 regression on existing suites.
 
-Tests : 15 new MCP schema cases (`src/__tests__/list-queries-v2.3.3-createdby-updatedsince.test.ts`) + 6 new Convex round-trip cases.
-
-Pi pull cycle unblocked : `list_tasks createdBy="pi" status="review" fields="lite"` returns only Pi-dispatched tasks recently moved to review, payload 5-10× smaller.
-
-Cap fleet : 0 overflow tolérance future (auto-clamp).
-
-VP task: `k1796s5j6jfkvkx0tn5n926ftd87jx9p`. Successor of `k17e09ng1tf217n93z9m4tr0mx87hfe0` (v2.3.2 PR #537).
+VP task: k17218rvqyncs1v6rwj3qdzfsn87jj4n. Beta unblock chain: DCR fix → 5 quick wins onboarding (seed-profiles + marie-iris-rh client + README VP Cloud + runbook + email).
 
 ## v2.3.2 — 2026-05-28
 

package/dist/src/auth.js

@@ -231,10 +231,18 @@ export function bearerAuthMiddleware() {
                 console.error("[auth] CONVEX_URL_INTERNAL not set — cannot route DCR OAuth token");
                 return c.json({ error: "Server misconfigured: internal deployment URL missing" }, 500);
             }
-            // Map DCR single-scope string → OAuthContext fields.
-            // DCR tokens always carry "mcp:full" which maps to full access.
+            // SECURITY FIX: DCR tokens from the legacy oauthDcr path (oauthTokens
+            // table) carry "mcp:full" as a scope string. Previously this was mapped
+            // to scopeProfile="master" which granted cross-tenant, full-access.
+            // This is the DCR master-scope leak identified in VP Cloud audit Day 84.
+            //
+            // Fix: DCR self-registered clients ALWAYS resolve to "client-generic"
+            // (deny-by-default). "mcp:full" in the legacy table is a scope label, NOT
+            // an authorization to bypass namespace isolation. Master scope is only
+            // granted via the master bearer token path (layer 1) or via the
+            // oauth_access_tokens table with an admin-provisioned scopeProfile
+            // (layer 2). The DCR layer (layer 3) never grants master access.
             const scopes = dcrResult.scope.split(/\s+/).filter(Boolean);
-            const isFull = scopes.includes("mcp:full");
             c.set("tenant", {
                 tenantName: `dcr:${dcrResult.clientId}`,
                 convexUrl: internalUrl,
@@ -243,10 +251,11 @@ export function bearerAuthMiddleware() {
                 clientId: dcrResult.clientId,
                 userId: dcrResult.clientId,
                 scopes,
-                scopeProfile: isFull ? "master" : "client-generic",
-                fromAllowList: isFull ? ["*"] : [],
-                namespaceReadPrefixes: isFull ? ["*"] : [],
-                namespaceWritePrefixes: isFull ? ["*"] : [],
+                // Always tenant-scoped — never master — regardless of scope string value.
+                scopeProfile: "client-generic",
+                fromAllowList: [],
+                namespaceReadPrefixes: [],
+                namespaceWritePrefixes: [],
                 expiresAt: dcrResult.expiresAt,
                 isMaster: false,
             });

package/dist/src/tools.d.ts

@@ -96,7 +96,6 @@ export declare const fieldsSchema: z.ZodEnum<{
     lite: "lite";
     full: "full";
 }>;
-export declare const updatedSinceSchema: z.ZodNumber;
 export interface ParsedConvexError {
     code: string;
     message: string;

package/dist/src/tools.js

@@ -162,14 +162,6 @@ export const fieldsSchema = z
     .describe('Field projection — "lite" returns compact fields only ' +
     '(typical 5-10× smaller payload for large list scans), ' +
     '"full" (default) returns the full document.');
-// v2.3.3 — Unix timestamp ms filter for "updated since".
-// Pass `Date.now() - 24*60*60*1000` for "last 24h" pattern.
-export const updatedSinceSchema = z
-    .number()
-    .int()
-    .positive()
-    .describe("Unix timestamp (ms) — return only rows whose updatedAt >= this value. " +
-    "Typical usage: Date.now() - 24*60*60*1000 for last-24h window.");
 const mandateStatusSchema = z
     .enum(["requested", "accepted", "in_progress", "delivered", "settled"])
     .describe("Mandate lifecycle status");
@@ -1149,25 +1141,20 @@ export function registerTools(server, convex, oauthCtx) {
             .min(1)
             .max(200)
             .optional()
-            .describe("Maximum number of tasks to return. Default 50 with fields=lite, auto-clamped to 30 when fields=full and no explicit limit (overflow protection)."),
+            .default(50)
+            .describe("Maximum number of tasks to return (default 50)"),
         fields: fieldsSchema
             .optional()
             .describe('Field projection ("lite"|"full")'),
-        createdBy: assigneeSchema
-            .optional()
-            .describe("Filter by task creator (e.g. 'pi' to find Pi-dispatched tasks)"),
-        updatedSince: updatedSinceSchema.optional(),
-    }, async ({ assignedTo, assignedToInstance, status, project, limit, fields, createdBy, updatedSince, }) => {
+    }, async ({ assignedTo, assignedToInstance, status, project, limit, fields, }) => {
         try {
             const tasks = await convex.query("tasks:list", {
                 assignedTo,
                 assignedToInstance,
                 status,
                 project,
-                limit,
+                limit: limit ?? 50,
                 fields,
-                createdBy,
-                updatedSince,
             });
             return {
                 content: [
@@ -1483,23 +1470,18 @@ export function registerTools(server, convex, oauthCtx) {
             .min(1)
             .max(200)
             .optional()
-            .describe("Maximum number of tasks to return. Default 50 with fields=lite, auto-clamped to 30 when fields=full and no explicit limit."),
+            .default(50)
+            .describe("Maximum number of tasks to return (default 50)"),
         fields: fieldsSchema
             .optional()
             .describe('Field projection ("lite"|"full")'),
-        createdBy: assigneeSchema
-            .optional()
-            .describe("Filter by task creator"),
-        updatedSince: updatedSinceSchema.optional(),
-    }, async ({ missionId, status, limit, fields, createdBy, updatedSince }) => {
+    }, async ({ missionId, status, limit, fields }) => {
         try {
             const tasks = await convex.query("tasks:listByMission", {
                 missionId: missionId,
                 status,
-                limit,
+                limit: limit ?? 50,
                 fields,
-                createdBy,
-                updatedSince,
             });
             return {
                 content: [
@@ -1583,20 +1565,19 @@ export function registerTools(server, convex, oauthCtx) {
             .min(1)
             .max(200)
             .optional()
-            .describe("Maximum number of missions to return. Default 50 with fields=lite, auto-clamped to 30 when fields=full and no explicit limit."),
+            .default(50)
+            .describe("Maximum number of missions to return (default 50)"),
         fields: fieldsSchema
             .optional()
             .describe('Field projection ("lite"|"full")'),
-        updatedSince: updatedSinceSchema.optional(),
-    }, async ({ project, pilot, status, limit, fields, updatedSince }) => {
+    }, async ({ project, pilot, status, limit, fields }) => {
         try {
             const missions = await convex.query("missions:list", {
                 project,
                 pilot,
                 status,
-                limit,
+                limit: limit ?? 50,
                 fields,
-                updatedSince,
             });
             return {
                 content: [
@@ -1918,18 +1899,17 @@ export function registerTools(server, convex, oauthCtx) {
             .min(1)
             .max(100)
             .optional()
-            .describe("Maximum notes to return. Default 20 with fields=lite, auto-clamped to 15 when fields=full and no explicit limit."),
+            .default(20)
+            .describe("Maximum notes to return (default 20)"),
         fields: fieldsSchema
             .optional()
             .describe('Field projection ("lite"|"full")'),
-        updatedSince: updatedSinceSchema.optional(),
-    }, async ({ topic, limit, fields, updatedSince }) => {
+    }, async ({ topic, limit, fields }) => {
         try {
             const notes = await convex.query("briefingNotes:list", {
                 topic,
-                limit,
+                limit: limit ?? 20,
                 fields,
-                updatedSince,
             });
             return {
                 content: [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "vantage-peers-mcp",
-  "version": "2.3.3",
+  "version": "2.3.4",
   "description": "MCP server for VantagePeers — shared memory, messaging, and task coordination for AI agent teams",
   "type": "module",
   "main": "./dist/server.js",