valent-pipeline 0.2.20 → 0.2.21

package/skills/valent-run-deferred-tests/SKILL.md

@@ -0,0 +1,109 @@
+---
+name: valent-run-deferred-tests
+description: 'Run deferred iOS tests on a Mac host. Use when the user says "run deferred tests", "run ios tests", or "complete deferred"'
+argument-hint: '<story-id>'
+---
+
+# valent-run-deferred-tests
+
+Run deferred iOS Maestro flows for stories that shipped as SHIP-PARTIAL on a non-Mac host. Requires a Mac with Xcode and iOS Simulator installed.
+
+## Arguments
+
+The user provides a story ID: `STORY-042`
+
+If no argument is provided, scan `{story_output_directory}` for all stories with `ios_deferred: true` in their `mobile-handoff.md` and process them all.
+
+## Execution Steps
+
+### Step 0: Pre-Flight Checks
+
+1. Verify host is Mac: `uname -s` must return `Darwin`
+   - If not Mac: **STOP** with: `This skill requires a Mac with Xcode and iOS Simulator. Current host: {uname output}.`
+2. Verify Xcode tools: `xcrun simctl list devices` must succeed
+   - If fails: **STOP** with: `Xcode command line tools not installed. Run: xcode-select --install`
+3. Verify Maestro installed: `maestro --version` must succeed
+   - If fails: **STOP** with: `Maestro not installed. Install with: curl -Ls "https://get.maestro.mobile.dev" | bash`
+
+### Step 1: Load Pipeline Config
+
+Read `.valent-pipeline/pipeline-config.yaml` for tech stack, project config, and story output directory.
+
+### Step 2: Load Story Artifacts
+
+Read `{story_output_dir}/mobile-handoff.md`. Verify:
+- `ios_deferred: true` in frontmatter
+- `Deferred iOS Tests` section exists with at least one flow listed
+
+If `ios_deferred` is not `true`, **STOP** with: `Story {story_id} does not have deferred iOS tests.`
+
+Read `{story_output_dir}/qa-test-spec.md` for the original test specifications. If ACs have changed since the original run (compare against current repo state), flag the drift and spec against current reality.
+
+### Step 3: Clean Install Dependencies
+
+From repo root:
+- `npm ci` or `yarn install --frozen-lockfile` (Node dependencies)
+- If React Native: `cd ios && pod install && cd ..` (CocoaPods)
+- If Flutter: `flutter pub get`
+
+This is done once, shared across all deferred stories.
+
+### Step 4: Build iOS App
+
+Build the iOS binary from HEAD of `main` (one build, shared across all stories):
+- React Native: `npx react-native build-ios --scheme {scheme} --configuration Debug --simulator`
+- Flutter: `flutter build ios --debug --simulator`
+
+If build fails, **STOP** with build output. This is a blocking issue.
+
+### Step 5: Boot iOS Simulator
+
+Follow emulator lifecycle procedure from `.valent-pipeline/steps/mobile/emulator-lifecycle.md` (iOS section):
+1. `xcrun simctl list devices available` — pick appropriate device
+2. `xcrun simctl boot {device_udid}`
+3. Wait for boot confirmation
+
+Install the built app on the simulator.
+
+### Step 6: Execute Deferred Maestro Flows (Per Story)
+
+For each deferred flow from `mobile-handoff.md#deferred-ios-tests`:
+1. **State isolation:** `xcrun simctl terminate {device_udid} {bundle_id}` + `xcrun simctl privacy {device_udid} reset all {bundle_id}`
+2. **Pre-grant permissions:** per flow requirements
+3. **Execute:** `maestro test {flow_file} --device {ios_simulator_name}`
+4. **Record result:** pass/fail with output
+
+### Step 7: Update Story Artifacts
+
+- Update `mobile-handoff.md`:
+  - Move flows from `Deferred iOS Tests` to `Maestro Flow Files` with iOS results
+  - Update `Platform Coverage` table with iOS results
+  - Update `Test Results Summary` iOS section
+  - Set `ios_deferred: false` in frontmatter if all flows passed
+
+- Update `execution-report.md`:
+  - Add iOS results to the `Mobile Platform Coverage Audit` section
+  - Update platform coverage from `PARTIAL-IOS-DEFERRED` to `FULL` (if all pass)
+
+- If **all deferred flows pass:**
+  - Update `judge-decision.md`: change verdict from `SHIP-PARTIAL` to `SHIP`, update Platform Coverage evidence item to `PASS`, add `SHIP-PARTIAL Detail` noting "Resolved via /run-deferred-tests"
+  - Story transitions from `android-only-verified` → `verified`
+
+- If **any deferred flows fail:**
+  - File bugs in `bugs.md` against current code (routed to next sprint)
+  - Story remains `SHIP-PARTIAL` until bugs are fixed and deferred tests re-run
+  - Update `judge-decision.md` with failure details but do NOT change verdict
+
+### Step 8: Report
+
+Output summary:
+- Stories processed: {count}
+- Per story: flows executed, pass/fail counts, updated verdict
+- If failures: bug IDs filed, recommended next steps
+
+## Notes
+
+- This skill is idempotent — re-running picks up any remaining deferred flows.
+- Deferred flows are the same YAML files MOBILE wrote; they just weren't executed on the original host.
+- The iOS binary is built once from HEAD and shared across all stories. If code has changed significantly since the original run, test failures may reflect current code state, not the original implementation.
+- If processing multiple stories, the simulator stays booted between stories — only app state is cleared.

package/src/commands/db-rebuild.js

@@ -9,6 +9,11 @@ const ARTIFACT_MAP = {
   'qa-test-spec.md': { type: 'qa-test-spec', agent: 'QA-A' },
   'bend-handoff.md': { type: 'bend-handoff', agent: 'BEND' },
   'fend-handoff.md': { type: 'fend-handoff', agent: 'FEND' },
+  'data-handoff.md': { type: 'data-handoff', agent: 'DATA' },
+  'mcp-dev-handoff.md': { type: 'mcp-dev-handoff', agent: 'MCP-DEV' },
+  'libdev-handoff.md': { type: 'libdev-handoff', agent: 'LIBDEV' },
+  'docgen-handoff.md': { type: 'docgen-handoff', agent: 'DOCGEN' },
+  'iac-handoff.md': { type: 'iac-handoff', agent: 'IAC' },
   'critic-review.md': { type: 'critic-review', agent: 'CRITIC' },
   'execution-report.md': { type: 'execution-report', agent: 'QA-B' },
   'bugs.md': { type: 'bugs', agent: 'QA-B' },

package/src/lib/config-schema.js

@@ -116,7 +116,7 @@ export const defaults = {
   },
   models: {
     opus: ['BEND', 'FEND', 'CRITIC'],
-    sonnet: ['REQS', 'UXA', 'QA-A', 'QA-B', 'READINESS', 'JUDGE', 'PMCP', 'Retrospective'],
+    sonnet: ['REQS', 'UXA', 'QA-A', 'QA-B', 'READINESS', 'JUDGE', 'PMCP', 'Retrospective', 'DATA', 'MCP-DEV', 'LIBDEV', 'DOCGEN', 'IAC'],
     haiku: ['Knowledge', 'Embed', 'Help'],
   },
   quality: {

package/src/lib/db.js

@@ -12,7 +12,7 @@ import { existsSync, readFileSync } from 'fs';
 
 // ---------------------------------------------------------------------------
 // Schema DDL — authoritative source. Keep pipeline/scripts/db-bootstrap.ts
-// in sync when modifying (see docs/design/refactor-checklist.md).
+// in sync when modifying (see pipeline/docs/design/refactor-checklist.md).
 // ---------------------------------------------------------------------------
 
 export const SCHEMA_DDL = `