valent-pipeline 0.19.67 → 0.19.68

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "valent-pipeline",
-  "version": "0.19.67",
+  "version": "0.19.68",
   "description": "v3 multi-agent AI pipeline for software development lifecycle",
   "type": "module",
   "bin": {

package/src/commands/check-spec-conformance.js

@@ -3,6 +3,7 @@ import { isAbsolute, join } from 'path';
 import { checkSpecConformance } from '../lib/spec-conformance.js';
 import { evidenceDir, latestRun } from '../lib/evidence.js';
 import { parseJunit } from '../lib/junit.js';
+import { detectManifestCaseDrift } from '../lib/spec-manifest.js';
 
 const DEFAULT_TEST_RE = /\.(test|spec)\.(js|ts|jsx|tsx|mjs|cjs)$/;
 const IGNORE_DIRS = new Set([
@@ -79,6 +80,12 @@ export async function checkSpecConformanceCmd(options) {
     process.exit(2);
   }
 
+  const drift = detectManifestCaseDrift(manifest);
+  if (drift) {
+    console.error(`spec-conformance: ${drift}`);
+    process.exit(1);
+  }
+
   if (!Array.isArray(manifest?.cases) || manifest.cases.length === 0) {
     console.log(`spec-conformance: manifest has no cases — skipping (no-op pass).`);
     process.exit(0);

package/src/commands/trace.js

@@ -11,6 +11,7 @@ import { join, isAbsolute, dirname } from 'path';
 import { traceCheck, traceMatrix } from '../lib/trace.js';
 import { evidenceDir, resolveRunForAssert, requiredCaseIdsForRun, resolveRoot } from '../lib/evidence.js';
 import { parseJunit } from '../lib/junit.js';
+import { detectManifestCaseDrift } from '../lib/spec-manifest.js';
 
 /** Load an exact evidence run by id (for `--run`), or null if absent/unreadable. */
 function loadRunById(evDir, runId) {
@@ -48,6 +49,8 @@ function loadInputs(options) {
   if (!existsSync(specPath)) return { noop: `no spec manifest at ${specPath} — skipping (no-op pass).` };
   const reqsManifest = readJson(reqsPath, 'reqs manifest');
   const specManifest = readJson(specPath, 'spec manifest');
+  const drift = detectManifestCaseDrift(specManifest);
+  if (drift) return { error: drift };
   const cases = Array.isArray(specManifest?.cases) ? specManifest.cases : [];
   if (cases.length > 0 && !cases.some((c) => Array.isArray(c.ac) && c.ac.length > 0)) {
     return { noop: 'spec manifest predates the per-case `ac` field — skipping (no-op pass). Re-run QA-A to gain mechanical AC coverage.' };
@@ -93,6 +96,10 @@ export async function traceCheckCmd(options) {
     process.exit(2);
   }
   const inputs = loadInputs(options);
+  if (inputs.error) {
+    console.error(`trace-check: ${inputs.error}`);
+    process.exit(1);
+  }
   if (inputs.noop) {
     console.log(`trace-check: ${inputs.noop}`);
     process.exit(0);
@@ -108,6 +115,10 @@ export async function traceMatrixCmd(options) {
     process.exit(2);
   }
   const inputs = loadInputs(options);
+  if (inputs.error) {
+    console.error(`trace-matrix: ${inputs.error}`);
+    process.exit(1);
+  }
   if (inputs.noop) {
     console.log(`trace-matrix: ${inputs.noop}`);
     process.exit(0);

package/src/lib/spec-manifest.js

@@ -0,0 +1,30 @@
+// Shared guard against qa-test-spec.manifest.json schema drift (M-223).
+//
+// The canonical manifest carries its spec'd cases under `cases` (pipeline/schemas/qa-spec-manifest.schema.json,
+// `required: ["schema","story","cases"]`). QA-A is an LLM and can drift the key — e.g. emit `testCases` instead
+// of `cases`. The downstream readers (`trace check`, `check-spec-conformance`) then silently see ZERO cases:
+// trace check reports every AC uncovered (a phantom `uncoveredAcs` coverage gap that reads as a real defect),
+// and spec-conformance takes its empty-manifest no-op PASS (masking the drift entirely). Both cost a confused
+// diagnosis + a re-run (3.9, 2026-06-28). The schema existed but was never enforced at ingestion.
+//
+// This detects the specific, recoverable drift — `cases` absent/empty WHILE a case-like array (objects with a
+// string `id`) sits under another top-level key — and returns an actionable message so the gate fails LOUD with
+// the real reason instead of a phantom coverage gap or a vacuous pass. It deliberately does NOT fire for a
+// genuinely empty/absent `cases` (a pre-Phase manifest or a story with no spec'd cases yet) — that stays a
+// legitimate no-op, so this adds a clear failure ONLY where the manifest is populated-but-misnamed. Returns the
+// message string, or null when there is no drift.
+export function detectManifestCaseDrift(manifest) {
+  if (!manifest || typeof manifest !== 'object') return null;
+  if (Array.isArray(manifest.cases) && manifest.cases.length > 0) return null; // canonical + populated
+
+  const caseLike = (arr) => Array.isArray(arr) && arr.length > 0
+    && arr.every((c) => c && typeof c === 'object' && typeof c.id === 'string' && c.id.length > 0);
+  const aliases = Object.keys(manifest).filter((k) => k !== 'cases' && caseLike(manifest[k]));
+  if (!aliases.length) return null; // genuinely empty/absent — legitimate no-op, not drift
+
+  const k = aliases[0];
+  const n = manifest[k].length;
+  return `no populated \`cases\` array but found ${n} case-like entr${n === 1 ? 'y' : 'ies'} under \`${k}\` `
+    + `— qa-test-spec.manifest.json schema drift (the canonical key is \`cases\`). Re-author the manifest with `
+    + `the cases under \`cases\` (see pipeline/schemas/qa-spec-manifest.schema.json).`;
+}