valent-pipeline 0.19.52 → 0.19.53

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "valent-pipeline",
-  "version": "0.19.52",
+  "version": "0.19.53",
   "description": "v3 multi-agent AI pipeline for software development lifecycle",
   "type": "module",
   "bin": {

package/pipeline/orchestrators/claude-code/sprint.workflow.js

@@ -2115,10 +2115,21 @@ async function runStory(story) {
   // the round-trip cost and the rework-cycle count. Same preCriticChecks the gate runs; the
   // skip-waiver / spec-conformance rules are always named. Static + args only => journal-replay safe.
   const preHandoffStaticCmds = preCriticChecks.map((c) => subCmd(c, storyId, effectiveWorkspaces))
-  const preHandoffNote = (preHandoffStaticCmds.length || specConformanceEnabled || traceCheckEnabled)
+  // Fix #3 (rework-reduction, 2026-06-24): the pre-CRITIC gate ALSO runs spec-conformance + trace check
+  // (runPreCriticGate below), but the dev was only TOLD the rules, never handed the commands to run them.
+  // The field's `rework after static` round-trips were test files with a dropped assertion target / a
+  // missing AC trace-id / a mis-placed waiver — all catchable by running these two CLIs in the build turn.
+  // Thread the SAME commands the gate runs into the self-gate so the dev catches them in-context (no
+  // re-spawn). Static + args only => journal-replay safe.
+  const preHandoffSpecCmds = [
+    ...(specConformanceEnabled ? [`node .valent-pipeline/bin/cli.js check-spec-conformance --story ${storyId}`] : []),
+    ...(traceCheckEnabled ? [`node .valent-pipeline/bin/cli.js trace check --story ${storyId}`] : []),
+  ]
+  const preHandoffNote = (preHandoffStaticCmds.length || preHandoffSpecCmds.length)
     ? '\n\n## Definition of done — run these BEFORE you write your handoff\n' +
       'The deterministic pre-CRITIC gate runs the moment you hand off; a failure costs a full rework cycle (a re-spawn). Pass them first-try:\n' +
       preHandoffStaticCmds.map((c) => `  - \`${c}\` — must exit 0 (lint / type / static).\n`).join('') +
+      preHandoffSpecCmds.map((c) => `  - \`${c}\` — must exit 0 (spec-conformance / trace: catches a dropped assertion target, an omitted spec\'d case, a missing AC trace-id, or an un-waived skip BEFORE the gate round-trips you).\n`).join('') +
       '  - Every deliberately skipped or pending test MUST carry an inline `// valent-waiver: <reason>` (on the skip line or in the test name) — an un-waived skip is rejected by the spec-conformance check.\n' +
       '  - Do NOT drop a spec\'d assertion target or omit a spec\'d case to make a suite pass.\n' +
       'Run them locally, fix EVERYTHING they flag, and only then write your handoff — this is part of the build, not the gate\'s job to find for you.'