valent-pipeline 0.19.35 → 0.19.37

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "valent-pipeline",
-  "version": "0.19.35",
+  "version": "0.19.37",
   "description": "v3 multi-agent AI pipeline for software development lifecycle",
   "type": "module",
   "bin": {

package/pipeline/orchestrators/claude-code/sprint.workflow.js

@@ -1875,6 +1875,21 @@ async function runStory(story) {
       await runGitStep(storyId, [
         `node .valent-pipeline/bin/cli.js git start-story --story ${storyId}${gitFlags}`,
       ], 'start', 'QA')
+      // Cross-lane pin coherence on the inline-fix revalidation path (2026-06-19, M-28): the blocking
+      // bug's fix already merged INTO this story branch (ship-story --into) and was CRITIC-approved in
+      // its OWN lane — but that merge advanced the story tip PAST the story's last critic pin. The
+      // revalidation runs no CRITIC (by design — the fix was already reviewed) and `commitAndRepin`
+      // no-ops here (no devTasks), so the STALE story critic pin would trip `pins:critic`
+      // (evidence assert --require-pins critic) against the merged tip and FALSE-VOID a genuine SHIP —
+      // exactly the 2.11 reject. Re-pin critic so the pin records the cross-lane coverage that
+      // genuinely exists (story code @ the old pin + the bug fix @ its lane's own approving pin); the
+      // bug only merged here because it SHIPPED through its own CRITIC+JUDGE gates, and this no-rebuild
+      // path introduces no new source, so the coverage is real. The v3 source-delta check still
+      // fails-closed on any genuine un-reviewed change after this point. This is the "revalidation
+      // legitimately re-pins" case the pin-coherence doctrine already anticipates (evidence.js).
+      await runGitStep(storyId, [
+        `node .valent-pipeline/bin/cli.js evidence pin --story ${storyId} --gate critic`,
+      ], 'reval-repin-critic', 'QA')
     }
     await spawn('QA-B', 'qa-b.md',
       'This is a RE-VALIDATION of a previously-rejected story whose blocking bug has since been fixed and ' +

package/src/lib/sprint.js

@@ -226,22 +226,27 @@ export function packSprint(stories, velocity, opts = {}) {
   // groomed story alone — pulling in its groomed prerequisites first so order stays dependency-safe
   // — accepting an over-budget sprint. `over_budget` is flagged so the planner can surface
   // "this story exceeds velocity; planned alone — consider splitting it."
+  // forceAdd: include a story over-budget, pulling in its unsatisfied blocking bugs + groomed deps
+  // FIRST so execution order stays dependency-safe. Shared by both over-budget guards below.
+  const forceAdd = (story) => {
+    if (inSprint.has(story.id)) return;
+    for (const bugId of bugsOf(story)) {
+      const bug = byId.get(bugId);
+      if (bug && !satisfied.has(bug.status) && !inSprint.has(bugId)) forceAdd(bug);
+    }
+    for (const depId of depsOf(story)) {
+      const dep = byId.get(depId);
+      if (dep && dep.status === 'groomed' && !inSprint.has(depId)) forceAdd(dep);
+    }
+    add(story);
+  };
+
   let overBudget = false;
+  // Anti-stall (empty sprint): nothing fit the budget but groomed work exists — the smallest eligible
+  // story exceeds the whole velocity. Plan the highest-priority groomed story alone, over budget, so the
+  // project can never stall on a story that can never be packed. Same out-of-batch guard as the main
+  // loop (review #20): never force-plan a story whose unpacked prerequisite never shipped.
   if (sprintStories.length === 0 && byPriority.length > 0) {
-    const forceAdd = (story) => {
-      if (inSprint.has(story.id)) return;
-      for (const bugId of bugsOf(story)) {
-        const bug = byId.get(bugId);
-        if (bug && !satisfied.has(bug.status) && !inSprint.has(bugId)) forceAdd(bug);
-      }
-      for (const depId of depsOf(story)) {
-        const dep = byId.get(depId);
-        if (dep && dep.status === 'groomed' && !inSprint.has(depId)) forceAdd(dep);
-      }
-      add(story);
-    };
-    // Same out-of-batch guard as the main loop (review #20): the anti-stall must not force-plan
-    // a story whose unpacked prerequisite never shipped.
     const candidate = byPriority.find((s) => outOfBatchDepsSatisfied(s));
     if (candidate) {
       forceAdd(candidate);
@@ -249,6 +254,20 @@ export function packSprint(stories, velocity, opts = {}) {
     }
   }
 
+  // Feature-starvation guard (HARNESS-GAPS 2026-06-18, M-19 Issue 2 / orchestrator-confirmed): the
+  // empty-sprint anti-stall above does NOT fire when a small bug/spike fits — so a 1-pt bug packed while
+  // every groomed FEATURE exceeds velocity strands all feature work indefinitely (a bug-only sprint makes
+  // no product progress). If the packed set has NO feature story yet a deps-satisfied groomed feature
+  // exists, force the highest-priority one in over budget (same dependency-safe forceAdd).
+  const isFeature = (s) => s && s.type !== 'bug' && s.type !== 'spike';
+  if (sprintStories.length > 0 && !sprintStories.some((id) => isFeature(byId.get(id)))) {
+    const topFeature = byPriority.find((s) => isFeature(s) && !inSprint.has(s.id) && outOfBatchDepsSatisfied(s));
+    if (topFeature) {
+      forceAdd(topFeature);
+      overBudget = true;
+    }
+  }
+
   const buffer = groomed.filter((s) => !inSprint.has(s.id)).map((s) => s.id);
   const pointsPlanned = sprintStories.reduce((sum, id) => sum + pointsOf(byId.get(id)), 0);