valent-pipeline 0.19.23 → 0.19.24

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "valent-pipeline",
-  "version": "0.19.23",
+  "version": "0.19.24",
   "description": "v3 multi-agent AI pipeline for software development lifecycle",
   "type": "module",
   "bin": {

package/pipeline/orchestrators/claude-code/sprint.workflow.js

@@ -2030,11 +2030,30 @@ async function runStory(story) {
     }
   }
 
+  // Shift-left pre-handoff self-gate (review 2026-06-15): the dev fan-out used to hand off WITHOUT
+  // knowing which deterministic checks the pre-CRITIC STATIC gate would run the instant it did — so
+  // lint/type failures and un-waived test skips reached the gate and cost a full rework round-trip
+  // (a re-spawn), the dominant avoidable-rework pattern in the field (a soft correction-directive
+  // reduced it but did not close it). Thread the gate's OWN checks into the build prompt so the dev
+  // runs them IN its build turn (same context, no re-spawn) and hands off clean. The gate
+  // (runPreCriticGate) stays the mechanical backstop; this just makes it pass first-try, cutting both
+  // the round-trip cost and the rework-cycle count. Same preCriticChecks the gate runs; the
+  // skip-waiver / spec-conformance rules are always named. Static + args only => journal-replay safe.
+  const preHandoffStaticCmds = preCriticChecks.map((c) => subCmd(c, storyId, effectiveWorkspaces))
+  const preHandoffNote = (preHandoffStaticCmds.length || specConformanceEnabled || traceCheckEnabled)
+    ? '\n\n## Definition of done — run these BEFORE you write your handoff\n' +
+      'The deterministic pre-CRITIC gate runs the moment you hand off; a failure costs a full rework cycle (a re-spawn). Pass them first-try:\n' +
+      preHandoffStaticCmds.map((c) => `  - \`${c}\` — must exit 0 (lint / type / static).\n`).join('') +
+      '  - Every deliberately skipped or pending test MUST carry an inline `// valent-waiver: <reason>` (on the skip line or in the test name) — an un-waived skip is rejected by the spec-conformance check.\n' +
+      '  - Do NOT drop a spec\'d assertion target or omit a spec\'d case to make a suite pass.\n' +
+      'Run them locally, fix EVERYTHING they flag, and only then write your handoff — this is part of the build, not the gate\'s job to find for you.'
+    : ''
+
   phase('Build')
   // Genuine barrier: CRITIC needs ALL active dev agents' work before reviewing.
   const builds = await parallel(
     devTasks.map((t) => () =>
-      spawn(t.agent, `${t.agent.toLowerCase()}.md`, (t.subject || 'Implement production code and tests per the brief and test spec.') + atddReadOnlyNote, {
+      spawn(t.agent, `${t.agent.toLowerCase()}.md`, (t.subject || 'Implement production code and tests per the brief and test spec.') + atddReadOnlyNote + preHandoffNote, {
         label: `build:${t.ref}:${storyId}`,
         phase: 'Build',
       })),