uups-checker 1.0.0

package/BEEFY_MONAD_ANALYSIS.md

@@ -0,0 +1,239 @@
+# Beefy Finance Monad Chain Analysis
+
+## Overview
+Analyzing Beefy Finance vaults deployed on Monad chain with focus on yield strategies, security, and opportunities.
+
+**Chain Stats:**
+- Total Value Locked: $176.82M
+- Weekly Yield: $206,390
+- Weekly Revenue: $11,632
+- Weekly Buyback: $3,001
+
+## Vault Analysis
+
+### 1. WBTC-WMON PancakeSwap CLM Vault (Boosted)
+**Performance:**
+- APY: 171.38%
+- Base APY: 115.09%
+- Daily APY: 0.3642%
+- Daily Boost: 0.21%
+- TVL: $84,804
+- Liquidity: $74,840
+
+**Strategy Type:** Concentrated Liquidity Market (CLM) with Boost
+**Risk Level:** High (volatile pair, concentrated liquidity)
+**Notes:** Extremely high APY suggests high IL risk and potential reward farming incentives
+
+### 2. WETH-WMON PancakeSwap CLM Vault (Boosted)
+**Performance:**
+- APY: 100.57%
+- Base APY: 56.7%
+- Daily APY: 0.2433%
+- Daily Boost: 0.1231%
+- TVL: $112,714
+- Liquidity: $53,943
+
+**Strategy Type:** CLM with Boost
+**Risk Level:** Medium-High
+**Notes:** Native token pairing with ETH, lower TVL than liquidity suggests active management
+
+### 3. USDC-WMON PancakeSwap CLM Vault (Boosted)
+**Performance:**
+- APY: 125.77%
+- Base APY: 93.13%
+- Daily APY: 0.2699%
+- Daily Boost: 0.1804%
+- TVL: $307,443
+- Liquidity: $618,097
+
+**Strategy Type:** CLM with Boost
+**Risk Level:** Medium (stablecoin pairing reduces IL)
+**Notes:** Highest TVL in CLM vaults, good liquidity depth, safer IL profile
+
+### 4. apyUSD 18Jun26 Pendle Vault
+**Performance:**
+- APY: 14.99%
+- Daily APY: 0.0396%
+- TVL: $49,908
+- Liquidity: $11.17M
+
+**Strategy Type:** Pendle yield tokenization with Points
+**Risk Level:** Low-Medium
+**Notes:** Fixed maturity date (June 18, 2026), points farming strategy
+
+### 5. apxUSD 18Jun26 Pendle Vault
+**Performance:**
+- APY: 11.36%
+- Daily APY: 0.0299%
+- TVL: $3.11
+- Liquidity: $3.97M
+
+**Strategy Type:** Pendle yield tokenization with Points
+**Risk Level:** Low-Medium
+**Notes:** Very low TVL despite high liquidity - potential opportunity or red flag
+
+### 6. VIRTUAL-USDC PancakeSwap CLM Vault
+**Performance:**
+- APY: 29.86%
+- Daily APY: 0.0716%
+- TVL: $182.46
+- Liquidity: $271,960
+
+**Strategy Type:** CLM
+**Risk Level:** Medium
+**Notes:** Minimal TVL, decent liquidity
+
+### 7. VIRTUAL-USDC PancakeSwap CLM Pool
+**Performance:**
+- APY: 28.47%
+- Daily APY: 0.0749%
+- TVL: $1.01
+- Liquidity: $271,960
+
+**Strategy Type:** Direct CLM Pool
+**Risk Level:** Medium
+**Notes:** Nearly empty vault, same liquidity as vault version
+
+### 8. WETH-USDC PancakeSwap CLM Vault
+**Performance:**
+- APY: 54.05%
+- Daily APY: 0.1184%
+- TVL: $13,462
+- Liquidity: $5.00M
+
+**Strategy Type:** CLM
+**Risk Level:** Low-Medium
+**Notes:** Classic blue-chip pair, excellent liquidity depth
+
+### 9. WETH-USDC PancakeSwap CLM Pool
+**Performance:**
+- APY: 49.51%
+- Daily APY: 0.1223%
+- TVL: $10,711
+- Liquidity: $5.00M
+
+**Strategy Type:** Direct CLM Pool
+**Risk Level:** Low-Medium
+**Notes:** Direct pool access, slightly lower APY than vault
+
+## Security Considerations
+
+### Smart Contract Risks
+1. **CLM Strategy Complexity:** Concentrated liquidity requires active rebalancing
+2. **Boost Mechanisms:** Additional complexity in boosted vaults
+3. **Cross-Protocol Risk:** Dependency on PancakeSwap and Pendle protocols
+4. **Monad Chain Maturity:** Relatively new chain, less battle-tested
+
+### Key Areas to Audit
+
+
+#### 1. Vault Contract Architecture
+- Deposit/withdrawal mechanisms
+- Fee structures
+- Emergency withdrawal functions
+- Pause mechanisms
+- Access controls
+
+#### 2. Strategy Contracts
+- Rebalancing logic for CLM positions
+- Reward harvesting and compounding
+- Slippage protection
+- Price oracle dependencies
+
+#### 3. Boost Mechanisms
+- Boost calculation logic
+- Reward distribution fairness
+- Potential gaming vectors
+
+#### 4. Integration Points
+- PancakeSwap CLM integration
+- Pendle protocol integration
+- Token approvals and allowances
+- Cross-contract calls
+
+## Potential Vulnerabilities to Test
+
+### High Priority
+1. **Reentrancy in deposit/withdraw flows**
+2. **Price manipulation via flash loans**
+3. **Reward calculation overflow/underflow**
+4. **Access control bypasses**
+5. **Emergency function abuse**
+
+### Medium Priority
+6. **Slippage exploitation during rebalancing**
+7. **Fee calculation errors**
+8. **Rounding errors in share calculations**
+9. **Stale price oracle data**
+10. **Boost calculation manipulation**
+
+### Low Priority
+11. **Gas griefing attacks**
+12. **Front-running harvest calls**
+13. **Dust amount handling**
+
+## Recommended Testing Approach
+
+### Phase 1: Contract Discovery
+```solidity
+// Fetch vault addresses from Beefy API
+// Verify contract source code
+// Map contract relationships
+```
+
+### Phase 2: Static Analysis
+```bash
+# Run Slither on vault contracts
+slither VaultContract.sol --detect reentrancy-eth,reentrancy-no-eth
+
+# Check for common patterns
+slither VaultContract.sol --detect arbitrary-send-eth,suicidal
+```
+
+### Phase 3: Dynamic Testing
+```solidity
+// Test deposit/withdrawal flows
+// Test reward harvesting
+// Test emergency scenarios
+// Test edge cases (zero amounts, max amounts)
+```
+
+### Phase 4: Economic Analysis
+- Calculate actual vs advertised APY
+- Analyze fee impact on returns
+- Test IL scenarios for CLM positions
+- Verify boost calculations
+
+## Opportunities
+
+### High APY Vaults (>100%)
+1. **WBTC-WMON (171.38%)** - High risk, high reward
+2. **USDC-WMON (125.77%)** - Better risk/reward with stablecoin
+
+### Stable Yield (10-30%)
+1. **Pendle vaults (11-15%)** - Lower risk, fixed maturity
+2. **WETH-USDC (49-54%)** - Blue chip pair, good liquidity
+
+### Arbitrage Opportunities
+- **Vault vs Pool APY differences** (WETH-USDC: 54.05% vs 49.51%)
+- **Low TVL with high liquidity** (apxUSD: $3.11 TVL, $3.97M liquidity)
+
+## Red Flags
+
+1. **apxUSD vault:** $3.11 TVL with $3.97M liquidity - why is no one depositing?
+2. **VIRTUAL-USDC pool:** $1.01 TVL - essentially empty
+3. **High APYs on WMON pairs:** Potential for rapid depreciation of native token
+4. **New chain risk:** Monad is relatively new, less security track record
+
+## Next Steps
+
+1. **Fetch contract addresses** from Beefy API
+2. **Verify source code** on Monad explorer
+3. **Run automated security tools** (Slither, Mythril)
+4. **Create Foundry test suite** for identified vulnerabilities
+5. **Analyze tokenomics** of WMON and reward tokens
+6. **Review audit reports** if available
+
+## Conclusion
+
+The Monad Beefy vaults present interesting opportunities with high APYs, but require careful security analysis. The CLM strategies add complexity, and the new chain introduces additional risk. Priority should be given to auditing the USDC-WMON vault (highest TVL) and investigating the apxUSD anomaly (high liquidity, no deposits).

package/BEEFY_STAKING_ANALYSIS.md

@@ -0,0 +1,136 @@
+# Beefy Staking Contract Analysis
+## Contract: 0x453D4Ba9a2D594314DF88564248497F7D74d6b2C (BSC)
+
+### Contract Type
+Standard Synthetix-style StakingRewards contract (similar to MasterChef reward pool)
+
+### Key Parameters
+- **Staking Token**: 0xca3f508b8e4dd382ee878a314789373d80a5190a
+- **Rewards Token**: 0xbb4cdb9cbd36b01bd1cbaebf2de08d9173bc095c (WBNB)
+- **Total Staked**: 82.18 tokens
+- **Reward Rate**: ~3.05e27 per second
+- **Period Finish**: 1668010298 (Nov 9, 2022)
+- **Last Update**: 1668010298
+
+### Contract Status
+**INACTIVE** - The reward period ended in November 2022. No new rewards are being distributed.
+
+### Known Exploit Vectors for This Contract Type
+
+#### 1. **First Depositor Inflation Attack** ❌ NOT APPLICABLE
+- **Description**: Attacker deposits 1 wei, then directly transfers large amount to inflate share price
+- **Status**: Pool already has 82.18 tokens staked, attack window closed
+- **Impact**: N/A
+
+#### 2. **Reward Rate Manipulation** ❌ NOT APPLICABLE  
+- **Description**: Manipulate `notifyRewardAmount()` to drain rewards
+- **Status**: Reward period ended, no active rewards
+- **Impact**: N/A
+
+#### 3. **Rounding Error Exploitation** ⚠️ HISTORICAL RISK
+- **Description**: Small stakes round down to 0 rewards due to division by 1e18
+- **Formula**: `earned = balance * (rewardPerToken - userRewardPerTokenPaid) / 1e18`
+- **Status**: Was possible during active period
+- **Impact**: LOW - Dust amounts only
+
+#### 4. **Reward Calculation Precision Loss** ⚠️ HISTORICAL RISK
+- **Description**: `rewardPerToken = rewardPerTokenStored + (timeDelta * rewardRate * 1e18 / totalSupply)`
+- **Issue**: When totalSupply is very large, rewards per token become tiny
+- **Status**: With 82 tokens staked, precision was maintained
+- **Impact**: LOW
+
+#### 5. **Time-Based Reward Sniping** ❌ NOT APPLICABLE
+- **Description**: Stake right before reward distribution, unstake immediately after
+- **Status**: Rewards ended in 2022
+- **Impact**: N/A
+
+#### 6. **Reentrancy on Withdraw** ✅ PROTECTED
+- **Description**: Reenter during token transfer to manipulate state
+- **Protection**: Uses `updateReward` modifier before state changes
+- **Status**: Standard Checks-Effects-Interactions pattern followed
+- **Impact**: NONE
+
+### Potential Exploits (If Contract Were Active)
+
+#### A. **Reward Draining via Flash Loan**
+```solidity
+// If rewards were active:
+1. Flash loan large amount of staking tokens
+2. Stake all tokens
+3. Wait for rewards to accumulate (even 1 block)
+4. Withdraw + claim rewards
+5. Repay flash loan
+6. Keep rewards
+```
+**Mitigation**: Requires time-weighted staking or minimum lock period
+
+#### B. **Sandwich Attack on Reward Distribution**
+```solidity
+// Front-run notifyRewardAmount():
+1. Detect notifyRewardAmount() in mempool
+2. Front-run with large stake
+3. Let notifyRewardAmount() execute
+4. Back-run with immediate withdraw
+5. Claim disproportionate rewards
+```
+**Mitigation**: Requires gradual reward distribution or vesting
+
+#### C. **Dust Attack for Gas Griefing**
+```solidity
+// Create many tiny stakes:
+1. Stake 1 wei from many addresses
+2. Force contract to track many users
+3. Increase gas costs for legitimate users
+4. Potential DoS on reward calculations
+```
+**Mitigation**: Minimum stake requirement
+
+### DeFiHackLabs Knowledge Base Matches
+
+#### Similar Exploits:
+1. **Sorra Finance Hack (Jan 2025)** - $41K
+   - Flawed `getPendingRewards()` logic
+   - Failed to track distributed rewards
+   - Enabled repeated withdrawals
+   - **Match**: Reward calculation vulnerability
+
+2. **Penpie Protocol Exploit** - $27M
+   - Missing reentrancy guards in PendleStaking
+   - Market manipulation + malicious harvest
+   - **Match**: Staking contract reentrancy
+
+3. **Balancer Vault Inflation Attack**
+   - First depositor manipulation
+   - Share price inflation
+   - **Match**: ERC4626-style vault vulnerability
+
+### BlockSec Knowledge Base Matches
+
+#### Common Staking Vulnerabilities:
+1. **Reward Calculation Errors**
+   - Integer overflow/underflow
+   - Precision loss in division
+   - Incorrect time delta calculations
+
+2. **Access Control Issues**
+   - Unauthorized reward distribution
+   - Missing owner checks
+   - Compromised admin keys
+
+3. **Economic Attacks**
+   - Flash loan manipulation
+   - Sandwich attacks
+   - Reward sniping
+
+### Conclusion
+
+**Current Status**: This Beefy staking contract is INACTIVE (rewards ended Nov 2022) and has 82.18 tokens still staked. No active exploits are possible.
+
+**Historical Assessment**: During its active period, the contract was vulnerable to:
+- Flash loan reward manipulation
+- Sandwich attacks on reward distribution  
+- Minor rounding errors for dust amounts
+
+**Security Rating**: MEDIUM - Standard Synthetix implementation with known limitations but no critical flaws. The contract follows best practices for this design pattern.
+
+**Recommendation**: Users with staked tokens should withdraw their principal. No rewards are accumulating.

package/BEEFY_XVS_WBNB_ACTUAL_FINDINGS.md

@@ -0,0 +1,223 @@
+# Beefy XVS-WBNB Vault - Actual Findings
+
+## Vault Details
+- **Vault:** 0x5C60E395995123dE9B9099d01E592c97a73e0e12
+- **Strategy:** 0x3DF82f3E1a11B9d7d06267773B5BB2be5F8Be010
+- **TVL:** $16,938
+- **APY:** 39.78%
+- **Chain:** BNB Chain (Mainnet Fork Tested)
+
+---
+
+## Test Results Summary
+
+### ✅ REENTRANCY - NOT EXPLOITABLE FOR PROFIT
+
+**Status:** Vulnerability exists but NOT profitable
+
+**Test Result:**
+```
+Attacker deposited: 100 ether
+Attacker withdrew: 99.999 ether (lost 1 wei)
+Profit: 0
+```
+
+**Why No Profit:**
+The reentrancy allows calling `withdrawAll()` multiple times, but:
+1. Each withdrawal burns the attacker's shares
+2. The attacker only gets back their own deposited funds
+3. Cannot steal from other depositors
+4. Share accounting prevents double-spending
+
+**Actual Impact:** 
+- Griefing attack only
+- Could cause gas waste
+- Could disrupt normal operations
+- NOT a fund-stealing vulnerability
+
+**Severity Downgrade:** HIGH → LOW (griefing only)
+
+---
+
+## ⚠️ CONFIRMED: Public Harvest Function
+
+**Status:** CONFIRMED - Anyone can call harvest
+
+**Test Result:**
+```
+test_HarvestManipulation() - PASS
+Logs:
+  Harvest succeeded - anyone can call!
+```
+
+**Actual Profit Calculation:**
+
+The harvest function has no access control, but the profit depends on:
+
+1. **Call Reward:** 0 (checked on-chain)
+2. **Pending Rewards:** 0 CAKE currently
+3. **MEV Opportunity:** Depends on reward accumulation
+
+**Profit Scenario:**
+```
+IF rewards accumulate to 100 CAKE:
+- Attacker front-runs legitimate harvest
+- Attacker gets call reward (if configured)
+- Attacker can sandwich the reward swaps
+- Estimated profit: 0.1-0.5% of reward value
+```
+
+**Current State:**
+- No pending rewards to harvest
+- Call reward is 0
+- Limited immediate profit
+
+**Severity:** MEDIUM (MEV extraction, not fund theft)
+
+---
+
+## Real Profit Calculation
+
+### Scenario 1: Reentrancy Attack
+```
+Investment: 100 ETH worth of LP
+Profit: 0 ETH
+ROI: 0%
+Gas Cost: ~800k gas (~$5-10)
+Net Profit: NEGATIVE
+```
+
+**Verdict:** NOT PROFITABLE
+
+### Scenario 2: Public Harvest MEV
+```
+Pending Rewards: Variable (currently 0)
+Call Reward: 0
+MEV from sandwich: 0.1-0.5% of rewards
+Estimated profit per harvest: $0-50 (depends on reward size)
+Gas cost: ~200k gas (~$2-5)
+Net profit: $0-45 per harvest
+```
+
+**Verdict:** MARGINALLY PROFITABLE (only when rewards accumulate)
+
+### Scenario 3: Flash Loan + Harvest Manipulation
+```
+Flash loan: 10,000 BNB
+Manipulate XVS-WBNB pool price
+Trigger harvest at manipulated price
+Profit from price difference
+Estimated profit: $100-500 (high risk)
+Gas + flash loan fees: $50-100
+Net profit: $0-400
+```
+
+**Verdict:** POTENTIALLY PROFITABLE (but risky and complex)
+
+---
+
+## Actual Vulnerabilities Ranked by Profit
+
+### 1. Public Harvest (MEDIUM)
+- **Profit:** $0-50 per harvest
+- **Frequency:** Every 8-24 hours
+- **Complexity:** Low
+- **Risk:** Low
+- **Total potential:** $0-1,500/month
+
+### 2. Flash Loan + Harvest (MEDIUM-HIGH)
+- **Profit:** $100-500 per attack
+- **Frequency:** When rewards accumulate
+- **Complexity:** High
+- **Risk:** High (could fail, lose gas)
+- **Total potential:** $500-2,000/month
+
+### 3. Reentrancy (LOW)
+- **Profit:** $0
+- **Frequency:** N/A
+- **Complexity:** Medium
+- **Risk:** None (no profit)
+- **Total potential:** $0
+
+---
+
+## Why This Vault Isn't Worth Exploiting
+
+1. **Low TVL:** Only $16,938 - limited profit potential
+2. **No Call Rewards:** Harvest doesn't pay the caller
+3. **Reentrancy Doesn't Steal:** Just withdraws your own funds
+4. **Better Targets Exist:** Other vaults have higher TVL and worse security
+
+---
+
+## Comparison to Real Exploits
+
+### This Vault:
+- Max profit: ~$500/attack
+- Requires flash loan
+- High complexity
+- Low success rate
+
+### Typical DeFi Exploit:
+- Profit: $100k - $10M
+- Direct fund theft
+- Medium complexity
+- High success rate if vulnerability exists
+
+---
+
+## Actual Recommendations
+
+### For Beefy Team:
+
+1. **Add harvest access control** (prevents MEV, not critical)
+   ```solidity
+   modifier onlyKeeper() {
+       require(msg.sender == keeper, "!keeper");
+       _;
+   }
+   ```
+
+2. **Add ReentrancyGuard** (prevents griefing, not fund theft)
+   ```solidity
+   function withdrawAll() external nonReentrant {
+       // ...
+   }
+   ```
+
+3. **Priority:** LOW - No immediate fund theft risk
+
+### For Researchers:
+
+1. **Don't waste time on this vault** - profit too low
+2. **Look for:**
+   - Higher TVL vaults (>$1M)
+   - Actual fund theft vulnerabilities
+   - Broken access controls on admin functions
+   - Price oracle manipulation with high impact
+
+---
+
+## Conclusion
+
+**Initial Assessment:** CRITICAL - Reentrancy can drain vault!
+
+**Actual Reality:** LOW - Reentrancy doesn't steal funds, public harvest has minimal MEV
+
+**Profit Potential:** $0-500 per attack (not worth the effort)
+
+**Recommendation:** Move on to more profitable targets
+
+The vault has security issues but they're not exploitable for significant profit. The reentrancy is a red herring - it looks scary but doesn't actually steal funds. The public harvest is the real issue but with only $16k TVL and no call rewards, the MEV opportunity is minimal.
+
+---
+
+## Lessons Learned
+
+1. **Reentrancy ≠ Automatic Profit** - Need to verify actual fund flow
+2. **Test with real numbers** - Don't assume vulnerability = profit
+3. **Consider economics** - Gas costs, flash loan fees, slippage
+4. **TVL matters** - Small vaults aren't worth complex attacks
+5. **Verify on mainnet fork** - Simulations reveal actual behavior
+
+This is why you always test exploits before claiming bounties or attempting attacks. The vulnerability exists but the economics don't work out.