usb 1.8.1-libusb.6 → 1.9.2

package/CHANGELOG.md

@@ -0,0 +1,73 @@
+# Changelog
+
+## [1.9.2] - 2021-12-05
+
+### Fixed
+- Fixed exit delay and hang by moving queue start/stop to device open/close  - [`460`](https://github.com/node-usb/node-usb/pull/460) ([MikeColeGuru](https://github.com/MikeColeGuru))
+
+## [1.9.1] - 2021-11-14
+
+### Fixed
+- Reverted fix for exit delay fixing a segfault issue it introduced - [`456`](https://github.com/node-usb/node-usb/pull/456) ([Rob Moran](https://github.com/thegecko))
+
+## [1.9.0] - 2021-11-08
+
+### Changed
+- Changed libusb dependency to upstream v1.0.23 - [`453`](https://github.com/node-usb/node-usb/pull/453) ([Rob Moran](https://github.com/thegecko))
+
+## [1.8.1] - 2021-11-08
+
+### Added
+- Added functionality to ref/unref the hotplug events - [`455`](https://github.com/node-usb/node-usb/pull/455) ([Guilherme Francescon](https://github.com/gfcittolin))
+- Added CHANGELOG - [`454`](https://github.com/node-usb/node-usb/pull/454) ([Rob Moran](https://github.com/thegecko))
+
+### Fixed
+- Fixed delay when exiting program - [`455`](https://github.com/node-usb/node-usb/pull/455) ([Rob Moran](https://github.com/thegecko))
+
+## [1.8.0] - 2021-10-14
+
+### Added
+- Added prebuildify and GitHub action for native binaries - [`450`](https://github.com/node-usb/node-usb/pull/450) ([Rob Moran](https://github.com/thegecko))
+
+### Fixed
+- Fixed crash after wake on Windows when using Electron - [`451`](https://github.com/node-usb/node-usb/pull/451) ([Rob Moran](https://github.com/thegecko))
+- Fixed invalid initial refs - [`445`](https://github.com/node-usb/node-usb/pull/445) ([Alba Mendez](https://github.com/mildsunrise))
+
+### Changed
+- Changed GitHub organisation to [node-usb](https://github.com/node-usb) - [`447`](https://github.com/node-usb/node-usb/pull/447) ([Rob Moran](https://github.com/thegecko))
+
+## [1.7.2] - 2021-08-30
+
+### Fixed
+- Fixed crash when exiting on MacOS with Electron 9 - [`440`](https://github.com/node-usb/node-usb/pull/440) ([Daniel Main](https://github.com/danielmain))
+
+### Changed
+- **Breaking:** Changed minimum Node.js version to `10` - [`428`](https://github.com/node-usb/node-usb/pull/428) ([Rob Moran](https://github.com/thegecko))
+
+## [1.7.1] - 2021-05-08
+
+### Fixed
+- Fixed compiler warnings - [`419`](https://github.com/node-usb/node-usb/pull/419) ([Joel Purra](https://github.com/joelpurra))
+
+## [1.7.0] - 2021-04-10
+
+### Changed
+- Changed native support to use Node Addon API - [`399`](https://github.com/node-usb/node-usb/pull/399) ([Georg Vienna](https://github.com/geovie))
+
+## [1.6.5] - 2021-02-14
+
+### Changed
+- Changed prebuild for Electron 12 beta to nightly - [`410`](https://github.com/node-usb/node-usb/pull/410) ([Piotr Rogowski](https://github.com/karniv00l))
+
+### Removed
+- Removed `portNumbers` test on arm64 - [`408`](https://github.com/node-usb/node-usb/pull/408) ([Rob Moran](https://github.com/thegecko))
+
+## [1.6.4] - 2021-01-30
+
+### Added
+- Added prebuild for Electron 10 and 12 beta - [`407`](https://github.com/node-usb/node-usb/pull/407) ([Rob Moran](https://github.com/thegecko))
+- Added prebuild for Electron 9 - [`362`](https://github.com/node-usb/node-usb/pull/362) (Luke Whyte)
+
+### Changed
+- Changed to GitHub Actions for prebuild workflow - [`404`](https://github.com/node-usb/node-usb/pull/404) ([Rob Moran](https://github.com/thegecko))
+- Changed Node.js 13 prebuild target to Node.js 14 - [`374`](https://github.com/node-usb/node-usb/pull/374) ([Micah Zoltu](https://github.com/MicahZoltu))

package/{Readme.md → README.md}

@@ -304,6 +304,12 @@ Attaches a callback to plugging in a `device`.
 ### usb.on('detach', function(device) { ... });
 Attaches a callback to unplugging a `device`.
 
+### usb.refHotplugEvents();
+Restore (re-reference) the hotplug events unreferenced by `unrefHotplugEvents()`
+
+### usb.unrefHotplugEvents();
+Listening to events will prevent the process to exit. By calling this function, hotplug events will be unreferenced by the event loop, allowing the process to exit even when listening for the `attach` and `detach` events.
+
 
 Development and testing
 =======================

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "usb",
   "description": "Library to access USB devices",
-  "version": "1.8.1-libusb.6",
+  "version": "1.9.2",
   "engines": {
     "node": ">=10.16.0"
   },
@@ -55,7 +55,7 @@
   },
   "devDependencies": {
     "coffeescript": "~2.4.1",
-    "mocha": "^8.3.2",
+    "mocha": "^9.1.3",
     "node-gyp": "^7.1.2",
     "prebuildify": "^4.2.1",
     "prebuildify-ci": "^1.0.5",

package/src/device.cc

@@ -19,18 +19,12 @@ Device::Device(const Napi::CallbackInfo & info) : Napi::ObjectWrap<Device>(info)
 	device = info[0].As<Napi::External<libusb_device>>().Data();
 	libusb_ref_device(device);
 	byPtr.insert(std::make_pair(device, this));
-#ifndef USE_POLL
-	completionQueue.start(info.Env());
-#endif
 	DEBUG_LOG("Created device %p", this);
 	Constructor(info);
 }
 
 Device::~Device(){
 	DEBUG_LOG("Freed device %p", this);
-#ifndef USE_POLL
-	completionQueue.stop();
-#endif
 	byPtr.erase(device);
 	libusb_close(device_handle);
 	libusb_unref_device(device);
@@ -194,6 +188,9 @@ Napi::Value Device::Open(const Napi::CallbackInfo& info) {
 	ENTER_METHOD(Device, 0);
 	if (!self->device_handle){
 		CHECK_USB(libusb_open(self->device, &self->device_handle));
+#ifndef USE_POLL
+    	completionQueue.start(info.Env());
+#endif
 	}
 	return env.Undefined();
 }
@@ -203,6 +200,9 @@ Napi::Value Device::Close(const Napi::CallbackInfo& info) {
 	if (self->canClose()){
 		libusb_close(self->device_handle);
 		self->device_handle = NULL;
+#ifndef USE_POLL
+	    completionQueue.stop();
+#endif        
 	}else{
 		THROW_ERROR("Can't close device with a pending request");
 	}

package/src/node_usb.cc

@@ -7,6 +7,8 @@ Napi::Value GetDeviceList(const Napi::CallbackInfo& info);
 Napi::Value GetLibusbCapability(const Napi::CallbackInfo& info);
 Napi::Value EnableHotplugEvents(const Napi::CallbackInfo& info);
 Napi::Value DisableHotplugEvents(const Napi::CallbackInfo& info);
+Napi::Value RefHotplugEvents(const Napi::CallbackInfo& info);
+Napi::Value UnrefHotplugEvents(const Napi::CallbackInfo& info);
 void initConstants(Napi::Object target);
 
 libusb_context* usb_context;
@@ -17,6 +19,7 @@ struct HotPlug {
 
 #ifdef USE_POLL
 #include <poll.h>
+#include <uv.h>
 #include <sys/time.h>
 
 std::map<int, uv_poll_t*> pollByFD;
@@ -98,6 +101,8 @@ Napi::Object Init(Napi::Env env, Napi::Object exports) {
 	exports.Set("_getLibusbCapability", Napi::Function::New(env, GetLibusbCapability));
 	exports.Set("_enableHotplugEvents", Napi::Function::New(env, EnableHotplugEvents));
 	exports.Set("_disableHotplugEvents", Napi::Function::New(env, DisableHotplugEvents));
+	exports.Set("refHotplugEvents", Napi::Function::New(env, RefHotplugEvents));
+	exports.Set("unrefHotplugEvents", Napi::Function::New(env, UnrefHotplugEvents));
 	return exports;
 }
 
@@ -212,10 +217,27 @@ Napi::Value DisableHotplugEvents(const Napi::CallbackInfo& info) {
 	return env.Undefined();
 }
 
+Napi::Value RefHotplugEvents(const Napi::CallbackInfo& info) {
+	Napi::Env env = info.Env();
+	Napi::HandleScope scope(env);
+	if (hotplugEnabled) {
+		hotplugQueue.ref(env);
+	}
+	return env.Undefined();
+}
+
+Napi::Value UnrefHotplugEvents(const Napi::CallbackInfo& info) {
+	Napi::Env env = info.Env();
+	Napi::HandleScope scope(env);
+	if (hotplugEnabled) {
+		hotplugQueue.unref(env);
+	}
+	return env.Undefined();
+}
+
 #define DEFINE_CONSTANT(OBJ, VALUE) \
 	OBJ.DefineProperty(Napi::PropertyDescriptor::Value(#VALUE, Napi::Number::New(OBJ.Env(), VALUE), static_cast<napi_property_attributes>(napi_enumerable | napi_configurable)));
 
-
 void initConstants(Napi::Object target){
 	DEFINE_CONSTANT(target, LIBUSB_CLASS_PER_INTERFACE);
 	DEFINE_CONSTANT(target, LIBUSB_CLASS_AUDIO);

package/src/uv_async_queue.h

@@ -3,31 +3,39 @@
 
 template <class T>
 class UVQueue{
-	public:
-		typedef void (*fptr)(T);
-
-		Napi::ThreadSafeFunction tsfn;
-
-		UVQueue(fptr cb): callback(cb)  {}
-
-		void start(Napi::Env env) {
-			Napi::Function empty_func = Napi::Function::New(env, [](const Napi::CallbackInfo& cb) {});
-			tsfn = Napi::ThreadSafeFunction::New(env, empty_func, "libusb", 0, 1);
-		}
-
-		void stop() {
-    		tsfn.Release();
-		}
-		
-		void post(T value){
-			auto cb = callback;
-			tsfn.BlockingCall( value, [cb](Napi::Env _env, Napi::Function _jsCallback, T val) {
-				cb(val);
-			});
-		}
-
-	private:
-		fptr callback;
+    public:
+        typedef void (*fptr)(T);
+
+        Napi::ThreadSafeFunction tsfn;
+
+        UVQueue(fptr cb): callback(cb)  {}
+
+        void start(Napi::Env env) {
+            Napi::Function empty_func = Napi::Function::New(env, [](const Napi::CallbackInfo& cb) {});
+            tsfn = Napi::ThreadSafeFunction::New(env, empty_func, "libusb", 0, 1);
+        }
+
+        void stop() {
+            tsfn.Release();
+        }
+ 
+        void ref(Napi::Env env) {
+            tsfn.Ref(env);
+        }
+
+        void unref(Napi::Env env) {
+            tsfn.Unref(env);
+        }
+
+        void post(T value){
+            auto cb = callback;
+            tsfn.BlockingCall( value, [cb](Napi::Env _env, Napi::Function _jsCallback, T val) {
+                cb(val);
+            });
+        }
+
+    private:
+        fptr callback;
 };
 
 #endif

package/usb.js

@@ -14,6 +14,8 @@ if (usb.INIT_ERROR) {
 	usb.getDeviceList = function () { return []; };
 	usb._enableHotplugEvents = function () { };
 	usb._disableHotplugEvents = function () { };
+	usb.refHotplugEvents = function () { };
+	usb.unrefHotplugEvents = function () { };
 }
 
 Object.keys(events.EventEmitter.prototype).forEach(function (key) {
@@ -508,12 +510,12 @@ OutEndpoint.prototype.transferWithZLP = function (buf, cb) {
 	}
 }
 
-// Polling mechanism for discovering Windows device changes until this is fixed:
+// Polling mechanism for discovering device changes until this is fixed:
 // https://github.com/libusb/libusb/issues/86
-exports._windowsPollTimeout = 500;
+exports._pollTimeout = 500;
 var hotplugSupported = usb._getLibusbCapability(usb.LIBUSB_CAP_HAS_HOTPLUG) > 0;
 var pollingHotplug = false;
-var windowsDevices = [];
+var pollDevices = [];
 function pollHotplug(start) {
 	if (start) {
 		pollingHotplug = true;
@@ -526,14 +528,14 @@ function pollHotplug(start) {
 	if (!start) {
 		// Find attached devices
 		for (var device of devices) {
-			var found = windowsDevices.find(item => item.deviceAddress === device.deviceAddress);
+			var found = pollDevices.find(item => item.deviceAddress === device.deviceAddress);
 			if (!found) {
 				usb.emit('attach', device);
 			}
 		}
 
 		// Find detached devices
-		for (var device of windowsDevices) {
+		for (var device of pollDevices) {
 			var found = devices.find(item => item.deviceAddress === device.deviceAddress);
 			if (!found) {
 				usb.emit('detach', device);
@@ -541,10 +543,10 @@ function pollHotplug(start) {
 		}
 	}
 
-	windowsDevices = devices;
+	pollDevices = devices;
 	setTimeout(() => {
 		pollHotplug();
-	}, exports._windowsPollTimeout);
+	}, exports._pollTimeout);
 }
 
 var hotplugListeners = 0;

package/index.js

@@ -1,20 +0,0 @@
-const usb = require('./');
-
-const a = d => console.log('a', d);
-const d = d => console.log('d', d);
-
-console.log('listening');
-usb.on('attach', a);
-usb.on('detach', d);
-
-setTimeout(() => {
-    console.log('ignoring');
-    usb.off('attach', a);
-    usb.off('detach', d);
-
-    setTimeout(() => {
-        console.log('listening');
-        usb.on('attach', a);
-        usb.on('detach', d); 
-    }, 5000);
-}, 5000);