unoverse 0.1.103 → 0.1.105

package/operator/ansible/playbooks/test-connectivity.yml

@@ -167,15 +167,28 @@
     # PACKAGES_PATH any more and docker-compose.yml has no such volume, so the check could
     # only ever report 0 and tell the operator to run a command that would not fix it.
 
+    # SINCE THE SERVICES RESTARTED, NOT SINCE FIVE MINUTES AGO.
+    #
+    # A first setup necessarily boots the services before the schema exists — migrations run
+    # THROUGH the unoverse container, so there is nothing to run them in until it is up — and
+    # db-setup restarts everything afterwards. A fixed five-minute window straddles that
+    # restart and reports the pre-migration errors as if they were current: every first
+    # deploy ended with 'relation "memories" does not exist' in red, describing a state that
+    # had already been fixed two minutes earlier by this very playbook.
+    #
+    # The question is "is anything wrong NOW", so the window starts when the services did.
     - name: "[12/14] Check for errors in service logs"
       shell: |
         cd /opt/gravity
-        ERRORS=$(docker compose logs --tail=50 --since=5m 2>&1 | grep -iE 'error|fatal|panic|does not exist|ECONNREFUSED' | grep -v 'NOGROUP' | tail -10)
+        # Newest container start: everything before it belongs to a previous run.
+        SINCE=$(docker compose ps -q 2>/dev/null | xargs -r docker inspect -f '{{.State.StartedAt}}' 2>/dev/null | sort | tail -1)
+        [ -n "$SINCE" ] || SINCE=5m
+        ERRORS=$(docker compose logs --tail=50 --since="$SINCE" 2>&1 | grep -iE 'error|fatal|panic|does not exist|ECONNREFUSED' | grep -v 'NOGROUP' | tail -10)
         if [ -n "$ERRORS" ]; then
           echo "$ERRORS"
           exit 1
         else
-          echo "No recent errors"
+          echo "No errors since the services started"
         fi
       register: log_errors
       ignore_errors: yes

package/operator/lib/tfsummary.mjs

@@ -141,26 +141,43 @@ process.stdin.on("end", () => {
 
   const groups = { create: [], update: [], delete: [], replace: [] };
   const supporting = { create: 0, update: 0, delete: 0, replace: 0 };
+  // LOSING SOMETHING IS NEVER ANONYMOUS. Counting the plumbing is right when things are
+  // being built — nobody needs eleven IAM attachments enumerated. It is wrong the moment
+  // anything is destroyed or replaced: "plus 1 supporting resource" was a security group
+  // about to be deleted, and the operator hit Ctrl-C when Terraform printed "Destroying"
+  // for something the summary had not named. Anything being taken away is listed.
+  const named = { delete: [], replace: [] };
 
   for (const r of plan.resource_changes ?? []) {
     const act = action(r.change ?? {});
     if (!act) continue;
     const d = describe(r);
     if (d) groups[act].push(d);
-    else supporting[act]++;
+    else if (act === "delete" || act === "replace") {
+      // Turn the terraform type into something readable: aws_security_group → security group
+      const label = r.type.replace(/^(aws|digitalocean|random|time|archive)_/, "").replace(/_/g, " ");
+      const v = r.change?.before ?? r.change?.after ?? {};
+      named[act].push({ what: label.charAt(0).toUpperCase() + label.slice(1), detail: v.name ?? v.id ?? "" });
+    } else supporting[act]++;
   }
 
-  const total = Object.values(groups).flat().length + Object.values(supporting).reduce((a, b) => a + b, 0);
+  const total = Object.values(groups).flat().length
+    + Object.values(supporting).reduce((a, b) => a + b, 0)
+    + named.delete.length + named.replace.length;
   const out = [];
   if (total === 0) {
     console.log(`\n  ${green("●")} Your infrastructure already matches. Nothing to change.\n`);
     return;
   }
 
-  const width = Math.max(...Object.values(groups).flat().map((d) => d.what.length), 0) + 2;
+  const width = Math.max(
+    ...Object.values(groups).flat().map((d) => d.what.length),
+    ...named.delete.map((d) => d.what.length),
+    ...named.replace.map((d) => d.what.length),
+    0) + 2;
 
   for (const act of ["create", "update", "replace", "delete"]) {
-    const list = groups[act];
+    const list = [...groups[act], ...(named[act] ?? [])];
     const extra = supporting[act];
     if (!list.length && !extra) continue;
     const colour = act === "delete" || act === "replace" ? red : act === "update" ? yellow : green;
@@ -194,6 +211,6 @@ process.stdin.on("end", () => {
   // something is not. `process.exitCode` rather than `process.exit`, which can cut off
   // the output above while it is still draining down a pipe.
   const destructive =
-    groups.delete.length + groups.replace.length + supporting.delete + supporting.replace;
+    groups.delete.length + groups.replace.length + named.delete.length + named.replace.length;
   if (destructive) process.exitCode = 3;
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "unoverse",
-  "version": "0.1.103",
+  "version": "0.1.105",
   "description": "The Unoverse front door — create a Studio project, a universe, or a client app, and launch Studio.",
   "license": "SEE LICENSE IN README.md",
   "type": "module",