unnbound-events 3.0.0-beta.1 → 3.0.0-beta.2

package/README.md

@@ -86,6 +86,8 @@ Return `undefined`, `null`, or omit properties to default to `204 No Content`.
 
 `c.request.body` used to vary by `content-type`. It is now always an `ArrayBuffer` of the exact request-content bytes after HTTP transport framing.
 
+Queued (SQS) messages replay through the same router, so the table below applies to queue handlers too — migrate them alongside your HTTP handlers. The bytes differ only for queued JSON, which is re-serialized through the queue envelope and so arrives as equivalent JSON rather than the publisher's original bytes; every other queued content type is byte-exact.
+
 | `content-type` | 2.0.x | Current version |
 | --- | --- | --- |
 | `application/json` | parsed object | `ArrayBuffer` |
@@ -96,9 +98,10 @@ Return `undefined`, `null`, or omit properties to default to `204 No Content`.
 
 Handlers for the first four must decode explicitly — see [Handlers](#handlers) for the per-type recipes. Handlers that already received bytes (XML, EDI, CSV, binary) are unaffected.
 
-Two things to check when upgrading an existing workflow:
+Three things to check when upgrading an existing workflow:
 
 - A malformed JSON body used to arrive as `undefined`. It now arrives as raw bytes and `JSON.parse` throws — handle it where you decode.
+- A missing body used to arrive as `undefined`, so `if (!c.request.body)` guards fired. Over HTTP it is now a zero-length `ArrayBuffer`, which is truthy, and those guards silently stop firing. Check `c.request.body.byteLength` instead. Queued delivery is the exception: a bodyless async request replays as the four bytes `null`, because the queue envelope stores `null` and it is re-serialized on the way in.
 - `tsc` catches direct property access on the body, but not a body passed straight to a logger or serializer. Those compile clean and emit `{}` at runtime. Audit every `server.post` / `server.put` handler before deploying.
 
 ## Middleware

package/dist/lib/adapters/extended-sqs-client.d.ts

@@ -7,12 +7,7 @@ export interface S3Pointer {
 }
 export type S3PointerMessage = ['software.amazon.payloadoffloading.PayloadS3Pointer', S3Pointer];
 type SQSClientConfig = ConstructorParameters<typeof SQSClient>[0];
-/**
- * Internal SQS envelope before it re-enters the HTTP router. Inline bodies
- * remain decoded JSON values until QueueAdapter serializes them into request
- * bytes, so this must not claim the public IncomingRequest body contract.
- * This distinction changes only the type, not SQS delivery behavior.
- */
+/** Queue envelopes hold decoded values until replay, so body is not yet an ArrayBuffer. */
 interface SqsEnvelopeRequest extends Omit<IncomingRequest, 'body'> {
     body: unknown;
 }

package/dist/lib/routing/endpoint.d.ts

@@ -2,7 +2,6 @@ import type { Context } from 'hono';
 import type { EventHandlerResult } from '../event';
 import { type MiddlewareHandler } from './middleware';
 import type { EventEnvironment, EventVariables, MaybePromise } from './types';
-export { attachTraceHeaders, respondWith } from './response';
 export type Handler<I, R = EventHandlerResult> = (input: I) => MaybePromise<R>;
 export interface Endpoint<I> {
     (path: string, handler: Handler<I>): MaybePromise<void>;

package/dist/lib/routing/endpoint.js

@@ -1,13 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.patchEndpoint = exports.parseEndpointArguments = exports.buildEndpointArguments = exports.respondWith = exports.attachTraceHeaders = void 0;
+exports.patchEndpoint = exports.parseEndpointArguments = exports.buildEndpointArguments = void 0;
 const unnbound_logger_sdk_1 = require("unnbound-logger-sdk");
 const utils_1 = require("../utils");
 const middleware_1 = require("./middleware");
 const response_1 = require("./response");
-var response_2 = require("./response");
-Object.defineProperty(exports, "attachTraceHeaders", { enumerable: true, get: function () { return response_2.attachTraceHeaders; } });
-Object.defineProperty(exports, "respondWith", { enumerable: true, get: function () { return response_2.respondWith; } });
 const buildEndpointArguments = (...args) => {
     const { path, middlewares, handler } = (0, exports.parseEndpointArguments)(...args);
     const patchedHandler = (0, exports.patchEndpoint)(handler);
@@ -27,7 +24,7 @@ const patchEndpoint = (handler) => {
         state.request.params = { ...state.request.params, ...context.req.param() };
         const result = await (0, unnbound_logger_sdk_1.startSpan)('Event request', async () => {
             const result = await handler(state);
-            return { status: result?.status ?? 204, headers: result?.headers, body: result?.body };
+            return { status: (0, response_1.resolveStatus)(result), headers: result?.headers, body: result?.body };
         }, (o) => (0, utils_1.buildIncomingPayload)(state, o));
         return (0, response_1.respondWith)(context, result);
     };

package/dist/lib/routing/middleware.js

@@ -1,6 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.buildMiddlewareArguments = exports.parseMiddlewareArguments = exports.patchMiddleware = void 0;
+const unnbound_logger_sdk_1 = require("unnbound-logger-sdk");
+const utils_1 = require("../utils");
 const response_1 = require("./response");
 const patchMiddleware = (handler) => {
     return async (context, next) => {
@@ -12,11 +14,10 @@ const patchMiddleware = (handler) => {
         // response contract as endpoint handlers.
         if (result == null)
             return;
-        return (0, response_1.respondWith)(context, {
-            status: result.status ?? 204,
-            headers: result.headers,
-            body: result.body,
-        });
+        // Short-circuiting skips patchEndpoint, so nothing else emits the request
+        // span. Without this, denied requests are absent from workflow traces.
+        const traced = await (0, unnbound_logger_sdk_1.startSpan)('Event request', async () => ({ status: (0, response_1.resolveStatus)(result), headers: result.headers, body: result.body }), (o) => (0, utils_1.buildIncomingPayload)(state, o));
+        return (0, response_1.respondWith)(context, traced);
     };
 };
 exports.patchMiddleware = patchMiddleware;

package/dist/lib/routing/response.d.ts

@@ -1,4 +1,6 @@
 import type { Context } from 'hono';
-import type { StrictEventHandlerResult } from '../event';
+import type { EventHandlerResult, StrictEventHandlerResult } from '../event';
+export declare const isContentlessStatus: (status: number) => boolean;
+export declare const resolveStatus: (result?: EventHandlerResult) => import("hono/utils/http-status").StatusCode;
 export declare const respondWith: (context: Context, result: StrictEventHandlerResult) => (Response & import("hono").TypedResponse<never, -1 | 100 | 102 | 103 | 200 | 201 | 202 | 203 | 206 | 207 | 208 | 226 | 300 | 301 | 302 | 303 | 305 | 306 | 307 | 308 | 400 | 401 | 402 | 403 | 404 | 405 | 406 | 407 | 408 | 409 | 410 | 411 | 412 | 413 | 414 | 415 | 416 | 417 | 418 | 421 | 422 | 423 | 424 | 425 | 426 | 428 | 429 | 431 | 451 | 500 | 501 | 502 | 503 | 504 | 505 | 506 | 507 | 508 | 510 | 511, "json">) | (Response & import("hono").TypedResponse<null, -1 | 100 | 101 | 102 | 103 | 200 | 201 | 202 | 203 | 204 | 205 | 206 | 207 | 208 | 226 | 300 | 301 | 302 | 303 | 304 | 305 | 306 | 307 | 308 | 400 | 401 | 402 | 403 | 404 | 405 | 406 | 407 | 408 | 409 | 410 | 411 | 412 | 413 | 414 | 415 | 416 | 417 | 418 | 421 | 422 | 423 | 424 | 425 | 426 | 428 | 429 | 431 | 451 | 500 | 501 | 502 | 503 | 504 | 505 | 506 | 507 | 508 | 510 | 511, "body">) | (Response & import("hono").TypedResponse<ArrayBuffer, -1 | 100 | 102 | 103 | 200 | 201 | 202 | 203 | 206 | 207 | 208 | 226 | 300 | 301 | 302 | 303 | 305 | 306 | 307 | 308 | 400 | 401 | 402 | 403 | 404 | 405 | 406 | 407 | 408 | 409 | 410 | 411 | 412 | 413 | 414 | 415 | 416 | 417 | 418 | 421 | 422 | 423 | 424 | 425 | 426 | 428 | 429 | 431 | 451 | 500 | 501 | 502 | 503 | 504 | 505 | 506 | 507 | 508 | 510 | 511, "body">);
 export declare const attachTraceHeaders: (headers?: Record<string, string>) => Record<string, string> | undefined;

package/dist/lib/routing/response.js

@@ -1,11 +1,18 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.attachTraceHeaders = exports.respondWith = void 0;
+exports.attachTraceHeaders = exports.respondWith = exports.resolveStatus = exports.isContentlessStatus = void 0;
 const unnbound_logger_sdk_1 = require("unnbound-logger-sdk");
+// Response rejects bodies on these statuses; dropping one prevents a 500.
+const CONTENTLESS_STATUSES = new Set([204, 205, 304]);
+const isContentlessStatus = (status) => CONTENTLESS_STATUSES.has(status);
+exports.isContentlessStatus = isContentlessStatus;
+const resolveStatus = (result) => result?.status ?? (result?.body ? 200 : 204);
+exports.resolveStatus = resolveStatus;
 const respondWith = (context, result) => {
     const headers = (0, exports.attachTraceHeaders)(result.headers);
-    if (!result.body)
+    if (!result.body || CONTENTLESS_STATUSES.has(result.status)) {
         return context.body(null, result.status, headers);
+    }
     // Signed protocol responses such as AS2 MDNs must remain byte-exact.
     if (result.body instanceof Uint8Array || result.body instanceof ArrayBuffer) {
         const bytes = result.body instanceof ArrayBuffer ? result.body : Uint8Array.from(result.body).buffer;

package/dist/lib/utils.js

@@ -6,6 +6,7 @@ const trace_1 = require("unnbound-logger-sdk/dist/trace");
 const types_1 = require("unnbound-logger-sdk/dist/types");
 const utils_1 = require("unnbound-logger-sdk/dist/utils");
 const error_1 = require("./error");
+const response_1 = require("./routing/response");
 const normalizeHeaders = (headers) => {
     return Object.fromEntries(Object.entries(headers).map(([key, value]) => [
         key,
@@ -115,16 +116,18 @@ const buildResponsePayload = (result) => {
     const declaredHeaders = result?.headers
         ? Object.fromEntries(Object.entries((0, exports.normalizeHeaders)(result.headers)).map(([name, value]) => [name.toLowerCase(), value]))
         : undefined;
-    // Byte responses go out with exactly the declared headers (no content-type
-    // unless the handler set one); everything else is JSON-serialized on the
-    // wire. The trace mirrors that, and the declared content-type drives the
-    // display decode so byte responses labeled JSON/XML/text trace readably.
-    const isByteBody = result?.body instanceof Uint8Array || result?.body instanceof ArrayBuffer;
+    // Binary responses keep declared headers; JSON gets the SDK default.
+    // The declared content type also controls trace decoding.
     const traceHeaders = headersForTrace(declaredHeaders ?? {});
+    const status = (0, response_1.resolveStatus)(result);
+    // Mirror the wire: respondWith drops the body on contentless statuses, so the
+    // trace must not claim one — nor a content type for a body never sent.
+    const body = (0, response_1.isContentlessStatus)(status) ? undefined : result?.body;
+    const isByteBody = body instanceof Uint8Array || body instanceof ArrayBuffer;
     return {
-        status: result?.status ?? 204,
-        headers: isByteBody ? traceHeaders : { 'content-type': 'application/json; charset=utf-8', ...traceHeaders },
-        body: result?.body ? describeBody(result.body, declaredHeaders?.['content-type']) : undefined,
+        status,
+        headers: body && !isByteBody ? { 'content-type': 'application/json; charset=utf-8', ...traceHeaders } : traceHeaders,
+        body: body ? describeBody(body, declaredHeaders?.['content-type']) : undefined,
     };
 };
 const buildIncomingPayload = (event, result) => {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "unnbound-events",
   "description": "Unified events SDK to handle HTTP routes and queued messages with a single routing API.",
-  "version": "3.0.0-beta.1",
+  "version": "3.0.0-beta.2",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {