universal-dev-standards 6.7.4 → 6.8.0

package/src/utils/skills-installer.js

@@ -19,7 +19,7 @@ import {
   getCommandsSupportedAgents,
   getCommandFileExtension
 } from '../config/ai-agent-paths.js';
-import { computeDirectoryHashes, computeFileHash } from './hasher.js';
+import { computeDirectoryHashes, computeFileHash, normalizeLineEndings } from './hasher.js';
 import { isLocalizedLocale } from './locale.js';
 import { getSkillsSourceDir } from './skills-source.js';
 
@@ -504,6 +504,16 @@ export function resolveSkillFiles(skillName, locale = 'en') {
  * are different installs, and a hash over contents alone would call a rename
  * "unchanged".
  *
+ * Content is line-ending normalized before hashing (GitHub issue #155): the
+ * counterpart on the actual-state side, `hashInstalledSkillDir` in
+ * `reconciler/actual-state-scanner.js`, hashes files that were checked out
+ * into the adopter's own repo and so may have been rewritten to CRLF by
+ * `core.autocrlf=true` on Windows. Both sides must apply the same
+ * normalization or every skill would report as changed on Windows, same as
+ * the `.standards/*` hashes this issue was filed about — the two functions
+ * only stay comparable by construction if they agree on this too, which is
+ * why the paired tests in `skill-content-hash.test.js` exist.
+ *
  * @param {Array<{name: string, content: string}>} files
  * @returns {string|null} `sha256:<hex>`, or null for an empty resolution
  */
@@ -513,7 +523,7 @@ export function computeSkillContentHash(files) {
   for (const f of files) {
     h.update(f.name);
     h.update('\0');
-    h.update(f.content);
+    h.update(normalizeLineEndings(f.content));
     h.update('\0');
   }
   return `sha256:${h.digest('hex')}`;
@@ -779,13 +789,17 @@ export function resolveCommandContent(cmdName, agent, locale = 'en') {
  *
  * Same `sha256:` shape as `computeSkillContentHash` so the two sides of the
  * diff can be compared without caring which category an entry came from.
+ * Line-ending normalized before hashing for the same reason as
+ * `computeSkillContentHash` (GitHub issue #155) — its actual-state
+ * counterpart in `reconciler/actual-state-scanner.js` hashes an installed
+ * command file that may have been checked out as CRLF on Windows.
  *
  * @param {string|null} content
  * @returns {string|null}
  */
 export function computeCommandContentHash(content) {
   if (content === null || content === undefined) return null;
-  return `sha256:${createHash('sha256').update(content).digest('hex')}`;
+  return `sha256:${createHash('sha256').update(normalizeLineEndings(content)).digest('hex')}`;
 }
 
 function installSingleCommand(cmdName, targetDir, agent, locale = 'en') {

package/src/utils/spec-linter.js

@@ -2,6 +2,22 @@
  * Spec Linter — Stateless analysis functions for spec quality checks
  * @module utils/spec-linter
  * @see specs/superspec-borrowing-phase1-2-spec.md (AC-11, AC-12, AC-13)
+ *
+ * XSPEC-383 R5 (Option E): `checkACCoverage` / `collectTestFiles` / `scanDir`
+ * were removed here. They shipped 2026-04-07, had passing unit tests, and were
+ * never wired to any CLI command — `uds lint` did not exist. 2026-08-19,
+ * registering `uds lint` and running it against VibeOps's 93 real specs
+ * surfaced that the removed check would have reported 0/98 ACs covered on
+ * every one of them, for two independent reasons: it derived AC identifiers
+ * positionally (`AC-1`, `AC-2`, …) instead of reading the ones a spec
+ * declares, and it hardcoded the `@AC-N` tag convention from this repo's own
+ * `skills/ac-coverage`, while VibeOps's tests tag coverage as `AC-045-001`
+ * without an `@` prefix. Neither project is "wrong" — they never agreed on a
+ * convention — but a linter that always reports zero regardless of actual
+ * coverage is worse than no linter: it looks like a working gate. Redoing AC
+ * coverage requires deciding how identifiers are read and how conventions are
+ * negotiated across adopters; that is a new design, not a patch, and is out
+ * of scope for R5.
  */
 
 import { readFileSync, readdirSync, existsSync } from 'fs';
@@ -9,35 +25,6 @@ import { join, basename } from 'path';
 import { StandardValidator } from './standard-validator.js';
 import { MicroSpec } from '../vibe/micro-spec.js';
 
-/**
- * Check if a spec's ACs are referenced in test files
- * @param {string} specId - e.g. "SPEC-001"
- * @param {string[]} acIds - e.g. ["AC-1", "AC-2", "AC-3"]
- * @param {string} projectPath - Project root directory
- * @returns {{ covered: string[], orphans: string[], coverage: number }}
- */
-export function checkACCoverage(specId, acIds, projectPath) {
-  const covered = [];
-  const orphans = [];
-
-  // Collect all test file contents
-  const testContent = collectTestFiles(projectPath);
-
-  for (const acId of acIds) {
-    // Search for @AC-N pattern in test files
-    const pattern = new RegExp(`@${acId}\\b`);
-    if (testContent.some(content => pattern.test(content))) {
-      covered.push(acId);
-    } else {
-      orphans.push(acId);
-    }
-  }
-
-  const coverage = acIds.length > 0 ? covered.length / acIds.length : 0;
-
-  return { covered, orphans, coverage };
-}
-
 /**
  * Validate depends_on references exist
  * @param {Object[]} specs - Array of specs with { id, dependsOn }
@@ -75,14 +62,22 @@ export function checkSpecSize(specFilePath, options = {}) {
 }
 
 /**
- * Run all lint checks on specs in a project
+ * Run all lint checks (dependency validity + size) on specs in a project.
+ *
+ * `specsDirExists` is a three-state signal, not decoration: "no specs
+ * directory" and "specs directory with zero problems" must not collapse into
+ * the same `{ pass: 0, warn: 0, fail: 0 }` shape, or a caller cannot tell
+ * "nothing was checked" from "everything is fine" (XSPEC-383 R4/R5's own
+ * standing rule for this repo's gates — see check-module-reachability.mjs and
+ * check-command-existence.mjs).
+ *
  * @param {string} projectPath - Project root directory
- * @returns {{ results: Object[], summary: { pass: number, warn: number, fail: number } }}
+ * @returns {{ results: Object[], summary: { pass: number, warn: number, fail: number }, specsDir: string, specsDirExists: boolean }}
  */
 export function lintAll(projectPath) {
   const specsDir = join(projectPath, 'specs');
   if (!existsSync(specsDir)) {
-    return { results: [], summary: { pass: 0, warn: 0, fail: 0 } };
+    return { results: [], summary: { pass: 0, warn: 0, fail: 0 }, specsDir: 'specs', specsDirExists: false };
   }
 
   // Load all specs
@@ -102,10 +97,6 @@ export function lintAll(projectPath) {
   const summary = { pass: 0, warn: 0, fail: 0 };
 
   for (const spec of allSpecs) {
-    // AC coverage
-    const acIds = (spec.acceptance || []).map((_, i) => `AC-${i + 1}`);
-    const acCoverage = checkACCoverage(spec.id, acIds, projectPath);
-
     // Dependencies for this spec
     const specBroken = depResults.broken.filter(b => b.spec === spec.id);
     const specValid = depResults.valid.filter(v => v.spec === spec.id);
@@ -116,22 +107,18 @@ export function lintAll(projectPath) {
     const size = checkSpecSize(specPath);
 
     // Determine worst status
-    let worstStatus = 'pass';
-    if (specBroken.length > 0 || size.status === 'fail' || acCoverage.coverage === 0 && acIds.length > 0) {
-      worstStatus = 'fail';
-    } else if (size.status === 'warn' || acCoverage.coverage < 1) {
-      worstStatus = 'warn';
+    let status = 'pass';
+    if (specBroken.length > 0 || size.status === 'fail') {
+      status = 'fail';
+    } else if (size.status === 'warn') {
+      status = 'warn';
     }
 
-    summary[worstStatus]++;
+    summary[status]++;
 
     results.push({
       spec: spec.id,
-      acCoverage: {
-        covered: acCoverage.covered,
-        orphans: acCoverage.orphans,
-        coverage: acCoverage.coverage,
-      },
+      status,
       deps,
       size: {
         effectiveLines: size.effectiveLines,
@@ -140,33 +127,5 @@ export function lintAll(projectPath) {
     });
   }
 
-  return { results, summary };
-}
-
-// ─── Internal helpers ───
-
-function collectTestFiles(projectPath) {
-  const contents = [];
-  const testDirs = ['tests', 'test', '__tests__', 'cli/tests'];
-
-  for (const dir of testDirs) {
-    const fullDir = join(projectPath, dir);
-    if (existsSync(fullDir)) {
-      scanDir(fullDir, contents);
-    }
-  }
-
-  return contents;
-}
-
-function scanDir(dir, contents) {
-  const entries = readdirSync(dir, { withFileTypes: true });
-  for (const entry of entries) {
-    const fullPath = join(dir, entry.name);
-    if (entry.isDirectory()) {
-      scanDir(fullPath, contents);
-    } else if (entry.name.match(/\.(test|spec)\.(js|ts|mjs|cjs)$/)) {
-      contents.push(readFileSync(fullPath, 'utf-8'));
-    }
-  }
+  return { results, summary, specsDir: 'specs', specsDirExists: true };
 }

package/standards-registry.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json-schema.org/draft/2020-12/schema",
-  "version": "6.7.4",
+  "version": "6.8.0",
   "lastUpdated": "2026-05-13",
   "description": "Standards registry for universal-dev-standards with integrated skills and AI-optimized formats",
   "formats": {
@@ -58,14 +58,14 @@
     "standards": {
       "name": "universal-dev-standards",
       "url": "https://github.com/AsiaOstrich/universal-dev-standards",
-      "version": "6.7.4"
+      "version": "6.8.0"
     },
     "skills": {
       "name": "universal-dev-standards",
       "url": "https://github.com/AsiaOstrich/universal-dev-standards",
       "localPath": "skills",
       "rawUrl": "https://raw.githubusercontent.com/AsiaOstrich/universal-dev-standards/main/skills",
-      "version": "6.7.4",
+      "version": "6.8.0",
       "note": "Skills are now included in the main repository under skills/"
     }
   },
@@ -2260,7 +2260,7 @@
       "id": "license-compliance",
       "name": "License Compliance Standards",
       "nameZh": "授權合規標準",
-      "version": "6.7.4",
+      "version": "6.8.0",
       "source": {
         "human": "core/license-compliance.md",
         "ai": "ai/standards/license-compliance.ai.yaml"
@@ -2272,7 +2272,7 @@
       "id": "verification-oracle",
       "name": "Verification Oracle Standards",
       "nameZh": "驗證 Oracle 標準",
-      "version": "6.7.4",
+      "version": "6.8.0",
       "source": {
         "human": "core/verification-oracle.md",
         "ai": "ai/standards/verification-oracle.ai.yaml"
@@ -2284,7 +2284,7 @@
       "id": "model-provenance",
       "name": "Model Provenance Policy Standards",
       "nameZh": "模型來源政策標準",
-      "version": "6.7.4",
+      "version": "6.8.0",
       "source": {
         "human": "core/model-provenance.md",
         "ai": "ai/standards/model-provenance.ai.yaml"
@@ -2296,7 +2296,7 @@
       "id": "resource-cost-boundary",
       "name": "Resource / Cost Boundary Declaration Standards",
       "nameZh": "資源／成本邊界宣告標準",
-      "version": "6.7.4",
+      "version": "6.8.0",
       "source": {
         "human": "core/resource-cost-boundary.md",
         "ai": "ai/standards/resource-cost-boundary.ai.yaml"

package/src/commands/sync.js

@@ -1,133 +0,0 @@
-/**
- * Sync Command — Export current work context for session resume
- * Zero AI tokens — pure shell/JS execution
- *
- * @module commands/sync
- * @see specs/superspec-borrowing-phase1-2-spec.md (AC-16, AC-17)
- */
-
-import { execSync } from 'child_process';
-import { readFileSync, writeFileSync, existsSync, readdirSync, mkdirSync } from 'fs';
-import { join } from 'path';
-
-const MAX_LINES = 500;
-
-/**
- * Generate context.md from git info and optional workflow state
- * @param {string} projectPath - Project root directory
- * @returns {string} Path to generated context.md
- */
-export function generateContext(projectPath) {
-  const lines = [];
-
-  lines.push('# Development Context');
-  lines.push(`> Auto-generated by \`uds sync\` at ${new Date().toISOString()}`);
-  lines.push('> This file helps restore context in a new AI session.');
-  lines.push('');
-
-  // ─── Git Status ───
-  lines.push('## Git Status');
-  lines.push('');
-
-  const branch = gitCmd('git rev-parse --abbrev-ref HEAD', projectPath);
-  lines.push(`- **Branch**: ${branch}`);
-
-  const baseBranch = detectBaseBranch(projectPath);
-  if (baseBranch && baseBranch !== branch) {
-    const commitCount = gitCmd(`git rev-list --count ${baseBranch}..HEAD`, projectPath) || '0';
-    lines.push(`- **Base**: ${baseBranch} (+${commitCount} commits)`);
-  }
-
-  lines.push('');
-  lines.push('### Recent Commits');
-  lines.push('');
-
-  const logOutput = gitCmd('git log --oneline -20', projectPath);
-  if (logOutput) {
-    lines.push(...logOutput.split('\n').map(l => `- ${l}`));
-  } else {
-    lines.push('(no commits)');
-  }
-  lines.push('');
-
-  lines.push('### Changed Files');
-  lines.push('');
-
-  if (baseBranch && baseBranch !== branch) {
-    const diffStat = gitCmd(`git diff --stat ${baseBranch}..HEAD`, projectPath);
-    if (diffStat) {
-      lines.push('```');
-      lines.push(...diffStat.split('\n'));
-      lines.push('```');
-    }
-  } else {
-    lines.push('(on base branch, no diff)');
-  }
-  lines.push('');
-
-  // ─── Workflow State ───
-  const workflowState = readWorkflowState(projectPath);
-  if (workflowState) {
-    lines.push('## Workflow State');
-    lines.push('');
-    lines.push(...workflowState);
-    lines.push('');
-  }
-
-  // Truncate to MAX_LINES
-  const truncated = lines.slice(0, MAX_LINES);
-
-  // Write to .workflow-state/context.md
-  const outputDir = join(projectPath, '.workflow-state');
-  mkdirSync(outputDir, { recursive: true });
-  const outputPath = join(outputDir, 'context.md');
-  writeFileSync(outputPath, truncated.join('\n'), 'utf-8');
-
-  return outputPath;
-}
-
-// ─── Helpers ───
-
-function gitCmd(cmd, cwd) {
-  try {
-    return execSync(cmd, { cwd, encoding: 'utf-8', stdio: ['pipe', 'pipe', 'ignore'] }).trim();
-  } catch {
-    return '';
-  }
-}
-
-function detectBaseBranch(projectPath) {
-  // Check for common base branches
-  for (const name of ['main', 'master']) {
-    const exists = gitCmd(`git rev-parse --verify ${name}`, projectPath);
-    if (exists) return name;
-  }
-  return null;
-}
-
-function readWorkflowState(projectPath) {
-  const stateDir = join(projectPath, '.workflow-state');
-  if (!existsSync(stateDir)) return null;
-
-  const yamlFiles = readdirSync(stateDir)
-    .filter(f => f.endsWith('.yaml') && !f.endsWith('.log.yaml'))
-    .sort();
-
-  if (yamlFiles.length === 0) return null;
-
-  // Read the most recent state file
-  const latestFile = yamlFiles[yamlFiles.length - 1];
-  const content = readFileSync(join(stateDir, latestFile), 'utf-8');
-
-  const lines = [];
-  // Extract key fields
-  const specMatch = content.match(/spec_id:\s*(.+)/);
-  const phaseMatch = content.match(/current_phase:\s*(.+)/);
-  const statusMatch = content.match(/status:\s*(.+)/);
-
-  if (specMatch) lines.push(`- **Spec**: ${specMatch[1].trim()}`);
-  if (phaseMatch) lines.push(`- **Phase**: ${phaseMatch[1].trim()}`);
-  if (statusMatch) lines.push(`- **Status**: ${statusMatch[1].trim()}`);
-
-  return lines.length > 0 ? lines : null;
-}