unguard 0.15.2 → 0.16.1

package/README.md

@@ -2,45 +2,140 @@
 
 Unguard your code. Defend against overdefensive AI-generated code.
 
-Type-aware static analysis powered by the TypeScript compiler API.
+Type-aware static analysis powered by the TypeScript compiler itself.
 
 If `??` is on a non-nullable type, you don't need it.
 
 If `?.` is on a guaranteed object, it's noise.
 
-unguard proves it with types.
+unguard proves it with types, and complains.
 
-## Install
+![unguard scanning a file and citing the types that prove each guard dead](https://raw.githubusercontent.com/TwoAbove/unguard/main/demo/demo.gif)
+
+## Quick start
 
 ```bash
-npm install -g unguard
+npx unguard
 ```
 
-or simply
+No config, no setup. unguard finds your tsconfig, builds a real TypeScript program, and reports only what the types prove. (`npm install -g unguard` if you prefer a global install.)
 
-```bash
-npx unguard
+## What it catches
+
+AI assistants pad code with guards against states the type system already rules out. Each one reads like caution, and in aggregate, they bury the real contracts. unguard reads the types and proves which guards need to be unguarded.
+
+**Dead fallbacks** - the type says the value is always there:
+
+```typescript
+const attempts = job.attempts ?? 1; // attempts: number
+```
+
+```txt
+10:20  warning  Nullish coalescing (??) fallback on a non-nullable type is dead
+                code; remove the fallback or fix the type upstream
+```
+
+**Dead narrowing** - the diagnostic cites the type that decides the condition:
+
+```typescript
+if (typeof job.id !== "string") {   // id: string
+  throw new Error("job is missing an id");
+}
+```
+
+```txt
+12:7   warning  typeof comparison is always false: `job.id` is `string`, and
+                typeof always yields "string" for that type
+```
+
+**Fabricated types** - external data asserted into shape instead of validated:
+
+```typescript
+const payload = JSON.parse(job.payload) as Payload;
+```
+
+```txt
+17:21  error    Casting `any`/`unknown` to a concrete type without runtime
+                validation fabricates structure; validate first or narrow with
+                a type guard
+```
+
+**Swallowed errors** - failure silently becomes a normal-looking value:
+
+```typescript
+try {
+  return { id: job.id, attempts, payload };
+} catch {
+  return null;
+}
+```
+
+```txt
+19:5   warning  Catch swallows the error: it neither throws nor returns a value
+                referencing the caught error. Propagate via throw, or model
+                failure into the return type carrying the original error
+```
+
+Plus more type-system evasions (`as any`, `x as unknown as T`, `@ts-ignore`), cross-file analysis (exports nobody imports, optional parameters no call site ever passes, arguments that are the same literal everywhere, dead overloads, copy-pasted functions), and more - the full catalog is in [Current Rules](#current-rules).
+
+## Why not just typescript-eslint?
+
+Keep typescript-eslint - unguard is a complement to it, not a replacement. Its `no-unnecessary-condition` overlaps with a slice of `no-dead-narrowing`, and that's roughly where the overlap ends. Unguard, on the other hand, provides more:
+
+- **Whole-project analysis.** unguard indexes every call site, import, and export across your tsconfig groups (and is monorepo-aware). Lint rules see one file at a time while unguard can prove an optional parameter is never passed, an argument is always the same literal, an export is never imported.
+- **Defensive-pattern focus.** Swallowed catches detected structurally (does any expression in the catch reference the error?), `throw new Error(e.message)` losing the cause, unvalidated casts of external data, defaults that widen interface contracts.
+- **Tiers split by proof.** `scan` runs only rules whose findings the checker demonstrates - it's designed to gate CI without false-positive fatigue. Everything debatable lives in `audit`.
+- **Zero config.** `npx unguard` on any TypeScript repo.
+
+## For AI coding agents
+
+unguard is built for the verify loop. Findings are proofs with the evidence in the message, which is exactly what an agent needs to fix code instead of arguing with a style warning. Add to your `CLAUDE.md` / `AGENTS.md` / rules file:
+
+```markdown
+After changing TypeScript, run `npx unguard` and fix every finding.
+Diagnostics cite the type that proves the defect - fix the code (or the type),
+don't add suppressions. If a guard is genuinely intentional, annotate it:
+`// @unguard <rule-id> <reason>`.
+```
+
+And gate CI:
+
+```yaml
+- name: unguard
+  run: npx unguard --fail-on=error
 ```
 
 ## Usage
 
 ```bash
-unguard src                                  # scan files/directories
-unguard src --config ./unguard.config.json   # load config
-unguard src --ignore '**/*.gen.ts'           # add ignore globs
-unguard src --filter no-any-cast             # run a single rule
-unguard src --rule duplicate-*=warning       # override rule severity/policy
-unguard src --rule category:cross-file=warning
-unguard src --rule tag:safety=error
-unguard src --severity=error,warning         # show errors+warnings
-unguard src --fail-on=error                  # fail only on errors
-unguard src --format=flat                    # one-line-per-diagnostic, grepable
-unguard src --format=flat | grep error
-unguard src --concurrency 1                  # disable worker-thread parallelism
-unguard src --no-cache                       # bypass on-disk diagnostic cache
+unguard                                  # scan files/directories
+unguard audit                            # run heuristic rules as review prompts
+unguard --config ./unguard.config.json   # load config
+unguard --ignore '**/*.gen.ts'           # add ignore globs
+unguard --filter no-any-cast             # run a single rule
+unguard --rule duplicate-*=warning       # override rule severity/policy
+unguard --rule category:cross-file=warning
+unguard --rule tag:safety=error
+unguard --severity=error,warning         # show errors+warnings
+unguard --fail-on=error                  # fail only on errors
+unguard --format=flat                    # one-line-per-diagnostic, grepable
+unguard --format=flat | grep error
+unguard --format=json                    # machine-readable report
+unguard --fix                            # apply auto-fixes, report what remains
+unguard baseline                         # record current issues as the baseline
+unguard --no-baseline                    # ignore unguard.baseline.json for this scan
+unguard --concurrency 1                  # disable worker-thread parallelism, can be slow for large codebases
+unguard --no-cache                       # bypass on-disk diagnostic cache
 ```
 
-Add `unguard` to your lint check, especially if code is written by AI.
+### Two tiers: `scan` and `audit`
+
+Every rule is classified by confidence:
+
+- **proven** - the checker or AST demonstrates the defect; every finding demands a fix (or an explicit `@unguard` annotation). `unguard scan` runs these and is meant to gate CI or commits.
+- **heuristic** - strong pattern evidence, but a correct alternative reading exists: deliberate duplication, API surface for external consumers, intentionally optional params. `unguard audit` runs these and exits 0 unless `--fail-on` is passed explicitly, so findings surface for review without blocking anything.
+
+`--filter <rule>` and explicit `rules` selections bypass the tiers - a rule requested by name runs in either command.
 
 ### Config
 
@@ -58,6 +153,15 @@ Add `unguard` to your lint check, especially if code is written by AI.
     "no-ts-ignore": "error",
     "prefer-*": "off"
   },
+  "overrides": [
+    {
+      "files": ["tests/**", "**/*.test.ts"],
+      "rules": {
+        "no-non-null-assertion": "off",
+        "duplicate-*": "off"
+      }
+    }
+  ],
   "failOn": "error",
   "concurrency": 4,
   "cache": true
@@ -71,6 +175,9 @@ Selectors support:
 - wildcard: `duplicate-*`
 - category: `category:cross-file`
 - tag: `tag:safety`
+- confidence tier: `confidence:proven`, `confidence:heuristic`
+
+`overrides` entries apply a rule policy only to diagnostics in files matching the listed globs (gitignore syntax, relative to the working directory). Later entries win; `off` drops the diagnostic. Typical use: relaxing rules in test directories, where non-null assertions and duplication are often deliberate.
 
 ### Ignore behavior
 
@@ -97,6 +204,8 @@ unguard src --fail-on=error
 
 `--severity` filters display only. `--fail-on` evaluates all diagnostics after rule policy.
 
+`unguard audit` defaults to `--fail-on=none` and exits 0 regardless of findings. Pass `--fail-on` explicitly to make audit gate.
+
 ### Output formats
 
 **Grouped** (default) -- diagnostics grouped by file:
@@ -112,84 +221,124 @@ src/lib/probe.ts
 src/lib/probe.ts:37:4 warning [no-swallowed-catch] Catch swallows the error...
 ```
 
+**JSON** (`--format=json`) -- machine-readable, for CI integrations:
+
+```json
+{
+  "diagnostics": [
+    {
+      "file": "src/lib/probe.ts",
+      "line": 37,
+      "column": 4,
+      "severity": "warning",
+      "ruleId": "no-swallowed-catch",
+      "message": "Catch swallows the error...",
+      "fixable": false
+    }
+  ],
+  "fileCount": 1,
+  "exitCode": 1
+}
+```
+
+### Auto-fix
+
+`--fix` applies fixes for diagnostics whose replacement is provably semantics-preserving (dead `??` fallbacks, dead `?.`, no-op `await`, redundant casts, `cond ? true : false`, and similar), then reports what remains. The exit code reflects only the remaining diagnostics.
+
+### Baseline
+
+Adopting unguard in an existing codebase? `unguard baseline src` records every current issue in `unguard.baseline.json`. Subsequent scans suppress a `(file, rule)` group as long as its count stays at or below the recorded number - new issues anywhere still fail, and fixing old ones ratchets the allowance down on the next `unguard baseline`. Use `--no-baseline` to see the full picture.
+
 ## Current Rules
 
+The **Tier** column says which command runs the rule: `scan` (proven) or `audit` (heuristic).
+
 ### Type system evasion
 
-| Rule | Severity | What it catches |
-| ---- | -------- | --------------- |
-| `no-any-cast` | error | `x as any` |
-| `no-explicit-any-annotation` | error | `param: any`, `const x: any` |
-| `no-inline-type-assertion` | error | `x as { ... }`, `<{ ... }>x` |
-| `no-type-assertion` | error | `x as unknown as T` |
-| `no-ts-ignore` | error | `@ts-ignore` / `@ts-expect-error` |
+| Rule | Severity | Tier | What it catches |
+| ---- | -------- | ---- | --------------- |
+| `no-any-cast` | error | scan | `x as any` -- erases type safety for everything downstream of the cast |
+| `no-explicit-any-annotation` | error | scan | `param: any`, `const x: any` -- an `any` annotation where a real type (or `unknown`) belongs |
+| `no-inline-type-assertion` | error | scan | `x as { ... }`, `<{ ... }>x` -- asserting into an anonymous inline shape; name the type or fix it upstream |
+| `no-type-assertion` | error | scan | `x as unknown as T` -- the double assertion that can connect any two types |
+| `no-ts-ignore` | error | scan | `@ts-ignore` -- silences the checker unconditionally |
+| `no-ts-expect-error` | warning | scan | `@ts-expect-error` -- self-expiring, but still an evasion |
+| `no-never-cast` | warning | scan | `x as never` -- silences the checker completely, usually to force past an exhaustiveness error |
+| `no-redundant-cast` | error | scan | `x as T` where `x` already has type `T` |
+| `no-unvalidated-cast` | error | scan | `JSON.parse(...) as T`, `await fetch(...).json() as T` -- casting external data into a shape nothing has checked |
+| `redundant-narrowing-then-cast` | warning | scan | `if (typeof x === "string") { (x as string).length }` -- the `if` already narrowed `x`, so the cast adds nothing |
+| `return-type-widens-via-destructure` | warning | scan | `const [x] = await db...returning(); return x;` in a function declared to return `T` -- an array element is really `T \| undefined`, so the return type hides the empty case |
 
 ### Defensive code (type-aware)
 
 These rules use the TypeScript type checker. Non-nullable types suppress the diagnostic; nullable types are flagged.
 
-| Rule | Severity | What it catches |
-| ---- | -------- | --------------- |
-| `no-optional-property-access` | warning | `obj?.prop` on a non-nullable type |
-| `no-optional-element-access` | warning | `obj?.[key]` on a non-nullable type |
-| `no-optional-call` | warning | `fn?.()` on a non-nullable type |
-| `no-nullish-coalescing` | warning | `x ?? fallback` on a non-nullable type |
-| `no-logical-or-fallback` | warning | `map.get(k) \|\| fallback`, `count \|\| 1` -- `\|\|` swallows `0` and `""`; use `??` |
-| `no-null-ternary-normalization` | warning | `x == null ? fallback : x` |
-| `no-coalesce-then-guard` | warning | `const x = a ?? null; if (x == null)` -- guard re-checks the same partition the `??` just created |
-| `no-await-coalesce` | warning | `await fn() ?? fallback` -- fuses the call's failure mode into the fallback (skips `Map.get`, `Array.find`, and structural optionals) |
-| `no-non-null-assertion` | warning | `x!` on a nullable type without a local narrowing guard |
-| `no-double-negation-coercion` | info | `!!value` |
-| `no-redundant-existence-guard` | warning | `obj && obj.prop` on a non-nullable type |
+Nullability-driven rules require `strictNullChecks` (or `strict`). Without it the checker erases `null`/`undefined` from every type, so these rules are skipped with a warning rather than reporting every load-bearing guard as dead code.
+
+| Rule | Severity | Tier | What it catches |
+| ---- | -------- | ---- | --------------- |
+| `no-optional-property-access` | warning | scan | `obj?.prop` on a non-nullable type |
+| `no-optional-element-access` | warning | scan | `obj?.[key]` on a non-nullable type |
+| `no-optional-call` | warning | scan | `fn?.()` on a non-nullable type |
+| `no-nullish-coalescing` | warning | scan | `x ?? fallback` on a non-nullable type |
+| `no-logical-or-fallback` | warning | scan | `map.get(k) \|\| fallback`, `count \|\| 1` -- `\|\|` swallows `0` and `""`; use `??` |
+| `no-null-ternary-normalization` | warning | scan | `x == null ? fallback : x` -- a hand-rolled `??`: dead if the type is non-nullable, and a sign the type needs fixing if it isn't |
+| `no-coalesce-then-guard` | warning | scan | `const x = a ?? null; if (x == null)` -- the `if` re-asks the question the `??` just answered |
+| `no-await-coalesce` | warning | audit | `await fn() ?? fallback` -- defaulting away a call's nullable result hides why it can be empty; check it and branch instead (built-in lookups like `Map.get` and `Array.find` are exempt) |
+| `no-non-null-assertion` | warning | scan | `x!` on a nullable type without a local narrowing guard |
+| `no-double-negation-coercion` | warning | scan | `!!value` inside an `if`/`while`/ternary test -- the construct already coerces (`const flag = !!x` and other places that need an actual boolean are fine) |
+| `no-redundant-existence-guard` | warning | scan | `obj && obj.prop` on a non-nullable type |
+| `no-dead-narrowing` | warning | scan | Conditions statically decided by the operand's declared type: truthiness checks that can never fail, `typeof` comparisons that can never (or must always) match, always-true `instanceof`, type-predicate calls whose argument already has the asserted type. Exempt: ambient globals (`typeof document === "undefined"` probes the environment, not the type) and, without `noUncheckedIndexedAccess`, truthiness checks (index reads erase `undefined`, so the guard may be load-bearing) |
+| `no-coalesce-undefined` | warning | scan | `x ?? undefined` where `x` can be `undefined` but never `null` -- an identity no-op |
+| `redundant-boolean-branch` | warning | scan | `cond ? true : false`, `if (cond) return true; return false;` -- the condition is already boolean. The inverted form is flagged only when the replacement is a readable `!cond`; compound conditions are never rewritten into `!(a && b)` |
+| `no-useless-await` | warning | scan | `await x` where `x`'s type has no `then` -- a no-op that suggests asynchrony that isn't there |
+| `redundant-destructure-default` | warning | scan | `const { a = fallback } = obj` where `obj.a` is required and non-undefined -- the default can never apply |
 
 ### Error handling
 
-| Rule | Severity | What it catches |
-| ---- | -------- | --------------- |
-| `no-swallowed-catch` | warning | `catch (e) {}`, `catch (e) { log(e); return fallback }`, `.catch(() => fallback)` -- error neither rethrown nor surfaced in the return value |
-| `no-error-rewrap` | error | `throw new Error(e.message)` without `{ cause: e }` |
+| Rule | Severity | Tier | What it catches |
+| ---- | -------- | ---- | --------------- |
+| `no-swallowed-catch` | warning | scan | `catch (e) {}`, `.catch(() => fallback)` -- error is neither rethrown, returned, nor passed into a handling call |
+| `no-error-rewrap` | error | scan | `throw new Error(e.message)` without `{ cause: e }` |
 
 ### Interface design
 
-| Rule | Severity | What it catches |
-| ---- | -------- | --------------- |
-| `no-inline-param-type` | warning | `(params: { id: string; ... })` — inline object type on parameter |
-| `prefer-default-param-value` | info | Optional param reassigned with `??` in the body |
-| `prefer-required-param-with-guard` | info | `arg?: T` followed by `if (!arg) throw` |
-| `no-defaulted-required-port-arg` | warning | `class C implements I { method(arg = x) }` where `I.method(arg)` is required -- the default widens the interface contract |
-| `repeated-literal-property` | warning | Same literal value repeated across object properties -- likely a missed constant |
-| `repeated-return-shape` | warning | Multiple functions return object literals with the same property names -- extract a shared return type |
-
-### State management
-
-| Rule | Severity | What it catches |
-| ---- | -------- | --------------- |
-| `no-module-state-write` | warning | Function mutates a module-scope binding (`count++`, `state.ready = ...`, `cache.set(...)`) |
+| Rule | Severity | Tier | What it catches |
+| ---- | -------- | ---- | --------------- |
+| `no-inline-param-type` | warning | audit | `(params: { id: string; ... })` -- an object type spelled out in the signature; name it so call sites and other signatures can share it |
+| `prefer-type-predicate` | warning | audit | `(x: unknown): boolean` whose body is `typeof`/`instanceof`/`in` checks -- returning `x is T` would let callers narrow |
+| `optional-param-coerced-in-body` | warning | scan | Optional param forced non-optional in the body (`x = x ?? def`, `x ??= def`, or `if (!x) throw`) |
+| `no-defaulted-required-port-arg` | warning | scan | `class C implements I { method(arg = x) }` where `I.method(arg)` is required -- the implementation quietly makes a required argument optional |
+| `repeated-literal-property` | warning | audit | Same literal value repeated across object properties -- likely a missed constant |
+| `repeated-return-shape` | warning | audit | Multiple functions return object literals with the same property names -- extract a shared return type |
+| `trivial-type-alias` | info | audit | `type Foo = Bar;` -- a second name for an existing type with no change (info: an alias marking a domain boundary is often deliberate) |
 
 ### Cross-file analysis
 
-| Rule | Severity | What it catches |
-| ---- | -------- | --------------- |
-| `duplicate-type-declaration` | warning | Same type shape in multiple files |
-| `duplicate-type-name` | warning | Same exported type name, different shapes |
-| `duplicate-function-declaration` | warning | Same function body in multiple files |
-| `duplicate-function-name` | warning | Same exported function name, different bodies |
-| `duplicate-constant-declaration` | warning | Same constant value in multiple files |
-| `duplicate-inline-type-in-params` | warning | Same inline `{ ... }` param type repeated across signatures |
-| `duplicate-file` | warning | File with identical content to another file |
-| `near-duplicate-function` | warning | Function bodies that match after renaming params and literals -- likely a copy-paste |
-| `duplicate-statement-sequence` | info | Repeated block of statements across functions or files |
-| `trivial-wrapper` | info | Function that delegates to another without transformation |
-| `unused-export` | info | Exported function with no usages in the project |
-| `optional-arg-always-used` | warning | Optional param provided at every call site |
-| `explicit-null-arg` | warning | `fn(null)` / `fn(undefined)` to project functions |
-| `dead-overload` | warning | Overload signature with zero matching project call sites |
+| Rule | Severity | Tier | What it catches |
+| ---- | -------- | ---- | --------------- |
+| `duplicate-type-declaration` | warning | audit | Same type shape in multiple files |
+| `duplicate-type-name` | warning | audit | Same exported type name, different shapes |
+| `duplicate-function-declaration` | warning | audit | Same function body in multiple files |
+| `duplicate-function-name` | warning | audit | Same exported function name, different bodies |
+| `duplicate-constant-declaration` | info | audit | Same constant value in multiple files (info: coincidental value equality is common) |
+| `duplicate-inline-type-in-params` | warning | audit | Same inline `{ ... }` param type repeated across signatures |
+| `duplicate-file` | warning | audit | File with identical content to another file |
+| `near-duplicate-function` | warning | audit | Function bodies that match after renaming params and literals -- likely a copy-paste |
+| `duplicate-statement-sequence` | warning | audit | Repeated block of statements across functions or files (identical text; lookup tables that vary only by literal data are not flagged) |
+| `trivial-wrapper` | warning | audit | Function that delegates to another without transformation (skipped when the wrapper specializes a type predicate, introduces generics, reorders args, or partially applies) |
+| `unused-export` | warning | audit | Exported function, type, or constant with no usages in the project. Imports resolve through the checker (path aliases, workspace packages) and usage is merged across tsconfig groups, so an export consumed by a sibling monorepo package counts as used. Consumers outside the scanned tree, such as a published package's API surface, are invisible to the analysis - hence audit tier |
+| `optional-arg-always-used` | warning | audit | Optional param provided at every call site -- make it required |
+| `optional-arg-never-used` | warning | audit | Optional param never provided at any call site -- remove it, inline the default |
+| `constant-argument` | warning | audit | Parameter receives the same literal at every call site -- inline the value |
+| `explicit-null-arg` | warning | audit | `fn(null)` / `fn(undefined)` passed to a project function -- the parameter invites nullish values; redesign it so callers can omit the argument |
+| `dead-overload` | warning | audit | Overload signature with zero matching project call sites |
 
 ### Imports
 
-| Rule | Severity | What it catches |
-| ---- | -------- | --------------- |
-| `no-dynamic-import` | error | `import("./module")` |
+| Rule | Severity | Tier | What it catches |
+| ---- | -------- | ---- | --------------- |
+| `no-dynamic-import` | warning | audit | `import("./module")` -- breaks static analysis (warning, not error: code-splitting and lazy loading are legitimate) |
 
 ## Annotations
 
@@ -207,8 +356,8 @@ file.ts:2:31 error Explicit `any` annotation ... (intentional escape hatch for u
 For `warning` and `info` diagnostics, you can explicitly mark a finding as intentional with `@unguard <rule-id>` on the same line or immediately above:
 
 ```typescript
-// @unguard no-module-state-write module cache is intentional in this adapter
-cache.set(user.id, user);
+// @unguard no-nullish-coalescing intentional default for legacy callers
+const port = config.port ?? 3000;
 ```
 
 `@unguard` never suppresses `error` diagnostics.
@@ -221,6 +370,7 @@ import { executeScan, scan } from "unguard";
 const result = await scan({ paths: ["src/"] }); // raw diagnostics
 const execution = await executeScan({
   paths: ["src"],
+  mode: "scan", // or "audit" for the heuristic tier
   ignore: ["**/*.gen.ts"],
   rulePolicy: {
     "duplicate-*": "warning",
@@ -228,6 +378,7 @@ const execution = await executeScan({
     "tag:safety": "error",
     "prefer-*": "off",
   },
+  overrides: [{ files: ["tests/**"], rules: { "no-non-null-assertion": "off" } }],
   showSeverities: ["error", "warning"],
   failOn: "error",
 });
@@ -245,7 +396,7 @@ run, if every file's content hash and the active rule set are unchanged,
 unguard returns cached diagnostics without building a TypeScript program.
 The cache invalidates automatically on:
 
-- file content changes (mtime-only changes are ignored — `git checkout` and `git stash` stay cache hits)
+- file content changes (mtime-only changes are ignored - `git checkout` and `git stash` stay cache hits)
 - changes to active rules or rule severities
 - changes to scan paths, ignore globs, or `failOn`
 - unguard version upgrades