unbrowse 2.12.2 → 2.12.7

package/runtime-src/graph/index.ts

@@ -291,7 +291,7 @@ function inferRequires(endpoint: EndpointDescriptor): OperationBinding[] {
       semantic_type: key.endsWith("_id") || key === "id" ? "identifier" : "input",
     });
   };
-  for (const key of Object.keys(endpoint.path_params ?? {})) add(key, "path_params", false);
+  for (const key of Object.keys(endpoint.path_params ?? {})) add(key, "path_params");
   for (const key of Object.keys(endpoint.query ?? {})) add(normalizeQueryBindingKey(key), "query", false);
   for (const match of endpoint.url_template.matchAll(/\{([^}]+)\}/g)) add(match[1], "url_template");
   return requires;
@@ -411,20 +411,6 @@ function isGenericBindingKey(key: string | undefined): boolean {
   return /^(id|ids|url|urls|page|cursor|offset|limit|slug(?:_\d+)?|pathname|domain|query|q|type|name)$/.test(key);
 }
 
-const PAGINATION_KEYS = new Set(["cursor", "page", "offset", "page_token", "next_cursor", "after", "before", "start", "next_page", "continuation_token", "skip", "from", "scroll_id"]);
-function isPaginationBindingKey(key: string): boolean {
-  return PAGINATION_KEYS.has(key) || /^(next_|prev_|previous_)/.test(key) || /_cursor$/.test(key);
-}
-
-function classifyEdgeKind(source: SkillOperationNode, target: SkillOperationNode, bindingKey: string): SkillOperationEdge["kind"] {
-  if (source.operation_id === target.operation_id && isPaginationBindingKey(bindingKey)) return "pagination";
-  const LIST_ACTIONS = new Set(["list", "search", "timeline", "trending", "feed"]);
-  const DETAIL_ACTIONS = new Set(["detail", "fetch"]);
-  if (LIST_ACTIONS.has(source.action_kind) && DETAIL_ACTIONS.has(target.action_kind) && source.resource_kind === target.resource_kind && source.resource_kind !== "resource") return "parent_child";
-  if (target.auth_required && /^(auth|login|token|session|oauth)$/.test(source.action_kind)) return "auth";
-  return "dependency";
-}
-
 function isGenericSemanticType(type: string | undefined): boolean {
   if (!type) return true;
   return /^(identifier|input|resource|value|string|number|flag)$/.test(type);
@@ -576,27 +562,6 @@ export function resolveEndpointSemantic(
 
 function buildOperationNode(endpoint: EndpointDescriptor): SkillOperationNode {
   const semantic = resolveEndpointSemantic(endpoint);
-  const normalizedRequires = (() => {
-    const byBinding = new Map<string, OperationBinding>();
-    for (const binding of semantic.requires ?? []) {
-      const pathParamValue = (endpoint.path_params as Record<string, string> | undefined)?.[binding.key];
-      const defaultedPathParam =
-        binding.source === "path_params" &&
-        typeof pathParamValue === "string" && pathParamValue !== "";
-      const normalized = defaultedPathParam ? { ...binding, required: false } : binding;
-      const id = [normalized.key, normalized.source ?? "", normalized.semantic_type ?? ""].join("|");
-      const existing = byBinding.get(id);
-      if (!existing) {
-        byBinding.set(id, normalized);
-        continue;
-      }
-      byBinding.set(id, {
-        ...existing,
-        required: existing.required && normalized.required,
-      });
-    }
-    return [...byBinding.values()];
-  })();
   return {
     operation_id: endpoint.endpoint_id,
     endpoint_id: endpoint.endpoint_id,
@@ -608,7 +573,7 @@ function buildOperationNode(endpoint: EndpointDescriptor): SkillOperationNode {
     description_in: semantic.description_in,
     description_out: semantic.description_out,
     response_summary: semantic.response_summary,
-    requires: normalizedRequires,
+    requires: semantic.requires ?? [],
     provides: semantic.provides ?? [],
     negative_tags: semantic.negative_tags ?? [],
     example_request: semantic.example_request,
@@ -694,7 +659,7 @@ export function buildSkillOperationGraph(endpoints: EndpointDescriptor[]): Skill
   for (const target of operations) {
     for (const required of target.requires) {
       for (const source of operations) {
-        if (source.operation_id === target.operation_id && !isPaginationBindingKey(required.key)) continue;
+        if (source.operation_id === target.operation_id) continue;
         const match = source.provides.find((provided) => {
           const exactKeyMatch = provided.key === required.key && !isGenericBindingKey(required.key);
           const semanticMatch =
@@ -702,14 +667,10 @@ export function buildSkillOperationGraph(endpoints: EndpointDescriptor[]): Skill
             !!required.semantic_type &&
             provided.semantic_type === required.semantic_type &&
             !isGenericSemanticType(required.semantic_type);
-          const paginationSelfMatch =
-            source.operation_id === target.operation_id &&
-            provided.key === required.key &&
-            isPaginationBindingKey(required.key);
-          return exactKeyMatch || semanticMatch || paginationSelfMatch;
+          return exactKeyMatch || semanticMatch;
         });
         if (!match) continue;
-        if (source.operation_id !== target.operation_id && !isBefore(source.observed_at, target.observed_at)) continue;
+        if (!isBefore(source.observed_at, target.observed_at)) continue;
         const edgeId = `${source.operation_id}:${target.operation_id}:${required.key}`;
         if (seenEdges.has(edgeId)) continue;
         seenEdges.add(edgeId);
@@ -718,26 +679,14 @@ export function buildSkillOperationGraph(endpoints: EndpointDescriptor[]): Skill
           from_operation_id: source.operation_id,
           to_operation_id: target.operation_id,
           binding_key: required.key,
-          kind: match.key === required.key ? classifyEdgeKind(source, target, required.key) : "hint",
+          kind: match.key === required.key ? "dependency" : "hint",
           confidence: match.key === required.key ? 0.9 : 0.6,
         });
       }
     }
   }
-
-  // Operations that are targets of dependency edges are not entry points
-  const dependencyTargets = new Set(
-    edges.filter((e) => e.kind === "dependency").map((e) => e.to_operation_id),
-  );
   const entryOperationIds = operations
-    .filter(
-      (operation) =>
-        !dependencyTargets.has(operation.operation_id) &&
-        (operation.requires.length === 0 ||
-          operation.requires.every(
-            (binding) => binding.source === "query" || binding.source === "path_params",
-          )),
-    )
+    .filter((operation) => operation.requires.length === 0 || operation.requires.every((binding) => binding.source === "query"))
     .map((operation) => operation.operation_id);
 
   return {
@@ -749,12 +698,8 @@ export function buildSkillOperationGraph(endpoints: EndpointDescriptor[]): Skill
 }
 
 export function ensureSkillOperationGraph(skill: SkillManifest): SkillOperationGraph {
-  if (skill.operation_graph?.operations?.length) {
-    // Rebuild if stored graph is stale (doesn't cover all endpoints)
-    const graphOpIds = new Set(skill.operation_graph.operations.map((op) => op.operation_id));
-    const allCovered = skill.endpoints.every((ep) => graphOpIds.has(ep.endpoint_id));
-    if (allCovered) return skill.operation_graph;
-  }
+  if (skill.endpoints.length > 0) return buildSkillOperationGraph(skill.endpoints);
+  if (skill.operation_graph?.operations?.length) return skill.operation_graph;
   return buildSkillOperationGraph(skill.endpoints);
 }
 
@@ -782,7 +727,7 @@ export function knownBindingsFromInputs(
   return known;
 }
 
-export function isRunnable(operation: SkillOperationNode, bindings: Record<string, unknown>): boolean {
+function isRunnable(operation: SkillOperationNode, bindings: Record<string, unknown>): boolean {
   return operation.requires.every((binding) => {
     if (!binding.required) return true;
     const value = bindings[binding.key];
@@ -790,69 +735,6 @@ export function isRunnable(operation: SkillOperationNode, bindings: Record<strin
   });
 }
 
-/**
- * Compute the set of reachable operation IDs given current known bindings.
- *
- * An operation is reachable (A_reachable) if:
- *   1. It has no required bindings (entry point), OR
- *   2. All its required bindings are present in knownBindings, OR
- *   3. All its required bindings can be transitively satisfied — either
- *      directly from knownBindings or from the provides of another
- *      reachable operation.
- *
- * Uses a fixpoint computation: starts with directly-runnable operations,
- * then iteratively adds operations whose requirements are met by the
- * accumulated provides of the reachable set, until no new operations
- * are added.
- */
-export function computeReachableEndpoints(
-  graph: SkillOperationGraph,
-  knownBindings: Record<string, unknown>,
-): Set<string> {
-  const reachable = new Set<string>();
-  if (!graph.operations || graph.operations.length === 0) return reachable;
-
-  // Seed: operations that are directly runnable with current bindings
-  for (const op of graph.operations) {
-    if (isRunnable(op, knownBindings)) {
-      reachable.add(op.operation_id);
-    }
-  }
-
-  // Fixpoint expansion: iterate until stable
-  let changed = true;
-  while (changed) {
-    changed = false;
-    // Collect all binding keys provided by currently reachable operations
-    const availableKeys = new Set<string>(Object.keys(knownBindings));
-    for (const op of graph.operations) {
-      if (!reachable.has(op.operation_id)) continue;
-      for (const provided of op.provides) {
-        availableKeys.add(provided.key);
-      }
-    }
-
-    // Check each non-reachable operation
-    for (const op of graph.operations) {
-      if (reachable.has(op.operation_id)) continue;
-      const allSatisfied = op.requires.every((binding) => {
-        if (!binding.required) return true;
-        // Check direct bindings first
-        const directValue = knownBindings[binding.key];
-        if (directValue != null && directValue !== "") return true;
-        // Check if any reachable operation provides this key
-        return availableKeys.has(binding.key);
-      });
-      if (allSatisfied) {
-        reachable.add(op.operation_id);
-        changed = true;
-      }
-    }
-  }
-
-  return reachable;
-}
-
 export function getSkillChunk(
   skill: SkillManifest,
   opts?: {

package/runtime-src/intent-match.ts

@@ -1266,7 +1266,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["full_name", "name", "repository.name", "path_with_namespace"]) &&
       hasAnyPath(row, ["url", "web_url", "description", "stargazers_count", "stars", "star_count", "forks_count", "owner.login", "owner"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "repository_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "repository_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(package|packages)\b/.test(lower)) {
@@ -1274,7 +1274,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["name", "package.name"]) &&
       hasAnyPath(row, ["version", "description", "summary", "url", "keywords", "requires_dist", "dependencies"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "package_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "package_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(model|models)\b/.test(lower)) {
@@ -1282,7 +1282,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["id", "modelId", "name"]) &&
       hasAnyPath(row, ["downloads", "likes", "pipeline_tag", "url"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "model_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "model_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(news|story|stories|article|articles|hacker news)\b/.test(lower)) {
@@ -1290,7 +1290,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["objectID", "id", "url", "link"]) &&
       hasAnyPath(row, ["title", "story_title", "author", "points", "num_comments", "meta"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "story_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "story_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\bsearch images\b/.test(lower)) {
@@ -1298,7 +1298,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["repo_name", "name", "full_name"]) &&
       hasAnyPath(row, ["short_description", "description", "star_count", "pull_count", "url"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "image_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "image_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(get )?image tags\b/.test(lower)) {
@@ -1306,7 +1306,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["name", "tag"]) &&
       hasAnyPath(row, ["last_updated", "updated_at", "full_size", "digest"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "tag_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "tag_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(company|companies|organization|organisations|business)\b/.test(lower)) {
@@ -1314,7 +1314,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["name", "title", "public_identifier"]) &&
       hasAnyPath(row, ["description", "industry", "url", "website", "employee_count", "follower_count"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "company_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "company_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(person|people|profile|profiles|member|members|user|users)\b/.test(lower)) {
@@ -1323,7 +1323,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["headline", "url", "public_identifier", "username"])
     );
     const minRows = /\b(profile|profiles|user|users|person)\b/.test(lower) && !/\bsearch\b/.test(lower) ? 1 : 2;
-    return matching.length >= minRows ? { verdict: "pass", reason: "people_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= minRows ? { verdict: "pass", reason: "people_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(comment|comments)\b/.test(lower)) {
@@ -1331,7 +1331,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["id", "url", "permalink"]) &&
       hasAnyPath(row, ["author", "body", "text"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "comment_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "comment_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(email|emails|mail|inbox)\b/.test(lower)) {
@@ -1340,20 +1340,20 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["subject", "thread.subject", "from", "sender", "thread.latest_sender_name"]) &&
       hasAnyPath(row, ["date", "thread.formatted_date", "preview", "thread.preview", "matchedEmail.content_markdown"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "email_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "email_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(post|posts|tweet|tweets|status|statuses)\b/.test(lower)) {
     const matching = objects.filter((row) =>
-      hasAnyPath(row, ["id", "url", "uri", "permalink", "_id", "entityUrn", "rest_id"]) &&
+      hasAnyPath(row, ["id", "url", "uri", "permalink"]) &&
       countMatchingGroups(row, [
-        ["content", "text", "title", "body", "message", "description", "summary", "commentary.text.text"],
-        ["account.username", "account.acct", "username", "author", "user.name", "from.name", "actor.name", "actor.name.text"],
-        ["score", "points", "likes", "favorite_count", "num_comments", "reply_count", "reactions", "repost_count"],
-        ["date", "created_at", "published_at", "timestamp", "meta", "created_time", "createdAt", "updated_at", "time"],
+        ["content", "text", "title", "body"],
+        ["account.username", "account.acct", "username", "author", "user.name"],
+        ["score", "points", "likes", "favorite_count", "num_comments", "reply_count"],
+        ["date", "created_at", "published_at", "timestamp", "meta"],
       ]) >= 2
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "post_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "post_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(reddit|subreddit)\b/.test(lower)) {
@@ -1362,7 +1362,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["title", "subreddit", "author"]) &&
       hasAnyPath(row, ["num_comments", "score", "permalink"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "reddit_post_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "reddit_post_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(topic|topics|trend|trending|hashtag|hashtags)\b/.test(lower)) {
@@ -1370,7 +1370,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["name", "title", "query"]) &&
       hasAnyPath(row, ["url", "name", "query"])
     );
-    return matching.length >= 2 ? { verdict: "pass", reason: "topic_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 2 ? { verdict: "pass", reason: "topic_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(doc|docs|documentation)\b/.test(lower)) {
@@ -1379,7 +1379,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["url", "link", "href", "mdn_url"]) &&
       hasAnyPath(row, ["summary", "description", "slug", "popularity", "score"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "document_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "document_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(paper|papers)\b/.test(lower)) {
@@ -1388,7 +1388,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["url", "link", "href"]) &&
       hasAnyPath(row, ["summary", "description", "author", "authors", "date", "published", "meta"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "paper_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "paper_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(question|questions)\b/.test(lower)) {
@@ -1401,7 +1401,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
         ["author", "date", "created_at", "meta"],
       ]) >= 2
     );
-    return matching.length >= 2 ? { verdict: "pass", reason: "question_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 2 ? { verdict: "pass", reason: "question_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(recipe|recipes)\b/.test(lower)) {
@@ -1410,7 +1410,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["url", "link", "href"]) &&
       hasAnyPath(row, ["rating", "review_count", "author", "description", "summary", "cook_time", "total_time"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "recipe_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "recipe_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(course|courses)\b/.test(lower)) {
@@ -1419,7 +1419,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["url", "link", "href"]) &&
       hasAnyPath(row, ["rating", "partner", "provider", "instructor", "description", "summary", "duration", "level"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "course_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "course_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(definition|dictionary|meaning)\b/.test(lower)) {
@@ -1427,7 +1427,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["term", "title", "name", "word"]) &&
       hasAnyPath(row, ["definition", "summary", "body", "description"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "definition_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "definition_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(stock|stocks|ticker|tickers|quote|quotes)\b/.test(lower)) {
@@ -1436,7 +1436,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["price", "regularMarketPrice", "current_price"]) &&
       hasAnyPath(row, ["name", "currency", "change_percent", "market_cap", "market_state"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "quote_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "quote_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(product|products|item|items)\b/.test(lower)) {
@@ -1453,7 +1453,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
         String(getPath(row, "url") ?? ""),
       )
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "product_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "product_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   if (/\b(channel|channels|server|servers|guild|guilds|workspace|workspaces)\b/.test(lower)) {
@@ -1462,7 +1462,7 @@ function classifyRows(rows: unknown[], intent: string): { verdict: "pass" | "fai
       hasAnyPath(row, ["id", "url", "channel_id", "guild_id", "workspace_id"]) &&
       hasAnyPath(row, ["description", "type", "member_count", "url"])
     );
-    return matching.length >= 1 ? { verdict: "pass", reason: "channel_rows" } : { verdict: "skip", reason: "wrong_entity_type" };
+    return matching.length >= 1 ? { verdict: "pass", reason: "channel_rows" } : { verdict: "fail", reason: "wrong_entity_type" };
   }
 
   return { verdict: "skip", reason: "unclassified_array" };