ummaya 0.2.4 → 0.2.6

package/tui/src/tools/FileEditTool/call.ts

@@ -0,0 +1,228 @@
+import { dirname, sep } from 'path'
+import { logEvent } from 'src/services/analytics/index.js'
+import { getFeatureValue_CACHED_MAY_BE_STALE } from '../../services/analytics/growthbook.js'
+import { diagnosticTracker } from '../../services/diagnosticTracking.js'
+import { clearDeliveredDiagnosticsForFile } from '../../services/lsp/LSPDiagnosticRegistry.js'
+import { notifyVscodeFileUpdated } from '../../services/mcp/vscodeSdkMcp.js'
+import {
+  activateConditionalSkillsForPaths,
+  addSkillDirectories,
+  discoverSkillDirsForPaths,
+} from '../../skills/loadSkillsDir.js'
+import type { ToolResult, ToolUseContext } from '../../Tool.js'
+import type { AssistantMessage } from '../../types/message.js'
+import { getCwd } from '../../utils/cwd.js'
+import { logForDebugging } from '../../utils/debug.js'
+import { countLinesChanged } from '../../utils/diff.js'
+import { isEnvTruthy } from '../../utils/envUtils.js'
+import { isENOENT } from '../../utils/errors.js'
+import { getFileModificationTime, writeTextContent } from '../../utils/file.js'
+import { logFileOperation } from '../../utils/fileOperationAnalytics.js'
+import {
+  type LineEndingType,
+  readFileSyncWithMetadata,
+} from '../../utils/fileRead.js'
+import { getFsImplementation } from '../../utils/fsOperations.js'
+import {
+  fetchSingleFileGitDiff,
+  type ToolUseDiff,
+} from '../../utils/gitDiff.js'
+import { logError } from '../../utils/log.js'
+import { expandPath } from '../../utils/path.js'
+import { documentDerivativeMutationValidationForResolvedTarget } from '../DocumentPrimitive/documentMutationGuard.js'
+import { FILE_UNEXPECTEDLY_MODIFIED_ERROR } from './constants.js'
+import type { FileEditInput, FileEditOutput } from './types.js'
+import {
+  findActualString,
+  getPatchForEdit,
+  preserveQuoteStyle,
+} from './utils.js'
+
+export async function callFileEditTool(
+  input: FileEditInput,
+  {
+    readFileState,
+    userModified,
+    updateFileHistoryState,
+    dynamicSkillDirTriggers,
+  }: ToolUseContext,
+  parentMessage: AssistantMessage,
+): Promise<ToolResult<FileEditOutput>> {
+  const { file_path, old_string, new_string, replace_all = false } = input
+  const fs = getFsImplementation()
+  const absoluteFilePath = expandPath(file_path)
+  const documentValidation =
+    documentDerivativeMutationValidationForResolvedTarget(absoluteFilePath)
+  if (documentValidation !== null) throw new Error(documentValidation.message)
+
+  const cwd = getCwd()
+  if (!isEnvTruthy(process.env.CLAUDE_CODE_SIMPLE)) {
+    const newSkillDirs = await discoverSkillDirsForPaths(
+      [absoluteFilePath],
+      cwd,
+    )
+    if (newSkillDirs.length > 0) {
+      for (const dir of newSkillDirs) {
+        dynamicSkillDirTriggers?.add(dir)
+      }
+      addSkillDirectories(newSkillDirs).catch(() => {})
+    }
+
+    activateConditionalSkillsForPaths([absoluteFilePath], cwd)
+  }
+
+  await diagnosticTracker.beforeFileEdited(absoluteFilePath)
+
+  await fs.mkdir(dirname(absoluteFilePath))
+  const { fileHistoryEnabled, fileHistoryTrackEdit } = await import(
+    '../../utils/fileHistory.js'
+  )
+  if (fileHistoryEnabled()) {
+    await fileHistoryTrackEdit(
+      updateFileHistoryState,
+      absoluteFilePath,
+      parentMessage.uuid,
+    )
+  }
+
+  const {
+    content: originalFileContents,
+    fileExists,
+    encoding,
+    lineEndings: endings,
+  } = readFileForEdit(absoluteFilePath)
+
+  if (fileExists) {
+    const lastWriteTime = getFileModificationTime(absoluteFilePath)
+    const lastRead = readFileState.get(absoluteFilePath)
+    if (!lastRead || lastWriteTime > lastRead.timestamp) {
+      const isFullRead =
+        lastRead &&
+        lastRead.offset === undefined &&
+        lastRead.limit === undefined
+      const contentUnchanged =
+        isFullRead && originalFileContents === lastRead.content
+      if (!contentUnchanged) {
+        throw new Error(FILE_UNEXPECTEDLY_MODIFIED_ERROR)
+      }
+    }
+  }
+
+  const actualOldString =
+    findActualString(originalFileContents, old_string) || old_string
+  const actualNewString = preserveQuoteStyle(
+    old_string,
+    actualOldString,
+    new_string,
+  )
+
+  const { patch, updatedFile } = getPatchForEdit({
+    filePath: absoluteFilePath,
+    fileContents: originalFileContents,
+    oldString: actualOldString,
+    newString: actualNewString,
+    replaceAll: replace_all,
+  })
+
+  writeTextContent(absoluteFilePath, updatedFile, encoding, endings)
+
+  const { getLspServerManager } = await import('../../services/lsp/manager.js')
+  const lspManager = getLspServerManager()
+  if (lspManager) {
+    clearDeliveredDiagnosticsForFile(`file://${absoluteFilePath}`)
+    lspManager
+      .changeFile(absoluteFilePath, updatedFile)
+      .catch((err: Error) => {
+        logForDebugging(
+          `LSP: Failed to notify server of file change for ${absoluteFilePath}: ${err.message}`,
+        )
+        logError(err)
+      })
+    lspManager.saveFile(absoluteFilePath).catch((err: Error) => {
+      logForDebugging(
+        `LSP: Failed to notify server of file save for ${absoluteFilePath}: ${err.message}`,
+      )
+      logError(err)
+    })
+  }
+
+  notifyVscodeFileUpdated(absoluteFilePath, originalFileContents, updatedFile)
+
+  readFileState.set(absoluteFilePath, {
+    content: updatedFile,
+    timestamp: getFileModificationTime(absoluteFilePath),
+    offset: undefined,
+    limit: undefined,
+  })
+
+  if (absoluteFilePath.endsWith(`${sep}CLAUDE.md`)) {
+    logEvent('tengu_write_claudemd', {})
+  }
+  countLinesChanged(patch)
+
+  logFileOperation({
+    operation: 'edit',
+    tool: 'FileEditTool',
+    filePath: absoluteFilePath,
+  })
+
+  logEvent('tengu_edit_string_lengths', {
+    oldStringBytes: Buffer.byteLength(old_string, 'utf8'),
+    newStringBytes: Buffer.byteLength(new_string, 'utf8'),
+    replaceAll: replace_all,
+  })
+
+  let gitDiff: ToolUseDiff | undefined
+  if (
+    isEnvTruthy(process.env.CLAUDE_CODE_REMOTE) &&
+    getFeatureValue_CACHED_MAY_BE_STALE('tengu_quartz_lantern', false)
+  ) {
+    const startTime = Date.now()
+    const diff = await fetchSingleFileGitDiff(absoluteFilePath)
+    if (diff) gitDiff = diff
+    logEvent('tengu_tool_use_diff_computed', {
+      isEditTool: true,
+      durationMs: Date.now() - startTime,
+      hasDiff: !!diff,
+    })
+  }
+
+  const data: FileEditOutput = {
+    filePath: file_path,
+    oldString: actualOldString,
+    newString: new_string,
+    originalFile: originalFileContents,
+    structuredPatch: patch,
+    userModified: userModified ?? false,
+    replaceAll: replace_all,
+    ...(gitDiff && { gitDiff }),
+  }
+  return { data }
+}
+
+function readFileForEdit(absoluteFilePath: string): {
+  content: string
+  fileExists: boolean
+  encoding: BufferEncoding
+  lineEndings: LineEndingType
+} {
+  try {
+    const meta = readFileSyncWithMetadata(absoluteFilePath)
+    return {
+      content: meta.content,
+      fileExists: true,
+      encoding: meta.encoding,
+      lineEndings: meta.lineEndings,
+    }
+  } catch (e) {
+    if (isENOENT(e)) {
+      return {
+        content: '',
+        fileExists: false,
+        encoding: 'utf8',
+        lineEndings: 'LF',
+      }
+    }
+    throw e
+  }
+}

package/tui/src/tools/FileEditTool/validateInput.ts

@@ -0,0 +1,196 @@
+import { checkTeamMemSecrets } from '../../services/teamMemorySync/teamMemSecretGuard.js'
+import type { ToolUseContext, ValidationResult } from '../../Tool.js'
+import { getCwd } from '../../utils/cwd.js'
+import { isENOENT } from '../../utils/errors.js'
+import {
+  FILE_NOT_FOUND_CWD_NOTE,
+  findSimilarFile,
+  getFileModificationTime,
+  suggestPathUnderCwd,
+} from '../../utils/file.js'
+import { formatFileSize } from '../../utils/format.js'
+import { getFsImplementation } from '../../utils/fsOperations.js'
+import { expandPath } from '../../utils/path.js'
+import { matchingRuleForInput } from '../../utils/permissions/filesystem.js'
+import { validateInputForSettingsFileEdit } from '../../utils/settings/validateEditTool.js'
+import { documentDerivativeMutationValidationForResolvedTarget } from '../DocumentPrimitive/documentMutationGuard.js'
+import { NOTEBOOK_EDIT_TOOL_NAME } from '../NotebookEditTool/constants.js'
+import type { FileEditInput } from './types.js'
+import { findActualString } from './utils.js'
+
+const MAX_EDIT_FILE_SIZE = 1024 * 1024 * 1024
+
+export async function validateFileEditInput(
+  input: FileEditInput,
+  toolUseContext: ToolUseContext,
+): Promise<ValidationResult> {
+  const { file_path, old_string, new_string, replace_all = false } = input
+  const fullFilePath = expandPath(file_path)
+  const documentValidation =
+    documentDerivativeMutationValidationForResolvedTarget(fullFilePath)
+  if (documentValidation !== null) return documentValidation
+
+  const secretError = checkTeamMemSecrets(fullFilePath, new_string)
+  if (secretError) {
+    return { result: false, message: secretError, errorCode: 0 }
+  }
+  if (old_string === new_string) {
+    return {
+      result: false,
+      message:
+        'No changes to make: old_string and new_string are exactly the same.',
+      errorCode: 1,
+    }
+  }
+
+  const appState = toolUseContext.getAppState()
+  const denyRule = matchingRuleForInput(
+    fullFilePath,
+    appState.toolPermissionContext,
+    'edit',
+    'deny',
+  )
+  if (denyRule !== null) {
+    return {
+      result: false,
+      message:
+        'File is in a directory that is denied by your permission settings.',
+      errorCode: 2,
+    }
+  }
+
+  if (fullFilePath.startsWith('\\\\') || fullFilePath.startsWith('//')) {
+    return { result: true }
+  }
+
+  const fs = getFsImplementation()
+  try {
+    const { size } = await fs.stat(fullFilePath)
+    if (size > MAX_EDIT_FILE_SIZE) {
+      return {
+        result: false,
+        message: `File is too large to edit (${formatFileSize(size)}). Maximum editable file size is ${formatFileSize(MAX_EDIT_FILE_SIZE)}.`,
+        errorCode: 10,
+      }
+    }
+  } catch (e) {
+    if (!isENOENT(e)) {
+      throw e
+    }
+  }
+
+  let fileContent: string | null
+  try {
+    const fileBuffer = await fs.readFileBytes(fullFilePath)
+    const encoding: BufferEncoding =
+      fileBuffer.length >= 2 &&
+      fileBuffer[0] === 0xff &&
+      fileBuffer[1] === 0xfe
+        ? 'utf16le'
+        : 'utf8'
+    fileContent = fileBuffer.toString(encoding).replaceAll('\r\n', '\n')
+  } catch (e) {
+    if (isENOENT(e)) {
+      fileContent = null
+    } else {
+      throw e
+    }
+  }
+
+  if (fileContent === null) {
+    if (old_string === '') {
+      return { result: true }
+    }
+    const similarFilename = findSimilarFile(fullFilePath)
+    const cwdSuggestion = await suggestPathUnderCwd(fullFilePath)
+    let message = `File does not exist. ${FILE_NOT_FOUND_CWD_NOTE} ${getCwd()}.`
+
+    if (cwdSuggestion) {
+      message += ` Did you mean ${cwdSuggestion}?`
+    } else if (similarFilename) {
+      message += ` Did you mean ${similarFilename}?`
+    }
+
+    return {
+      result: false,
+      message,
+      errorCode: 4,
+    }
+  }
+
+  if (old_string === '') {
+    if (fileContent.trim() !== '') {
+      return {
+        result: false,
+        message: 'Cannot create new file - file already exists.',
+        errorCode: 3,
+      }
+    }
+
+    return { result: true }
+  }
+
+  if (fullFilePath.endsWith('.ipynb')) {
+    return {
+      result: false,
+      message: `File is a Jupyter Notebook. Use the ${NOTEBOOK_EDIT_TOOL_NAME} to edit this file.`,
+      errorCode: 5,
+    }
+  }
+
+  const readTimestamp = toolUseContext.readFileState.get(fullFilePath)
+  if (!readTimestamp || readTimestamp.isPartialView) {
+    return {
+      result: false,
+      message: 'File has not been read yet. Read it first before writing to it.',
+      errorCode: 6,
+    }
+  }
+
+  const lastWriteTime = getFileModificationTime(fullFilePath)
+  if (lastWriteTime > readTimestamp.timestamp) {
+    const isFullRead =
+      readTimestamp.offset === undefined && readTimestamp.limit === undefined
+    if (!isFullRead || fileContent !== readTimestamp.content) {
+      return {
+        result: false,
+        message:
+          'File has been modified since read, either by the user or by a linter. Read it again before attempting to write it.',
+        errorCode: 7,
+      }
+    }
+  }
+
+  const actualOldString = findActualString(fileContent, old_string)
+  if (!actualOldString) {
+    return {
+      result: false,
+      message: `String to replace not found in file.\nString: ${old_string}`,
+      errorCode: 8,
+    }
+  }
+
+  const matches = fileContent.split(actualOldString).length - 1
+  if (matches > 1 && !replace_all) {
+    return {
+      result: false,
+      message: `Found ${matches} matches of the string to replace, but replace_all is false. To replace all occurrences, set replace_all to true. To replace only one occurrence, please provide more context to uniquely identify the instance.\nString: ${old_string}`,
+      errorCode: 9,
+    }
+  }
+
+  const settingsValidationResult = validateInputForSettingsFileEdit(
+    fullFilePath,
+    fileContent,
+    () =>
+      replace_all
+        ? fileContent.replaceAll(actualOldString, new_string)
+        : fileContent.replace(actualOldString, new_string),
+  )
+
+  if (settingsValidationResult !== null) {
+    return settingsValidationResult
+  }
+
+  return { result: true }
+}

package/tui/src/tools/FileReadTool/imageProcessor.ts

@@ -3,6 +3,19 @@ import { isInBundledMode } from '../../utils/bundledMode.js'
 
 export type SharpInstance = {
   metadata(): Promise<{ width: number; height: number; format: string }>
+  extract(options: {
+    left: number
+    top: number
+    width: number
+    height: number
+  }): SharpInstance
+  composite(
+    images: Array<{
+      input: Buffer
+      left?: number
+      top?: number
+    }>,
+  ): SharpInstance
   resize(
     width: number,
     height: number,