ultra-builder-pro-cli 0.23.0 → 0.24.1

package/mcp-server/lib/decision-records.cjs

@@ -0,0 +1,337 @@
+'use strict';
+
+const canonical = require('./canonical-json.cjs');
+const artifactRegistry = require('./artifact-registry.cjs');
+const ops = require('./state-ops.cjs');
+const { writeManagedJson } = require('./managed-file-write.cjs');
+const { readStableProjectFile } = require('./safe-project-file.cjs');
+
+class DecisionRecordError extends Error {
+  constructor(code, message, details) {
+    super(message);
+    this.name = 'DecisionRecordError';
+    this.code = code;
+    if (details) this.details = details;
+  }
+}
+
+function requiredText(value, field) {
+  const normalized = typeof value === 'string' ? value.trim() : '';
+  if (!normalized) throw new DecisionRecordError('VALIDATION_ERROR', `${field} is required`);
+  return normalized;
+}
+
+function plainObject(value, field) {
+  if (value === undefined) return {};
+  if (!value || typeof value !== 'object' || Array.isArray(value)) {
+    throw new DecisionRecordError('VALIDATION_ERROR', `${field} must be an object`);
+  }
+  return JSON.parse(JSON.stringify(value));
+}
+
+function stringArray(value, field) {
+  if (value === undefined) return [];
+  if (!Array.isArray(value)) {
+    throw new DecisionRecordError('VALIDATION_ERROR', `${field} must be an array`);
+  }
+  return value.map((item, index) => requiredText(item, `${field}[${index}]`));
+}
+
+function normalizeScope(scope = {}) {
+  const baseline = typeof scope.baseline_id === 'string' ? scope.baseline_id.trim() : '';
+  const change = typeof scope.change_id === 'string' ? scope.change_id.trim() : '';
+  if (Boolean(baseline) === Boolean(change)) {
+    throw new DecisionRecordError(
+      'VALIDATION_ERROR',
+      'decision scope must contain exactly one of baseline_id or change_id',
+    );
+  }
+  return baseline
+    ? { type: 'baseline', id: baseline }
+    : { type: 'change', id: change };
+}
+
+function parseJson(value, fallback) {
+  try { return value == null ? fallback : JSON.parse(value); }
+  catch { return fallback; }
+}
+
+function rowToDecision(row) {
+  if (!row) return null;
+  return {
+    id: row.id,
+    scope: { [`${row.scope_type}_id`]: row.scope_id },
+    scope_type: row.scope_type,
+    scope_id: row.scope_id,
+    question: row.question,
+    recommendation: row.recommendation,
+    selection: row.selection,
+    effects: parseJson(row.effects_json, {}),
+    non_goals: parseJson(row.non_goals_json, []),
+    owner: row.owner,
+    source: row.source,
+    provenance: parseJson(row.provenance_json, {}),
+    applied_refs: parseJson(row.applied_refs_json, []),
+    status: row.status,
+    digest: row.digest,
+    artifact_path: row.artifact_path,
+    supersedes_id: row.supersedes_id,
+    created_at: row.created_at,
+    updated_at: row.updated_at,
+  };
+}
+
+function readDecision(db, id) {
+  return rowToDecision(db.prepare('SELECT * FROM decision_records WHERE id = ?').get(id));
+}
+
+function decisionValue(decision) {
+  return {
+    schema_version: '1.0',
+    id: decision.id,
+    scope: { type: decision.scope_type, id: decision.scope_id },
+    question: decision.question,
+    recommendation: decision.recommendation,
+    selection: decision.selection,
+    effects: decision.effects,
+    non_goals: decision.non_goals,
+    owner: decision.owner,
+    source: decision.source,
+    provenance: decision.provenance,
+    applied_refs: decision.applied_refs,
+    status: decision.status,
+    supersedes_id: decision.supersedes_id || null,
+  };
+}
+
+function readDecisionArtifact(db, id, { rootDir = process.cwd() } = {}) {
+  const decision = readDecision(db, id);
+  if (!decision) {
+    throw new DecisionRecordError('DECISION_NOT_FOUND', `decision not found: ${id}`);
+  }
+  const computed = canonical.digest(decisionValue(decision));
+  if (computed !== decision.digest) {
+    throw new DecisionRecordError(
+      'DECISION_DIGEST_MISMATCH',
+      `Decision Record database authority is corrupt: ${id}`,
+      { expected: decision.digest, actual: computed },
+    );
+  }
+  const read = readStableProjectFile(rootDir, decision.artifact_path, { encoding: 'utf8' });
+  const artifact = db.prepare(
+    `SELECT digest FROM artifacts
+     WHERE path = ? AND status <> 'archived'
+     ORDER BY updated_at DESC, rowid DESC LIMIT 1`,
+  ).get(decision.artifact_path) || db.prepare(
+    `SELECT digest FROM artifacts
+     WHERE path = ? ORDER BY updated_at DESC, rowid DESC LIMIT 1`,
+  ).get(decision.artifact_path);
+  if (!artifact?.digest || artifact.digest !== read.digest) {
+    throw new DecisionRecordError(
+      'DECISION_FILE_DRIFT',
+      `Decision Record bytes no longer match the Artifact Registry: ${id}`,
+      {
+        path: decision.artifact_path,
+        expected: artifact?.digest || null,
+        actual: read.digest,
+      },
+    );
+  }
+  let document;
+  try { document = JSON.parse(read.text); }
+  catch (cause) {
+    throw new DecisionRecordError(
+      'DECISION_ARTIFACT_INVALID',
+      `Decision Record is not valid JSON: ${decision.artifact_path}`,
+      { cause: cause.message },
+    );
+  }
+  const { digest: documentDigest, ...documentValue } = document;
+  if (documentDigest !== decision.digest
+      || canonical.digest(documentValue) !== decision.digest) {
+    throw new DecisionRecordError(
+      'DECISION_DIGEST_MISMATCH',
+      `Decision Record file does not match its accepted authority: ${id}`,
+    );
+  }
+  return { ...decision, file_digest: read.digest };
+}
+
+function listAcceptedDecisions(
+  db,
+  scope = {},
+  { limit = 100, rootDir = null, validateFiles = false } = {},
+) {
+  const normalized = normalizeScope(scope);
+  const rows = db.prepare(
+    `SELECT * FROM decision_records
+     WHERE scope_type = ? AND scope_id = ? AND status = 'accepted'
+     ORDER BY updated_at DESC, id ASC LIMIT ?`,
+  ).all(
+    normalized.type,
+    normalized.id,
+    Math.min(Math.max(Number(limit) || 100, 1), 500),
+  ).map(rowToDecision);
+  return validateFiles
+    ? rows.map((row) => readDecisionArtifact(db, row.id, { rootDir }))
+    : rows;
+}
+
+function normalizeAppliedRefs(value) {
+  if (value === undefined) return [];
+  if (!Array.isArray(value)) {
+    throw new DecisionRecordError('VALIDATION_ERROR', 'applied_refs must be an array');
+  }
+  return value.map((item, index) => {
+    if (!item || typeof item !== 'object' || Array.isArray(item)) {
+      throw new DecisionRecordError('VALIDATION_ERROR', `applied_refs[${index}] must be an object`);
+    }
+    return {
+      ref: requiredText(item.ref, `applied_refs[${index}].ref`),
+      ...(item.field ? { field: requiredText(item.field, `applied_refs[${index}].field`) } : {}),
+      ...(item.digest ? { digest: requiredText(item.digest, `applied_refs[${index}].digest`) } : {}),
+    };
+  });
+}
+
+function artifactPath(scope, id) {
+  return scope.type === 'baseline'
+    ? `.ultra/decisions/baseline/${id}.json`
+    : `.ultra/changes/active/${scope.id}/decisions/${id}.json`;
+}
+
+function acceptDecision(db, input = {}, { rootDir = process.cwd() } = {}) {
+  const scope = normalizeScope(input.scope);
+  const value = {
+    schema_version: '1.0',
+    id: requiredText(input.id, 'id'),
+    scope: { type: scope.type, id: scope.id },
+    question: requiredText(input.question, 'question'),
+    recommendation: requiredText(input.recommendation, 'recommendation'),
+    selection: requiredText(input.selection, 'selection'),
+    effects: plainObject(input.effects, 'effects'),
+    non_goals: stringArray(input.non_goals, 'non_goals'),
+    owner: requiredText(input.owner, 'owner'),
+    source: requiredText(input.source, 'source'),
+    provenance: plainObject(input.provenance, 'provenance'),
+    applied_refs: normalizeAppliedRefs(input.applied_refs),
+    status: 'accepted',
+    supersedes_id: input.supersedes_id
+      ? requiredText(input.supersedes_id, 'supersedes_id')
+      : null,
+  };
+  const digest = canonical.digest(value);
+  const document = { ...value, digest };
+  const relative = artifactPath(scope, value.id);
+  const existing = readDecision(db, value.id);
+  if (existing) {
+    if (existing.digest !== digest) {
+      throw new DecisionRecordError(
+        'DECISION_ID_CONFLICT',
+        `decision ${value.id} already exists with different content`,
+      );
+    }
+    return existing;
+  }
+  if (value.supersedes_id) {
+    const prior = readDecision(db, value.supersedes_id);
+    if (!prior) {
+      throw new DecisionRecordError(
+        'DECISION_NOT_FOUND',
+        `superseded decision not found: ${value.supersedes_id}`,
+      );
+    }
+    if (prior.scope_type !== scope.type || prior.scope_id !== scope.id) {
+      throw new DecisionRecordError(
+        'DECISION_SCOPE_CONFLICT',
+        'a decision can only supersede another decision in the same scope',
+      );
+    }
+  }
+  const published = writeManagedJson(rootDir, relative, document);
+  return ops.tx(db, () => {
+    if (value.supersedes_id) {
+      db.prepare(
+        `UPDATE decision_records SET status = 'superseded',
+         updated_at = strftime('%Y-%m-%dT%H:%M:%fZ', 'now')
+         WHERE id = ? AND status = 'accepted'`,
+      ).run(value.supersedes_id);
+    }
+    db.prepare(
+      `INSERT INTO decision_records
+       (id, scope_type, scope_id, question, recommendation, selection,
+        effects_json, non_goals_json, owner, source, provenance_json,
+        applied_refs_json, status, digest, artifact_path, supersedes_id)
+       VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 'accepted', ?, ?, ?)`,
+    ).run(
+      value.id,
+      scope.type,
+      scope.id,
+      value.question,
+      value.recommendation,
+      value.selection,
+      JSON.stringify(value.effects),
+      JSON.stringify(value.non_goals),
+      value.owner,
+      value.source,
+      JSON.stringify(value.provenance),
+      JSON.stringify(value.applied_refs),
+      digest,
+      relative,
+      value.supersedes_id,
+    );
+    artifactRegistry.recordArtifactInTx(db, {
+      id: `artifact-decision-${value.id}`,
+      owner_type: scope.type,
+      owner_id: scope.id,
+      change_id: scope.type === 'change' ? scope.id : null,
+      kind: 'decision_record',
+      path: relative,
+      content_digest: published.digest,
+      source_refs: [{
+        type: scope.type,
+        id: scope.id,
+        relation: 'decided_for',
+      }],
+      consumer_refs: [{
+        type: 'external',
+        id: 'ultra-context-consumer',
+        relation: 'consumed_by',
+      }],
+      provenance: {
+        writer: 'decision-records',
+        decision_digest: digest,
+        owner: value.owner,
+        source: value.source,
+      },
+      metadata: {
+        decision_id: value.id,
+        status: value.status,
+        supersedes_id: value.supersedes_id,
+      },
+    }, { rootDir });
+    ops.appendEventInTx(db, {
+      type: 'decision_recorded',
+      change_id: scope.type === 'change' ? scope.id : null,
+      payload: {
+        decision_id: value.id,
+        scope_type: scope.type,
+        scope_id: scope.id,
+        digest,
+        artifact_path: relative,
+        supersedes_id: value.supersedes_id,
+      },
+    });
+    return readDecision(db, value.id);
+  });
+}
+
+module.exports = {
+  DecisionRecordError,
+  normalizeScope,
+  readDecision,
+  readDecisionArtifact,
+  decisionValue,
+  listAcceptedDecisions,
+  acceptDecision,
+};

package/mcp-server/lib/doctor.cjs

@@ -13,8 +13,7 @@ const recovery = require('../../orchestrator/recovery.cjs');
 const baselines = require('./baseline-workflow.cjs');
 const changes = require('./change-workflow.cjs');
 const archiveJournal = require('./archive-journal.cjs');
-const workflows = require('./workflow-state.cjs');
-const decisions = require('./decision-dialogue.cjs');
+const stageCheckpoints = require('./stage-checkpoints.cjs');
 const runtimePaths = require('./runtime-paths.cjs');
 const artifactRegistry = require('./artifact-registry.cjs');
 const planStore = require('./plan-store.cjs');
@@ -107,6 +106,76 @@ function inspectTeamTaskLedger(db, rootDir) {
   }
 }
 
+function inspectStageCheckpoints(db) {
+  const rows = db.prepare(
+    `SELECT id, stage, scope_type, scope_id, revision, status, payload_json,
+            evidence_json, diagnostics_json, context_envelope_id, digest,
+            supersedes_id
+     FROM stage_checkpoints ORDER BY stage, scope_type, scope_id, revision`,
+  ).all();
+  const counts = { draft: 0, accepted: 0, superseded: 0 };
+  const issues = [];
+  for (const row of rows) {
+    counts[row.status] = Number(counts[row.status] || 0) + 1;
+    let payload;
+    let evidence;
+    let diagnostics;
+    try {
+      payload = JSON.parse(row.payload_json);
+      evidence = JSON.parse(row.evidence_json);
+      diagnostics = JSON.parse(row.diagnostics_json);
+    } catch {
+      issues.push({ code: 'CHECKPOINT_JSON_INVALID', checkpoint_id: row.id });
+      continue;
+    }
+    const expected = stageCheckpoints.checkpointDigest({
+      stage: row.stage,
+      scope_type: row.scope_type,
+      scope_id: row.scope_id,
+      revision: row.revision,
+      payload,
+      evidence,
+      diagnostics,
+      context_envelope_id: row.context_envelope_id,
+      supersedes_id: row.supersedes_id,
+    });
+    if (expected !== row.digest) {
+      issues.push({ code: 'CHECKPOINT_DIGEST_MISMATCH', checkpoint_id: row.id });
+    }
+  }
+  return {
+    status: issues.length === 0 ? 'pass' : 'fail',
+    total: rows.length,
+    ...counts,
+    issues,
+  };
+}
+
+function inspectDecisionRecords(db) {
+  const rows = db.prepare(
+    `SELECT id, status, digest, artifact_path
+     FROM decision_records ORDER BY created_at, id`,
+  ).all();
+  return {
+    status: 'pass',
+    total: rows.length,
+    accepted: rows.filter((row) => row.status === 'accepted').length,
+    superseded: rows.filter((row) => row.status === 'superseded').length,
+  };
+}
+
+function inspectLegacyHistory(db) {
+  const count = (table) => db.prepare(`SELECT COUNT(*) AS count FROM ${table}`).get().count;
+  return {
+    status: 'informational',
+    workflow_runs: count('workflow_runs'),
+    workflow_steps: count('workflow_steps'),
+    decision_threads: count('decision_threads'),
+    decision_items: count('decision_items'),
+    authority: false,
+  };
+}
+
 function inspectSystem(db, { rootDir = process.cwd() } = {}) {
   const tables = new Set(tableNames(db));
   const missing = REQUIRED_TABLES.filter((name) => !tables.has(name));
@@ -141,18 +210,21 @@ function inspectSystem(db, { rootDir = process.cwd() } = {}) {
   const baseline = missing.length === 0
     ? baselines.inspectBaseline(db, { rootDir })
     : { status: 'fail', blockers: ['BASELINE_STATE_UNAVAILABLE'], warnings: [], baseline: null };
-  const workflowHealth = missing.length === 0
-    ? workflows.inspectWorkflowHealth(db, { rootDir })
-    : {
-      status: 'fail', active: 0, blocked: 0, ready: 0, stale_outputs: [],
-      historical_stale_outputs: [], terminal_authority_runs: [], untracked_active_changes: [],
-    };
+  const checkpointHealth = missing.length === 0
+    ? inspectStageCheckpoints(db)
+    : { status: 'fail', total: 0, issues: [{ code: 'STATE_DB_UNAVAILABLE' }] };
   const decisionHealth = missing.length === 0
-    ? decisions.inspectDecisionHealth(db, { rootDir })
+    ? inspectDecisionRecords(db)
+    : { status: 'fail', total: 0, accepted: 0, superseded: 0 };
+  const legacyHistory = missing.length === 0
+    ? inspectLegacyHistory(db)
     : {
-      status: 'fail', active: 0, completed: 0, awaiting_owner: 0, awaiting_blocking: 0,
-      checkpoint_ready: 0,
-      deferred_blocking: 0, stale_artifacts: [], current: null, current_thread_id: null,
+      status: 'informational',
+      workflow_runs: 0,
+      workflow_steps: 0,
+      decision_threads: 0,
+      decision_items: 0,
+      authority: false,
     };
   const artifactHealth = missing.length === 0
     ? artifactRegistry.inspectArtifactHealth(db, { rootDir })
@@ -170,7 +242,7 @@ function inspectSystem(db, { rootDir = process.cwd() } = {}) {
     || pending.length > 0 || running.length > 0 || failed.length > 0 || orphanSessions > 0 || activeMissing > 0
     || sessionCloses.status === 'fail'
     || archiveIntents.length > 0
-    || eventCursor > projectedCursor || workflowHealth.status === 'fail'
+    || eventCursor > projectedCursor || checkpointHealth.status === 'fail'
     || decisionHealth.status === 'fail'
     || artifactHealth.status === 'fail'
     || planPublications.status === 'fail'
@@ -213,22 +285,9 @@ function inspectSystem(db, { rootDir = process.cwd() } = {}) {
         blockers: baseline.blockers,
         warnings: baseline.warnings,
       },
-      workflows: {
-        status: workflowHealth.status === 'fail'
-          ? 'fail'
-          : (workflowHealth.blocked > 0
-            || workflowHealth.historical_stale_outputs.length > 0
-            || workflowHealth.terminal_authority_runs.length > 0
-            || workflowHealth.untracked_active_changes.length > 0 ? 'warning' : 'pass'),
-        active: workflowHealth.active,
-        blocked: workflowHealth.blocked,
-        ready: workflowHealth.ready,
-        stale_outputs: workflowHealth.stale_outputs,
-        historical_stale_outputs: workflowHealth.historical_stale_outputs,
-        terminal_authority_runs: workflowHealth.terminal_authority_runs,
-        untracked_active_changes: workflowHealth.untracked_active_changes,
-      },
+      checkpoints: checkpointHealth,
       decisions: decisionHealth,
+      legacy_history: legacyHistory,
       external_providers: {
         status: 'pass', ownership: 'external',
         note: 'Ultra stores provider metadata references only and never owns memory or code-graph content.',
@@ -469,7 +528,7 @@ async function runDoctor(db, {
         recovered,
         plan_publications: deferred,
         archives: deferred,
-        workflows: deferred,
+        legacy_history: deferred,
       },
     };
   }
@@ -496,7 +555,7 @@ async function runDoctor(db, {
         recovered,
         plan_publications: planGate,
         archives: deferred,
-        workflows: deferred,
+        legacy_history: deferred,
         spec_events: deferred,
         interrupted: deferred,
         requeued: deferred,
@@ -529,7 +588,7 @@ async function runDoctor(db, {
         recovered,
         plan_publications: planPublications,
         archives: archiveGate,
-        workflows: deferred,
+        legacy_history: deferred,
         spec_events: deferred,
         interrupted: deferred,
         requeued: deferred,
@@ -538,7 +597,6 @@ async function runDoctor(db, {
       },
     };
   }
-  const workflowRecovery = workflows.recoverUntrackedChangeWorkflows(db, { rootDir });
   const cursor = runtime.readConsumerCursor(db, SPEC_CONSUMER);
   const consumed = ops.consumeSpecChangedEvents(db, { since_id: cursor, limit: 500 });
   runtime.writeConsumerCursor(db, SPEC_CONSUMER, consumed.next_since_id);
@@ -555,7 +613,7 @@ async function runDoctor(db, {
     repair: {
       close_intents: recovered,
       plan_publications: planPublications,
-      archives, workflows: workflowRecovery, recovered, consumed,
+      archives, recovered, consumed,
       interrupted, requeued, ensured, projections,
     },
   };