ultimate-unreal-engine-mcp 0.1.11 → 0.1.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ultimate-unreal-engine-mcp",
-  "version": "0.1.11",
+  "version": "0.1.13",
   "description": "MCP server giving AI assistants full access to Unreal Engine 5.7 projects",
   "type": "module",
   "engines": {

package/unreal-plugin/MCPBridge/Source/MCPBridgeEditor/Private/MCPAssetCommands.cpp

@@ -348,7 +348,25 @@ void RegisterAssetCommands(FMCPCommandRouter& Router)
 			return;
 		}
 
-		// Create package and the object inside it.
+		// Check if the asset already exists (e.g. from a previous session that saved to disk).
+		UObject* Existing = StaticFindObject(AssetClass, nullptr, *AssetPath);
+		if (!Existing)
+		{
+			// Also check disk — LoadObject will find .uasset files from a prior save.
+			Existing = LoadObject<UObject>(nullptr, *AssetPath);
+		}
+		if (Existing)
+		{
+			// Asset already exists — return success with existing path.
+			TSharedPtr<FJsonObject> Data = MakeShared<FJsonObject>();
+			Data->SetStringField(TEXT("path"), AssetPath);
+			Data->SetStringField(TEXT("class"), ClassName);
+			Data->SetBoolField(TEXT("created"), false);
+			Data->SetBoolField(TEXT("already_exists"), true);
+			SendResponse(BuildSuccessResponse(CorrId, Data));
+			return;
+		}
+
 		UPackage* Package = CreatePackage(*AssetPath);
 		if (!Package)
 		{
@@ -419,21 +437,26 @@ void RegisterAssetCommands(FMCPCommandRouter& Router)
 			}
 		}
 
-		// Notify asset registry and save.
+		// Notify asset registry.
 		FAssetRegistryModule::AssetCreated(NewAsset);
 		NewAsset->MarkPackageDirty();
 		Package->SetDirtyFlag(true);
 
-		// Auto-save so the asset persists.
+		// Save to disk — ensure parent directory exists first.
+		bool bSaved = false;
 		FString FilePath = FPackageName::LongPackageNameToFilename(AssetPath, FPackageName::GetAssetPackageExtension());
+		FString FileDir = FPaths::GetPath(FilePath);
+		IFileManager::Get().MakeDirectory(*FileDir, true);
+
 		FSavePackageArgs SaveArgs;
 		SaveArgs.TopLevelFlags = RF_Public | RF_Standalone;
-		UPackage::SavePackage(Package, NewAsset, *FilePath, SaveArgs);
+		bSaved = UPackage::SavePackage(Package, NewAsset, *FilePath, SaveArgs);
 
 		TSharedPtr<FJsonObject> Data = MakeShared<FJsonObject>();
 		Data->SetStringField(TEXT("path"), AssetPath);
 		Data->SetStringField(TEXT("class"), ClassName);
 		Data->SetBoolField(TEXT("created"), true);
+		Data->SetBoolField(TEXT("saved_to_disk"), bSaved);
 
 		SendResponse(BuildSuccessResponse(CorrId, Data));
 	});
@@ -472,6 +495,22 @@ void RegisterAssetCommands(FMCPCommandRouter& Router)
 		FString PackagePath, AssetName;
 		AssetPath.Split(TEXT("/"), &PackagePath, &AssetName, ESearchCase::IgnoreCase, ESearchDir::FromEnd);
 
+		// Check if the curve already exists.
+		UObject* Existing = StaticFindObject(UCurveFloat::StaticClass(), nullptr, *AssetPath);
+		if (!Existing)
+		{
+			Existing = LoadObject<UCurveFloat>(nullptr, *AssetPath);
+		}
+		if (Existing)
+		{
+			TSharedPtr<FJsonObject> Data = MakeShared<FJsonObject>();
+			Data->SetStringField(TEXT("path"), AssetPath);
+			Data->SetBoolField(TEXT("created"), false);
+			Data->SetBoolField(TEXT("already_exists"), true);
+			SendResponse(BuildSuccessResponse(CorrId, Data));
+			return;
+		}
+
 		UPackage* Package = CreatePackage(*AssetPath);
 		if (!Package)
 		{
@@ -522,10 +561,15 @@ void RegisterAssetCommands(FMCPCommandRouter& Router)
 		Curve->MarkPackageDirty();
 		Package->SetDirtyFlag(true);
 
+		// Save to disk.
+		bool bSaved = false;
 		FString FilePath = FPackageName::LongPackageNameToFilename(AssetPath, FPackageName::GetAssetPackageExtension());
+		FString FileDir = FPaths::GetPath(FilePath);
+		IFileManager::Get().MakeDirectory(*FileDir, true);
+
 		FSavePackageArgs SaveArgs;
 		SaveArgs.TopLevelFlags = RF_Public | RF_Standalone;
-		UPackage::SavePackage(Package, Curve, *FilePath, SaveArgs);
+		bSaved = UPackage::SavePackage(Package, Curve, *FilePath, SaveArgs);
 
 		TSharedPtr<FJsonObject> Data = MakeShared<FJsonObject>();
 		Data->SetStringField(TEXT("path"), AssetPath);

package/unreal-plugin/MCPBridge/Source/MCPBridgeEditor/Private/MCPImportExportCommands.cpp

@@ -236,9 +236,15 @@ void RegisterImportExportCommands(FMCPCommandRouter& Router)
 		Payload->TryGetBoolField(TEXT("combine_meshes"), bCombineMeshes);
 		Payload->TryGetNumberField(TEXT("scale_factor"), ScaleFactor);
 
-		// Capture everything for async dispatch.
-		AsyncTask(ENamedThreads::GameThread, [CorrId, SendResponse, SourceFile, DestPath,
-			bImportMaterials, bCombineMeshes, ScaleFactor]()
+		// Defer the import to the next engine tick via FTSTicker.
+		// Reason: ImportAssetTasks triggers the Interchange pipeline which
+		// enqueues task-graph work.  Running it inside the router's
+		// AsyncTask(GameThread) hits the recursion guard (Assertion
+		// ++Queue.RecursionGuard == 1).  A ticker callback runs on the
+		// game thread but OUTSIDE the task-graph scope.
+		FTSTicker::GetCoreTicker().AddTicker(
+			FTickerDelegate::CreateLambda([CorrId, SendResponse, SourceFile, DestPath,
+				bImportMaterials, bCombineMeshes, ScaleFactor](float) -> bool
 		{
 			// Split dest_path into package path + asset name.
 			FString PackagePath = DestPath;
@@ -307,7 +313,8 @@ void RegisterImportExportCommands(FMCPCommandRouter& Router)
 			Data->SetNumberField(TEXT("count"), static_cast<double>(AssetsArray.Num()));
 
 			SendResponse(BuildImpSuccessResponse(CorrId, Data) + TEXT("\n"));
-		});
+			return false; // One-shot: remove ticker after execution
+		}), 0.0f);
 	});
 
 	// -----------------------------------------------------------------------
@@ -753,7 +760,9 @@ void RegisterImportExportCommands(FMCPCommandRouter& Router)
 		Payload->TryGetBoolField(TEXT("import_materials"), bImportMaterials);
 		Payload->TryGetNumberField(TEXT("scale_factor"), ScaleFactor);
 
-		AsyncTask(ENamedThreads::GameThread, [CorrId, SendResponse, Directory, DestPath, Extensions, bImportMaterials, ScaleFactor]()
+		// Defer to next tick to avoid Interchange task-graph recursion (same as import.fbx fix).
+		FTSTicker::GetCoreTicker().AddTicker(
+			FTickerDelegate::CreateLambda([CorrId, SendResponse, Directory, DestPath, Extensions, bImportMaterials, ScaleFactor](float) -> bool
 		{
 			// Enumerate all matching files in the directory.
 			TArray<FString> FoundFiles;
@@ -843,6 +852,7 @@ void RegisterImportExportCommands(FMCPCommandRouter& Router)
 			Data->SetArrayField(TEXT("errors"), ErrorsArray);
 
 			SendResponse(BuildImpSuccessResponse(CorrId, Data) + TEXT("\n"));
-		});
+			return false; // One-shot: remove ticker after execution
+		}), 0.0f);
 	});
 }