ultimate-pi 0.19.1 → 0.22.0

package/.pi/agents/pi-pi/prompt-expert.md

@@ -20,10 +20,25 @@ You are a prompt templates expert for the Pi coding agent. You know EVERYTHING a
 ```markdown
 ---
 description: What this template does
+argument-hint: "<required>" [optional flags]
 ---
 Your prompt content here with $1 and $@ arguments
 ```
 
+### Autocomplete (`description` + `argument-hint`)
+
+Pi shows both in the `/` menu ([prompt-templates.md](https://github.com/badlogic/pi-mono/blob/main/packages/coding-agent/docs/prompt-templates.md)):
+
+- `description` — what the command does (required for shipped ultimate-pi prompts).
+- `argument-hint` — shown **before** the description in the menu.
+  - `<angle brackets>` — required arguments
+  - `[square brackets]` — optional arguments
+  - Omit `argument-hint` entirely when the command takes no user arguments (do not use `argument-hint: ""`).
+
+Example menu line: `→ plan   "<task>" [--quick]  — PM-grade harness plan…`
+
+**Extension-only commands** (no `.md` template) use `pi.registerCommand({ getArgumentCompletions })` — see `.pi/lib/harness-slash-completions.ts` and [extensions.md](https://github.com/badlogic/pi-mono/blob/main/packages/coding-agent/docs/extensions.md). `harness-verify` enforces prompt frontmatter on shipped `.pi/prompts/*.md`.
+
 ### Arguments
 
 - `$1`, `$2`, ... — positional arguments
@@ -61,8 +76,8 @@ Your prompt content here with $1 and $@ arguments
 
 ### Description
 
-- Optional frontmatter field
-- If missing, first non-empty line is used as description
+- Required on ultimate-pi shipped prompts (`harness-verify` checks)
+- If missing upstream, Pi falls back to the first non-empty body line
 - Shown in autocomplete when typing `/`
 
 ## CRITICAL: First Action

package/.pi/auto-commit.json

@@ -2,7 +2,8 @@
 	"dryRun": false,
 	"coAuthor": {
 		"login": "pi-mono",
-		"email": "261679550+pi-mono@users.noreply.github.com"
+		"email": "261679550+pi-mono@users.noreply.github.com",
+		"required": true
 	},
 	"branch": {
 		"strategy": "auto-feature-branch",
@@ -15,6 +16,12 @@
 		"ignore": true
 	},
 	"message": {
-		"scopeDefault": "harness"
+		"template": "{type}({scope}): {subject}",
+		"templateNoScope": "{type}: {subject}",
+		"typeDefault": "chore",
+		"scopeDefault": "harness",
+		"bodySeparator": "\n\n",
+		"coAuthorTrailer": "Co-authored-by: {login} <{email}>",
+		"maxSubjectLength": 72
 	}
 }

package/.pi/extensions/debate-orchestrator.ts

@@ -18,6 +18,7 @@ import {
 } from "../lib/debate-bus-state.js";
 import { isHarnessProjectEnabled } from "../lib/harness-project-config.js";
 import { getRunIdFromSession } from "../lib/harness-run-context.js";
+import { completeDebateOpen } from "../lib/harness-slash-completions.js";
 import { normalizePlanDebateId } from "../lib/plan-debate-id.js";
 import { initPlanMessenger } from "../lib/plan-messenger.js";
 
@@ -55,6 +56,8 @@ export default function debateOrchestrator(pi: ExtensionAPI) {
 
 	pi.registerCommand("harness-debate-open", {
 		description: "Open a headless debate session",
+		getArgumentCompletions: (prefix) =>
+			completeDebateOpen(prefix, process.cwd()),
 		handler: async (args, ctx) => {
 			const runId = getRunId(ctx);
 			const trimmed = args.trim();

package/.pi/extensions/harness-anchored-edit.ts

@@ -0,0 +1,139 @@
+/**
+ * Hash-anchored read/edit — first-class harness read and edit tools (always on).
+ * @see .pi/harness/docs/adrs/0051-hash-anchored-executor-edits.md
+ */
+import { resolve } from "node:path";
+import type { TextContent } from "@earendil-works/pi-ai";
+import {
+	createReadTool,
+	type ExtensionAPI,
+} from "@earendil-works/pi-coding-agent";
+import { Type } from "typebox";
+import {
+	anchoredEditTaskId,
+	applyAnchoredEditsToFile,
+	hashLinesStateful,
+} from "../lib/harness-anchored-edit/index.js";
+import type { AnchoredEdit } from "../lib/harness-anchored-edit/types.js";
+
+const anchoredEditEntrySchema = Type.Object({
+	anchor: Type.String({
+		description:
+			"Start anchor from read output, format Word§exact line text (e.g. Apple§const x = 1).",
+	}),
+	end_anchor: Type.Optional(
+		Type.String({
+			description: "End anchor for replace ranges (same format as anchor).",
+		}),
+	),
+	edit_type: Type.Optional(
+		Type.Union([
+			Type.Literal("replace"),
+			Type.Literal("insert_after"),
+			Type.Literal("insert_before"),
+		]),
+	),
+	text: Type.String({ description: "New text for insert/replace." }),
+});
+
+const anchoredEditSchema = Type.Object({
+	path: Type.String({ description: "Path to the file to edit." }),
+	edits: Type.Array(anchoredEditEntrySchema, {
+		description:
+			"Batch all edits for this file in one call. Use anchors from the latest read.",
+	}),
+});
+
+const readSchema = Type.Object({
+	path: Type.String({ description: "Path to the file to read." }),
+	offset: Type.Optional(Type.Number({ description: "1-based start line." })),
+	limit: Type.Optional(Type.Number({ description: "Max lines to read." })),
+});
+
+function stripAnchoredFromReadOutput(text: string): string {
+	return text
+		.split("\n")
+		.map((line) => {
+			const idx = line.indexOf("§");
+			if (idx === -1) return line;
+			const prefix = line.slice(0, idx);
+			if (/^[A-Z][a-zA-Z]*$/.test(prefix)) {
+				return line.slice(idx + 1);
+			}
+			return line;
+		})
+		.join("\n");
+}
+
+export default function harnessAnchoredEdit(pi: ExtensionAPI): void {
+	const readToolByCwd = new Map<string, ReturnType<typeof createReadTool>>();
+
+	function getReadTool(cwd: string) {
+		let tool = readToolByCwd.get(cwd);
+		if (!tool) {
+			tool = createReadTool(cwd);
+			readToolByCwd.set(cwd, tool);
+		}
+		return tool;
+	}
+
+	pi.registerTool({
+		name: "read",
+		label: "read",
+		description:
+			"Read a file; each line is prefixed with a stable anchor (Word§line). Use those anchors in edit.",
+		parameters: readSchema,
+		async execute(toolCallId, params, signal, onUpdate, ctx) {
+			const base = getReadTool(ctx.cwd);
+			const result = await base.execute(toolCallId, params, signal, onUpdate);
+			const taskId = anchoredEditTaskId({
+				sessionId: (ctx as { sessionId?: string }).sessionId,
+			});
+			const absolutePath = resolve(ctx.cwd, params.path);
+			for (const block of result.content) {
+				if (block.type !== "text") continue;
+				const plain = stripAnchoredFromReadOutput(block.text);
+				block.text = hashLinesStateful(absolutePath, plain, taskId);
+			}
+			return result;
+		},
+	});
+
+	pi.registerTool({
+		name: "edit",
+		label: "edit",
+		description:
+			"Edit using line anchors from read. Batch multiple edits per file. For replace, set end_anchor (defaults to anchor for single-line replace).",
+		parameters: anchoredEditSchema,
+		promptGuidelines: [
+			"Use anchors from the latest read output (Word§line).",
+			"Batch all edits for one file in a single edit call.",
+			"For renames across files: sg -p to locate, then minimal anchored edits — do not use replace_symbol tools.",
+		],
+		async execute(_toolCallId, params, _signal, _onUpdate, ctx) {
+			const absolutePath = resolve(ctx.cwd, params.path);
+			const taskId = anchoredEditTaskId({
+				sessionId: (ctx as { sessionId?: string }).sessionId,
+			});
+			const edits = params.edits as AnchoredEdit[];
+
+			const result = await applyAnchoredEditsToFile(
+				absolutePath,
+				edits,
+				taskId,
+			);
+
+			if (!result.ok) {
+				return {
+					content: [{ type: "text", text: result.error }] as TextContent[],
+					details: { error: true },
+				};
+			}
+
+			return {
+				content: [{ type: "text", text: result.message }] as TextContent[],
+				details: result.details,
+			};
+		},
+	});
+}

package/.pi/extensions/harness-ask-user.ts

@@ -1,23 +1,16 @@
 /**
  * harness-ask-user — structured user decisions for harness planning and setup.
- * Design references: pi-ask-user, @pi-unipi/ask-user, rpiv-ask-user-question (not vendored).
  */
 
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
-import { runAskDialog } from "../lib/ask-user/dialog.js";
-import { runAskFallback } from "../lib/ask-user/fallback.js";
+import { runAskUser } from "../lib/ask-user/index.js";
 import { renderAskCall, renderAskResult } from "../lib/ask-user/render.js";
 import {
 	AskUserParamsSchema,
 	PROMPT_GUIDELINES,
 	PROMPT_SNIPPET,
 } from "../lib/ask-user/schema.js";
-import type { AskUserParams, DialogResult } from "../lib/ask-user/types.js";
-import {
-	formatResultText,
-	toToolDetails,
-	validateAskParams,
-} from "../lib/ask-user/validate.js";
+import type { AskUserParams } from "../lib/ask-user/types.js";
 import { claimHarnessGovernanceLoad } from "../lib/extension-load-guard.js";
 
 // @ts-expect-error pi extensions run as ESM
@@ -35,36 +28,22 @@ export default function harnessAskUser(pi: ExtensionAPI) {
 		parameters: AskUserParamsSchema,
 
 		async execute(_toolCallId, params, _signal, _onUpdate, ctx) {
-			const validated = validateAskParams(params as AskUserParams);
-			if (typeof validated === "string") {
+			const result = await runAskUser(params as AskUserParams, {
+				ui: ctx.ui,
+				hasUI: ctx.hasUI,
+				sessionName: undefined,
+			});
+
+			if ("error" in result) {
 				return {
-					content: [{ type: "text", text: validated }],
-					details: {
-						question: params.question ?? "",
-						options: [],
-						response: null,
-						cancelled: true,
-					},
+					content: [{ type: "text", text: result.error }],
+					details: result.details,
 				};
 			}
 
-			let outcome: DialogResult;
-			if (ctx.hasUI) {
-				outcome = await runAskDialog(ctx.ui, validated);
-			} else {
-				outcome = await runAskFallback(ctx.ui, validated);
-			}
-
-			const details = toToolDetails(
-				validated,
-				outcome.response,
-				outcome.cancelled,
-			);
-			const text = formatResultText(outcome.response, outcome.cancelled);
-
 			return {
-				content: [{ type: "text", text }],
-				details,
+				content: result.content,
+				details: result.details,
 			};
 		},
 

package/.pi/extensions/harness-debate-tools.ts

@@ -51,7 +51,6 @@ import {
 	withReviewRoundYamlWrite,
 } from "../lib/harness-debate-workflow-deps.js";
 
-// @ts-expect-error pi extensions run as ESM
 const MODULE_URL = import.meta.url;
 
 function getRunId(ctx: {
@@ -98,9 +97,7 @@ function subagentResults(
 
 const USE_SUBMIT_TOOLS = process.env.HARNESS_SUBMIT_TOOLS !== "0";
 
-export default function harnessDebateTools(pi: ExtensionAPI) {
-	if (!claimHarnessGovernanceLoad("harness-debate-tools", MODULE_URL)) return;
-
+function registerHarnessDebateHandler1(pi: ExtensionAPI) {
 	pi.on("tool_result", async (event, ctx) => {
 		if (event.isError || event.toolName !== "subagent") return;
 		const runId = getRunId(ctx);
@@ -171,7 +168,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			details: { applied, status },
 		});
 	});
+}
 
+function registerHarnessDebateHandler2(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_plan_debate_eligibility",
 		label: "Plan Debate Eligibility",
@@ -247,7 +246,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			};
 		},
 	});
+}
 
+function registerHarnessDebateHandler3(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_debate_open",
 		label: "Open Plan Debate",
@@ -332,7 +333,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			};
 		},
 	});
+}
 
+function registerHarnessDebateHandler4(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_messenger_post",
 		label: "Post Debate Messenger Message",
@@ -397,7 +400,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			};
 		},
 	});
+}
 
+function registerHarnessDebateHandler5(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_messenger_read_round",
 		label: "Read Debate Round Transcript",
@@ -422,7 +427,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			};
 		},
 	});
+}
 
+function registerHarnessDebateHandler6(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_debate_submit_round",
 		label: "Submit Plan Review Round",
@@ -551,7 +558,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			};
 		},
 	});
+}
 
+function registerHarnessDebateHandler7(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_debate_consensus",
 		label: "Finalize Plan Debate Consensus",
@@ -590,7 +599,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			};
 		},
 	});
+}
 
+function registerHarnessDebateHandler8(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_debate_apply_lane",
 		label: "Apply Debate Lane YAML + Messenger",
@@ -624,7 +635,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			};
 		},
 	});
+}
 
+function registerHarnessDebateHandler9(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_debate_round_status",
 		label: "Plan Debate Round Status",
@@ -669,7 +682,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			};
 		},
 	});
+}
 
+function registerHarnessDebateHandler10(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_debate_focus_coverage",
 		label: "Plan Debate Focus Coverage",
@@ -712,7 +727,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			};
 		},
 	});
+}
 
+function registerHarnessDebateHandler11(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_debate_advance_thread",
 		label: "Advance Plan Debate Thread",
@@ -746,7 +763,9 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 			};
 		},
 	});
+}
 
+function registerHarnessDebateHandler12(pi: ExtensionAPI) {
 	pi.registerTool({
 		name: "harness_plan_scope_check",
 		label: "Plan Scope Drift Check",
@@ -771,3 +790,23 @@ export default function harnessDebateTools(pi: ExtensionAPI) {
 		},
 	});
 }
+
+function registerHarnessDebateToolHandlers(pi: ExtensionAPI) {
+	registerHarnessDebateHandler1(pi);
+	registerHarnessDebateHandler2(pi);
+	registerHarnessDebateHandler3(pi);
+	registerHarnessDebateHandler4(pi);
+	registerHarnessDebateHandler5(pi);
+	registerHarnessDebateHandler6(pi);
+	registerHarnessDebateHandler7(pi);
+	registerHarnessDebateHandler8(pi);
+	registerHarnessDebateHandler9(pi);
+	registerHarnessDebateHandler10(pi);
+	registerHarnessDebateHandler11(pi);
+	registerHarnessDebateHandler12(pi);
+}
+
+export default function harnessDebateTools(pi: ExtensionAPI) {
+	if (!claimHarnessGovernanceLoad("harness-debate-tools", MODULE_URL)) return;
+	registerHarnessDebateToolHandlers(pi);
+}

package/.pi/extensions/harness-live-widget.ts

@@ -84,28 +84,37 @@ function visibleWidth(input: string): number {
 	return width;
 }
 
+const WIDE_SINGLE_CODE_POINTS = new Set([0x2329, 0x232a]);
+const WIDE_RANGES: ReadonlyArray<readonly [number, number]> = [
+	[0x1100, 0x115f],
+	[0x2e80, 0xa4cf],
+	[0xac00, 0xd7a3],
+	[0xf900, 0xfaff],
+	[0xfe10, 0xfe19],
+	[0xfe30, 0xfe6f],
+	[0xff00, 0xff60],
+	[0xffe0, 0xffe6],
+	[0x1f300, 0x1faff],
+	[0x20000, 0x3fffd],
+];
+
+function inRange(codePoint: number, start: number, end: number): boolean {
+	return codePoint >= start && codePoint <= end;
+}
+
+function isWideCodePoint(codePoint: number): boolean {
+	if (WIDE_SINGLE_CODE_POINTS.has(codePoint)) return true;
+	if (inRange(codePoint, 0x2e80, 0xa4cf) && codePoint === 0x303f) return false;
+	return WIDE_RANGES.some(([start, end]) => inRange(codePoint, start, end));
+}
+
 function charDisplayWidth(char: string): number {
 	const codePoint = char.codePointAt(0);
 	if (codePoint == null) return 0;
-	if (codePoint <= 0x1f || (codePoint >= 0x7f && codePoint <= 0x9f)) return 0;
-	if (codePoint >= 0x300 && codePoint <= 0x36f) return 0;
-	if (
-		codePoint >= 0x1100 &&
-		(codePoint <= 0x115f ||
-			codePoint === 0x2329 ||
-			codePoint === 0x232a ||
-			(codePoint >= 0x2e80 && codePoint <= 0xa4cf && codePoint !== 0x303f) ||
-			(codePoint >= 0xac00 && codePoint <= 0xd7a3) ||
-			(codePoint >= 0xf900 && codePoint <= 0xfaff) ||
-			(codePoint >= 0xfe10 && codePoint <= 0xfe19) ||
-			(codePoint >= 0xfe30 && codePoint <= 0xfe6f) ||
-			(codePoint >= 0xff00 && codePoint <= 0xff60) ||
-			(codePoint >= 0xffe0 && codePoint <= 0xffe6) ||
-			(codePoint >= 0x1f300 && codePoint <= 0x1faff) ||
-			(codePoint >= 0x20000 && codePoint <= 0x3fffd))
-	) {
-		return 2;
-	}
+	if (inRange(codePoint, 0x00, 0x1f) || inRange(codePoint, 0x7f, 0x9f))
+		return 0;
+	if (inRange(codePoint, 0x300, 0x36f)) return 0;
+	if (isWideCodePoint(codePoint)) return 2;
 	return 1;
 }