ultimate-pi 0.10.0 → 0.11.0

package/.pi/extensions/lib/harness-subagents/parent-harness-ui-bridge.ts

@@ -1,13 +1,11 @@
 /**
- * Registers ask_user and approve_plan in subagent sessions, delegating UI to the parent harness session.
+ * Registers ask_user in subagent sessions, delegating UI to the parent harness session.
  */
 
 import type {
 	ExtensionAPI,
 	ExtensionContext,
 } from "@earendil-works/pi-coding-agent";
-import { Text } from "@earendil-works/pi-tui";
-import { Type } from "@sinclair/typebox";
 import type {
 	PlanPacketLike,
 	PlanUserApproval,
@@ -27,32 +25,8 @@ import {
 	toToolDetails,
 	validateAskParams,
 } from "../ask-user/validate.js";
-import {
-	CREATE_PLAN_GUIDELINES,
-	CREATE_PLAN_SNIPPET,
-	executeCreatePlan,
-	formatCreatePlanResultText,
-} from "../plan-approval/create-plan.js";
-import { runPlanApprovalDialog } from "../plan-approval/dialog.js";
-import { runPlanApprovalFallback } from "../plan-approval/fallback.js";
-import {
-	renderApprovePlanCall,
-	renderApprovePlanResult,
-} from "../plan-approval/render.js";
-import {
-	ApprovePlanParamsSchema,
-	PROMPT_GUIDELINES as PLAN_PROMPT_GUIDELINES,
-	PROMPT_SNIPPET as PLAN_PROMPT_SNIPPET,
-} from "../plan-approval/schema.js";
-import type { ApprovePlanParams } from "../plan-approval/types.js";
-import {
-	formatApprovePlanResultText,
-	toApprovePlanToolDetails,
-	validateApprovePlanParams,
-} from "../plan-approval/validate.js";
 
 const HARNESS_UI_AGENT_TYPES = new Set([
-	"harness/planner",
 	"harness/evaluator",
 	"harness/adversary",
 	"harness/tie-breaker",
@@ -76,18 +50,6 @@ export interface ParentHarnessUiHooks {
 	) => void;
 }
 
-const CreatePlanParamsSchema = Type.Object({
-	plan_packet: Type.Object(
-		{},
-		{
-			description:
-				"Approved PlanPacket to persist (same object as approve_plan).",
-		},
-	),
-});
-
-const PLANNER_ONLY_AGENT = "harness/planner";
-
 export function agentTypeAllowsParentHarnessUi(agentType: string): boolean {
 	return HARNESS_UI_AGENT_TYPES.has(agentType);
 }
@@ -120,7 +82,7 @@ export function createParentHarnessUiBridgeFactory(
 			name: "ask_user",
 			label: "Ask User",
 			description:
-				"Ask the user a structured question (parent session UI). Use for clarification — not final plan approval (use approve_plan).",
+				"Ask the user a structured question (parent session UI). Plan approval uses approve_plan on the parent orchestrator only.",
 			promptSnippet: ASK_PROMPT_SNIPPET,
 			promptGuidelines: ASK_PROMPT_GUIDELINES,
 			parameters: AskUserParamsSchema,
@@ -162,137 +124,6 @@ export function createParentHarnessUiBridgeFactory(
 				return renderAskResult(result, options, theme);
 			},
 		});
-
-		if (agentType !== PLANNER_ONLY_AGENT) {
-			return;
-		}
-
-		pi.registerTool({
-			name: "approve_plan",
-			label: "Approve Plan",
-			description:
-				"Present the full PlanPacket for user approval in the parent TUI (scrollable overlay).",
-			promptSnippet: PLAN_PROMPT_SNIPPET,
-			promptGuidelines: PLAN_PROMPT_GUIDELINES,
-			parameters: ApprovePlanParamsSchema,
-			async execute(_toolCallId, params, _signal, _onUpdate) {
-				const validated = validateApprovePlanParams(
-					params as ApprovePlanParams,
-				);
-				if (typeof validated === "string") {
-					return {
-						content: [{ type: "text", text: validated }],
-						details: {
-							plan_packet: (params as ApprovePlanParams).plan_packet ?? {},
-							options: [],
-							response: null,
-							cancelled: true,
-						},
-					};
-				}
-
-				hooks?.appendPlanDraft?.({
-					plan_packet: validated.plan_packet,
-					human_summary: validated.human_summary,
-				});
-
-				let outcome: DialogResult;
-				if (parentCtx.hasUI) {
-					outcome = await runPlanApprovalDialog(parentCtx.ui, validated);
-				} else {
-					outcome = await runPlanApprovalFallback(parentCtx.ui, validated);
-				}
-				const details = toApprovePlanToolDetails(
-					validated,
-					outcome.response,
-					outcome.cancelled,
-				);
-				notifyPlanApproval(hooks, details, "approve_plan");
-				const text = formatApprovePlanResultText(
-					outcome.response,
-					outcome.cancelled,
-				);
-				return {
-					content: [{ type: "text", text }],
-					details,
-				};
-			},
-			renderCall(args, theme) {
-				return renderApprovePlanCall(args, theme);
-			},
-			renderResult(result, options, theme) {
-				return renderApprovePlanResult(result, options, theme);
-			},
-		});
-
-		pi.registerTool({
-			name: "create_plan",
-			label: "Create Plan",
-			description:
-				"Write the approved PlanPacket to the canonical plan-packet.json for this harness run. Requires approve_plan Approve first. Do not use write/edit.",
-			promptSnippet: CREATE_PLAN_SNIPPET,
-			promptGuidelines: CREATE_PLAN_GUIDELINES,
-			parameters: CreatePlanParamsSchema,
-			async execute(_toolCallId, params, _signal, _onUpdate, ctx) {
-				const validated = validateApprovePlanParams(
-					params as ApprovePlanParams,
-				);
-				if (typeof validated === "string") {
-					return {
-						content: [{ type: "text", text: validated }],
-						details: { error: validated },
-					};
-				}
-				const projectRoot = hooks?.projectRoot ?? parentCtx.cwd;
-				const parentEntries = hooks?.getParentEntries?.() ?? [];
-				const subEntries = ctx.sessionManager.getEntries();
-				const result = await executeCreatePlan(validated.plan_packet, {
-					projectRoot,
-					getParentEntries: () => parentEntries,
-					getSubagentEntries: () => subEntries,
-					getParentRunContext: () => hooks?.getParentRunContext?.() ?? null,
-					onCommitted: (runCtx, packet, planPath) => {
-						hooks?.onPlanCommitted?.(runCtx, packet, planPath);
-					},
-				});
-				const text = formatCreatePlanResultText(result);
-				return {
-					content: [{ type: "text", text }],
-					details: result.ok
-						? {
-								plan_path: result.planPath,
-								plan_id: result.planId,
-							}
-						: { error: result.error },
-					isError: !result.ok,
-				};
-			},
-			renderCall(args, theme) {
-				const packet = (args as { plan_packet?: PlanPacketLike }).plan_packet;
-				const id = packet?.plan_id ?? "?";
-				return new Text(theme.fg("accent", `create_plan: ${id}`), 0, 0);
-			},
-			renderResult(result, _options, theme) {
-				const details = result.details as
-					| { plan_path?: string; error?: string }
-					| undefined;
-				if (details?.error) {
-					return new Text(
-						theme.fg("error", details.error ?? "create_plan failed"),
-						0,
-						0,
-					);
-				}
-				return new Text(
-					theme.fg(
-						"success",
-						`Wrote ${details?.plan_path ?? "plan-packet.json"}`,
-					),
-					0,
-					0,
-				);
-			},
-		});
 	};
 }
 

package/.pi/extensions/lib/harness-subagents/parent-harness-ui-hooks.ts

@@ -7,6 +7,7 @@ import {
 	type PlanUserApproval,
 	planPacketSummary,
 } from "../../../lib/harness-run-context.js";
+import { writePlanReviewMarkdown } from "../plan-approval/plan-review.js";
 import type { ParentHarnessUiHooks } from "./parent-harness-ui-bridge.js";
 
 function persistRunContext(pi: ExtensionAPI, runCtx: HarnessRunContext): void {
@@ -26,6 +27,23 @@ export function createParentHarnessUiHooks(
 			const planId = String(draft.plan_packet.plan_id ?? "plan");
 			const summary =
 				draft.human_summary?.trim() || `Plan ${planId} — pending your approval`;
+			const runCtx = getLatestRunContext(getParentEntries());
+			void writePlanReviewMarkdown(projectRoot, runCtx, draft.plan_packet, {
+				human_summary: draft.human_summary,
+				status: "draft",
+			}).then((reviewPath) => {
+				if (!reviewPath) return;
+				pi.sendMessage({
+					customType: "harness-plan-review-path",
+					content: `Editor review: ${reviewPath}`,
+					display: true,
+					details: {
+						schema_version: "1.0.0",
+						plan_review_path: reviewPath,
+						plan_id: planId,
+					},
+				});
+			});
 			pi.sendMessage({
 				customType: "harness-plan-draft",
 				content: summary,

package/.pi/extensions/lib/harness-subagents/spawn-policy.ts

@@ -10,7 +10,6 @@ export const SUBAGENT_BLOCKED_TOOLS = new Set([
 ]);
 
 const ASK_USER_ALLOWED_AGENT_TYPES = new Set([
-	"harness/planner",
 	"harness/evaluator",
 	"harness/adversary",
 	"harness/tie-breaker",
@@ -42,12 +41,9 @@ export function evaluateSubagentToolCall(
 		};
 	}
 	if (toolName === "approve_plan" || toolName === "create_plan") {
-		if (agentType === "harness/planner") {
-			return { action: "allow" };
-		}
 		return {
 			action: "block",
-			reason: `Tool "${toolName}" is only available for harness/planner.`,
+			reason: `Tool "${toolName}" is only available in the parent harness orchestrator session.`,
 		};
 	}
 	return { action: "allow" };

package/.pi/extensions/lib/harness-subagents/vendored/agent-runner.ts

@@ -420,13 +420,6 @@ export async function runAgent(
 		names.filter((t) => {
 			if (EXCLUDED_TOOL_NAMES.includes(t)) return false;
 			if (t === "ask_user" && harnessUiBridge) return true;
-			if (
-				(t === "approve_plan" || t === "create_plan") &&
-				harnessUiBridge &&
-				type === "harness/planner"
-			) {
-				return true;
-			}
 			if (disallowedSet?.has(t)) return false;
 			if (builtinToolNameSet.has(t)) return true;
 			if (extensions === false) return false;
@@ -442,13 +435,6 @@ export async function runAgent(
 	} else {
 		const fallback = toolNames.filter((t) => {
 			if (t === "ask_user" && harnessUiBridge) return true;
-			if (
-				(t === "approve_plan" || t === "create_plan") &&
-				harnessUiBridge &&
-				type === "harness/planner"
-			) {
-				return true;
-			}
 			return !disallowedSet?.has(t);
 		});
 		session.setActiveToolsByName(fallback);
@@ -470,10 +456,6 @@ export async function runAgent(
 	if (harnessUiBridge) {
 		const withHarnessUi = new Set(session.getActiveToolNames());
 		withHarnessUi.add("ask_user");
-		if (type === "harness/planner") {
-			withHarnessUi.add("approve_plan");
-			withHarnessUi.add("create_plan");
-		}
 		session.setActiveToolsByName([...withHarnessUi]);
 	}
 

package/.pi/extensions/lib/harness-subagents/vendored/index.ts

@@ -17,10 +17,7 @@ import {
 } from "@earendil-works/pi-coding-agent";
 import { Text } from "@earendil-works/pi-tui";
 import { Type } from "@sinclair/typebox";
-import {
-	getLatestRunContext,
-	syncPlannerApprovalsToParent,
-} from "../../../../lib/harness-run-context.js";
+import { getLatestRunContext } from "../../../../lib/harness-run-context.js";
 import { getDriftReport } from "../agent-manifest.js";
 import { Blackboard } from "../blackboard.js";
 import {
@@ -759,7 +756,9 @@ export function createHarnessSubagentsExtension(packageRoot: string) {
 		});
 
 		// Live widget: show running agents above editor
-		const widget = new AgentWidget(manager, agentActivity);
+		const widget = new AgentWidget(manager, agentActivity, () => {
+			pi.events.emit("subagents:agents-widget-mounted", {});
+		});
 
 		// ---- Join mode configuration ----
 		let defaultJoinMode: JoinMode = "smart";
@@ -1501,24 +1500,6 @@ Guidelines:
 
 					clearInterval(spinnerInterval);
 
-					if (
-						subagentType === "harness/planner" &&
-						record.session &&
-						record.status !== "running" &&
-						record.status !== "queued"
-					) {
-						const parentEntries = ctx.sessionManager.getEntries();
-						const runCtx = getLatestRunContext(parentEntries);
-						if (runCtx) {
-							syncPlannerApprovalsToParent(
-								(type, data) => pi.appendEntry(type, data),
-								parentEntries,
-								record.session.sessionManager.getEntries(),
-								runCtx,
-							);
-						}
-					}
-
 					// Clean up foreground agent from widget
 					if (fgId) {
 						agentActivity.delete(fgId);
@@ -1631,19 +1612,6 @@ Guidelines:
 						cancelNudge(params.agent_id);
 					}
 
-					if (record.session && record.status !== "running") {
-						const parentEntries = _ctx.sessionManager.getEntries();
-						const runCtx = getLatestRunContext(parentEntries);
-						if (runCtx) {
-							syncPlannerApprovalsToParent(
-								(type, data) => pi.appendEntry(type, data),
-								parentEntries,
-								record.session.sessionManager.getEntries(),
-								runCtx,
-							);
-						}
-					}
-
 					// Verbose: include full conversation
 					if (params.verbose && record.session) {
 						const conversation = getAgentConversation(record.session);

package/.pi/extensions/lib/harness-subagents/vendored/ui/agent-widget.ts

@@ -264,6 +264,7 @@ export class AgentWidget {
 	constructor(
 		private manager: AgentManager,
 		private agentActivity: Map<string, AgentActivity>,
+		private onWidgetRegistered?: () => void,
 	) {}
 
 	/** Set the UI context (grabbed from first tool execution). */
@@ -615,6 +616,7 @@ export class AgentWidget {
 				{ placement: "aboveEditor" },
 			);
 			this.widgetRegistered = true;
+			this.onWidgetRegistered?.();
 		} else {
 			// Widget already registered — just request a re-render of existing components.
 			this.tui?.requestRender();

package/.pi/extensions/lib/plan-approval/create-plan.ts

@@ -9,6 +9,7 @@ import {
 	saveRunContextToDisk,
 	validatePlanPacket,
 } from "../../../lib/harness-run-context.js";
+import { writePlanReviewMarkdown } from "./plan-review.js";
 
 export const CREATE_PLAN_SNIPPET =
 	"create_plan({ plan_packet: { ...approved PlanPacket } })";
@@ -116,6 +117,10 @@ export async function executeCreatePlan(
 		/* disk mirror best-effort */
 	}
 
+	await writePlanReviewMarkdown(deps.projectRoot, updated, planPacket, {
+		status: "committed",
+	});
+
 	deps.onCommitted(updated, planPacket, planPath);
 
 	return {