ultimate-jekyll-manager 1.9.23 → 1.9.25

package/bin/ultimate-jekyll

@@ -1,5 +1,9 @@
 #!/usr/bin/env node
-const argv = require('yargs')(process.argv.slice(2)).parseSync();
+// Value-less flags must be declared boolean — otherwise yargs treats the next
+// positional as the flag's VALUE (`mgr test --extended some/target` became
+// extended='some/target' with NO target, silently running EVERYTHING in
+// normal mode). Mirrors the same fix in BEM's CLI.
+const argv = require('yargs')(process.argv.slice(2)).boolean(['extended']).parseSync();
 const cli = new (require('../dist/cli.js'))(argv);
 (async function() {
   'use strict';

package/dist/test/runner.js

@@ -398,6 +398,11 @@ function filterBySource(source, files, sourceFilter, pathPart) {
   });
 }
 
+// Glob ignore patterns implementing the "underscore = not a suite" convention:
+// `_`-prefixed FILES (e.g. test/_init.js) and everything under a `_`-prefixed
+// DIRECTORY at any depth (helpers, fixtures — e.g. test/_helpers/harness.js).
+const DISCOVERY_IGNORE = ['**/_*.js', '**/_*/**'];
+
 function discoverTestFiles(target) {
   const { source: sourceFilter, pathPart } = parseTarget(target);
 
@@ -421,7 +426,7 @@ function discoverTestFiles(target) {
   // Consumers write their own boot tests under <cwd>/test/boot/.
   const frameworkSuitesDir = path.join(__dirname, 'suites');
   if (jetpack.exists(frameworkSuitesDir)) {
-    const ignore = ['_**'];
+    const ignore = [...DISCOVERY_IGNORE];
     if (!isFrameworkSelfTest) ignore.push('boot/**');
     glob('**/*.js', { cwd: frameworkSuitesDir, ignore }).sort().forEach((rel) => {
       framework.push(path.join(frameworkSuitesDir, rel));
@@ -430,9 +435,10 @@ function discoverTestFiles(target) {
 
   // Consumer project suites — CWD/test/**/*.js. Skip when running from inside the
   // framework's own dist tree (where consumer-tests-dir === framework-tests-parent).
+  // Excludes `_`-prefixed files and directories (see DISCOVERY_IGNORE).
   const projectTestsDir = path.join(process.cwd(), 'test');
   if (jetpack.exists(projectTestsDir) && projectTestsDir !== path.dirname(frameworkSuitesDir)) {
-    glob('**/*.js', { cwd: projectTestsDir, ignore: ['_**'] }).sort().forEach((rel) => {
+    glob('**/*.js', { cwd: projectTestsDir, ignore: [...DISCOVERY_IGNORE] }).sort().forEach((rel) => {
       project.push(path.join(projectTestsDir, rel));
     });
   }
@@ -508,4 +514,4 @@ async function runInitSetups() {
   }
 }
 
-module.exports = { run, SkipError };
+module.exports = { run, SkipError, DISCOVERY_IGNORE };

package/dist/test/suites/build/test-discovery.test.js

@@ -0,0 +1,63 @@
+// Build-layer tests for test-suite discovery — specifically the
+// "underscore = not a suite" convention: `_`-prefixed files and everything
+// under `_`-prefixed directories (at ANY depth) must be excluded, so consumers
+// can keep helpers and fixture trees (e.g. test/_helpers/harness.js)
+// next to their suites.
+
+const path = require('path');
+
+module.exports = {
+  type: 'suite',
+  layer: 'build',
+  description: 'test discovery — underscore exclusion convention',
+  tests: [
+    {
+      name: 'runner exports DISCOVERY_IGNORE',
+      run: (ctx) => {
+        const runner = require(path.join(__dirname, '..', '..', 'runner.js'));
+        ctx.expect(Array.isArray(runner.DISCOVERY_IGNORE)).toBe(true);
+        ctx.expect(runner.DISCOVERY_IGNORE.length >= 2).toBe(true);
+      },
+    },
+    {
+      name: 'glob with DISCOVERY_IGNORE skips _ files and _ dirs at any depth',
+      run: (ctx) => {
+        const fs = require('fs');
+        const os = require('os');
+        const glob = require('glob').globSync;
+        const { DISCOVERY_IGNORE } = require(path.join(__dirname, '..', '..', 'runner.js'));
+
+        const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'ujm-discovery-test-'));
+        const write = (rel) => {
+          const file = path.join(tmp, rel);
+          fs.mkdirSync(path.dirname(file), { recursive: true });
+          fs.writeFileSync(file, 'module.exports = {};\n');
+        };
+
+        // Should be DISCOVERED:
+        write('build/config.test.js');
+        write('page/runner.test.js');
+        write('boot/nested/deep.test.js');
+
+        // Should be EXCLUDED:
+        write('_init.js');                                  // top-level _ file
+        write('page/_helper.js');                           // nested _ file
+        write('_helpers/harness.js');                       // file in top-level _ dir
+        write('_fixtures/packages/runner/mod/index.js');    // deep inside a _ dir
+        write('boot/_private/util.js');                     // _ dir below a layer dir
+
+        const found = glob('**/*.js', { cwd: tmp, ignore: [...DISCOVERY_IGNORE] }).sort();
+
+        try {
+          ctx.expect(found).toEqual([
+            'boot/nested/deep.test.js',
+            'build/config.test.js',
+            'page/runner.test.js',
+          ]);
+        } finally {
+          fs.rmSync(tmp, { recursive: true, force: true });
+        }
+      },
+    },
+  ],
+};

package/docs/test-framework.md

@@ -234,7 +234,7 @@ Same protocol as EM (`__EM_TEST__`) and BXM (`__BXM_TEST__`). One marker per fra
 
 - **Framework suites**: glob `<ujm>/dist/test/suites/**/*.js` (resolved from `__dirname/suites` in `runner.js`).
 - **Consumer suites**: glob `<cwd>/test/**/*.js`.
-- **Excluded** (`_` underscore convention): any file or directory starting with `_` is excluded from suite discovery. Put shared helpers, fixture data, and non-test support files in `_`-prefixed paths — e.g. `test/_fixtures/`, `test/_helpers/`. The runner still specifically loads `test/_init.js` as the lifecycle hook. Matches the same convention in BEM/EM/BXM.
+- **Excluded** (the `_` underscore convention — `DISCOVERY_IGNORE` in `src/test/runner.js`): `_`-prefixed FILES (`test/_init.js`, `test/page/_helper.js`) and everything under a `_`-prefixed DIRECTORY at **any depth** (`test/_fixtures/**`, `test/boot/_private/**`) are excluded from suite discovery. Put shared helpers, fixture data, and non-test support files in `_`-prefixed paths — e.g. `test/_fixtures/`, `test/_helpers/`. The runner still specifically loads `test/_init.js` as the lifecycle hook. Matches the same convention in BEM/EM/BXM.
 - **Framework boot suites** are excluded when the cwd's `package.json#name` is not `ultimate-jekyll-manager` — they target UJM's fixture site, not the consumer's. Consumers write their own boot tests in `<cwd>/test/boot/`.
 
 ## `test/_init.js` — pre-test lifecycle hook

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ultimate-jekyll-manager",
-  "version": "1.9.23",
+  "version": "1.9.25",
   "description": "Ultimate Jekyll dependency manager",
   "main": "dist/index.js",
   "files": [