ultimate-jekyll-manager 0.0.291 → 0.0.294

package/CHANGELOG.md

@@ -29,6 +29,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Dev-only warning in FormManager for form fields missing `name` attributes (skipped by validation and `getData()`)
 
 ### Changed
+- Replace hardcoded discount codes with server-side validation via `payments/discount` API endpoint
+- Simplify payment intent payload: remove `auth`, `cancelUrl`, and `verification.status` fields; send `discountCode` from validated state
+- Form submit falls back to first visible payment button when Enter is pressed instead of throwing
+- Clear FormManager dirty state before redirect to avoid "leave site" prompt
+- Use proper adjective forms in subscription terms text (e.g., "annual" instead of "annually")
+- Add discount disclaimer to subscription terms when a discount code is applied
 - Align billing section to backend SSOT: consume unified subscription structure directly (3 statuses, `product.id` as object, `payment.price` in dollars, `cancellation.pending`, `trial.claimed` + `trial.expires`)
 - Use WM bindings (`data-wm-bind`) for billing plan heading, action button visibility, and cancel trigger instead of manual JS DOM manipulation
 - Standardize cancel, delete, and data-request forms to use FormManager built-in `required` validation instead of manual disabled toggle and checkbox throws
@@ -37,6 +43,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Checkout payment method buttons start hidden and are revealed via `data-wm-bind` when payment methods load
 - Remove development-only guard from click prevention logging in body.html
 
+### Removed
+- Remove hardcoded `DISCOUNT_CODES` map and `autoApplyWelcomeCoupon` (replaced by server-side validation)
+- Remove `generateCheckoutId` and `state.checkoutId` from checkout session
+- Unexport `resolvePrice` helper (internal-only usage)
+
 ### Fixed
 - Fix broken `</>` tag in checkout HTML causing page rendering to break
 - Fix checkout price display for APIs returning plain numbers instead of `{amount: N}` objects

package/dist/assets/js/pages/payment/checkout/index.js

@@ -2,7 +2,7 @@
 import { FormManager } from '__main_assets__/js/libs/form-manager.js';
 import { fetchAppConfig, fetchTrialEligibility, warmupServer, createPaymentIntent } from './modules/api.js';
 import { state, buildBindingsState, resolveProcessor, FREQUENCIES, getAvailableFrequencies } from './modules/state.js';
-import { applyDiscountCode, autoApplyWelcomeCoupon } from './modules/discount.js';
+import { applyDiscountCode } from './modules/discount.js';
 import { initializeRecaptcha } from './modules/recaptcha.js';
 import { trackBeginCheckout, trackAddPaymentInfo } from './modules/tracking.js';
 
@@ -59,24 +59,9 @@ function trackAbandonedCart(webManager, product, state) {
     .catch((e) => console.warn('Failed to track abandoned cart:', e));
 }
 
-// Generate unique checkout session ID
-function generateCheckoutId() {
-  const urlParams = new URLSearchParams(window.location.search);
-  const existing = urlParams.get('checkoutId');
-  if (existing) return existing;
-
-  const timestamp = Date.now().toString(36);
-  const random1 = Math.random().toString(36).substring(2, 8);
-  const random2 = Math.random().toString(36).substring(2, 8);
-  return `CHK-${timestamp}-${random1}-${random2}`.toUpperCase();
-}
-
 // Initialize checkout
 async function initializeCheckout() {
   try {
-    // Generate session ID
-    state.checkoutId = generateCheckoutId();
-
     // Parse URL params
     const urlParams = new URLSearchParams(window.location.search);
     const productId = urlParams.get('product');
@@ -182,9 +167,6 @@ async function initializeCheckout() {
     // Create/reset abandoned cart tracker (fire-and-forget, authenticated only)
     trackAbandonedCart(webManager, product, state);
 
-    // Auto-apply welcome coupon
-    autoApplyWelcomeCoupon(formManager, updateUI);
-
   } catch (error) {
     console.error('Checkout initialization failed:', error);
     showError(error.message || 'Failed to load checkout. Please refresh the page and try again.');
@@ -211,13 +193,12 @@ function setupForm() {
 
   // Form submission (payment)
   formManager.on('submit', async ({ $submitButton }) => {
-    if (!$submitButton) {
-      throw new Error('Please choose a payment method.');
-    }
-
-    const paymentMethod = $submitButton.getAttribute('data-payment-method');
+    // Fall back to first visible payment button if Enter was pressed without clicking one
+    const $btn = $submitButton
+      || document.querySelector('#checkout-form button[data-payment-method]:not([hidden])');
+    const paymentMethod = $btn?.getAttribute('data-payment-method');
     if (!paymentMethod) {
-      throw new Error('Invalid payment method selected.');
+      throw new Error('Please choose a payment method.');
     }
 
     // Track payment info
@@ -234,6 +215,9 @@ function setupForm() {
       formData: formManager.getData(),
     });
 
+    // Clear dirty state so FormManager doesn't trigger "leave site" prompt
+    formManager.setDirty(false);
+
     // Redirect to processor checkout
     window.location.href = response.url;
 
@@ -246,7 +230,7 @@ function setupForm() {
   if ($applyDiscountBtn) {
     $applyDiscountBtn.addEventListener('click', () => {
       const data = formManager.getData();
-      applyDiscountCode(data.discount, updateUI);
+      applyDiscountCode(data.discount, updateUI, webManager);
     });
   }
 

package/dist/assets/js/pages/payment/checkout/modules/api.js

@@ -30,6 +30,16 @@ export async function fetchTrialEligibility(webManager) {
   }
 }
 
+// Validate a discount code via backend
+export async function validateDiscountCode(webManager, code) {
+  const response = await fetch(`${webManager.getApiUrl()}/backend-manager/payments/discount`, {
+    response: 'json',
+    query: { code },
+  });
+
+  return response;
+}
+
 // Fire-and-forget server warmup
 export function warmupServer(webManager) {
   fetch(`${webManager.getApiUrl()}/backend-manager/payments/intent`, {
@@ -43,28 +53,22 @@ export async function createPaymentIntent({ webManager, state, processor, formDa
   // Get reCAPTCHA token
   const recaptchaToken = await getRecaptchaToken('payment_intent');
 
-  // User info
-  const user = webManager.auth().getUser();
+  // Discount code from form data (validated server-side)
+  const discountCode = state.discountCode || '';
 
-  // Discount code from form data
-  const discountCode = state.discountPercent > 0
-    ? (formData.discount || '').trim().toUpperCase()
-    : undefined;
+  // Supplemental form data (everything except fields we handle explicitly)
+  const supplemental = { ...formData };
+  delete supplemental.frequency;
+  delete supplemental.discount;
 
-  // Build payload (flat fields to match backend schema)
+  // Build payload
   const payload = {
     processor,
     productId: state.product.id,
     frequency: state.frequency,
     trial: state.trialEligible,
-    auth: {
-      uid: user?.uid || '',
-      email: user?.email || '',
-    },
     attribution: webManager.storage().get('attribution', {}),
-    cancelUrl: window.location.href,
     verification: {
-      status: 'pending',
       'g-recaptcha-response': recaptchaToken || '',
     },
   };
@@ -74,11 +78,7 @@ export async function createPaymentIntent({ webManager, state, processor, formDa
     payload.discount = discountCode;
   }
 
-  if (formData) {
-    // Clean form data -- remove fields we handle explicitly
-    const supplemental = { ...formData };
-    delete supplemental.frequency;
-    delete supplemental.discount;
+  if (Object.keys(supplemental).length > 0) {
     payload.supplemental = supplemental;
   }
 

package/dist/assets/js/pages/payment/checkout/modules/discount.js

@@ -1,12 +1,26 @@
 // Discount code logic for checkout
-import { state, DISCOUNT_CODES } from './state.js';
+import { state } from './state.js';
+import { validateDiscountCode } from './api.js';
+
+// Cached webManager reference (set on first call)
+let _webManager = null;
+
+/**
+ * Apply a discount code via server-side validation
+ * @param {string} code - Discount code to validate
+ * @param {Function} updateUI - Callback to refresh bindings
+ * @param {object} webManager - WebManager instance (required on first call)
+ */
+export async function applyDiscountCode(code, updateUI, webManager) {
+  if (webManager) {
+    _webManager = webManager;
+  }
 
-// Apply a discount code
-// updateUI callback decouples this from the bindings system
-export async function applyDiscountCode(code, updateUI) {
   code = (code || '').trim().toUpperCase();
 
   if (!code) {
+    state.discountCode = null;
+    state.discountPercent = 0;
     state.discountUI = { loading: false, success: false, error: true, message: 'Please enter a discount code' };
     updateUI();
     return;
@@ -16,22 +30,24 @@ export async function applyDiscountCode(code, updateUI) {
   state.discountUI = { loading: true, success: false, error: false, message: '' };
   updateUI();
 
-  // Simulate API delay (TODO: replace with real API call)
-  await new Promise(resolve => setTimeout(resolve, 800));
+  try {
+    const result = await validateDiscountCode(_webManager, code);
 
-  if (DISCOUNT_CODES[code]) {
-    state.discountPercent = DISCOUNT_CODES[code];
-    state.discountUI = { loading: false, success: true, error: false, message: `Discount applied: ${state.discountPercent}% off` };
-  } else {
+    if (result.valid) {
+      state.discountCode = result.code;
+      state.discountPercent = result.percent;
+      state.discountUI = { loading: false, success: true, error: false, message: `Discount applied: ${result.percent}% off` };
+    } else {
+      state.discountCode = null;
+      state.discountPercent = 0;
+      state.discountUI = { loading: false, success: false, error: true, message: 'Invalid discount code' };
+    }
+  } catch (e) {
+    console.warn('Discount validation failed:', e);
+    state.discountCode = null;
     state.discountPercent = 0;
-    state.discountUI = { loading: false, success: false, error: true, message: 'Invalid discount code' };
+    state.discountUI = { loading: false, success: false, error: true, message: 'Unable to validate discount code. Please try again.' };
   }
 
   updateUI();
 }
-
-// Auto-apply welcome coupon
-export function autoApplyWelcomeCoupon(formManager, updateUI) {
-  formManager.setData({ discount: 'WELCOME15' });
-  applyDiscountCode('WELCOME15', updateUI);
-}

package/dist/assets/js/pages/payment/checkout/modules/state.js

@@ -6,13 +6,6 @@ import { calculatePrices } from './pricing.js';
 // All supported billing frequencies
 export const FREQUENCIES = ['daily', 'weekly', 'monthly', 'annually'];
 
-// Hardcoded discount codes (TODO: move to API)
-export const DISCOUNT_CODES = {
-  'FLASH20': 20,
-  'SAVE10': 10,
-  'WELCOME15': 15,
-};
-
 // Minimal mutable state
 export const state = {
   // From API (stored once, never transformed)
@@ -22,15 +15,13 @@ export const state = {
 
   // User selections
   frequency: 'annually',
+  discountCode: null,
   discountPercent: 0,
   trialEligible: false,
 
   // UI state
   discountUI: { loading: false, success: false, error: false, message: '' },
   error: { show: false, message: '' },
-
-  // Session
-  checkoutId: null,
 };
 
 // Resolve which processor handles a payment method
@@ -52,7 +43,7 @@ export function resolveProcessor(paymentMethod) {
 }
 
 // Resolve price for a frequency (handles both `{ amount: N }` and plain `N` formats)
-export function resolvePrice(product, frequency) {
+function resolvePrice(product, frequency) {
   const entry = product?.prices?.[frequency];
   if (entry == null) return 0;
   return typeof entry === 'object' ? (entry.amount || 0) : Number(entry) || 0;
@@ -122,7 +113,7 @@ export function buildBindingsState(webManager) {
         recurringAmount: formatCurrency(prices.recurring),
         recurringPeriod: frequencyLabels[cycle] || cycle,
         showTerms: isSubscription,
-        termsText: buildTermsText(product, cycle, hasFreeTrial, prices),
+        termsText: buildTermsText(product, cycle, hasFreeTrial, prices, state.discountPercent > 0),
       },
       trial: {
         show: hasFreeTrial,
@@ -170,10 +161,11 @@ function formatCurrency(amount) {
 const FREQUENCY_DAYS = { daily: 1, weekly: 7, monthly: 30, annually: 365 };
 
 // Build subscription terms text
-function buildTermsText(product, cycle, hasFreeTrial, prices) {
+function buildTermsText(product, cycle, hasFreeTrial, prices, hasDiscount) {
   if (!product || product.type !== 'subscription') return '';
 
-  const periodText = cycle;
+  const periodAdjectiveMap = { daily: 'daily', weekly: 'weekly', monthly: 'monthly', annually: 'annual' };
+  const periodText = periodAdjectiveMap[cycle] || cycle;
   const renewalDate = new Date();
   const daysToAdd = hasFreeTrial
     ? (product.trial?.days || 7)
@@ -186,9 +178,11 @@ function buildTermsText(product, cycle, hasFreeTrial, prices) {
     year: 'numeric',
   });
 
+  const discountNote = hasDiscount ? ' Discount code applies to first payment only and is not available with PayPal.' : '';
+
   if (hasFreeTrial) {
-    return `You won't be charged for your free trial. On ${formatted}, your ${periodText} subscription will start and you'll be charged ${formatCurrency(prices.recurring)} plus applicable tax. Cancel anytime before then.`;
+    return `You won't be charged for your free trial. On ${formatted}, your ${periodText} subscription will start and you'll be charged ${formatCurrency(prices.recurring)} plus applicable tax. Cancel anytime before then.${discountNote}`;
   }
 
-  return `Your ${periodText} subscription will start today and renew on ${formatted} for ${formatCurrency(prices.recurring)} plus applicable tax. Cancel anytime.`;
+  return `Your ${periodText} subscription will start today and renew on ${formatted} for ${formatCurrency(prices.recurring)} plus applicable tax. Cancel anytime.${discountNote}`;
 }

package/dist/defaults/dist/_layouts/themes/classy/frontend/pages/blog/post.html

@@ -37,7 +37,7 @@ newsletter:
 ---
 
 <!-- Article Header & Content -->
-<article class="pt-8">
+<article class="pt-10">
   <div class="container">
     <div class="row justify-content-center mb-3">
       <div class="col-xl-8 col-lg-8 col-md-12 col-12">

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ultimate-jekyll-manager",
-  "version": "0.0.291",
+  "version": "0.0.294",
   "description": "Ultimate Jekyll dependency manager",
   "main": "dist/index.js",
   "exports": {