ultimate-jekyll-manager 0.0.238 → 0.0.239

package/dist/assets/js/modules/vert.js

@@ -11,13 +11,17 @@ const searchParams = new URLSearchParams(window.location.search);
 const qsDebug = searchParams.get('debug') === 'true';
 const qsLoud = searchParams.get('loud') === 'true';
 
-// Reveal a vert-unit by removing the initial hide styles
-const revealVertUnit = ($vertUnit) => {
-  if ($vertUnit) {
-    $vertUnit.style.removeProperty('overflow');
-    $vertUnit.style.removeProperty('max-height');
-  }
-};
+// DISABLED: Hide/reveal system for vert units. Was causing in-house verts (promo-server fallback)
+// to not display because: (1) vert-unit starts hidden with max-height:0, (2) AdSense "ghost fills"
+// (reports filled but renders nothing) would reveal an empty container, (3) iframe height was set
+// to 0 and relied on promo-server sending dimensions back, but promo-server was sending height:0.
+// Re-enable once promo-server set-dimensions is fixed and ghost fill detection is added.
+// const revealVertUnit = ($vertUnit) => {
+//   if ($vertUnit) {
+//     $vertUnit.style.removeProperty('overflow');
+//     $vertUnit.style.removeProperty('max-height');
+//   }
+// };
 
 // Protect height-constrained ancestors from AdSense's height: auto !important override.
 // Walks up from the ad's script element and observes any ancestor with a fixed-height class.
@@ -114,7 +118,8 @@ const setupMessageHandler = () => {
       const $iframe = document.getElementById(payload.id);
       if ($iframe) {
         $iframe.style.height = payload.height + 'px';
-        revealVertUnit($iframe.closest('vert-unit'));
+        // DISABLED: See revealVertUnit note above
+        // revealVertUnit($iframe.closest('vert-unit'));
       }
     } else if (command === 'uj-vert-unit:click') {
       // Navigate to the URL when ad is clicked
@@ -149,7 +154,8 @@ const monitorAdFillStatus = ($vertUnit, config) => {
     // Handle filled status
     if (status === 'filled') {
       console.log('[Vert] Adsense is filled, no fallback needed');
-      revealVertUnit($vertUnit);
+      // DISABLED: See revealVertUnit note above
+      // revealVertUnit($vertUnit);
       return;
     }
 
@@ -202,7 +208,7 @@ const createCustomAd = ($vertUnit, config) => {
   $iframe.style.cssText = config.style;
   $iframe.setAttribute('sandbox', 'allow-forms allow-popups allow-popups-to-escape-sandbox allow-same-origin allow-scripts allow-top-navigation-by-user-activation');
   $iframe.width = '100%';
-  $iframe.height = '0';
+  $iframe.height = '100%'; // DISABLED: was '0' to rely on promo-server set-dimensions, but promo-server sends height:0
   $iframe.setAttribute('frameborder', '0');
   $iframe.setAttribute('marginwidth', '0');
   $iframe.setAttribute('marginheight', '0');
@@ -216,8 +222,8 @@ const createCustomAd = ($vertUnit, config) => {
   $vertUnit.innerHTML = '';
   $vertUnit.appendChild($iframe);
 
-  // Reveal the vert unit now that custom ad is loaded
-  revealVertUnit($vertUnit);
+  // DISABLED: See revealVertUnit note above
+  // revealVertUnit($vertUnit);
 
   // Retrigger bindings to apply plan visibility
   webManager.auth().listen({ once: true }, async () => {
@@ -240,8 +246,8 @@ const createAdUnit = (config, $currentScript) => {
   $vertUnit.className = 'uj-vert-unit';
   $vertUnit.setAttribute('data-wm-bind', '@hide auth.account.subscription.product !== basic');
 
-  // Hide until ad is ready to prevent layout flash
-  $vertUnit.style.cssText = 'overflow:hidden; max-height:0;';
+  // DISABLED: See revealVertUnit note above
+  // $vertUnit.style.cssText = 'overflow:hidden; max-height:0;';
 
   // Create the ins element for AdSense
   const $ins = document.createElement('ins');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ultimate-jekyll-manager",
-  "version": "0.0.238",
+  "version": "0.0.239",
   "description": "Ultimate Jekyll dependency manager",
   "main": "dist/index.js",
   "exports": {