ultimate-express 2.0.2 → 2.0.4

package/README.md

@@ -189,6 +189,7 @@ In general, basically all features and options are supported. Use [Express 4.x d
 - ✅ app.engines
 - ✅ app.on("mount")
 - ✅ HEAD method
+- ✅ OPTIONS method
 
 ### Application settings
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ultimate-express",
-  "version": "2.0.2",
+  "version": "2.0.4",
   "description": "The Ultimate Express. Fastest http server with full Express compatibility, based on uWebSockets.",
   "main": "src/index.js",
   "scripts": {

package/src/application.js

@@ -191,6 +191,12 @@ class Application extends Router {
                 if(request._error) {
                     return this._handleError(request._error, null, request, response);
                 }
+                if(request._isOptions && request._matchedMethods.size > 0) {
+                    const allowedMethods = Array.from(request._matchedMethods).join(',');
+                    response.setHeader('Allow', allowedMethods);
+                    response.send(allowedMethods);
+                    return;
+                }
                 response.status(404);
                 this._sendErrorPage(request, response, `Cannot ${request.method} ${request.path}`, false);
             }

package/src/request.js

@@ -69,8 +69,11 @@ module.exports = class Request extends Readable {
             this._opPath = this._opPath.slice(0, -1);
         }
         this.method = req.getCaseSensitiveMethod().toUpperCase();
+        this._isOptions = this.method === 'OPTIONS';
+        this._isHead = this.method === 'HEAD';
         this.params = {};
-
+        
+        this._matchedMethods = new Set();
         this._gotParams = new Set();
         this._stack = [];
         this._paramStack = [];
@@ -252,7 +255,7 @@ module.exports = class Request extends Readable {
         if(this.#cachedParsedIp !== null) {
             return this.#cachedParsedIp;
         }
-        const finished = !this.res.socket.writable;
+        const finished = this.res.finished;
         if(finished) {
             // mark app as one that needs ip after response
             this.app.needsIpAfterResponse = true;

package/src/response.js

@@ -69,6 +69,7 @@ class Socket extends EventEmitter {
 
 module.exports = class Response extends Writable {
     #socket = null;
+    #ended = false;
     #pendingChunks = [];
     #lastWriteChunkTime = 0;
     #writeTimeout = null;
@@ -112,13 +113,16 @@ module.exports = class Response extends Writable {
             this._res.cork(() => {
                 this._res.close();
                 this.finished = true;
-                if(this.socketExists) this.socket.emit('close');
+                this.#socket?.emit('close');
             });
         });
+        this.once('close', () => {
+            this.#ended = true
+        })
     }
 
     get socket() {
-        this.socketExists = true;
+        if(this.#ended) return null;
         if(!this.#socket) {
             this.#socket = new Socket(this);
         }
@@ -188,7 +192,7 @@ module.exports = class Response extends Writable {
                     super.end();
                     this.finished = true;
                     this.writingChunk = false;
-                    if (this.socketExists) this.socket.emit('close');
+                    this.#socket?.emit('close');
                     callback(null);
                 } else if (!ok) {
                     this._res.ab = chunk;
@@ -198,7 +202,7 @@ module.exports = class Response extends Writable {
                         const [ok, done] = this._res.tryEnd(this._res.ab.slice(offset - this._res.abOffset), this.totalSize);
                         if (done) {
                             this.finished = true;
-                            if (this.socketExists) this.socket.emit('close');
+                            this.#socket?.emit('close');
                         }
                         if (ok) {
                             this.writingChunk = false;
@@ -258,10 +262,18 @@ module.exports = class Response extends Writable {
     sendStatus(code) {
         return this.status(code).send(statuses.message[+code] ?? code.toString());
     }
-    end(data) {
+    end(data, cb) {
+        if(typeof data === 'function') {
+            cb = data;
+            data = undefined;
+        }
+        if(typeof cb !== 'function') {
+            cb = undefined; // silence the error?
+        }
+
         if(this.writingChunk) {
             this.once('drain', () => {
-                this.end(data);
+                this.end(data, cb);
             });
             return;
         }
@@ -282,9 +294,13 @@ module.exports = class Response extends Writable {
                 if(fresh) {
                     this._res.end();
                     this.finished = true;
-                    if(this.socketExists) this.socket.emit('close');
+                    this.#socket?.emit('close');
                     this.emit('finish');
                     this.emit('close');
+                    cb && queueMicrotask(() => {
+                        this.#ended = true;
+                        cb();
+                    });
                     return;
                 }
             }
@@ -309,9 +325,13 @@ module.exports = class Response extends Writable {
             }
             
             this.finished = true;
-            if(this.socketExists) this.socket.emit('close');
+            this.#socket?.emit('close');
             this.emit('finish');
             this.emit('close');
+            cb && queueMicrotask(() => {
+                this.#ended = true;
+                cb();
+            });
         });
         return this;
     }

package/src/router.js

@@ -152,6 +152,9 @@ module.exports = class Router extends EventEmitter {
                 all: method === 'ALL' || method === 'USE',
                 gettable: method === 'GET' || method === 'HEAD',
             };
+            if(typeof route.path === 'string' && (route.path.includes(':') || route.path.includes('*') || (route.path.includes('(') && route.path.includes(')'))) && route.pattern instanceof RegExp) {
+                route.complex = true;
+            }
             routes.push(route);
             // normal routes optimization
             if(canBeOptimized(route.path) && route.pattern !== '/*' && !this.parent && this.get('case sensitive routing') && this.uwsApp) {
@@ -296,6 +299,12 @@ module.exports = class Router extends EventEmitter {
                 if(request._error) {
                     return this._handleError(request._error, null, request, response);
                 }
+                if(request._isOptions && request._matchedMethods.size > 0) {
+                    const allowedMethods = Array.from(request._matchedMethods).join(',');
+                    response.setHeader('Allow', allowedMethods);
+                    response.send(allowedMethods);
+                    return;
+                }
                 response.status(404);
                 request.noEtag = true;
                 this._sendErrorPage(request, response, `Cannot ${request.method} ${request._originalPath}`, false);
@@ -369,7 +378,7 @@ module.exports = class Router extends EventEmitter {
         req.route = route;
         if(route.optimizedParams) {
             req.params = {...req.optimizedParams};
-        } else if(typeof route.path === 'string' && (route.path.includes(':') || route.path.includes('*') || (route.path.includes('(') && route.path.includes(')'))) && route.pattern instanceof RegExp) {
+        } else if(route.complex) {
             let path = req._originalPath;
             if(req._stack.length > 0) {
                 path = path.replace(this.getFullMountpath(req), '');
@@ -445,7 +454,7 @@ module.exports = class Router extends EventEmitter {
     }
 
     async _routeRequest(req, res, startIndex = 0, routes = this._routes, skipCheck = false, skipUntil) {
-        let routeIndex = skipCheck ? startIndex : findIndexStartingFrom(routes, r => (r.all || r.method === req.method || (r.gettable && req.method === 'HEAD')) && this._pathMatches(r, req), startIndex);
+        let routeIndex = skipCheck ? startIndex : findIndexStartingFrom(routes, r => (r.all || r.method === req.method || req._isOptions || (r.gettable && req._isHead)) && this._pathMatches(r, req), startIndex);
         const route = routes[routeIndex];
         if(!route) {
             if(!skipCheck) {
@@ -546,6 +555,15 @@ module.exports = class Router extends EventEmitter {
                     }
                     
                     try {
+                        // handling OPTIONS method
+                        if(req._isOptions && !route.all && route.method !== 'OPTIONS') {
+                            req._matchedMethods.add(route.method);
+                            if(route.gettable) {
+                                req._matchedMethods.add('HEAD');
+                            }
+                            return next();
+                        }
+
                         // skipping routes we already went through via optimized path
                         if(!skipCheck && skipUntil && skipUntil.routeKey >= route.routeKey) {
                             return next();