ultimate-express 1.4.1 → 1.4.3

package/README.md

@@ -101,6 +101,7 @@ app.listen(3000, () => {
 ```
 
 - This also applies to non-SSL HTTP too. Do not create http server manually, use `app.listen()` instead.
+- NodeJS max header size is 16384 byte, uWebSockets 4096 byte, if you need long headers set the env variable `UWS_HTTP_MAX_HEADERS_SIZE`
 
 ## Performance tips
 
@@ -232,7 +233,7 @@ In general, basically all features and options are supported. Use [Express 4.x d
 - ✅ req.subdomains
 - ✅ req.xhr
 - 🚧 req.route (route implementation is different from Express)
-- 🚧 req.connection, req.socket (only `end()`, `encrypted`, `remoteAddress`, `localPort` and `remotePort` are supported)
+- 🚧 req.connection, req.socket (only `end()`, `encrypted`, `remoteAddress` and `localPort` are supported)
 - ✅ req.accepts()
 - ✅ req.acceptsCharsets()
 - ✅ req.acceptsEncodings()

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ultimate-express",
-  "version": "1.4.1",
+  "version": "1.4.3",
   "description": "The Ultimate Express. Fastest http server with full Express compatibility, based on uWebSockets.",
   "main": "src/index.js",
   "scripts": {

package/src/request.js

@@ -233,7 +233,7 @@ module.exports = class Request extends Readable {
     }
 
     get parsedIp() {
-        if(this.#cachedParsedIp) {
+        if(this.#cachedParsedIp !== null) {
             return this.#cachedParsedIp;
         }
         const finished = !this.res.socket.writable;
@@ -252,7 +252,7 @@ module.exports = class Request extends Readable {
         if(this.rawIp.byteLength === 4) {
             // ipv4
             ip = this.rawIp.join('.');
-        } else {
+        } else if(this.rawIp.byteLength === 16) {
             // ipv6
             const dv = new DataView(this.rawIp);
             for(let i = 0; i < 8; i++) {
@@ -261,6 +261,8 @@ module.exports = class Request extends Readable {
                     ip += ':';
                 }
             }
+        } else {
+            this.#cachedParsedIp = undefined; // unix sockets dont have ip
         }
         this.#cachedParsedIp = ip;
         return ip;
@@ -270,7 +272,6 @@ module.exports = class Request extends Readable {
         return {
             remoteAddress: this.parsedIp,
             localPort: this.app.port,
-            remotePort: this.app.port,
             encrypted: this.app.ssl,
             end: (body) => this.res.end(body)
         };

package/src/response.js

@@ -543,7 +543,7 @@ module.exports = class Response extends Writable {
         } else {
             field = field.toLowerCase();
             if(field === 'set-cookie' && Array.isArray(value)) {
-                value = value.join('; ');
+                value = value.join(', ');
             } else if(field === 'content-type') {
                 if(!value.includes('charset=') && (value.startsWith('text/') || value === 'application/json' || value === 'application/javascript')) {
                     value += '; charset=utf-8';