ultimate-express 1.3.0 → 1.3.2

package/README.md

@@ -289,6 +289,7 @@ Almost all middlewares that are compatible with Express are compatible with µEx
 - ✅ [body-parser](https://npmjs.com/package/body-parser) (use `express.text()` etc instead for better performance)
 - ✅ [cookie-parser](https://npmjs.com/package/cookie-parser)
 - ✅ [cookie-session](https://npmjs.com/package/cookie-session)
+- ✅ [compression](https://npmjs.com/package/compression)
 - ✅ [serve-static](https://npmjs.com/package/serve-static) (use `express.static()` instead for better performance)
 - ✅ [serve-index](https://npmjs.com/package/serve-index)
 - ✅ [cors](https://npmjs.com/package/cors)
@@ -301,10 +302,10 @@ Almost all middlewares that are compatible with Express are compatible with µEx
 - ✅ [express-rate-limit](https://npmjs.com/package/express-rate-limit)
 - ✅ [express-subdomain](https://npmjs.com/package/express-subdomain)
 - ✅ [vhost](https://npmjs.com/package/vhost)
+- ✅ [tsoa](https://github.com/lukeautry/tsoa)
 
 Middlewares and modules that are confirmed to not work:
 
-- ❌ [compression](https://npmjs.com/package/compression) - doesn't error, but doesn't compress
 - ❌ [express-async-errors](https://npmjs.com/package/express-async-errors) - doesn't work, use `app.set('catch async errors', true)` instead.
 
 ## Tested view engines

package/package.json

@@ -1,10 +1,11 @@
 {
   "name": "ultimate-express",
-  "version": "1.3.0",
+  "version": "1.3.2",
   "description": "The Ultimate Express. Fastest http server with full Express compatibility, based on uWebSockets.",
   "main": "src/index.js",
   "scripts": {
-    "test": "node tests/index.js"
+    "test": "node tests/index.js",
+    "dev": "node --inspect=9229 demo/index.js"
   },
   "engines": {
     "node": ">=16"
@@ -42,7 +43,7 @@
     "@types/express": "^4.0.0",
     "accepts": "^1.3.8",
     "bytes": "^3.1.2",
-    "cookie": "^0.6.0",
+    "cookie": "^1.0.1",
     "cookie-signature": "^1.2.1",
     "encodeurl": "^2.0.0",
     "etag": "^1.8.1",
@@ -62,6 +63,7 @@
   },
   "devDependencies": {
     "body-parser": "^1.20.3",
+    "compression": "^1.7.4",
     "cookie-parser": "^1.4.6",
     "cookie-session": "^2.1.0",
     "cors": "^2.8.5",
@@ -81,6 +83,7 @@
     "multer": "^1.4.5-lts.1",
     "mustache-express": "^1.3.2",
     "pako": "^2.1.0",
+    "pkg-pr-new": "^0.0.29",
     "pug": "^3.0.3",
     "response-time": "^2.3.2",
     "serve-index": "^1.9.1",

package/src/application.js

@@ -16,7 +16,7 @@ limitations under the License.
 
 const uWS = require("uWebSockets.js");
 const Router = require("./router.js");
-const { removeDuplicateSlashes, defaultSettings, compileTrust, createETagGenerator, fastQueryParse } = require("./utils.js");
+const { removeDuplicateSlashes, defaultSettings, compileTrust, createETagGenerator, fastQueryParse, NullObject } = require("./utils.js");
 const querystring = require("fast-querystring");
 const ViewClass = require("./view.js");
 const path = require("path");
@@ -27,7 +27,7 @@ const cpuCount = os.cpus().length;
 
 let workers = [];
 let taskKey = 0;
-const workerTasks = {};
+const workerTasks = new NullObject();
 
 function createWorker() {
     const worker = new Worker(path.join(__dirname, 'worker.js'));
@@ -47,7 +47,7 @@ function createWorker() {
 }
 
 class Application extends Router {
-    constructor(settings = {}) {
+    constructor(settings = new NullObject()) {
         super(settings);
         if(!settings?.uwsOptions) {
             settings.uwsOptions = {};
@@ -62,8 +62,8 @@ class Application extends Router {
             this.uwsApp = uWS.App(settings.uwsOptions);
             this.ssl = false;
         }
-        this.cache = {};
-        this.engines = {};
+        this.cache = new NullObject();
+        this.engines = new NullObject();
         this.locals = {
             settings: this.settings
         };
@@ -206,7 +206,7 @@ class Application extends Router {
                 throw err;
             }
             this.port = uWS.us_socket_local_port(socket);
-            callback(this.port);
+            if(callback) callback(this.port);
         };
         let fn = 'listen';
         let args = [];
@@ -229,6 +229,7 @@ class Application extends Router {
         }
         this.listenCalled = true;
         this.uwsApp[fn](...args);
+        return this.uwsApp;
     }
 
     address() {
@@ -260,10 +261,10 @@ class Application extends Router {
     render(name, options, callback) {
         if(typeof options === 'function') {
             callback = options;
-            options = {};
+            options = new NullObject();
         }
         if(!options) {
-            options = {};
+            options = new NullObject();
         } else {
             options = Object.assign({}, options);
         }
@@ -318,4 +319,4 @@ class Application extends Router {
 
 module.exports = function(options) {
     return new Application(options);
-}
+}

package/src/middlewares.js

@@ -20,10 +20,10 @@ const bytes = require('bytes');
 const zlib = require('fast-zlib');
 const typeis = require('type-is');
 const querystring = require('fast-querystring');
-const { fastQueryParse } = require('./utils.js');
+const { fastQueryParse, NullObject } = require('./utils.js');
 
 function static(root, options) {
-    if(!options) options = {};
+    if(!options) options = new NullObject();
     if(typeof options.index === 'undefined') options.index = 'index.html';
     if(typeof options.redirect === 'undefined') options.redirect = true;
     if(typeof options.fallthrough === 'undefined') options.fallthrough = true;
@@ -132,7 +132,7 @@ function createInflate(contentEncoding) {
 function createBodyParser(defaultType, beforeReturn) {
     return function(options) {
         if(typeof options !== 'object') {
-            options = {};
+            options = new NullObject();
         }
         if(typeof options.limit === 'undefined') options.limit = bytes('100kb');
         else options.limit = bytes(options.limit);
@@ -160,7 +160,7 @@ function createBodyParser(defaultType, beforeReturn) {
                 return next();
             }
 
-            req.body = {};
+            req.body = new NullObject();
 
             // skip reading body for non-json content type
             if(!type) {

package/src/request.js

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-const { patternToRegex, deprecated } = require("./utils.js");
+const { patternToRegex, deprecated, NullObject } = require("./utils.js");
 const accepts = require("accepts");
 const typeis = require("type-is");
 const parseRange = require("range-parser");
@@ -64,7 +64,7 @@ module.exports = class Request extends Readable {
             this._opPath = this._opPath.slice(0, -1);
         }
         this.method = req.getCaseSensitiveMethod().toUpperCase();
-        this.params = {};
+        this.params = new NullObject();
 
         this._gotParams = new Set();
         this._stack = [];
@@ -206,7 +206,7 @@ module.exports = class Request extends Readable {
         if(qp) {
             this.#cachedQuery = qp(this.urlQuery.slice(1));
         } else {
-            this.#cachedQuery = {};
+            this.#cachedQuery = new NullObject();
         }
         return this.#cachedQuery;
     }
@@ -351,53 +351,54 @@ module.exports = class Request extends Readable {
         if(this.#cachedHeaders) {
             return this.#cachedHeaders;
         }
-        let headers = {};
-        this.#rawHeadersEntries.forEach((val) => {
-            const key = val[0].toLowerCase();
-            const value = val[1];
-            if(headers[key]) {
+        this.#cachedHeaders = new NullObject();
+        for (let index = 0, len = this.#rawHeadersEntries.length; index < len; index++) {
+            let [key, value] = this.#rawHeadersEntries[index];   
+            key = key.toLowerCase();
+            if(this.#cachedHeaders[key]) {
                 if(discardedDuplicates.includes(key)) {
-                    return;
+                    continue;
                 }
                 if(key === 'cookie') {
-                    headers[key] += '; ' + value;
+                    this.#cachedHeaders[key] += '; ' + value;
                 } else if(key === 'set-cookie') {
-                    headers[key].push(value);
+                    this.#cachedHeaders[key].push(value);
                 } else {
-                    headers[key] += ', ' + value;
+                    this.#cachedHeaders[key] += ', ' + value;
                 }
-                return;
+                continue;
             }
             if(key === 'set-cookie') {
-                headers[key] = [value];
+                this.#cachedHeaders[key] = [value];
             } else {
-                headers[key] = value;
+                this.#cachedHeaders[key] = value;
             }
-        });
-        this.#cachedHeaders = headers;
-        return headers;
+        }
+        return this.#cachedHeaders;
     }
 
     get headersDistinct() {
         if(this.#cachedDistinctHeaders) {
             return this.#cachedDistinctHeaders;
         }
-        let headers = {};
+        this.#cachedDistinctHeaders = new NullObject();
         this.#rawHeadersEntries.forEach((val) => {
-            if(!headers[val[0]]) {
-                headers[val[0]] = [];
+            const [key, value] = val;
+            if(!this.#cachedDistinctHeaders[key]) {
+                this.#cachedDistinctHeaders[key] = [value];
+                return;
             }
-            headers[val[0]].push(val[1]);
+            this.#cachedDistinctHeaders[key].push(value);
         });
-        this.#cachedDistinctHeaders = headers;
-        return headers;
+        return this.#cachedDistinctHeaders;
     }
 
     get rawHeaders() {
         const res = [];
-        this.#rawHeadersEntries.forEach((val) => {
+        for (let index = 0, len = this.#rawHeadersEntries.length; index < len; index++) {
+            const val = this.#rawHeadersEntries[index];
             res.push(val[0], val[1]);
-        });
+        }
         return res;
     }
 }

package/src/response.js

@@ -20,7 +20,7 @@ const vary = require("vary");
 const encodeUrl = require("encodeurl");
 const { 
     normalizeType, stringify, deprecated, UP_PATH_REGEXP, decode,
-    containsDotFile, isPreconditionFailure, isRangeFresh, parseHttpDate
+    containsDotFile, isPreconditionFailure, isRangeFresh, NullObject
 } = require("./utils.js");
 const { Writable } = require("stream");
 const { isAbsolute } = require("path");
@@ -70,7 +70,7 @@ module.exports = class Response extends Writable {
         this._res = res;
         this.headersSent = false;
         this.app = app;
-        this.locals = {};
+        this.locals = new NullObject();
         this.finished = false;
         this.aborted = false;
         this.statusCode = 200;
@@ -208,12 +208,9 @@ module.exports = class Response extends Writable {
     _implicitHeader() {
         // compatibility function
         // usually should send headers but this is useless for us
-        return;
+        this.writeHead(this.statusCode);
     }
     status(code) {
-        if(this.headersSent) {
-            throw new Error('Can\'t set status: Response was already sent');
-        }
         this.statusCode = parseInt(code);
         return this;
     }
@@ -228,7 +225,7 @@ module.exports = class Response extends Writable {
         this._res.cork(() => {
             if(!this.headersSent) {
                 const etagFn = this.app.get('etag fn');
-                if(data && !this.headers['etag'] && etagFn && !this.req.noEtag) {
+                if(etagFn && data && !this.headers['etag'] && !this.req.noEtag) {
                     this.headers['etag'] = etagFn(data);
                 }
                 const fresh = this.req.fresh;
@@ -241,8 +238,9 @@ module.exports = class Response extends Writable {
                     return;
                 }
             }
-            if(!data && this.headers['content-length']) {
-                this._res.endWithoutBody(this.headers['content-length'].toString());
+            const contentLength = this.headers['content-length'];
+            if(!data && contentLength) {
+                this._res.endWithoutBody(contentLength.toString());
             } else {
                 if(data instanceof Buffer) {
                     data = data.buffer.slice(data.byteOffset, data.byteOffset + data.byteLength);
@@ -282,21 +280,23 @@ module.exports = class Response extends Writable {
         }
         if(typeof body === 'string') {
             const contentType = this.headers['content-type'];
-            if(contentType && !contentType.includes(';')) {
+            if(!contentType) {
+                this.headers['content-type'] = 'text/html; charset=utf-8';
+            } else if(!contentType.includes(';')) {
                 this.headers['content-type'] += '; charset=utf-8';
             }
         }
         return this.end(body);
     }
-    sendFile(path, options = {}, callback) {
+    sendFile(path, options = new NullObject(), callback) {
         if(typeof path !== 'string') {
             throw new TypeError('path argument is required to res.sendFile');
         }
         if(typeof options === 'function') {
             callback = options;
-            options = {};
+            options = new NullObject();
         }
-        if(!options) options = {};
+        if(!options) options = new NullObject();
         let done = callback;
         if(!done) done = this.req.next;
         // default options
@@ -362,7 +362,8 @@ module.exports = class Response extends Writable {
                     this.status(403);
                     return done(new Error('Forbidden'));
                 case 'ignore_files':
-                    if(parts.length > 1 && parts[parts.length - 1].startsWith('.')) {
+                    const len = parts.length;
+                    if(len > 1 && parts[len - 1].startsWith('.')) {
                         this.status(404);
                         return done(new Error('Not found'));
                     }
@@ -409,7 +410,7 @@ module.exports = class Response extends Writable {
         }
 
         // etag
-        if(options.etag && !this.headers['etag'] && etagFn) {
+        if(options.etag && etagFn && !this.headers['etag']) {
             this.headers['etag'] = etagFn(stat);
         }
         if(!options.etag) {
@@ -443,9 +444,10 @@ module.exports = class Response extends Writable {
                 }
                 if(ranges !== -2 && ranges.length === 1) {
                     this.status(206);
-                    this.headers['content-range'] = `bytes ${ranges[0].start}-${ranges[0].end}/${stat.size}`;
-                    offset = ranges[0].start;
-                    len = ranges[0].end - ranges[0].start + 1;
+                    const range = ranges[0];
+                    this.headers['content-range'] = `bytes ${range.start}-${range.end}/${stat.size}`;
+                    offset = range.start;
+                    len = range.end - range.start + 1;
                     ranged = true;
                 }
             }
@@ -488,16 +490,16 @@ module.exports = class Response extends Writable {
     download(path, filename, options, callback) {
         let done = callback;
         let name = filename;
-        let opts = options || {};
+        let opts = options || new NullObject();
 
         // support function as second or third arg
         if (typeof filename === 'function') {
             done = filename;
             name = null;
-            opts = {};
+            opts = new NullObject();
         } else if (typeof options === 'function') {
             done = options;
-            opts = {};
+            opts = new NullObject();
         }
 
         // support optional filename, where options may be in it's place
@@ -518,7 +520,7 @@ module.exports = class Response extends Writable {
     }
     set(field, value) {
         if(this.headersSent) {
-            throw new Error('Can\'t write headers: Response was already sent');
+            throw new Error('Cannot set headers after they are sent to the client');
         }
         if(typeof field === 'object') {
             for(const header in field) {
@@ -537,18 +539,12 @@ module.exports = class Response extends Writable {
         }
         return this;
     }
-    header(field, value) {
-        return this.set(field, value);
-    }
-    setHeader(field, value) {
-        return this.set(field, value);
-    }
+    header = this.set;
+    setHeader = this.set;
     get(field) {
         return this.headers[field.toLowerCase()];
     }
-    getHeader(field) {
-        return this.get(field);
-    }
+    getHeader = this.get;
     removeHeader(field) {
         delete this.headers[field.toLowerCase()];
         return this;
@@ -577,10 +573,10 @@ module.exports = class Response extends Writable {
     render(view, options, callback) {
         if(typeof options === 'function') {
             callback = options;
-            options = {};
+            options = new NullObject();
         }
         if(!options) {
-            options = {};
+            options = new NullObject();
         } else {
             options = Object.assign({}, options);
         }
@@ -594,7 +590,7 @@ module.exports = class Response extends Writable {
     }
     cookie(name, value, options) {
         if(!options) {
-            options = {};
+            options = new NullObject();
         }
         let val = typeof value === 'object' ? "j:"+JSON.stringify(value) : String(value);
         if(options.maxAge != null) {
@@ -707,14 +703,10 @@ module.exports = class Response extends Writable {
         let ct = type.indexOf('/') === -1
             ? (mime.contentType(type) || 'application/octet-stream')
             : type;
-        if(ct.startsWith('text/') || ct === 'application/json' || ct === 'application/javascript') {
-            ct += '; charset=UTF-8';
-        }
+
         return this.set('content-type', ct);
     }
-    contentType(type) {
-        return this.type(type);
-    }
+    contentType = this.type;
 
     vary(field) {
         vary(this, field);

package/src/router.js

@@ -18,6 +18,7 @@ const { patternToRegex, needsConversionToRegex, deprecated, findIndexStartingFro
 const Response = require("./response.js");
 const Request = require("./request.js");
 const { EventEmitter } = require("tseep");
+const { NullObject } = require("./utils.js");
 
 let routeKey = 0;
 
@@ -30,6 +31,8 @@ const methods = [
 ];
 const supportedUwsMethods = ['GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'OPTIONS', 'HEAD', 'CONNECT', 'TRACE'];
 
+const regExParam = /:(\w+)/g;
+
 module.exports = class Router extends EventEmitter {
     constructor(settings = {}) {
         super();
@@ -263,12 +266,12 @@ module.exports = class Router extends EventEmitter {
             method = 'del';
         }
         if(!route.optimizedRouter && route.path.includes(":")) {
-            route.optimizedParams = route.path.match(/:(\w+)/g).map(p => p.slice(1));
+            route.optimizedParams = route.path.match(regExParam).map(p => p.slice(1));
         }
         const fn = async (res, req) => {
             const { request, response } = this.handleRequest(res, req);
             if(route.optimizedParams) {
-                request.optimizedParams = {};
+                request.optimizedParams = new NullObject();
                 for(let i = 0; i < route.optimizedParams.length; i++) {
                     request.optimizedParams[route.optimizedParams[i]] = req.getParameter(i);
                 }
@@ -281,7 +284,7 @@ module.exports = class Router extends EventEmitter {
             }
         };
         route.optimizedPath = optimizedPath;
-        let replacedPath = route.path.replace(/:(\w+)/g, ':x');
+        let replacedPath = route.path.replace(regExParam, ':x');
         this.uwsApp[method](replacedPath, fn);
         if(!this.get('strict routing') && route.path[route.path.length - 1] !== '/') {
             this.uwsApp[method](replacedPath + '/', fn);
@@ -319,7 +322,7 @@ module.exports = class Router extends EventEmitter {
 
     _extractParams(pattern, path) {
         let match = pattern.exec(path);
-        const obj = match?.groups ?? {};
+        const obj = match?.groups ?? new NullObject();
         for(let i = 1; i < match.length; i++) {
             obj[i - 1] = match[i];
         }
@@ -342,7 +345,7 @@ module.exports = class Router extends EventEmitter {
                     }
                 }
             } else {
-                req.params = {};
+                req.params = new NullObject();
                 if(req._paramStack.length > 0) {
                     for(let params of req._paramStack) {
                         req.params = {...params, ...req.params};
@@ -406,33 +409,33 @@ module.exports = class Router extends EventEmitter {
     }
 
     async _routeRequest(req, res, startIndex = 0, routes = this._routes, skipCheck = false, skipUntil) {
-        return new Promise(async (resolve) => {
-            let routeIndex = skipCheck ? startIndex : findIndexStartingFrom(routes, r => (r.all || r.method === req.method || (r.gettable && req.method === 'HEAD')) && this._pathMatches(r, req), startIndex);
-            const route = routes[routeIndex];
-            if(!route) {
-                if(!skipCheck) {
-                    // on normal unoptimized routes, if theres no match then there is no route
-                    return resolve(false);
-                }
-                // on optimized routes, there can be more routes, so we have to use unoptimized routing and skip until we find route we stopped at
-                return resolve(this._routeRequest(req, res, 0, this._routes, false, skipUntil));
+        let routeIndex = skipCheck ? startIndex : findIndexStartingFrom(routes, r => (r.all || r.method === req.method || (r.gettable && req.method === 'HEAD')) && this._pathMatches(r, req), startIndex);
+        const route = routes[routeIndex];
+        if(!route) {
+            if(!skipCheck) {
+                // on normal unoptimized routes, if theres no match then there is no route
+                return false;
             }
-            let callbackindex = 0;
-            const continueRoute = await this._preprocessRequest(req, res, route);
-            if(route.use) {
-                const strictRouting = this.get('strict routing');
-                req._stack.push(route.path);
-                req._opPath = req.path.replace(this.getFullMountpath(req), '');
-                if(strictRouting) {
-                    if(req.endsWithSlash && req.path !== '/') {
-                        req._opPath += '/';
-                    }
-                } else if(req.endsWithSlash && req.path !== '/') {
-                    req._opPath = req._opPath.slice(0, -1);
+            // on optimized routes, there can be more routes, so we have to use unoptimized routing and skip until we find route we stopped at
+            return this._routeRequest(req, res, 0, this._routes, false, skipUntil);
+        }
+        let callbackindex = 0;
+        const continueRoute = await this._preprocessRequest(req, res, route);
+        if(route.use) {
+            const strictRouting = this.get('strict routing');
+            req._stack.push(route.path);
+            req._opPath = req.path.replace(this.getFullMountpath(req), '');
+            if(strictRouting) {
+                if(req.endsWithSlash && req.path !== '/') {
+                     req._opPath += '/';
                 }
-                req.url = req._opPath + req.urlQuery;
-                if(req.url === '') req.url = '/';
+            } else if(req.endsWithSlash && req.path !== '/') {
+                req._opPath = req._opPath.slice(0, -1);
             }
+            req.url = req._opPath + req.urlQuery;
+            if(req.url === '') req.url = '/';
+        }
+        return new Promise((resolve) => {
             const next = async (thingamabob) => {
                 if(thingamabob) {
                     if(thingamabob === 'route' || thingamabob === 'skipPop') {
@@ -533,7 +536,7 @@ module.exports = class Router extends EventEmitter {
     }
     
     route(path) {
-        let fns = {};
+        let fns = new NullObject();
         for(let method of methods) {
             fns[method] = (...callbacks) => {
                 return this.createRoute(method.toUpperCase(), path, fns, ...callbacks);
@@ -564,4 +567,4 @@ module.exports = class Router extends EventEmitter {
             `</body>\n` +
             `</html>\n`);
     }
-}
+}

package/src/types.d.ts

@@ -1,4 +1,49 @@
-declare module 'ultimate-express' {
-    import express from '@types/express';
-    export = express;
-}
+declare module "ultimate-express" {
+  import e from "@types/express";
+  import { AppOptions } from "uWebSockets.js";
+
+  type Settings = {
+    uwsOptions?: AppOptions;
+    threads?: number;
+  };
+
+  namespace express {
+    export import json = e.json;
+    export import raw = e.raw;
+    export import text = e.text;
+
+    // export import application = e.application;
+    export import request = e.request;
+    export import response = e.response;
+
+    export import static = e.static;
+    // export import query = e.query;
+
+    export import urlencoded = e.urlencoded;
+
+    export import RouterOptions = e.RouterOptions;
+    export import Application = e.Application;
+    export import CookieOptions = e.CookieOptions;
+    export import Errback = e.Errback;
+    export import ErrorRequestHandler = e.ErrorRequestHandler;
+    export import Express = e.Express;
+    export import Handler = e.Handler;
+    export import IRoute = e.IRoute;
+    export import IRouter = e.IRouter;
+    export import IRouterHandler = e.IRouterHandler;
+    export import IRouterMatcher = e.IRouterMatcher;
+    export import MediaType = e.MediaType;
+    export import NextFunction = e.NextFunction;
+    export import Locals = e.Locals;
+    export import Request = e.Request;
+    export import RequestHandler = e.RequestHandler;
+    export import RequestParamHandler = e.RequestParamHandler;
+    export import Response = e.Response;
+    export import Router = e.Router;
+    export import Send = e.Send;
+  }
+
+  function express(settings?: Settings): e.Express;
+
+  export = express;
+}

package/src/utils.js

@@ -23,7 +23,11 @@ const etag = require("etag");
 const { Stats } = require("fs");
 
 function fastQueryParse(query, options) {
-    if(query.length <= 128) {
+    const len = query.length;
+    if(len === 0){
+        return new NullObject();
+    }
+    if(len <= 128) {
         if(!query.includes('[') && !query.includes('%5B') && !query.includes('.') && !query.includes('%2E')) {
             return querystring.parse(query);
         }
@@ -44,9 +48,9 @@ function patternToRegex(pattern, isPrefix = false) {
     }
 
     let regexPattern = pattern
-        .replace(/\./g, '\\.')
-        .replace(/\-/g, '\\-')
-        .replace(/\*/g, '(.*)') // Convert * to .*
+        .replaceAll('.', '\\.')
+        .replaceAll('-', '\\-')
+        .replaceAll('*', '(.*)') // Convert * to .*
         .replace(/:(\w+)(\(.+?\))?/g, (match, param, regex) => {
             return `(?<${param}>${regex ? regex + '($|\\/)' : '[^/]+'})`;
         }); // Convert :param to capture group
@@ -101,12 +105,13 @@ function acceptParams(str) {
     const parts = str.split(/ *; */);
     const ret = { value: parts[0], quality: 1, params: {} }
   
-    for (let i = 1; i < parts.length; ++i) {
+    for (let i = 1, len = parts.length; i < len; ++i) {
       const pms = parts[i].split(/ *= */);
-      if ('q' === pms[0]) {
-        ret.quality = parseFloat(pms[1]);
+      const [pms_0, pms_1] = pms;
+      if ('q' === pms_0) {
+        ret.quality = parseFloat(pms_1);
       } else {
-        ret.params[pms[0]] = pms[1];
+        ret.params[pms_0] = pms_1;
       }
     }
   
@@ -218,7 +223,7 @@ function decode (path) {
 const UP_PATH_REGEXP = /(?:^|[\\/])\.\.(?:[\\/]|$)/;
 
 function containsDotFile(parts) {
-    for(let i = 0; i < parts.length; i++) {
+    for(let i = 0, len = parts.length; i < len; i++) {
         const part = parts[i];
         if(part.length > 1 && part[0] === '.') {
             return true;
@@ -315,6 +320,10 @@ function isRangeFresh(req, res) {
     return parseHttpDate(lastModified) <= parseHttpDate(ifRange);
 }
 
+// fast null object
+const NullObject = function() {};
+NullObject.prototype = Object.create(null);
+
 module.exports = {
     removeDuplicateSlashes,
     patternToRegex,
@@ -326,6 +335,7 @@ module.exports = {
     compileTrust,
     deprecated,
     UP_PATH_REGEXP,
+    NullObject,
     decode,
     containsDotFile,
     parseTokenList,
@@ -336,4 +346,4 @@ module.exports = {
     findIndexStartingFrom,
     fastQueryParse,
     canBeOptimized
-};
+};

package/src/view.js

@@ -16,11 +16,12 @@ limitations under the License.
 
 const path = require("path");
 const fs = require("fs");
+const { NullObject } = require("./utils.js");
 
 module.exports = class View {
     constructor(name, options) {
         this.name = name;
-        this.options = options ? Object.assign({}, options) : {};
+        this.options = options ? Object.assign({}, options) : new NullObject();
         this.defaultEngine = options.defaultEngine;
         this.ext = path.extname(name);
         this.root = options.root;