ultimate-brain 0.4.0 → 0.5.0

package/dist/lib/sync.js

@@ -1,6 +1,6 @@
 import { createHash } from "node:crypto";
 import { isDeepStrictEqual } from "node:util";
-import { applyAll, EDITABLE } from "./apply.js";
+import { applyAll } from "./apply.js";
 import { BrainError } from "./errors.js";
 import { assertNoProblems, isRecord, unknownKeys } from "./input.js";
 import { generateId, TYPE_PREFIX } from "./ids.js";
@@ -9,11 +9,13 @@ import { compareCodePoints } from "./notes.js";
 import { fullText, splitParts } from "./parts.js";
 import { loadSchemas } from "./schemas.js";
 import { formatDate, formatTimestamp, normalizeTimestamp } from "./time.js";
-const DATABASES = ["areas", "goals", "key_results", "projects", "people", "orgs", "decisions", "questions", "concepts", "review", "inbox"];
+import { lineDiff } from "./diff.js";
+import { bodyHash, bodyOf } from "./proposals.js";
+const DATABASES = ["areas", "goals", "key_results", "projects", "people", "orgs", "decisions", "questions", "concepts", "references", "review", "inbox"];
 const CREATABLE = new Set(["areas", "goals", "projects", "people", "orgs"]);
-const TYPE_FOR_DATABASE = { areas: "area", goals: "goal", projects: "project", people: "person", orgs: "org", decisions: "decision", questions: "question", concepts: "concept", review: "proposal" };
-const DATABASE_FOR_TYPE = { area: "areas", goal: "goals", project: "projects", person: "people", org: "orgs", decision: "decisions", question: "questions", concept: "concepts", source: "inbox", meeting: "meetings", proposal: "review" };
-const PUBLISHED_TYPES = new Set(["area", "goal", "project", "person", "org", "decision", "question", "concept", "source", "meeting", "proposal"]);
+const TYPE_FOR_DATABASE = { areas: "area", goals: "goal", projects: "project", people: "person", orgs: "org", decisions: "decision", questions: "question", concepts: "concept", references: "reference", review: "proposal" };
+const DATABASE_FOR_TYPE = { area: "areas", goal: "goals", project: "projects", person: "people", org: "orgs", decision: "decisions", question: "questions", concept: "concepts", reference: "references", source: "inbox", meeting: "meetings", proposal: "review" };
+const PUBLISHED_TYPES = new Set(["area", "goal", "project", "person", "org", "decision", "question", "concept", "reference", "source", "meeting", "proposal"]);
 function property(value, key) {
     return Object.hasOwn(value, key) ? value[key] : undefined;
 }
@@ -72,7 +74,7 @@ export function parseSnapshot(input) {
 }
 /** Compute the deterministic, no-network Notion pull plan (cli §5.14.2). */
 export function buildPlan(workspace, snapshot) {
-    const result = { as_of: snapshot.as_of, create: [], updates: [], corrections: [], decisions: [], full_text_requests: [], conflicts: [], ignored: [] };
+    const result = { as_of: snapshot.as_of, create: [], updates: [], corrections: [], decisions: [], full_text_requests: [], refresh_requests: [], report_fixes: [], conflicts: [], ignored: [] };
     const createsByPage = new Map();
     for (const row of snapshot.rows)
         if (CREATABLE.has(row.database) && blank(property(row.properties, "Brain ID"))) {
@@ -296,44 +298,56 @@ function planKeyFacts(row, note, published, updates, out) {
         updates.published = { ...(isRecord(updates.published) ? updates.published : {}), "Key Facts": text };
 }
 function planDecision(row, proposal, out) {
-    const decision = property(row.properties, "Decision");
-    if (decision === undefined || property(row.properties, "State") !== "Pending")
+    // A snapshot taken before migration 0009 has Decision and Note; Edit there is read as Fix (cli §5.14.2, 0045).
+    const call = property(row.properties, "Your call") ?? property(row.properties, "Decision");
+    const label = Object.hasOwn(row.properties, "Your call") ? "Your call" : "Decision";
+    const textLabel = Object.hasOwn(row.properties, "What to fix") || !Object.hasOwn(row.properties, "Note") ? "What to fix" : "Note";
+    if (call === undefined || call === null || property(row.properties, "State") !== "Pending")
         return;
     if (["applied", "closed"].includes(String(proposal.attributes.status))) {
         out.ignored.push({ database: row.database, page_id: row.page_id, brain_id: proposal.id, reason: "ALREADY_TERMINAL" });
         return;
     }
-    const action = String(decision).toLowerCase();
-    const note = property(row.properties, "Note");
-    if (!["approve", "reject", "edit"].includes(action)) {
-        out.ignored.push({ database: row.database, page_id: row.page_id, brain_id: proposal.id, reason: "NOT_CORRECTABLE" });
+    const action = String(call).toLowerCase() === "edit" ? "fix" : String(call).toLowerCase();
+    const text = property(row.properties, textLabel);
+    const written = typeof text === "string" && text.trim() !== "";
+    if (!["approve", "reject", "fix"].includes(action)) {
+        out.ignored.push({ database: row.database, page_id: row.page_id, brain_id: proposal.id, property: label, reason: "UNKNOWN_OPTION" });
         return;
     }
-    if (action === "edit" && !EDITABLE.has(String(proposal.attributes.kind))) {
-        out.conflicts.push(conflict(row, "EDIT_NOT_ALLOWED", `Edit is not allowed on a ${String(proposal.attributes.kind)} proposal`, "Decision", decision));
+    if (action === "fix" && !written) {
+        out.conflicts.push(conflict(row, "FIX_WITHOUT_TEXT", "Fix needs What to fix: what to correct", "What to fix"));
         return;
     }
-    if (action === "edit" && (note === null || note === undefined || note === "")) {
-        out.conflicts.push(conflict(row, "EDIT_WITHOUT_VALUE", "Edit needs a Note", "Note"));
+    if (action === "fix") {
+        out.conflicts.push(conflict(row, "FIX_TO_READ", "What to fix needs reading by the skill", "What to fix", text, "Fix"));
         return;
     }
-    if (action !== "edit" && typeof note === "string" && note !== "") {
-        out.conflicts.push(conflict(row, "NOTE_TO_READ", "Review Note needs interpretation by the skill", "Note", note, decision));
+    if (written) {
+        out.conflicts.push(conflict(row, "NOTE_TO_READ", "What to fix needs reading by the skill", "What to fix", text, action === "approve" ? "Approve" : "Reject"));
         return;
     }
-    out.decisions.push({ proposal: proposal.id, action: action, ...(action === "edit" ? { value: note, note: note } : {}), decided_at: row.last_edited, decided_by: "notion" });
+    out.decisions.push({ proposal: proposal.id, action: action, decided_at: row.last_edited, decided_by: "notion" });
 }
-/** An Inbox row is read only for its Full text box (cli §5.14.2, 0043). */
+/** An Inbox row is read for its Full text box (0043) and, on a Report row, Refresh and What to fix (cli §5.14.2, 0045). */
 function planInbox(workspace, row, out) {
+    const brainId = property(row.properties, "Brain ID");
+    const note = typeof brainId === "string" && brainId !== "" ? workspace.get(brainId) : undefined;
+    if (note !== undefined && isReport(note)) {
+        if (property(row.properties, "Refresh") === true)
+            out.refresh_requests.push({ page_id: row.page_id, report: note.id });
+        const text = property(row.properties, "What to fix");
+        const last = (Array.isArray(note.attributes.fixes) ? note.attributes.fixes : []).filter(isRecord).at(-1);
+        if (typeof text === "string" && text.trim() !== "" && text !== last?.text)
+            out.report_fixes.push({ page_id: row.page_id, report: note.id, text });
+    }
     if (property(row.properties, "Full text") !== true)
         return;
-    const brainId = property(row.properties, "Brain ID");
     const ignore = (id) => out.ignored.push({ database: row.database, page_id: row.page_id, brain_id: id, property: "Full text", reason: "NO_FULL_TEXT" });
     if (typeof brainId !== "string" || brainId === "") {
         ignore(null);
         return;
     }
-    const note = workspace.get(brainId);
     if (note === undefined) {
         out.conflicts.push(conflict(row, "UNKNOWN_BRAIN_ID", `No note has Brain ID ${brainId}`));
         return;
@@ -369,7 +383,7 @@ function planKeyResult(workspace, asOf, row, out) {
 }
 function sortPlan(plan) {
     const order = (item) => [DATABASES.indexOf(String(item.database)), String(item.page_id ?? item.id), String(item.field ?? item.property ?? "")].join("\u0000");
-    for (const values of [plan.create, plan.updates, plan.corrections, plan.decisions, plan.full_text_requests, plan.conflicts, plan.ignored])
+    for (const values of [plan.create, plan.updates, plan.corrections, plan.decisions, plan.full_text_requests, plan.refresh_requests, plan.report_fixes, plan.conflicts, plan.ignored])
         values.sort((a, b) => order(a).localeCompare(order(b)));
 }
 function notionFields(database, p, asOf) {
@@ -382,7 +396,7 @@ function notionFields(database, p, asOf) {
 }
 function brainProperties(database) {
     const common = [["Name", "title"], ["Summary", "summary"], ["Lifecycle", "lifecycle"]];
-    const extras = { goals: [["Why", "why"], ["Deadline", "facts.deadline"], ["Area", "area"]], projects: [["Key Facts", "facts"], ["Area", "area"], ["Goal", "goal"], ["Client", "client"], ["People", "people"]], people: [["Role", "facts.role"], ["Org", "org"]], decisions: [["Assessment", "assessment"], ["Project", "projects"], ["Area", "derived_area"]], questions: [["Kind", "kind"], ["Project", "projects"], ["Area", "derived_area"]], concepts: [["Project", "concept_projects"], ["Area", "concept_area"]] };
+    const extras = { goals: [["Why", "why"], ["Deadline", "facts.deadline"], ["Area", "area"]], projects: [["Key Facts", "facts"], ["Area", "area"], ["Goal", "goal"], ["Client", "client"], ["People", "people"]], people: [["Role", "facts.role"], ["Org", "org"]], decisions: [["Assessment", "assessment"], ["Project", "projects"], ["Area", "derived_area"]], questions: [["Kind", "kind"], ["Project", "projects"], ["Area", "derived_area"]], concepts: [["Project", "concept_projects"], ["Area", "concept_area"]], references: [["Project", "reference_projects"], ["Area", "reference_area"]] };
     return [...common, ...(extras[database] ?? [])];
 }
 function convertedValue(workspace, row, name, value, conflicts) {
@@ -446,9 +460,10 @@ export function parsePlan(input) {
     if (!isRecord(input))
         assertNoProblems([{ pointer: "", message: "must be an object" }]);
     const p = input;
-    const problems = unknownKeys(p, ["as_of", "create", "updates", "corrections", "decisions", "full_text_requests", "conflicts", "ignored"], "");
-    if (p.full_text_requests !== undefined && !Array.isArray(p.full_text_requests))
-        problems.push({ pointer: "/full_text_requests", message: "must be a list" });
+    const problems = unknownKeys(p, ["as_of", "create", "updates", "corrections", "decisions", "full_text_requests", "refresh_requests", "report_fixes", "conflicts", "ignored"], "");
+    for (const key of ["full_text_requests", "refresh_requests", "report_fixes"])
+        if (p[key] !== undefined && !Array.isArray(p[key]))
+            problems.push({ pointer: `/${key}`, message: "must be a list" });
     if (!isTimestamp(p.as_of))
         problems.push({ pointer: "/as_of", message: "must be an ISO 8601 UTC timestamp" });
     for (const key of ["create", "updates", "corrections", "decisions", "conflicts", "ignored"])
@@ -466,7 +481,7 @@ export function parsePlan(input) {
             problems.push({ pointer: `/create/${index}/lifecycle`, message: "must be a lifecycle string" });
     });
     assertNoProblems(problems);
-    return { ...p, full_text_requests: p.full_text_requests ?? [], as_of: normalizeTimestamp(p.as_of) };
+    return { ...p, full_text_requests: p.full_text_requests ?? [], refresh_requests: p.refresh_requests ?? [], report_fixes: p.report_fixes ?? [], as_of: normalizeTimestamp(p.as_of) };
 }
 export function applyPlan(workspace, plan, now, recordOnly) {
     const create = [];
@@ -538,17 +553,17 @@ export function applyPlan(workspace, plan, now, recordOnly) {
         ...updates.filter((item) => item.result === "applied").map((item) => ({ op: "sync-update", id: String(item.id), title: String(workspace.get(String(item.id))?.attributes.title ?? item.id) })),
         ...(correctionApply?.log ?? []), ...(decisionApply.log ?? []),
     ];
-    return { create, updates, corrections, decisions: decisionResult, full_text_requests: plan.full_text_requests, conflicts: plan.conflicts, ignored: plan.ignored, summary: summarize([...create, ...updates, ...corrections, ...decisionResult].map((item) => ({ ...item }))), log };
+    return { create, updates, corrections, decisions: decisionResult, full_text_requests: plan.full_text_requests, refresh_requests: plan.refresh_requests, report_fixes: plan.report_fixes, conflicts: plan.conflicts, ignored: plan.ignored, summary: summarize([...create, ...updates, ...corrections, ...decisionResult].map((item) => ({ ...item }))), log };
 }
 function references(value) { if (Array.isArray(value))
     return value.flatMap(references); if (isRecord(value))
-    return Object.values(value).flatMap(references); return typeof value === "string" && /^(area|gol|prj|per|org|mtg|dec|que|con|src|mem)-/.test(value) ? [value] : []; }
+    return Object.values(value).flatMap(references); return typeof value === "string" && /^(area|gol|prj|per|org|mtg|dec|que|con|ref|src|mem)-/.test(value) ? [value] : []; }
 function summarize(items) { const result = { applied: 0, closed: 0, recorded: 0, corrected: 0, skipped: 0, failed: 0 }; for (const item of items)
     if (typeof item.result === "string" && Object.hasOwn(result, item.result))
         result[item.result] += 1; return result; }
 export function render(workspace, now, ids, held) {
     const selected = ids === undefined
-        ? workspace.notes.filter((note) => (PUBLISHED_TYPES.has(note.type) && !(note.type === "source" && note.attributes.kind === undefined)) || (isReport(note) && note.attributes.notion === undefined))
+        ? workspace.notes.filter((note) => (PUBLISHED_TYPES.has(note.type) && !(note.type === "source" && note.attributes.kind === undefined)) || isReport(note))
         : ids.map((id) => workspace.get(id)).filter(Boolean);
     const items = [];
     const errors = [];
@@ -557,17 +572,21 @@ export function render(workspace, now, ids, held) {
         const database = isReport(note) ? "inbox" : DATABASE_FOR_TYPE[note.type];
         if (database === undefined || (note.type === "source" && note.attributes.kind === undefined))
             continue;
-        // A published report is never rendered again (0043).
-        if (isReport(note) && note.attributes.notion !== undefined)
-            continue;
         // An attached source has no Inbox row: its notes go on the parent's (0042).
         if (note.type === "source" && note.attributes.attached_to !== undefined)
             continue;
+        // A decided Review row leaves Notion 30 days after its decision, once (0045).
+        if (note.type === "proposal" && isRecord(note.attributes.notion_published) && note.attributes.notion_published["@trashed"] !== undefined)
+            continue;
         const databaseId = databaseIdFor(workspace, database);
         if (databaseId === "") {
             warnings.push({ code: "DATABASE_NOT_CONFIGURED", message: `${database} database is not configured`, id: note.id });
             continue;
         }
+        if (note.type === "proposal" && trashDue(note, now)) {
+            items.push({ id: note.id, type: note.type, database, database_id: databaseId, page_id: String(note.attributes.notion), action: "trash", properties: {}, body: null, sections: null, pending_relations: [], published: { "@trashed": formatTimestamp(now) } });
+            continue;
+        }
         if (note.type === "meeting" && typeof note.attributes.notion !== "string") {
             errors.push({ id: note.id, reason: "MEETING_NOT_PUBLISHED" });
             continue;
@@ -586,7 +605,7 @@ export function render(workspace, now, ids, held) {
         const properties = {};
         const pending = [];
         const heldProperties = held?.get(note.id) ?? new Set();
-        const isCreate = isReport(note) || (note.attributes.notion === undefined && capturePage === undefined);
+        const isCreate = note.attributes.notion === undefined && capturePage === undefined;
         for (const [name, value] of Object.entries(rendered)) {
             if (name === "@content" || heldProperties.has(name) || (capturePage !== undefined && name === "Name"))
                 continue;
@@ -598,6 +617,21 @@ export function render(workspace, now, ids, held) {
         if (content.hash !== undefined)
             rendered["@content"] = content.hash;
         const contentChanged = content.hash !== undefined && !isDeepStrictEqual(content.hash, published["@content"]);
+        // A report (0045): a refresh sends the body once and clears Refresh; a new fix clears What to fix.
+        let reportDue = false;
+        if (isReport(note)) {
+            const fixes = Array.isArray(note.attributes.fixes) ? note.attributes.fixes.length : 0;
+            const stored = typeof published["@fixes"] === "number" ? published["@fixes"] : 0;
+            if (!isCreate && contentChanged)
+                properties.Refresh = { type: "checkbox", value: false };
+            if (!isCreate && !contentChanged)
+                content.body = null;
+            if (fixes > stored) {
+                properties["What to fix"] = { type: "rich_text", value: null };
+                reportDue = true;
+            }
+            rendered["@fixes"] = Math.max(fixes, stored);
+        }
         // Full text (0043): the text goes out once per choice, and a ticked box is cleared once per request.
         const full = note.type === "source" && hasInboxBody(note) ? fullTextDue(note, published["@full_text"]) : undefined;
         if (full?.sections !== undefined)
@@ -607,7 +641,7 @@ export function render(workspace, now, ids, held) {
         if (full !== undefined && (full.sections !== undefined || full.clear))
             rendered["@full_text"] = full.record;
         const fullTextDueNow = full !== undefined && (full.sections !== undefined || full.clear);
-        if (!isCreate && Object.keys(properties).length === 0 && !contentChanged && !fullTextDueNow)
+        if (!isCreate && Object.keys(properties).length === 0 && !contentChanged && !fullTextDueNow && !reportDue)
             continue;
         if (!isCreate && note.type !== "meeting" && note.type !== "proposal")
             properties["Last Synced"] = { type: "date", value: { start: formatTimestamp(now), end: null } };
@@ -616,6 +650,16 @@ export function render(workspace, now, ids, held) {
     items.sort((a, b) => DATABASES.concat(["meetings"]).indexOf(a.database) - DATABASES.concat(["meetings"]).indexOf(b.database) || compareCodePoints(a.id, b.id));
     return { items, errors, warnings };
 }
+const TRASH_AFTER_MS = 30 * 24 * 60 * 60 * 1000;
+/** A published Review row whose proposal was applied or closed more than 30 days before `now` (0045). */
+function trashDue(note, now) {
+    const a = note.attributes;
+    if (typeof a.notion !== "string" || (a.status !== "applied" && a.status !== "closed"))
+        return false;
+    const decided = isRecord(a.decision) && typeof a.decision.decided_at === "string" ? a.decision.decided_at : a.updated;
+    const time = typeof decided === "string" ? Date.parse(decided) : Number.NaN;
+    return Number.isFinite(time) && now.getTime() - time > TRASH_AFTER_MS;
+}
 function databaseIdFor(workspace, database) { const notion = workspace.config.notion; if (!isRecord(notion) || !isRecord(notion.databases))
     return ""; return typeof notion.databases[database] === "string" ? notion.databases[database] : database === "inbox" && typeof notion.databases.capture_inbox === "string" ? notion.databases.capture_inbox : ""; }
 function renderedBrainValues(note, workspace) {
@@ -627,7 +671,9 @@ function renderedBrainValues(note, workspace) {
         const addLink = a.kind === "add_link";
         const after = addLink
             ? proposalLinks(a).map((link) => `${fieldLabel(String(link.field))}: ${noteTitle(link.value, workspace)}`).join("\n")
-            : a.kind === "review_notes" ? reviewNotesAfter(a, workspace) : undefined;
+            : a.kind === "review_notes" ? reviewNotesAfter(a, workspace) : a.kind === "update_body" ? bodyChange(a, workspace)?.join("\n") ?? null : undefined;
+        // A body diff can only be shown while the target's body is the one proposed against; then S keeps it (0045).
+        const proposed = staleBody(a, workspace) && isRecord(a.notion_published) && Object.hasOwn(a.notion_published, "Proposed") ? a.notion_published.Proposed : undefined;
         const reviewText = (value) => truncate(typeof value === "string" ? reviewMarkdown(value, target) : value);
         // A Review notes row names its source: the meeting for minutes, else the source (0041).
         const source = a.kind === "review_notes" && typeof a.source === "string" ? workspace.get(a.source) : undefined;
@@ -635,16 +681,16 @@ function renderedBrainValues(note, workspace) {
         const page = (source ?? target)?.attributes.notion;
         const meeting = typeof a.source === "string" ? workspace.get(a.source) : undefined;
         Object.assign(values, {
-            Name: a.title, Kind: select(a.kind), Target: targetText,
-            "Target Page": typeof page === "string" ? `https://www.notion.so/${page.replaceAll("-", "")}` : null,
+            Name: a.title, Kind: select(a.kind), About: targetText,
+            "About Page": typeof page === "string" ? `https://www.notion.so/${page.replaceAll("-", "")}` : null,
             "Source Meeting": meeting?.type === "meeting" && typeof meeting.attributes.notion === "string" ? [meeting.attributes.notion] : [],
-            Before: reviewText(proposalBefore(a, workspace)), After: reviewText(after ?? proposalAfter(a, workspace)),
+            Now: reviewText(proposalBefore(a, workspace)), Proposed: proposed !== undefined ? proposed : reviewText(after ?? proposalAfter(a, workspace)),
             Why: reviewText(a.why), State: select(proposalState(a.status)), "Brain ID": note.id,
         });
         return values;
     }
     if (isReport(note)) {
-        Object.assign(values, { Name: a.title, Kind: "Report", Project: relationPages(a.projects, workspace), Area: relationPages(a.area === undefined ? [] : [a.area], workspace), Ask: typeof a.asked_in === "string" ? [a.asked_in] : [], "Brain Status": "Processed", "Brain ID": note.id });
+        Object.assign(values, { Name: a.title, Kind: "Report", Project: relationPages(a.projects, workspace), Area: relationPages(a.area === undefined ? [] : [a.area], workspace), Ask: typeof a.asked_in === "string" ? [a.asked_in] : Array.isArray(a.asked_in) ? a.asked_in : [], "Brain Status": "Processed", "Brain ID": note.id });
         return values;
     }
     if (note.type === "meeting") {
@@ -664,10 +710,18 @@ function renderedBrainValues(note, workspace) {
         Object.assign(values, { Date: dateOutput(a.date), Assessment: select(a.assessment), Area: relationPages(projectAreas(a.projects, workspace), workspace), Project: relationPages(a.projects, workspace), "Decided In": relationPages(a.decided_in === undefined ? [] : [a.decided_in], workspace), Supersedes: relationPages((Array.isArray(a.relations) ? a.relations.filter(isRecord).filter((x) => x.type === "supersedes").map((x) => x.target) : []), workspace) });
     if (note.type === "question")
         Object.assign(values, { Kind: select(a.kind), Area: relationPages(projectAreas(a.projects, workspace), workspace), Project: relationPages(a.projects, workspace), "Raised In": relationPages(a.raised_in === undefined ? [] : [a.raised_in], workspace) });
-    // An answered question's Status goes out once as Answered; it stays yours after that (0041).
-    if (note.type === "question" && a.answer !== undefined && (!isRecord(a.notion_published) || a.notion_published.Status !== "Answered"))
-        values.Status = "Answered";
-    if (note.type === "concept")
+    // Status goes out once as Open while you never set one, and once as Answered after an approved answer; it stays yours otherwise (0041, 0045).
+    if (note.type === "question") {
+        const published = isRecord(a.notion_published) ? a.notion_published : {};
+        const yours = isRecord(a.notion_fields) && a.notion_fields.status !== undefined;
+        if (a.answer !== undefined) {
+            if (published.Status !== "Answered")
+                values.Status = "Answered";
+        }
+        else if (published.Status === undefined && !yours)
+            values.Status = "Open";
+    }
+    if (note.type === "concept" || note.type === "reference")
         Object.assign(values, { Project: relationPages(a.projects, workspace), Area: relationPages(a.area === undefined ? [] : [a.area], workspace) });
     return values;
 }
@@ -682,17 +736,17 @@ function projectAreas(projects, workspace) {
 /** The notes a source produced, with those of the sources attached to it (cli §5.14.4, 0042). */
 function producedBy(note, workspace) {
     const sources = new Set([note.id, ...workspace.notes.filter((candidate) => candidate.type === "source" && candidate.attributes.attached_to === note.id).map((candidate) => candidate.id)]);
-    return workspace.notes.filter((candidate) => ["decision", "question", "concept", "person"].includes(candidate.type) && Array.isArray(candidate.attributes.sources) && candidate.attributes.sources.some((id) => sources.has(String(id))));
+    return workspace.notes.filter((candidate) => ["decision", "question", "concept", "reference", "person"].includes(candidate.type) && Array.isArray(candidate.attributes.sources) && candidate.attributes.sources.some((id) => sources.has(String(id))));
 }
 function sourceValues(note, workspace) {
     const produced = producedBy(note, workspace);
     const ids = (type) => produced.filter((candidate) => candidate.type === type).map((candidate) => candidate.id).sort(compareCodePoints);
     const projects = [...new Set(produced.flatMap((candidate) => Array.isArray(candidate.attributes.projects) ? candidate.attributes.projects.filter((id) => typeof id === "string") : []))].sort(compareCodePoints);
     const areas = [...new Set([...produced.map((candidate) => candidate.attributes.area).filter((id) => typeof id === "string"), ...projects.flatMap((id) => { const area = workspace.get(id)?.attributes.area; return typeof area === "string" ? [area] : []; })])].sort(compareCodePoints);
-    return { Name: note.attributes.title, Kind: select(note.attributes.kind), Summary: note.attributes.summary ?? null, Decisions: relationPages(ids("decision"), workspace), Questions: relationPages(ids("question"), workspace), Concepts: relationPages(ids("concept"), workspace), People: relationPages(ids("person"), workspace), Project: relationPages(projects, workspace), Area: relationPages(areas, workspace), "Brain Status": "Processed", "Brain ID": note.id };
+    return { Name: note.attributes.title, Kind: select(note.attributes.kind), Summary: note.attributes.summary ?? null, Decisions: relationPages(ids("decision"), workspace), Questions: relationPages(ids("question"), workspace), Concepts: relationPages(ids("concept"), workspace), ...(databaseIdFor(workspace, "references") === "" ? {} : { References: relationPages(ids("reference"), workspace) }), People: relationPages(ids("person"), workspace), Project: relationPages(projects, workspace), Area: relationPages(areas, workspace), "Brain Status": "Processed", "Brain ID": note.id };
 }
 function notionProperty(name, value, note, workspace, pending) {
-    const relation = ["Area", "Goal", "Client", "People", "Org", "Project", "Decided In", "Raised In", "Supersedes", "Decisions", "Questions", "Concepts", "Attendees"].includes(name);
+    const relation = ["Area", "Goal", "Client", "People", "Org", "Project", "Decided In", "Raised In", "Supersedes", "Decisions", "Questions", "Concepts", "References", "Attendees"].includes(name);
     if (relation) {
         const sourceField = { Area: "area", Goal: "goal", Client: "client", People: "people", Org: "org", Project: "projects", "Decided In": "decided_in", "Raised In": "raised_in", Decisions: "decisions", Questions: "questions", Attendees: "attendees" };
         const raw = name === "Area" && (note.type === "decision" || note.type === "question") ? projectAreas(note.attributes.projects, workspace) : name === "Supersedes" ? (Array.isArray(note.attributes.relations) ? note.attributes.relations.filter(isRecord).filter((item) => item.type === "supersedes").map((item) => item.target) : []) : note.type === "source" ? sourceRelationIds(note, name, workspace) : note.attributes[sourceField[name] ?? ""];
@@ -710,7 +764,7 @@ function notionProperty(name, value, note, workspace, pending) {
     }
     if (name === "Ask")
         return { type: "relation", value: Array.isArray(value) ? value : [] };
-    if (name === "Target Page")
+    if (name === "About Page")
         return { type: "url", value };
     if (["Lifecycle", "Assessment", "Kind", "State", "Brain Status", "Status"].includes(name))
         return { type: "select", value };
@@ -726,6 +780,8 @@ function sourceRelationIds(note, name, workspace) {
         return produced.filter((candidate) => candidate.type === "question").map((candidate) => candidate.id);
     if (name === "Concepts")
         return produced.filter((candidate) => candidate.type === "concept").map((candidate) => candidate.id);
+    if (name === "References")
+        return produced.filter((candidate) => candidate.type === "reference").map((candidate) => candidate.id);
     if (name === "People")
         return produced.filter((candidate) => candidate.type === "person").map((candidate) => candidate.id);
     const projects = [...new Set(produced.flatMap((candidate) => Array.isArray(candidate.attributes.projects) ? candidate.attributes.projects.filter((id) => typeof id === "string") : []))];
@@ -759,7 +815,7 @@ function renderedContent(note, workspace) {
         const body = notionMarkdown(note.body.replace(/^\n+/, ""), note, workspace);
         return { body, sections: null, hash: hash(body) };
     }
-    if (note.type === "decision" || note.type === "question" || note.type === "concept") {
+    if (note.type === "decision" || note.type === "question" || note.type === "concept" || note.type === "reference") {
         const body = notionMarkdown(note.body, note, workspace);
         return { body, sections: null, hash: hash(body) };
     }
@@ -799,14 +855,34 @@ function personTitle(value, workspace) { return typeof value === "string" && wor
 function noteTitle(value, workspace) { return typeof value === "string" ? workspace.get(value)?.attributes.title ?? value : value ?? null; }
 function fieldLabel(field) { return field[0]?.toUpperCase() + field.slice(1).replaceAll("_", " "); }
 function truncate(value) { return typeof value === "string" ? value.slice(0, 2000) : value; }
-/** The lettered lines of a Review notes row: its notes, then its links (cli §5.14.4). */
+/** The lettered lines of a Review notes row: its changes, then its notes, then its links (cli §5.14.4, 0045). */
 function reviewNotesAfter(attributes, workspace) {
+    const changes = (Array.isArray(attributes.changes) ? attributes.changes.filter(isRecord) : []).map((change) => {
+        const target = String(noteTitle(change.target, workspace));
+        if (change.kind === "update_fact")
+            return `⚠ ${fieldLabel(String(change.field))} on ${target}: ${change.before === undefined ? "(new)" : String(noteTitle(change.before, workspace))} → ${String(noteTitle(change.after, workspace))}`;
+        if (change.kind === "update_body")
+            return `⚠ ${target}: ${bodyChange(change, workspace)?.length ?? 0} lines changed`;
+        return `Add to ${target}: ${String(change.content ?? "").split("\n")[0].slice(0, 80)}`;
+    });
     const notes = (Array.isArray(attributes.notes) ? attributes.notes : []).map((id) => {
         const note = workspace.get(String(id));
         return `${note === undefined ? "Note" : fieldLabel(note.type)}: ${String(noteTitle(id, workspace))}`;
     });
     const links = (Array.isArray(attributes.links) ? attributes.links.filter(isRecord) : []).map((link) => `${fieldLabel(String(link.field))} on ${String(noteTitle(link.target, workspace))}: ${String(noteTitle(link.value, workspace))}`);
-    return [...notes, ...links].map((line, index) => `${letters(index)}) ${line}`).join("\n");
+    return [...changes, ...notes, ...links].map((line, index) => `${letters(index)}) ${line}`).join("\n");
+}
+/** The changed lines an update_body proposes against its target's body (cli §5.19), or undefined once that body changed. */
+function bodyChange(change, workspace) {
+    const target = typeof change.target === "string" ? workspace.get(change.target) : undefined;
+    if (target === undefined || bodyHash(target.body) !== change.before_hash)
+        return undefined;
+    return lineDiff(target.body, bodyOf(String(change.content ?? "")));
+}
+/** Whether a proposal holds an update_body whose target's body is no longer the one it was proposed against. */
+function staleBody(attributes, workspace) {
+    const bodies = attributes.kind === "update_body" ? [attributes] : (Array.isArray(attributes.changes) ? attributes.changes.filter(isRecord) : []).filter((change) => change.kind === "update_body");
+    return bodies.some((change) => bodyChange(change, workspace) === undefined);
 }
 /** a, b, … z, then aa, ab, … */
 export function letters(index) {
@@ -837,7 +913,7 @@ function digestBody(note) {
     return [line, typeof a.summary === "string" ? a.summary : undefined, typeof a.digest === "string" ? a.digest.replace(/\n+$/, "") : undefined].filter((part) => part !== undefined).join("\n\n");
 }
 function proposalBefore(attributes, workspace) {
-    if (attributes.kind === "add_link" || attributes.kind === "review_notes" || attributes.kind === "answer")
+    if (attributes.kind === "add_link" || attributes.kind === "review_notes" || attributes.kind === "answer" || attributes.kind === "update_body")
         return null;
     if (attributes.kind === "supersede")
         return truncate(noteTitle(attributes.supersedes, workspace));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ultimate-brain",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "description": "CLI for an AI-assisted Markdown and Git second brain",
   "license": "MIT",
   "keywords": [

package/spec/schemas/brain.schema.json

@@ -156,6 +156,9 @@
             },
             "concepts": {
               "$ref": "#/$defs/dbId"
+            },
+            "references": {
+              "$ref": "#/$defs/dbId"
             }
           }
         },

package/spec/schemas/note.schema.json

@@ -26,6 +26,7 @@
         "decision",
         "question",
         "concept",
+        "reference",
         "source",
         "view",
         "memory"
@@ -152,6 +153,18 @@
         "$ref": "#/$defs/concept"
       }
     },
+    {
+      "if": {
+        "properties": {
+          "type": {
+            "const": "reference"
+          }
+        }
+      },
+      "then": {
+        "$ref": "#/$defs/reference"
+      }
+    },
     {
       "if": {
         "properties": {
@@ -196,7 +209,7 @@
     },
     "id": {
       "type": "string",
-      "pattern": "^(area|gol|prj|per|org|mtg|dec|que|con|src|mem|prp|vw)-[0-9abcdefghjkmnpqrstvwxyz]{8}$"
+      "pattern": "^(area|gol|prj|per|org|mtg|dec|que|con|ref|src|mem|prp|vw)-[0-9abcdefghjkmnpqrstvwxyz]{8}$"
     },
     "areaId": {
       "type": "string",
@@ -795,6 +808,24 @@
         }
       ]
     },
+    "reference": {
+      "description": "What the user kept from a document (decision 0045, spec/schema.md §4 reference).",
+      "allOf": [
+        {
+          "$ref": "#/$defs/knowledge"
+        },
+        {
+          "required": [
+            "sources"
+          ],
+          "properties": {
+            "sources": {
+              "minItems": 1
+            }
+          }
+        }
+      ]
+    },
     "source": {
       "required": [
         "source_key",
@@ -850,6 +881,13 @@
         "attached_to": {
           "$ref": "#/$defs/sourceId"
         },
+        "replaces": {
+          "$ref": "#/$defs/sourceId"
+        },
+        "keep": {
+          "type": "string",
+          "minLength": 1
+        },
         "summary": {
           "type": "string",
           "minLength": 1,
@@ -1098,6 +1136,45 @@
               ]
             }
           }
+        },
+        {
+          "description": "keep only on a source that is read for its content (0045).",
+          "if": {
+            "anyOf": [
+              {
+                "required": [
+                  "attached_to"
+                ]
+              },
+              {
+                "required": [
+                  "kind"
+                ],
+                "properties": {
+                  "kind": {
+                    "enum": [
+                      "minutes",
+                      "capture"
+                    ]
+                  }
+                }
+              },
+              {
+                "not": {
+                  "required": [
+                    "kind"
+                  ]
+                }
+              }
+            ]
+          },
+          "then": {
+            "not": {
+              "required": [
+                "keep"
+              ]
+            }
+          }
         }
       ]
     },
@@ -1133,7 +1210,48 @@
           "minLength": 1
         },
         "asked_in": {
-          "$ref": "#/$defs/notionPageId"
+          "oneOf": [
+            {
+              "$ref": "#/$defs/notionPageId"
+            },
+            {
+              "type": "array",
+              "minItems": 1,
+              "uniqueItems": true,
+              "items": {
+                "$ref": "#/$defs/notionPageId"
+              }
+            }
+          ]
+        },
+        "fixes": {
+          "type": "array",
+          "items": {
+            "type": "object",
+            "required": [
+              "text",
+              "received",
+              "proposals"
+            ],
+            "additionalProperties": false,
+            "properties": {
+              "text": {
+                "type": "string",
+                "minLength": 1
+              },
+              "received": {
+                "$ref": "#/$defs/timestamp"
+              },
+              "proposals": {
+                "type": "array",
+                "uniqueItems": true,
+                "items": {
+                  "type": "string",
+                  "pattern": "^prp-[0-9abcdefghjkmnpqrstvwxyz]{8}$"
+                }
+              }
+            }
+          }
         },
         "generated_from": {
           "type": "array",
@@ -1215,6 +1333,11 @@
                         "asked_in"
                       ]
                     },
+                    {
+                      "required": [
+                        "fixes"
+                      ]
+                    },
                     {
                       "required": [
                         "notion"
@@ -1274,6 +1397,11 @@
                         "asked_in"
                       ]
                     },
+                    {
+                      "required": [
+                        "fixes"
+                      ]
+                    },
                     {
                       "required": [
                         "notion"