uikit-react-public 0.40.1 → 0.40.2

package/lib/components/Header/Header.tsx

@@ -1,9 +1,10 @@
 import { memo, HTMLAttributes } from 'react';
 import { css, cx } from '@emotion/css';
-import { useTheme } from '../..';
+import { themes, useTheme } from '../../theme';
 import UclLogo from '../UclLogo/UclLogo';
 import HeaderMenu from './HeaderMenu';
 import Link from '../Link';
+import HeaderNew from '../HeaderNew';
 
 export const NAME = 'ucl-uikit-header';
 export const HEADER_DESKTOP_HEIGHT_PX = 72;
@@ -12,17 +13,19 @@ export const DEFAULT_Z_INDEX = 3;
 
 export interface HeaderProps extends HTMLAttributes<HTMLElement> {
   title?: string;
+  /** @deprecated Only used by the default-theme legacy Header. */
   fixed?: boolean;
   titleAs?: React.ElementType<React.HTMLAttributes<HTMLElement>>;
   titleClassName?: string;
   titleProps?: Record<string, unknown>;
   homeLinkHref?: string;
   homeLinkProps?: Record<string, unknown>;
+  /** @deprecated Use `homeLinkProps={{ 'aria-label': '...' }}` instead. */
   homeLinkAriaLabel?: string;
   testId?: string;
 }
 
-const Header = ({
+const LegacyHeader = ({
   title,
   fixed = false,
   titleAs = 'div',
@@ -159,15 +162,77 @@ const Header = ({
   );
 };
 
+const Header = ({
+  title,
+  titleAs = 'div',
+  titleClassName,
+  titleProps,
+  homeLinkHref,
+  homeLinkProps,
+  homeLinkAriaLabel,
+  testId = NAME,
+  className,
+  children,
+  fixed,
+  ...props
+}: HeaderProps) => {
+  const [theme] = useTheme();
+
+  if (theme === themes.default) {
+    return (
+      <LegacyHeader
+        title={title}
+        fixed={fixed}
+        titleAs={titleAs}
+        titleClassName={titleClassName}
+        titleProps={titleProps}
+        homeLinkHref={homeLinkHref}
+        homeLinkProps={homeLinkProps}
+        homeLinkAriaLabel={homeLinkAriaLabel}
+        testId={testId}
+        className={className}
+        {...props}
+      >
+        {children}
+      </LegacyHeader>
+    );
+  }
+
+  const resolvedHomeLinkProps =
+    homeLinkAriaLabel && !homeLinkProps?.['aria-label']
+      ? { ...homeLinkProps, 'aria-label': homeLinkAriaLabel }
+      : homeLinkProps;
+
+  return (
+    <HeaderNew
+      title={title ?? ''}
+      titleAs={titleAs}
+      titleClassName={titleClassName}
+      titleProps={titleProps}
+      homeLinkHref={homeLinkHref}
+      homeLinkProps={resolvedHomeLinkProps}
+      testId={testId}
+      className={className}
+      {...props}
+    >
+      {children}
+    </HeaderNew>
+  );
+};
+
 const MemoAppHeader = memo(Header);
 
 export interface IHeaderSubComponents {
   Menu: typeof HeaderMenu;
+  MenuContainer: (typeof HeaderNew)['MenuContainer'];
+  Item: (typeof HeaderNew)['Item'];
 }
 
 const HeaderWithSubComponents = MemoAppHeader as typeof MemoAppHeader &
   IHeaderSubComponents;
 
 HeaderWithSubComponents.Menu = HeaderMenu;
+HeaderWithSubComponents.MenuContainer = HeaderNew.MenuContainer;
+HeaderWithSubComponents.Item = HeaderNew.Item;
 
 export default HeaderWithSubComponents;

package/lib/components/Header/__tests__/Header.test.tsx

@@ -39,4 +39,54 @@ describe('Header', () => {
     expect(link).toBeInTheDocument();
     expect(link.getAttribute('href')).toBe('/');
   });
+
+  test('uses the legacy header for the default theme', () => {
+    const renderResult = render(
+      <ThemeContextProvider>
+        <Header title='LIDS'>
+          <Header.Menu testId='legacy-header-menu'>Menu</Header.Menu>
+        </Header>
+      </ThemeContextProvider>
+    );
+
+    expect(screen.getByTestId('legacy-header-menu')).toBeInTheDocument();
+    expect(
+      renderResult.container.querySelector('.ucl-uikit-header__border')
+    ).not.toBeInTheDocument();
+  });
+
+  test('uses the new header for light and dark themes', () => {
+    const renderResult = render(
+      <ThemeContextProvider theme='light'>
+        <Header title='LIDS'>
+          <Header.MenuContainer>
+            <Header.Item testId='new-header-item'>Item</Header.Item>
+          </Header.MenuContainer>
+        </Header>
+      </ThemeContextProvider>
+    );
+
+    expect(screen.getByTestId('new-header-item')).toHaveClass(
+      'ucl-uikit-header__item'
+    );
+    expect(
+      renderResult.container.querySelector('.ucl-uikit-header__border')
+    ).toBeInTheDocument();
+  });
+
+  test('maps the deprecated homeLinkAriaLabel prop to the new header link props', () => {
+    render(
+      <ThemeContextProvider theme='dark'>
+        <Header
+          title='LIDS'
+          homeLinkHref='/'
+          homeLinkAriaLabel='Go home'
+        />
+      </ThemeContextProvider>
+    );
+
+    const link = screen.getByLabelText('Go home');
+    expect(link).toBeInTheDocument();
+    expect(link.getAttribute('href')).toBe('/');
+  });
 });

package/lib/components/HeaderNew/Header.tsx

@@ -1,6 +1,6 @@
 import { memo, HTMLAttributes } from 'react';
 import { css, cx } from '@emotion/css';
-import { useTheme } from '../..';
+import { useTheme } from '../../theme';
 import HeaderMenuContainer from './HeaderMenuContainer';
 import HeaderItem from './HeaderItem';
 import HeaderTitle from './HeaderTitle';

package/lib/components/HeaderNew/HeaderBorder.tsx

@@ -1,5 +1,5 @@
 import { css, cx } from '@emotion/css';
-import { useTheme } from '../..';
+import { useTheme } from '../../theme';
 import { HTMLAttributes } from 'react';
 
 export const NAME = 'ucl-uikit-header__border';

package/lib/components/HeaderNew/HeaderItem.tsx

@@ -1,6 +1,6 @@
 import { HTMLAttributes } from 'react';
 import { css, cx } from '@emotion/css';
-import { useTheme } from '../..';
+import { useTheme } from '../../theme';
 
 export const NAME = 'ucl-uikit-header__item';
 

package/lib/components/HeaderNew/HeaderLogo.tsx

@@ -1,5 +1,7 @@
 import { css, cx } from '@emotion/css';
-import { UclLogoNew, UclLogoProps, useTheme } from '../..';
+import { useTheme } from '../../theme';
+import UclLogoNew from '../UclLogoNew/UclLogo';
+import type { UclLogoProps } from '../UclLogoNew/UclLogo';
 
 export const NAME = 'ucl-uikit-header__logo';
 

package/lib/components/HeaderNew/HeaderTitle.tsx

@@ -1,5 +1,5 @@
 import { css, cx } from '@emotion/css';
-import { useTheme } from '../..';
+import { useTheme } from '../../theme';
 import { HTMLAttributes } from 'react';
 
 export const NAME = 'ucl-uikit-header__title';

package/package.json

@@ -2,7 +2,7 @@
   "name": "uikit-react-public",
   "private": false,
   "license": "UNLICENSED",
-  "version": "0.40.1",
+  "version": "0.40.2",
   "type": "module",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",