uikit-react-public 0.21.9 → 0.22.1

package/lib/components/Spinner/Spinner.tsx

@@ -1,4 +1,4 @@
-import { SVGAttributes, forwardRef, memo } from 'react';
+import { SVGAttributes, Ref, memo } from 'react';
 import { css, cx } from '@emotion/css';
 import { useTheme } from '../../theme';
 
@@ -8,87 +8,86 @@ export interface SpinnerProps extends SVGAttributes<SVGSVGElement> {
   size?: number;
   strokeWidth?: number;
   testId?: string;
+  ref?: Ref<SVGSVGElement>;
   inheritColour?: boolean;
 }
 
-const Spinner = forwardRef<SVGSVGElement, SpinnerProps>(
-  (
-    {
-      size = 72,
-      strokeWidth = 4,
-      className,
-      testId = NAME,
-      inheritColour = false,
-      ...rest
-    }: SpinnerProps,
-    ref
-  ) => {
-    const [theme] = useTheme();
+const Spinner = ({
+  size = 72,
+  strokeWidth = 4,
+  className,
+  testId = NAME,
+  inheritColour = false,
+  ref,
+  ...rest
+}: SpinnerProps) => {
+  const [theme] = useTheme();
 
-    const rotationDuration = `3s`; // rotation duration
-    const dashDuration = `2s`; // dash duration
+  const rotationDuration = `3s`; // rotation duration
+  const dashDuration = `2s`; // dash duration
 
-    const baseStyle = css`
-      color: ${inheritColour ? 'inherit' : theme.colour.icon.brand};
-    `;
+  const baseStyle = css`
+    color: ${inheritColour ? 'inherit' : theme.colour.icon.brand};
+  `;
 
-    const gStyle = css`
-      transform-origin: 50% 50%;
-      animation: rotate ${rotationDuration} linear infinite;
+  const gStyle = css`
+    transform-origin: 50% 50%;
+    animation: rotate ${rotationDuration} linear infinite;
 
-      @keyframes rotate {
-        100% {
-          transform: rotate(360deg);
-        }
+    @keyframes rotate {
+      100% {
+        transform: rotate(360deg);
       }
-    `;
+    }
+  `;
 
-    const circleStyle = css`
-      stroke-linecap: square;
-      animation: dash ${dashDuration} ease-in-out infinite;
+  const circleStyle = css`
+    stroke-linecap: square;
+    animation: dash ${dashDuration} ease-in-out infinite;
 
-      @keyframes dash {
-        0% {
-          stroke-dasharray: 1, 150;
-          stroke-dashoffset: 0;
-        }
-        50% {
-          stroke-dasharray: 90, 150;
-          stroke-dashoffset: -35;
-        }
-        100% {
-          stroke-dasharray: 90, 150;
-          stroke-dashoffset: -124;
-        }
+    @keyframes dash {
+      0% {
+        stroke-dasharray: 1, 150;
+        stroke-dashoffset: 0;
       }
-    `;
+      50% {
+        stroke-dasharray: 90, 150;
+        stroke-dashoffset: -35;
+      }
+      100% {
+        stroke-dasharray: 90, 150;
+        stroke-dashoffset: -124;
+      }
+    }
+  `;
 
-    const style = cx(NAME, baseStyle, className);
+  const style = cx(NAME, baseStyle, className);
 
-    return (
-      <svg
-        viewBox='0 0 50 50'
-        className={style}
-        data-testid={testId}
-        ref={ref}
-        width={size} // Set the width of the SVG element
-        height={size} // Set the height of the SVG element
-        {...rest}
-      >
-        <g className={gStyle}>
-          <circle
-            className={circleStyle}
-            cx='25'
-            cy='25'
-            r='20'
-            fill='none'
-            stroke='currentColor'
-            strokeWidth={strokeWidth}
-          />
-        </g>
-      </svg>
-    );
-  }
-);
+  return (
+    <svg
+      role='progressbar'
+      aria-label='Loading'
+      viewBox='0 0 50 50'
+      className={style}
+      data-testid={testId}
+      ref={ref}
+      width={size} // Set the width of the SVG element
+      height={size} // Set the height of the SVG element
+      {...rest}
+    >
+      <g className={gStyle}>
+        <circle
+          className={circleStyle}
+          cx='25'
+          cy='25'
+          r='20'
+          fill='none'
+          stroke='currentColor'
+          strokeWidth={strokeWidth}
+        />
+      </g>
+    </svg>
+  );
+};
 
 export default memo(Spinner);

package/lib/components/Spinner/__tests__/Spinner.test.tsx

@@ -1,5 +1,5 @@
 import { describe, expect, test } from 'vitest';
-import { render } from '@testing-library/react';
+import { render, screen } from '@testing-library/react';
 import { css } from '@emotion/css';
 import SpinnerSvg from '../Spinner';
 import { ThemeContextProvider } from '../../..';
@@ -68,4 +68,36 @@ describe('SpinnerSvg', () => {
     const svg = getByTestId('custom-test-id');
     expect(svg).toBeDefined();
   });
+
+  // Accessibility tests
+
+  test('has role="progressbar" by default', () => {
+    render(
+      <ThemeContextProvider>
+        <SpinnerSvg />
+      </ThemeContextProvider>
+    );
+    expect(screen.getByRole('progressbar')).toBeInTheDocument();
+  });
+
+  test('has aria-label="Loading" by default', () => {
+    render(
+      <ThemeContextProvider>
+        <SpinnerSvg />
+      </ThemeContextProvider>
+    );
+    expect(screen.getByRole('progressbar')).toHaveAccessibleName('Loading');
+  });
+
+  test('aria-label can be overridden via props', () => {
+    render(
+      <ThemeContextProvider>
+        <SpinnerSvg aria-label='Loading visitors' />
+      </ThemeContextProvider>
+    );
+    expect(screen.getByRole('progressbar')).toHaveAccessibleName(
+      'Loading visitors'
+    );
+    expect(screen.getByRole('progressbar')).not.toHaveAccessibleName('Loading');
+  });
 });

package/lib/components/Spinner/__tests__/__snapshots__/Spinner.test.tsx.snap

@@ -2,17 +2,19 @@
 
 exports[`SpinnerSvg > Snapshot: custom className 1`] = `
 <svg
-  class="ucl-uikit-spinner css-g7tq6j"
+  aria-label="Loading"
+  class="ucl-uikit-spinner css-rppy7j"
   data-testid="ucl-uikit-spinner"
   height="72"
+  role="progressbar"
   viewBox="0 0 50 50"
   width="72"
 >
   <g
-    class="css-ypv7tf"
+    class="css-swia5b"
   >
     <circle
-      class="css-1w5ipzg"
+      class="css-1iyl2x2"
       cx="25"
       cy="25"
       fill="none"
@@ -26,17 +28,19 @@ exports[`SpinnerSvg > Snapshot: custom className 1`] = `
 
 exports[`SpinnerSvg > snapshot: custom size 1`] = `
 <svg
-  class="ucl-uikit-spinner css-1g359sh"
+  aria-label="Loading"
+  class="ucl-uikit-spinner css-1scd17h"
   data-testid="ucl-uikit-spinner"
   height="32"
+  role="progressbar"
   viewBox="0 0 50 50"
   width="32"
 >
   <g
-    class="css-ypv7tf"
+    class="css-swia5b"
   >
     <circle
-      class="css-1w5ipzg"
+      class="css-1iyl2x2"
       cx="25"
       cy="25"
       fill="none"
@@ -50,17 +54,19 @@ exports[`SpinnerSvg > snapshot: custom size 1`] = `
 
 exports[`SpinnerSvg > snapshot: default props 1`] = `
 <svg
-  class="ucl-uikit-spinner css-1g359sh"
+  aria-label="Loading"
+  class="ucl-uikit-spinner css-1scd17h"
   data-testid="ucl-uikit-spinner"
   height="72"
+  role="progressbar"
   viewBox="0 0 50 50"
   width="72"
 >
   <g
-    class="css-ypv7tf"
+    class="css-swia5b"
   >
     <circle
-      class="css-1w5ipzg"
+      class="css-1iyl2x2"
       cx="25"
       cy="25"
       fill="none"
@@ -74,17 +80,19 @@ exports[`SpinnerSvg > snapshot: default props 1`] = `
 
 exports[`SpinnerSvg > snapshot: inherits parent colour when inheritColour is true 1`] = `
 <svg
-  class="ucl-uikit-spinner css-1izyex6"
+  aria-label="Loading"
+  class="ucl-uikit-spinner css-15f359x"
   data-testid="ucl-uikit-spinner"
   height="72"
+  role="progressbar"
   viewBox="0 0 50 50"
   width="72"
 >
   <g
-    class="css-ypv7tf"
+    class="css-swia5b"
   >
     <circle
-      class="css-1w5ipzg"
+      class="css-1iyl2x2"
       cx="25"
       cy="25"
       fill="none"

package/lib/components/StandaloneLink/__tests__/__snapshots__/StandaloneLink.test.tsx.snap

@@ -2,7 +2,7 @@
 
 exports[`Link > snapshot: no props 1`] = `
 <a
-  class="ucl-uikit-base-link ucl-uikit-standalone-link css-1hrm145"
+  class="ucl-uikit-base-link ucl-uikit-standalone-link css-zj0pf"
   data-testid="ucl-uikit-standalone-link"
 >
   test
@@ -11,7 +11,7 @@ exports[`Link > snapshot: no props 1`] = `
 
 exports[`Link > snapshot: testId prop 1`] = `
 <a
-  class="ucl-uikit-base-link ucl-uikit-standalone-link css-1hrm145"
+  class="ucl-uikit-base-link ucl-uikit-standalone-link css-zj0pf"
   data-testid="test123"
 >
    testidlink 

package/lib/components/Table/improvements-tracking.md

@@ -0,0 +1,25 @@
+# Table – Improvements Tracking
+
+## Decision: Table.Cell should not support a `variant='button'` prop
+
+**Status:** Decided  
+**Date:** 2026-04-13  
+**Context:** EVE frontend – My Visitors screen (`MyVisitorsScreen.tsx`)
+
+### Problem
+
+We considered two approaches for adding interactive actions (e.g. "Invite again") inside table cells:
+
+- **A) `variant='button'` on `Table.Cell`** – The cell itself renders as a button, with props like `buttonProps`, `loading`, and `onClick` forwarded through the cell.
+- **B) `<Button>` as a child of `Table.Cell`** – The cell remains a plain container; a `<Button>` component is composed inside it.
+
+### Decision
+
+**Go with B – compose `<Button>` as a child.**
+
+### Rationale
+
+- **Composition over configuration.** Adding `variant='button'` conflates layout (cell) and interaction (button) concerns, increasing the API surface of `Table.Cell` with forwarded props (`loading`, `onClick`, `disabled`, `size`, button variant, etc.).
+- **Flexibility.** A child `<Button>` can easily be swapped for an icon button, a link, a menu, or multiple actions — without the cell API needing to accommodate every combination.
+- **No duplicated logic.** `<Button>` already handles loading spinners, disabled states, and accessibility. A `variant='button'` cell would need to re-implement or proxy all of that.
+- **Simpler Table.Cell API.** Fewer props to document, test, and maintain.

package/lib/components/index.ts

@@ -31,6 +31,9 @@ export type { SnackbarProps } from './Snackbar';
 export { default as Avatar } from './Avatar';
 export type { AvatarProps } from './Avatar';
 
+export { default as Badge } from './Badge';
+export type { BadgeProps } from './Badge';
+
 export { default as Spinner } from './Spinner';
 export type { SpinnerProps } from './Spinner';
 

package/package.json

@@ -2,7 +2,7 @@
   "name": "uikit-react-public",
   "private": false,
   "license": "UNLICENSED",
-  "version": "0.21.9",
+  "version": "0.22.1",
   "type": "module",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -17,6 +17,7 @@
     "dev": "vite",
     "dev_expose": "vite --host",
     "build": "tsc --p ./tsconfig-build.json && vite build",
+    "build:watch": "tsc --p ./tsconfig-build.json --watch --preserveWatchOutput & vite build --watch",
     "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
     "pre-commit": "lint-staged",
     "format": "prettier \"./**/*.{ts,tsx}\" --write --config ./prettierrc",