ui5-test-runner 5.6.0 → 5.6.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ui5-test-runner",
-  "version": "5.6.0",
+  "version": "5.6.2",
   "description": "Standalone test runner for UI5",
   "main": "index.js",
   "bin": {
@@ -17,7 +17,8 @@
     "test:coverall": "rimraf .nyc_output && jest --coverageDirectory .nyc_output --coverageReporters json && nyc --silent --no-clean npm run test:e2e && nyc merge .nyc_output .nyc_output/final/coverage.json && nyc report --temp-dir .nyc_output/final/ --report-dir coverage --branches 80 --functions 80 --lines 80 --statements 80",
     "test:unit": "jest",
     "test:unit:debug": "node --inspect node_modules/jest/bin/jest.js --runInBand --no-coverage",
-    "test:e2e": "node . --batch test/e2e/.*\\.json --report-dir e2e --start \"node test/e2e/serve.js\" --start-wait-url http://localhost:8081 --start-wait-method HEAD --start-timeout 30s",
+    "pretest:e2e": "npm install -g puppeteer selenium-webdriver playwright webdriverio jsdom",
+    "test:e2e": "node . --batch \"test/e2e/[\\w_]*\\.json\" --report-dir e2e --start \"node test/e2e/serve.js\" --start-wait-url http://localhost:8081 --start-wait-method HEAD --start-timeout 30s",
     "test:report": "node ./src/defaults/report.js ./test/report && reserve --config ./test/report/reserve.json",
     "test:text-report": "node ./src/defaults/text-report.js ./test/report",
     "build:doc": "node build/doc",
@@ -50,8 +51,8 @@
     "reserve": "2.1.0"
   },
   "devDependencies": {
-    "@openui5/types": "^1.133.0",
-    "@ui5/cli": "^4.0.13",
+    "@openui5/types": "^1.134.0",
+    "@ui5/cli": "^4.0.14",
     "@ui5/middleware-code-coverage": "^2.0.1",
     "dotenv": "^16.4.7",
     "jest": "^29.7.0",
@@ -60,7 +61,7 @@
     "rimraf": "^6.0.1",
     "standard": "^17.1.2",
     "typescript": "^5.8.2",
-    "ui5-tooling-transpile": "^3.7.1"
+    "ui5-tooling-transpile": "^3.7.3"
   },
   "optionalDependencies": {
     "fsevents": "^2.3.3"

package/src/coverage.js

@@ -30,16 +30,19 @@ async function nyc (job, ...args) {
   output.nyc(...args)
   const childProcess = fork(nycScript, args, { stdio: 'pipe' })
   output.monitor(childProcess)
-  const { promise, resolve, reject } = allocPromise()
-  childProcess.on('close', async code => {
-    if (code !== 0) {
-      reject(UTRError.NYC_FAILED(`Return code ${code}`))
-    }
-    resolve()
-  })
+  const { promise, resolve } = allocPromise()
+  childProcess.on('close', resolve)
   return promise
 }
 
+async function safeNyc (job, ...args) {
+  const code = await nyc(job, ...args)
+  if (code !== 0) {
+    const [command] = args
+    throw UTRError.NYC_FAILED(`nyc ${command} failed with code ${code}`)
+  }
+}
+
 const globalContextSearch = 'var global=new Function("return this")();'
 const globalContextReplace = 'var global=window.top;'
 
@@ -84,7 +87,7 @@ async function instrument (job) {
     }
   }
   job.status = 'Instrumenting'
-  await nyc(job, 'instrument', job.webapp, join(job.coverageTempDir, 'instrumented'), '--nycrc-path', job[$nycSettingsPath])
+  await safeNyc(job, 'instrument', job.webapp, join(job.coverageTempDir, 'instrumented'), '--nycrc-path', job[$nycSettingsPath])
 }
 
 function getUrlOrigin (job) {
@@ -250,7 +253,7 @@ async function generateCoverageReport (job) {
   const coverageMergedDir = join(job.coverageTempDir, 'merged')
   await createDir(coverageMergedDir)
   const coverageFilename = join(coverageMergedDir, 'coverage.json')
-  await nyc(job, 'merge', job.coverageTempDir, coverageFilename)
+  await safeNyc(job, 'merge', job.coverageTempDir, coverageFilename)
   if (job[$coverageRemote]) {
     await checkAllSourcesAreAvailable(job, coverageFilename)
   }
@@ -271,13 +274,20 @@ async function generateCoverageReport (job) {
       '--check-coverage'
     )
   }
-  await nyc(job, 'report', ...reporters, ...checks, '--temp-dir', coverageMergedDir, '--report-dir', job.coverageReportDir, '--nycrc-path', job[$nycSettingsPath])
+  const returnCode = await nyc(job, 'report', ...reporters, ...checks, '--temp-dir', coverageMergedDir, '--report-dir', job.coverageReportDir, '--nycrc-path', job[$nycSettingsPath])
   if (checks.length) {
     // The checks are not triggered if the coverage is empty
     const lcov = await stat(join(job.coverageReportDir, 'lcov.info'))
     if (lcov.size === 0) {
       throw UTRError.NYC_FAILED('No coverage information extracted')
     }
+    if (returnCode === 1) {
+      // Assuming coverage report shows the error
+      output.debug('coverage', `nyc report failed with code ${returnCode}`)
+      job.failed = true
+    }
+  } else if (returnCode !== 0) {
+    throw UTRError.NYC_FAILED(`nyc report failed with code ${returnCode}`)
   }
 }
 

package/src/report.js

@@ -43,9 +43,15 @@ module.exports = {
 
   async generate (job) {
     const output = getOutput(job)
+    try {
+      await generateCoverageReport(job)
+    } catch (e) {
+      output.genericError(e)
+      job.failed = true
+    }
+    job.status = 'Generating reports'
     job.end = new Date()
     job.failed = !!job.failed
-    job.status = 'Generating reports'
     job.testPageHashes = job.testPageUrls.map(url => filename(url))
     await save(job)
     await generateTextReport(job)
@@ -71,11 +77,7 @@ module.exports = {
       })
       return promise
     })
-    promises.push(generateCoverageReport(job).catch(e => {
-      output.genericError(e)
-      job.failed = true
-    }))
     await Promise.all(promises)
-    job.status = 'Reports gemerated'
+    job.status = 'Reports generated'
   }
 }

package/src/tests.js

@@ -127,8 +127,6 @@ async function process (job) {
   }
 
   await generate(job)
-
-  // TODO: #105 integrate end, find a way it can change job.failed
 }
 
 module.exports = {

package/src/ui5.js

@@ -8,6 +8,7 @@ const { getOutput, newProgress } = require('./output')
 const { download } = require('./tools')
 const { $statusProgressCount, $statusProgressTotal } = require('./symbols')
 const { parallelize } = require('./parallelize')
+const { relative: relativePath } = require('path')
 
 const buildCacheBase = job => {
   const [, hostName] = /https?:\/\/([^/]*)/.exec(job.ui5)
@@ -128,27 +129,37 @@ module.exports = {
       'ignore-unverifiable-certificate': true
     }]
 
-    job.libs.forEach(({ relative, source }) => {
+    for (let { relative, source } of job.libs) {
       if (source.endsWith('/') || source.endsWith('\\')) {
         source = source.substring(0, source.length - 1)
       }
-      mappings.unshift({
-        match: new RegExp(`\\/resources\\/${relative.replace(/\//g, '\\/')}(.*)`),
-        cwd: source,
-        file: '$1',
-        static: !job.watch && !job.debugDevMode
-      }, {
-        match: new RegExp(`\\/resources\\/${relative.replace(/\//g, '\\/')}(.*)`),
-        custom: async (request, response, $1) => {
-          if ($1 === undefined) {
-            getOutput(job).debug('libs', `Unable to map ${relative} : $1 is undefined`)
-          } else {
-            getOutput(job).debug('libs', `Unable to map ${relative}/${$1} to ${join(source, $1)}`)
+      const relativeUrl = relative.replace(/\//g, '\\/')
+      if (source.startsWith(job.webapp)) {
+        const relativeAbsoluteUrl = '/' + relativePath(job.webapp, source).replace(/\\/g, '/')
+        getOutput(job).debug('libs', `${relative} maps to webapp sub directory, use internal redirection to ${relativeAbsoluteUrl}`)
+        mappings.unshift({
+          match: new RegExp(`\\/resources\\/${relativeUrl}(.*)`),
+          custom: (request, response, $1) => `${relativeAbsoluteUrl}${$1}`
+        })
+      } else {
+        mappings.unshift({
+          match: new RegExp(`\\/resources\\/${relativeUrl}(.*)`),
+          cwd: source,
+          file: '$1',
+          static: !job.watch && !job.debugDevMode
+        }, {
+          match: new RegExp(`\\/resources\\/${relativeUrl}(.*)`),
+          custom: (request, response, $1) => {
+            if ($1 === undefined) {
+              getOutput(job).debug('libs', `Unable to map ${relative} : $1 is undefined`)
+            } else {
+              getOutput(job).debug('libs', `Unable to map ${relative}/${$1} to ${join(source, $1)}`)
+            }
+            return 404
           }
-          return 404
-        }
-      })
-    })
+        })
+      }
+    }
 
     return mappings
   }