ui5-test-runner 5.10.0 → 5.11.0

package/README.md

@@ -49,3 +49,4 @@ A self-sufficient test runner for UI5 applications enabling parallel execution o
 * [Marian Zeis](https://github.com/marianfoo): Documentation page revamp [PR #54](https://github.com/ArnaudBuchholz/ui5-test-runner/pull/54)
 * [Raj Singh](https://github.com/rajxsingh): Basic HTTP Authentication in Puppeteer [PR #71](https://github.com/ArnaudBuchholz/ui5-test-runner/pull/71)
 * [Andreas Kunz](https://github.com/akudev): Improved documentation for TypeScript testing and reviewed `nyc` settings handling [PR #110](https://github.com/ArnaudBuchholz/ui5-test-runner/pull/110)
+* [Juri Zeisler](https://github.com/juriz889): Added screenshots to the JUnit XML Report [PR #158](https://github.com/ArnaudBuchholz/ui5-test-runner/pull/158)

package/jest.config.json

@@ -9,7 +9,8 @@
   ],
   "collectCoverage": true,
   "collectCoverageFrom": [
-    "src/*.js"
+    "src/*.js",
+    "src/defaults/junit-xml-report.js"
   ],
   "coveragePathIgnorePatterns": [
     "\\.spec\\.js",

package/package.json

@@ -1,11 +1,15 @@
 {
   "name": "ui5-test-runner",
-  "version": "5.10.0",
+  "version": "5.11.0",
   "description": "Standalone test runner for UI5",
   "main": "index.js",
   "bin": {
     "ui5-test-runner": "./index.js"
   },
+  "publishConfig": {
+    "access": "public",
+    "provenance": true
+  },
   "engines": {
     "node": ">=18"
   },
@@ -23,7 +27,8 @@
     "test:text-report": "node ./src/defaults/text-report.js ./test/report",
     "build:doc": "node build/doc",
     "clean": "npm uninstall -g ui5-test-runner puppeteer nyc selenium-webdriver playwright webdriverio jsdom",
-    "update": "ncu -i --format group"
+    "update": "ncu -i --format group",
+    "semantic-release": "semantic-release"
   },
   "repository": {
     "type": "git",
@@ -49,20 +54,22 @@
     "pidtree": "^0.6.0",
     "punybind": "^1.2.1",
     "punyexpr": "1.2.0",
-    "reserve": "2.3.3"
+    "reserve": "2.3.4"
   },
   "devDependencies": {
-    "@openui5/types": "^1.140.0",
-    "@ui5/cli": "^4.0.26",
-    "@ui5/middleware-code-coverage": "^2.0.1",
+    "@openui5/types": "^1.142.0",
+    "@semantic-release/npm": "^13.1.2",
+    "@ui5/cli": "^4.0.35",
+    "@ui5/middleware-code-coverage": "^2.0.2",
     "dotenv": "^16.5.0",
     "jest": "^29.7.0",
     "nock": "^14.0.10",
     "npm-check-updates": "^18.3.0",
     "nyc": "^17.1.0",
-    "rimraf": "^6.0.1",
+    "rimraf": "^6.1.0",
+    "semantic-release": "^25.0.2",
     "standard": "^17.1.2",
-    "typescript": "^5.9.2",
+    "typescript": "^5.9.3",
     "ui5-tooling-transpile": "^3.9.2"
   },
   "optionalDependencies": {

package/src/defaults/browser.js

@@ -158,9 +158,11 @@ module.exports = ({
         '--disable-gpu',
         '--disable-extensions',
         '--log-level=3',
-        `--window-size=${options.viewportWidth},${options.viewportHeight}`,
-        `--lang=${options.language.join(',')}`
+        `--window-size=${options.viewportWidth},${options.viewportHeight}`
       ]
+      if (options.language) {
+        args.push(`--lang=${options.language.join(',')}`)
+      }
       if (!options.visible) {
         args.push('--headless=new')
       }

package/src/defaults/junit-xml-report.js

@@ -2,7 +2,7 @@
 
 // Based on specification from llg[.]cubic[.]org/docs/junit/
 
-const { join } = require('path')
+const { join, basename } = require('path')
 const { writeFile } = require('fs').promises
 const [, , reportDir] = process.argv
 
@@ -47,6 +47,9 @@ async function main () {
       time="${time}"`
 }
     >`)
+        if (test.screenshot) {
+          o(`      <system-out>[[ATTACHMENT|${join(basename(reportDir), qunitPage.id, test.screenshot)}]]</system-out>`)
+        }
         if (test.skip) {
           o('      <skipped></skipped>')
         } else if (!test.report) {

package/src/defaults/playwright.js

@@ -76,8 +76,15 @@ require('./browser')({
     networkWriter
   }) {
     const browsers = require(modules.playwright)
+    const args = []
+
+    if (options.browser === 'chromium' && options.unsecure) {
+      args.push('--disable-web-security')
+    }
+
     browser = await browsers[options.browser].launch({
-      headless: !options.visible
+      headless: !options.visible,
+      args
     })
 
     let recordVideo

package/src/defaults/selenium-webdriver/chrome.js

@@ -10,12 +10,12 @@ module.exports = async ({
   const chrome = require(join(settings.modules['selenium-webdriver'], 'chrome'))
 
   const chromeOptions = new chrome.Options()
-  if (!options.visible) {
-    chromeOptions.addArguments('--headless=new')
-    chromeOptions.addArguments('--log-level=3')
+  const chromeArgs = options.chromeArgs()
+  for (const arg of chromeArgs) {
+    if (arg !== 'true') {
+      chromeOptions.addArguments(arg)
+    }
   }
-  chromeOptions.addArguments('--start-maximized')
-  chromeOptions.addArguments('--disable-extensions')
   chromeOptions.setLoggingPrefs(loggingPreferences)
   if (options.binary) {
     chromeOptions.setChromeBinaryPath(options.binary)

package/src/defaults/selenium-webdriver.js

@@ -30,7 +30,8 @@ require('./browser')({
       ['browser', 'chrome', 'firefox', 'edge'],
       'visible',
       ['-s, --server <server>', 'Selenium server URL', url],
-      'binary'
+      'binary',
+      'unsecure'
     ]
   },
 

package/src/job.js

@@ -20,7 +20,8 @@ function buildArgs (parameters) {
   const after = []
   let browser = []
   Object.keys(parameters).forEach(name => {
-    if (name === '--') {
+    if (name === '--' || name === 'browserArgs') {
+      browser = parameters[name]
       return
     }
     const value = parameters[name]
@@ -41,9 +42,6 @@ function buildArgs (parameters) {
       }
     }
   })
-  if (parameters['--']) {
-    browser = parameters['--']
-  }
   const stringify = args => args.map(value => value.toString())
   return {
     before: stringify(before),

package/src/output.js

@@ -469,7 +469,7 @@ function build (job) {
     },
 
     failedToTerminateStartCommand () {
-      wrap(() => log(job, '⚠️ [STRTCT] Failed to terminate start command. This may cause issues with the shutdown'))()
+      wrap(() => log(job, '⚠️ [STRTCT] Failed to query and terminate all start command child processes, some may leak'))()
     },
 
     browserStart (url) {

package/src/report.js

@@ -7,8 +7,10 @@ const { filename, allocPromise } = require('./tools')
 const { fork } = require('child_process')
 const { getOutput } = require('./output')
 
-async function serialize (job, filename, json) {
-  await writeFile(join(job.reportDir, `${filename}.js`), `module.exports = ${JSON.stringify(json, (key, value) => {
+async function save (job) {
+  // Ensure the file is treated as CommonJS
+  await writeFile(join(job.reportDir, 'package.json'), '{"type": "commonjs"}')
+  await writeFile(join(job.reportDir, 'job.js'), `module.exports = ${JSON.stringify(job, (key, value) => {
     if (value && value instanceof RegExp) {
       return value.toString()
     }
@@ -16,10 +18,6 @@ async function serialize (job, filename, json) {
   }, 2)}`)
 }
 
-async function save (job) {
-  await serialize(job, 'job', job)
-}
-
 function generateTextReport (job) {
   const { promise, resolve } = allocPromise()
   const childProcess = fork(

package/src/start.js

@@ -77,7 +77,13 @@ async function start (job) {
     // eslint-disable-next-line no-unmodified-loop-condition
     while (!startProcessExited && Date.now() - begin <= job.startTimeout) {
       output.debug('start', `Getting start command ${startProcess.pid} child processes...`)
-      const childProcesses = await pidtree(startProcess.pid, { advanced: true })
+      let childProcesses
+      try {
+        childProcesses = await pidtree(startProcess.pid, { advanced: true })
+      } catch (e) {
+        output.genericError(e)
+        break
+      }
       output.debug('start', 'Child processes', JSON.stringify(childProcesses))
       if (childProcesses.length === 0) {
         try {
@@ -121,6 +127,7 @@ async function start (job) {
     }
     if (!startProcessExited) {
       output.failedToTerminateStartCommand()
+      startProcess.kill()
     }
   }