uglify-js-minify-css-allfiles 2.3.1 → 2.3.2

package/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.3.2] - 2025-02-14
+
+### Fixed
+
+- Fixed JS image versioning to handle existing versions and use global hash
+
 ## [2.3.1] - 2025-02-13
 
 ### Fixed

package/README.md

@@ -124,9 +124,6 @@ Automatic versioning for image references in JS and CSS files:
 - Random hash generation for JS image references
 - Support for multiple image formats (PNG, JPEG, GIF, SVG, WebP, etc.)
 - Handles various image path formats:
-  - Absolute and relative paths
-  - Data URIs
-  - HTTP/HTTPS URLs
   - Complex CSS background declarations
   - image-set() syntax support
 

package/dist/module.js

@@ -28,27 +28,31 @@ import { resolveImagePath, resolveModulePath, makeRelativePath, containsFolder,
  * @param {Logger} logger - Logger instance for tracking changes
  * @param {HashManager} hashManager - Manages content-based hashing for images
  * @param {string[]} targetExtensions - List of image extensions to process (e.g., ['.png', '.jpg'])
+ * @param {string} jsHashVersion - JS hash version string.
  * @returns {Promise<{content: string, modified: boolean}>} Modified content and whether changes were made
  */
-async function processPattern(pattern, content, fileExt, filePath, logger, hashManager, targetExtensions) {
+async function processPattern(pattern, content, fileExt, filePath, logger, hashManager, targetExtensions, jsHashVersion) {
   const promises = [];
   let newContent = content;
   let modified = false;
 
   if (fileExt === '.js') {
-    const newHash = crypto.randomBytes(16).toString('hex').substring(0, 8);
+    const newHash = jsHashVersion;
 
-    newContent = content.replace(pattern, (match, imagePath, ext, queryString) => {
+    newContent = content.replace(pattern, (match, quote, imagePath, endQuote) => {
       if (imagePath.startsWith('data:') || imagePath.startsWith('http://') || imagePath.startsWith('https://')) {
         return match;
       }
+
+      const cleanPath = imagePath.split('?')[0];
+
       modified = true;
       logger?.info('Updated JS image version', {
         file: filePath,
-        image: imagePath + ext,
+        image: cleanPath,
         newHash,
       });
-      return `${imagePath}${ext}?v=${newHash}${queryString}`;
+      return `${quote}${cleanPath}?v=${newHash}${endQuote}`;
     });
     return { content: newContent, modified };
   }
@@ -107,9 +111,10 @@ async function processPattern(pattern, content, fileExt, filePath, logger, hashM
  * @param {string[]} [versioningOptions.extensions] - List of file extensions to version.
  * @param {Logger} logger - Logger instance.
  * @param {HashManager} hashManager - Hash manager instance.
+ * @param {string} jsHashVersion - JS hash version string.
  * @returns {Promise<void>}
  */
-async function updateImageReferences(filePath, versioningOptions, logger, hashManager) {
+async function updateImageReferences(filePath, versioningOptions, logger, hashManager, jsHashVersion) {
   const { extensions } = versioningOptions;
   const targetExtensions =
     extensions || DEFAULT_IMAGE_EXTENSIONS.map((ext) => (ext === 'jpe?g' ? ['.jpg', '.jpeg'] : ['.' + ext.replace('?', '')])).flat();
@@ -122,7 +127,7 @@ async function updateImageReferences(filePath, versioningOptions, logger, hashMa
     let modified = false;
 
     for (const pattern of patterns) {
-      const result = await processPattern(pattern, content, fileExt, filePath, logger, hashManager, targetExtensions);
+      const result = await processPattern(pattern, content, fileExt, filePath, logger, hashManager, targetExtensions, jsHashVersion);
       content = result.content;
       modified = modified || result.modified;
     }
@@ -286,6 +291,7 @@ export default async function minifyAll(contentPath, options = {}) {
   const rootDir = resolvePath(contentPath || '');
   const babelOptions = await resolveBabelOptions(useBabel);
   const hashManager = useVersioning ? new HashManager(rootDir) : null;
+  const jsHashVersion = useVersioning ? crypto.randomBytes(16).toString('hex').substring(0, 8) : '';
 
   if (hashManager) {
     await hashManager.initialize();
@@ -309,7 +315,7 @@ export default async function minifyAll(contentPath, options = {}) {
 
       // Apply versioning after successful processing if enabled
       if (useVersioning && hashManager) {
-        await updateImageReferences(filePath, useVersioning, logger, hashManager);
+        await updateImageReferences(filePath, useVersioning, logger, hashManager, jsHashVersion);
       }
 
       logger?.incrementProcessedFiles(filePath);

package/dist/modules/imageUtils.js

@@ -24,7 +24,7 @@ export const IMAGE_PATTERNS = {
   ],
   js: [
     // Basic extension-based pattern for all quotes
-    new RegExp(`(['"\`])([^'"\`]*?\\.(?:${IMAGE_EXT_PATTERN}))(['"\`])`, 'gi'),
+    new RegExp(`(['"\`])([^'"\`]*?\\.(?:${IMAGE_EXT_PATTERN}))(?:\\?v=[^'"\`]*)?(['"\`])`, 'gi'),
   ],
 };
 

package/logs/log-02-13-2025.log

@@ -315,3 +315,16 @@
 [02/13/2025, 13:10:41] [INFO] Writing file: C:\Users\PEARL\Desktop\_code\minify_contents\test\test.css
 [02/13/2025, 13:10:41] [INFO] Writing file: C:\Users\PEARL\Desktop\_code\minify_contents\test\test.js
 [02/13/2025, 13:10:41] [INFO] Processing Summary {"summary":{"totalFilesProcessed":5,"filesWithErrors":0,"errorCount":0,"errorFiles":[]}}
+[02/13/2025, 13:21:29] [INFO] Starting minification process {"contentPath":"./test/","excludeFolder":"lib","useBabel":{"targets":"chrome 40"},"useVersioning":true}
+[02/13/2025, 13:21:29] [INFO] Writing file: C:\Users\PEARL\Desktop\_code\minify_contents\test\test.css
+[02/13/2025, 13:21:29] [INFO] Updated CSS image version {"file":"C:\\Users\\PEARL\\Desktop\\_code\\minify_contents\\test\\test.css","image":"img/sample.jpg","oldHash":"64d54047","newHash":"64d54047"}
+[02/13/2025, 13:21:29] [INFO] Updated CSS image version {"file":"C:\\Users\\PEARL\\Desktop\\_code\\minify_contents\\test\\test.css","image":"img/samples.svg","oldHash":"5e25d61b","newHash":"5e25d61b"}
+[02/13/2025, 13:21:29] [INFO] Updated file with versioned image references {"file":"C:\\Users\\PEARL\\Desktop\\_code\\minify_contents\\test\\test.css"}
+[02/13/2025, 13:21:30] [INFO] Writing file: C:\Users\PEARL\Desktop\_code\minify_contents\test\test.js
+[02/13/2025, 13:21:30] [INFO] Updated JS image version {"file":"C:\\Users\\PEARL\\Desktop\\_code\\minify_contents\\test\\test.js","image":"\"./img/sample.jpg./img/samples.svg","newHash":"1744e876"}
+[02/13/2025, 13:21:30] [INFO] Updated JS image version {"file":"C:\\Users\\PEARL\\Desktop\\_code\\minify_contents\\test\\test.js","image":"\"./img/sample.jpg","newHash":"1744e876"}
+[02/13/2025, 13:21:30] [INFO] Updated JS image version {"file":"C:\\Users\\PEARL\\Desktop\\_code\\minify_contents\\test\\test.js","image":"\"./img/samples.svg","newHash":"1744e876"}
+[02/13/2025, 13:21:30] [INFO] Updated JS image version {"file":"C:\\Users\\PEARL\\Desktop\\_code\\minify_contents\\test\\test.js","image":"\"./img/sample.jpg","newHash":"1744e876"}
+[02/13/2025, 13:21:30] [INFO] Updated JS image version {"file":"C:\\Users\\PEARL\\Desktop\\_code\\minify_contents\\test\\test.js","image":"\"./img/samples.svg","newHash":"1744e876"}
+[02/13/2025, 13:21:30] [INFO] Updated file with versioned image references {"file":"C:\\Users\\PEARL\\Desktop\\_code\\minify_contents\\test\\test.js"}
+[02/13/2025, 13:21:30] [INFO] Processing Summary {"summary":{"totalFilesProcessed":5,"filesWithErrors":0,"errorCount":0,"errorFiles":[]}}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "uglify-js-minify-css-allfiles",
-    "version": "2.3.1",
+    "version": "2.3.2",
     "description": "you will be able to minify all files as same file names which is js or css",
     "main": "minify.js",
     "type": "module",