ucu-mcp 0.3.2 → 0.3.6

package/CHANGELOG.md

@@ -5,6 +5,68 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.3.5] - 2026-06-06  *(Yanked — see 0.3.6)*
+
+### Tests
+
+- `macos-platform`: new regression test for the value-field regex pre-validation (`findElement({value:"[", textMode:"regex"})` throws `PlatformError` with an `Invalid regex pattern` message). Pins the 0.3.2 commit `0710eca` behavior change.
+- `macos-platform`: new regression test for the near-sort bounds fallback (elements without `bounds` are pushed to the end of the sorted result, instead of implicitly being centered at (0,0)). Pins the 0.3.2 commit `0710eca` second behavior change.
+- `tools-layer`: new regression test that `find_element({value:""})` returns `isError: true`. Pins the 0.3.2 commit `46d4ddd` schema tightening (`z.string().min(1).optional()`).
+
+### Changed
+
+- JXA `textMatches` regex branch now compiles the `RegExp` once per element instead of once per source (name / value / description) — three fewer compilations per matched element when `textMode="regex"`. The TS-side pre-validation in `findElement` guarantees the pattern is valid, so the `RegExp` constructor cannot throw here. (Herschel review perf Minor)
+
+### Fixed
+
+- Comment on the JXA `matchesValue` helper no longer claims "JXA function declarations are order-sensitive" (they aren't — JXA hoists them like any ES engine). The comment now correctly notes that the leading placement is for readability. (Herschel review comment Minor)
+
+## [0.3.6] - 2026-06-06
+
+### Re-publish of 0.3.5
+
+0.3.5 was published with a test that didn't account for the McpServer
+schema-validation wrapper. The test called `handler({value:""})`
+directly, which bypasses the schema validation, so the assertion
+`r.isError === true` saw `undefined` instead. The actual fix
+(asserting the zod schema constraint directly) was a one-test rewrite;
+0.3.6 carries the same code as 0.3.5 plus the test fix.
+
+### Yanked
+
+`ucu-mcp@0.3.5` was unpublished (yanked) within minutes of release
+due to the broken test. Users on `@latest` are now on 0.3.6.
+
+## [0.3.4] - 2026-06-06
+
+### Re-publish of 0.3.3
+
+0.3.3 was published with a syntax error in the source test file
+(`tests/unit/tools-layer.test.ts:355` was a continuation of a `//`
+comment block that lost its `//` prefix on a hard line break, so
+tsc parsed the second line as a bare identifier). The published
+npm tarball was functionally correct (`dist/` was unaffected), but
+the broken test file would fail to compile for any consumer
+running `npm test` against the source. The fix (a single-character
+comment prefix) was applied, but npm disallows re-publishing the
+same version, so the fixed source ships as 0.3.4 with the same
+contents and CHANGELOG entry as 0.3.3 plus this note.
+
+### Yanked
+
+`ucu-mcp@0.3.3` was unpublished (yanked) shortly after release due to
+the test file compile error. Users on `@latest` are now on 0.3.4.
+
+## [0.3.3] - 2026-06-06  *(Yanked — see 0.3.4)*
+
+### Tests
+
+- `tools-layer`: three new test cases cover `wait_for_element` value+textMode combinations (contains, exact, regex). They confirm the response surfaces the matched value unchanged so the model can branch on it. (Completes Singer Item 4)
+
+### Refactor
+
+- JXA `textMatches` and `valueMatches` consolidated through a shared `matchesValue(filter, value, mode)` helper. No behavior change; the three branches (contains / exact / regex) now live in one place. (Completes Singer Item 8)
+
 ## [0.3.2] - 2026-06-06
 
 ### Bug fixes

package/dist/src/platform/macos.js

@@ -863,45 +863,47 @@ export class MacOSPlatform {
         }
       }
 
-      function textMatches(elemName, elemValue, elemDesc) {
-        if (textFilter === null) return true;
-        var sources = [elemName, elemValue, elemDesc];
-        if (textMode === "exact") {
-          var t = textFilter.toLowerCase();
-          for (var i = 0; i < sources.length; i++) {
-            if (sources[i].toLowerCase() === t) return true;
-          }
-          return false;
-        } else if (textMode === "regex") {
+      // Shared filter helper. textMatches and valueMatches used to be near
+      // copies of the same three-branch dispatch (contains / exact / regex);
+      // this consolidates the logic so the two callers only differ in which
+      // sources they iterate. Declared before textMatches/valueMatches for
+      // readability — JXA's function declarations are hoisted, so order
+      // doesn't affect callability. (Singer Nit + Herschel comment fix)
+      function matchesValue(filter, value, mode) {
+        if (filter === null) return true;
+        if (mode === "exact") {
+          return value.toLowerCase() === filter.toLowerCase();
+        } else if (mode === "regex") {
           try {
-            var re = new RegExp(textFilter, "i");
-            for (var i = 0; i < sources.length; i++) {
-              if (re.test(sources[i])) return true;
-            }
-          } catch(e) {}
-          return false;
+            return new RegExp(filter, "i").test(value);
+          } catch(e) { return false; }
         } else {
           // contains (default)
-          var t = textFilter.toLowerCase();
+          return value.toLowerCase().indexOf(filter.toLowerCase()) !== -1;
+        }
+      }
+
+      function textMatches(elemName, elemValue, elemDesc) {
+        if (textFilter === null) return true;
+        var sources = [elemName, elemValue, elemDesc];
+        // Hoist regex compilation out of the loop. The TS-side pre-validation
+        // in findElement guarantees the pattern is valid, so the RegExp
+        // constructor cannot throw here. (Herschel perf Minor)
+        if (textMode === "regex") {
+          var reText = new RegExp(textFilter, "i");
           for (var i = 0; i < sources.length; i++) {
-            if (sources[i].toLowerCase().indexOf(t) !== -1) return true;
+            if (reText.test(sources[i])) return true;
           }
           return false;
         }
+        for (var j = 0; j < sources.length; j++) {
+          if (matchesValue(textFilter, sources[j], textMode)) return true;
+        }
+        return false;
       }
 
       function valueMatches(elemValue) {
-        if (valueFilter === null) return true;
-        if (textMode === "exact") {
-          return elemValue.toLowerCase() === valueFilter.toLowerCase();
-        } else if (textMode === "regex") {
-          try {
-            return new RegExp(valueFilter, "i").test(elemValue);
-          } catch(e) { return false; }
-        } else {
-          // contains (default)
-          return elemValue.toLowerCase().indexOf(valueFilter.toLowerCase()) !== -1;
-        }
+        return matchesValue(valueFilter, elemValue, textMode);
       }
 
       function matches(elem) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ucu-mcp",
-  "version": "0.3.2",
+  "version": "0.3.6",
   "description": "MCP server for Universal Computer Use — desktop automation for AI agents via Model Context Protocol",
   "type": "module",
   "bin": {