ucode-agent 1.48.0 → 1.49.0

package/src/tools/browser.js

@@ -188,7 +188,11 @@ export function forgetReviews() {
 const PROBE_TEXT = 'ucode check';
 
 /** Did anything at all happen on the page? */
-const moved = (a, b) => a.nodes !== b.nodes || a.text !== b.text || a.stored !== b.stored;
+// The markup itself, not its length: a timer going 25:00 -> 24:59, a counter
+// going 0 -> 1 or a task ticked off by a class change keeps every length the
+// same, and was reported as "NOTHING HAPPENS" — a false accusation the model
+// then "fixed" by rewriting script that worked.
+const moved = (a, b) => a.nodes !== b.nodes || a.html !== b.html || a.stored !== b.stored;
 
 /**
  * Use the app, rather than only looking at it.
@@ -218,6 +222,7 @@ async function useTheApp(page) {
   const snapshot = () => page.evaluate(() => ({
     nodes: document.body.querySelectorAll('*').length,
     text: document.body.innerText.replace(/\s+/g, ' ').trim().length,
+    html: document.body.innerHTML,
     stored: (() => { try { return JSON.stringify(localStorage).length; } catch { return 0; } })(),
   }));
 
@@ -326,7 +331,7 @@ export async function withStaticServer(dir, fn) {
   }
 }
 
-export async function lookAtApp({ url, paths = ['/'] }) {
+export async function lookAtApp({ url, paths = ['/'], review: withReview = true }) {
   const base = String(url ?? '').trim().replace(/\/+$/, '');
   if (!LOCAL.test(`${base}/`)) {
     throw new ToolFailure({
@@ -355,6 +360,10 @@ export async function lookAtApp({ url, paths = ['/'] }) {
     const errors = [];
     const failed = [];
     page.on('console', (m) => {
+      // The browser asks for /favicon.ico on its own. A page without one is
+      // not broken, and counting that 404 sent every plain-html build round
+      // a fix loop it did not need.
+      if (/\/favicon\.ico$/i.test(m.location()?.url ?? '')) return;
       if (m.type() === 'error' && !/devtools|download the react/i.test(m.text())) errors.push(m.text().slice(0, 200));
     });
     page.on('pageerror', (e) => errors.push(`uncaught: ${String(e.message).slice(0, 200)}`));
@@ -513,7 +522,7 @@ export async function lookAtApp({ url, paths = ['/'] }) {
   // error overlay is a minute spent on nothing.
   let critique = '';
   const state = reviews.get(base) ?? { done: false, tries: 0 };
-  if (!broken && !state.done && state.tries < 2 && toReview.length) {
+  if (withReview && !broken && !state.done && state.tries < 2 && toReview.length) {
     state.tries++;
     reviews.set(base, state);
     try {
@@ -530,7 +539,7 @@ export async function lookAtApp({ url, paths = ['/'] }) {
     critique ? `## Visual review\n${critique}` : '',
     '',
     problems
-      ? 'Fix the problems above, then look again to confirm.'
+      ? 'Fix the problems above - only those; leave everything that works as it is.'
       : state.done && critique
         ? 'The automatic checks found nothing. Weigh the visual review, fix what is worth fixing - ' +
           'the next look re-runs only the fast checks.'

package/src/tools/index.js

@@ -12,7 +12,7 @@ import { addBlock, BLOCK_NAMES, PLAIN_BLOCK_NAMES, ALL_BLOCK_NAMES } from './blo
 import { typeOf } from './types.js';
 import { runCommand, runCommands } from './shell.js';
 import { webSearch } from './web.js';
-import { createApp, TEMPLATE_NAMES, TEMPLATE_NOTES } from './scaffold.js';
+import { createApp, normaliseFiles, TEMPLATE_NAMES, TEMPLATE_NOTES } from './scaffold.js';
 import { deploy } from './deploy.js';
 import { clip, READ_LINES } from './shared.js';
 
@@ -702,13 +702,15 @@ export function describe(name, args = {}) {
       return `Running ${args.commands?.length ?? 0} commands together`;
     case 'deploy':
       return `Deploying ${clip(args.folder || '.', 30)} to Vercel`;
-    case 'create_app':
+    case 'create_app': {
+      const files = normaliseFiles(args.files).length;
       // Say which starter it actually is. Hardcoding one of them meant a plain
       // HTML app announced itself as Next.js, which is a line that is simply
       // untrue on screen while the opposite happens on disk.
       return `Creating ${clip(args.name || args.folder, 30)} from the ` +
         `${args.template === 'next-shadcn' ? 'Next.js' : 'HTML'} starter` +
-        `${args.files?.length ? ` with ${args.files.length} file${args.files.length === 1 ? '' : 's'}` : ''}`;
+        `${files ? ` with ${files} file${files === 1 ? '' : 's'}` : ''}`;
+    }
     case 'look_at_app':
       return `Looking at ${clip(args.url, 40)} on a phone and a desktop`;
     case 'web_search':

package/src/tools/scaffold.js

@@ -48,7 +48,7 @@ const SHOW_BACK = { 'plain-html': ['index.html', 'styles.css', 'app.js'] };
  * something adjacent. Each of those, refused, is a round trip spent being
  * told what could have been read — so they are all read.
  */
-function normaliseFiles(files) {
+export function normaliseFiles(files) {
   let value = files;
   if (typeof value === 'string') {
     try { value = JSON.parse(value); } catch { return []; }