ucode-agent 1.19.1 → 1.20.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ucode-agent",
-  "version": "1.19.1",
+  "version": "1.20.1",
   "description": "ucode - a terminal coding agent that reads, edits and runs your code, on NVIDIA and Cohere models.",
   "type": "module",
   "main": "ucode.js",

package/src/core/htmlcheck.js

@@ -0,0 +1,59 @@
+/**
+ * htmlcheck.js — the JavaScript inside an HTML file is still JavaScript.
+ *
+ * A single-file app keeps everything in one <script>, and nothing was looking
+ * at it: the checks run `node --check` on .js files and tsc on TypeScript
+ * projects, so an index.html whose script does not parse passed every one of
+ * them. The page renders, the CSS is right, and not one button works.
+ *
+ * The failure that prompted this: a model writing an HTML-escaping map inside
+ * an HTML file produced `"'":'''` — three quotes, a syntax error, the whole
+ * script dead. Everything looked finished.
+ *
+ * Parsing is Babel's, which ucode already carries. Only syntax is checked:
+ * an undefined variable is a runtime problem and this is not the place for it.
+ */
+
+import { parse } from '@babel/parser';
+
+/** Inline scripts worth parsing: not src=, not JSON, not a template. */
+const SCRIPTS = /<script\b([^>]*)>([\s\S]*?)<\/script\s*>/gi;
+
+const runnable = (attrs) => {
+  if (/\bsrc\s*=/i.test(attrs)) return false;         // a separate file, checked on its own
+  const type = /\btype\s*=\s*["']?([^"'\s>]+)/i.exec(attrs)?.[1]?.toLowerCase();
+  if (!type) return true;
+  return type === 'module' || type === 'text/javascript' || type === 'application/javascript';
+};
+
+/**
+ * Syntax errors in a file's inline scripts, with lines counted in the HTML
+ * rather than in the extracted fragment — a line number that does not match
+ * the file is worse than none.
+ */
+export function checkHtml(text) {
+  const html = String(text ?? '');
+  const problems = [];
+
+  for (const match of html.matchAll(SCRIPTS)) {
+    const [whole, attrs, body] = match;
+    if (!runnable(attrs) || !body.trim()) continue;
+
+    const before = html.slice(0, match.index + whole.indexOf(body));
+    const offset = before.split('\n').length - 1;
+
+    try {
+      parse(body, {
+        sourceType: 'module',          // accepts a plain script too
+        allowReturnOutsideFunction: true,
+        errorRecovery: false,
+        plugins: ['topLevelAwait'],
+      });
+    } catch (err) {
+      const line = (err.loc?.line ?? 1) + offset;
+      problems.push({ line, message: String(err.message ?? err).replace(/\s*\(\d+:\d+\)$/, '') });
+    }
+  }
+
+  return problems;
+}

package/src/core/loop.js

@@ -17,6 +17,7 @@ import { appendFileSync } from 'node:fs';
 import { readFile, access, mkdir } from 'node:fs/promises';
 import { testRunnerFor, relatedCommand, summariseFailures } from './tests.js';
 import { LogWatch } from './livelog.js';
+import { checkHtml } from './htmlcheck.js';
 import { runningServers } from '../tools/shell.js';
 import { spawn } from 'node:child_process';
 
@@ -100,7 +101,7 @@ const SILENT = new Set(['update_plan']);
 const MAX_FIX_ROUNDS = 3;
 
 /** Files worth checking after they change. */
-const CHECKABLE = /\.(?:[cm]?[jt]sx?|py)$/i;
+const CHECKABLE = /\.(?:[cm]?[jt]sx?|py|html?)$/i;
 
 /** Where TypeScript keeps what it learned, so the next check is a quick one. */
 export const TSBUILDINFO = 'node_modules/.cache/ucode/types.tsbuildinfo';
@@ -468,6 +469,11 @@ function systemPrompt({ cwd, skills, mode, check, map, memory }) {
     '  - One line when you move between the big pieces of work: "The layout is done,',
     '    now the animations."',
     '  - One line at the end saying what it does and how to try it.',
+    'That closing line is ONE OR TWO SENTENCES. Never a checklist, never a feature',
+    'list, never ticks or bullets walking through the request item by item. "Tide is',
+    'built - open tide/index.html, or serve the folder and visit it." Anything longer',
+    'is a status report nobody asked for, and it is the last thing on screen, so it',
+    'is what the whole session looks like.',
     'That is all. A line before every tool call is not narration, it is noise: the',
     'steps already show on screen, and repeating them in words buries the few',
     'sentences worth reading.',
@@ -1656,11 +1662,23 @@ export class Agent {
     const root = path.resolve(this.cwd);
     const tsRoots = new Set();
     const singles = [];
+    const problems = [];
 
     for (const rel of changed) {
       const abs = path.resolve(root, rel);
       if (!(await exists(abs))) continue;
       if (/\.py$/i.test(rel)) { singles.push({ abs, rel, command: `python -m py_compile "${abs}"` }); continue; }
+      // A single-file app keeps all its logic in an inline <script>, which no
+      // other check here ever looks at.
+      if (/\.html?$/i.test(rel)) {
+        const text = await readFile(abs, 'utf8').catch(() => null);
+        const bad = text === null ? [] : checkHtml(text);
+        if (bad.length) {
+          problems.push(`${rel} — the script in this page does not parse, so none of it runs:\n` +
+            bad.map((b) => `  line ${b.line}: ${b.message}`).join('\n'));
+        }
+        continue;
+      }
       let dir = path.dirname(abs);
       let owner = null;
       while (dir.startsWith(root)) {
@@ -1673,7 +1691,6 @@ export class Agent {
       else if (/\.[cm]?js$/i.test(rel)) singles.push({ abs, rel, command: `node --check "${abs}"` });
     }
 
-    const problems = [];
     const check = async (label, command, cwd) => {
       this.ui.toolCall(label);
       this.ui.startSpinner(label);