uapi-json 1.14.8 → 1.14.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "uapi-json",
-  "version": "1.14.8",
+  "version": "1.14.10",
   "description": "Travelport Universal API",
   "main": "src/",
   "files": [
@@ -45,7 +45,7 @@
     "node-errors-helpers": "^1.0.0",
     "pretty-data": "^0.40.0",
     "promise-retry": "^1.1.1",
-    "xml2js": "^0.4.23"
+    "xml2js": "^0.5.0"
   },
   "devDependencies": {
     "chai": "^4.3.7",

package/src/Services/Air/AirErrors.js

@@ -98,6 +98,7 @@ const AirRuntimeError = createErrorClass(
   errorTypes.RuntimeError
 );
 Object.assign(AirRuntimeError, createErrorsList({
+  NoSeatsAvailable: 'No seats available',
   PNRSyncFailed: 'Unexpected System Error. PNR(s) sync failed',
   SegmentBookingFailed: 'Failed to book on or more segments',
   SegmentWaitlisted: 'One or more segments is waitlisted, not allowed',

package/src/Services/Air/AirParser.js

@@ -507,6 +507,8 @@ const AirErrorHandler = function (rsp) {
   }
   const pcc = utils.getErrorPcc(rsp.faultstring);
   switch (code) {
+    case '20':
+      throw new AirRuntimeError.NoSeatsAvailable(rsp);
     case '345':
     case '1512':
       if (pcc !== null) {

package/src/Services/Terminal/Terminal.js

@@ -19,6 +19,10 @@ const RETRY_CODES_LIST = ['14058'];
 
 const DEFAULT_RETRY_TIMES = 3;
 
+const UNEXPECTED_TERMINAL_ERRORS = [
+  'NO PREVIOUS OR ORIGINAL REQUEST',
+];
+
 // Adding event handler on beforeExit and exit process events to process open terminals
 process.on('beforeExit', () => {
   Promise.all(
@@ -188,6 +192,10 @@ module.exports = function (settings) {
           sessionToken: tokenData.sessionToken,
           command: `SEM/${emulatePcc}/AG`,
         }).then((response) => {
+          if (response[0].match(/duty code not authorised/i)) {
+            return Promise.reject(new TerminalRuntimeError.TerminalAuthIssue(response));
+          }
+
           if (!response[0].match(/^PROCEED/)) {
             return Promise.reject(new TerminalRuntimeError.TerminalEmulationFailed(response));
           }
@@ -202,7 +210,7 @@ module.exports = function (settings) {
 
   const terminal = {
     getToken: getSessionToken,
-    executeCommand: (rawCommand, stopMD = defaultStopMD) => new Promise(async (resolve, reject) => {
+    executeCommand: async (rawCommand, stopMD = defaultStopMD) => {
       try {
         const sessionToken = await getSessionToken();
         const terminalId = getTerminalId(sessionToken);
@@ -223,14 +231,18 @@ module.exports = function (settings) {
           terminalState: TERMINAL_STATE_READY,
         });
 
-        resolve(response);
+        if (UNEXPECTED_TERMINAL_ERRORS.some(e => response.includes(e))) {
+          throw new TerminalRuntimeError.TerminalUnexpectedError({ screen: response });
+        }
+
+        return response;
       } catch (err) {
         Object.assign(state, {
           terminalState: TERMINAL_STATE_ERROR,
         });
-        reject(err);
+        throw err;
       }
-    }),
+    },
     closeSession: () => getSessionToken()
       .then(
         sessionToken => service.closeSession({

package/src/Services/Terminal/TerminalErrors.js

@@ -46,6 +46,8 @@ Object.assign(TerminalRuntimeError, createErrorsList({
   TerminalIsClosed: 'Terminal is closed',
   ErrorClosingSession: 'Error closing session',
   NoAgreement: ['There is no agreement between current pcc and you trying to reach', errorCodes.Validation],
+  TerminalAuthIssue: ['Temporary terminal auth issue. Please, try again later', errorCodes.Validation],
+  TerminalUnexpectedError: ['Terminal unexpected error. Please, try again later', errorCodes.Validation],
 }, TerminalRuntimeError));
 
 module.exports = {