u-foo 2.5.5 → 2.5.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "u-foo",
-  "version": "2.5.5",
+  "version": "2.5.6",
   "description": "Multi-Agent Workspace Protocol. Just add u. claude → uclaude, codex → ucodex.",
   "license": "SEE LICENSE IN LICENSE",
   "homepage": "https://ufoo.dev",

package/src/agents/launch/ptyRunner.js

@@ -61,8 +61,8 @@ function stripAnsi(text) {
 function rewriteTitleOscPrefix(text, prefix) {
   if (!prefix || !text) return text;
   return String(text).replace(/\x1b\]([012]);([^\x07\x1b]*)(\x07|\x1b\\)/g, (match, code, title, terminator) => {
-    if (!title || title.startsWith(`${prefix}:`)) return match;
-    return `\x1b]${code};${prefix}:${title}${terminator}`;
+    if (!title || title.startsWith(`${prefix}: `)) return match;
+    return `\x1b]${code};${prefix}: ${title}${terminator}`;
   });
 }
 

package/src/agents/launch/ptyWrapper.js

@@ -211,8 +211,8 @@ class PtyWrapper {
     if (!this.titlePrefix || !text) return text;
     const prefix = this.titlePrefix;
     return text.replace(/\x1b\]([012]);([^\x07\x1b]*)(\x07|\x1b\\)/g, (match, code, title, terminator) => {
-      if (!title || title.startsWith(`${prefix}:`)) return match;
-      return `\x1b]${code};${prefix}:${title}${terminator}`;
+      if (!title || title.startsWith(`${prefix}: `)) return match;
+      return `\x1b]${code};${prefix}: ${title}${terminator}`;
     });
   }
 

package/src/agents/prompts/native/index.js

@@ -70,7 +70,7 @@ function getSystemPrompt({
   // --- Dynamic sections (may change per session/turn) ---
   const dynamicSectionDefs = [
     systemPromptSection("ufoo", () => getUfooIntegrationSection()),
-    systemPromptSection("environment", () =>
+    uncachedSection("environment", () =>
       getEnvironmentSection({ workspaceRoot, model, provider }),
     ),
     uncachedSection("skills", () => {

package/src/agents/prompts/native/toolDescriptions/bash.js

@@ -6,7 +6,7 @@ function getBashToolDescription() {
   return `Run a single shell command in the workspace directory.
 
 Usage notes:
-- Default timeout is 60 seconds. Use timeoutMs to adjust for longer operations.
+- Default timeout is 60 seconds. Use timeoutMs to adjust for longer operations (maximum 600 seconds; larger values are clamped).
 - Do NOT use bash for file operations when a dedicated tool exists:
   - Use read instead of cat/head/tail.
   - Use write instead of echo/cat heredoc.

package/src/agents/prompts/native/toolDescriptions/read.js

@@ -7,11 +7,12 @@ function getReadToolDescription() {
 
 Usage notes:
 - The path parameter is relative to the workspace root.
-- By default reads the entire file. For large files, use startLine and endLine to read specific ranges.
+- By default reads the entire file. Files larger than ~4MB are only partially read from the start; in that case truncated is true.
+- Use startLine and endLine to read specific line ranges.
 - Use maxBytes to limit the amount of data returned (default ~200KB).
 - Cannot read directories — use bash with \`ls\` for that.
 - Always read a file before editing it to understand its current content and structure.
-- Results are returned with line numbers for easy reference.`;
+- The content field contains the raw file text without line numbers. The result also includes totalLines (lines in the portion that was read) and truncated (true when the content was cut short by maxBytes or the large-file limit).`;
 }
 
 module.exports = { READ_TOOL_NAME, getReadToolDescription };

package/src/code/agent.js

@@ -2,7 +2,7 @@ const readline = require("readline");
 const fs = require("fs");
 const path = require("path");
 const { execSync } = require("child_process");
-const { runToolCall } = require("./dispatch");
+const { runToolCall, TOOL_NAMES } = require("./dispatch");
 const { runNativeAgentTask } = require("./nativeRunner");
 const {
   runDecomposedTask,
@@ -440,6 +440,7 @@ async function runNaturalLanguageTask(task = "", state = {}, options = {}) {
   const timeoutMs = Number.isFinite(state.timeoutMs) ? state.timeoutMs : 600000;
   let streamed = false;
   let streamLastChar = "";
+  let toolEventsThisAttempt = 0;
   const onDelta = typeof options.onDelta === "function"
     ? options.onDelta
     : null;
@@ -495,23 +496,27 @@ async function runNaturalLanguageTask(task = "", state = {}, options = {}) {
     : runNativeAgentTask;
   const onPhase = typeof options.onPhase === "function" ? options.onPhase : null;
   const onThinkingDelta = typeof options.onThinkingDelta === "function" ? options.onThinkingDelta : null;
-  const invokeNative = (sessionIdValue = "", timeoutOverrideMs = timeoutMs) => runNativeAgentImpl({
-    workspaceRoot,
-    provider,
-    model,
-    prompt: effectiveTaskPrompt,
-    systemPrompt: systemContext,
-    messages: Array.isArray(state.nlMessages) ? state.nlMessages : [],
-    sessionId: String(sessionIdValue || ""),
-    timeoutMs: timeoutOverrideMs,
-    onStreamDelta: onStream,
-    onThinkingDelta,
-    onPhase,
-    onToolEvent: (event) => {
-      pushToolLog(event);
-    },
-    signal: options.signal,
-  });
+  const invokeNative = (sessionIdValue = "", timeoutOverrideMs = timeoutMs) => {
+    toolEventsThisAttempt = 0;
+    return runNativeAgentImpl({
+      workspaceRoot,
+      provider,
+      model,
+      prompt: effectiveTaskPrompt,
+      systemPrompt: systemContext,
+      messages: Array.isArray(state.nlMessages) ? state.nlMessages : [],
+      sessionId: String(sessionIdValue || ""),
+      timeoutMs: timeoutOverrideMs,
+      onStreamDelta: onStream,
+      onThinkingDelta,
+      onPhase,
+      onToolEvent: (event) => {
+        toolEventsThisAttempt += 1;
+        pushToolLog(event);
+      },
+      signal: options.signal,
+    });
+  };
 
   try {
     let cliRes;
@@ -551,7 +556,9 @@ async function runNaturalLanguageTask(task = "", state = {}, options = {}) {
 
       if (!cliRes || cliRes.ok === false) {
         const errMsg = String((cliRes && cliRes.error) || "");
-        if (isCliTimeoutError(errMsg)) {
+        // Only replay the whole task when this attempt ran no tool calls;
+        // retrying after executed write/edit/bash steps would replay side effects.
+        if (isCliTimeoutError(errMsg) && toolEventsThisAttempt === 0) {
           const extendedTimeoutMs = computeExtendedTimeout(timeoutMs);
           cliRes = await invokeNative(String(state.sessionId || ""), extendedTimeoutMs);
         }
@@ -1317,6 +1324,13 @@ function runSingleCommand(line = "", workspaceRoot = process.cwd()) {
     };
   }
   const tool = String(match[2] || "").trim().toLowerCase();
+  if (String(match[1]).toLowerCase() === "run" && !TOOL_NAMES.includes(tool)) {
+    // Natural language like "run the tests" is not a tool invocation.
+    return {
+      kind: "nl",
+      task: text,
+    };
+  }
   const payload = String(match[3] || "").trim();
   let args = {};
   try {
@@ -1546,7 +1560,7 @@ async function runUcodeCoreAgent({
         }
       }
       if (result.kind === "resume") {
-        const resumed = resumeSessionState(state, result.sessionId, workspaceRoot);
+        const resumed = resumeSessionState(state, result.sessionId, state.workspaceRoot || resolvedWorkspaceRoot);
         if (!resumed.ok) {
           stdout.write(`Error: ${resumed.error}\n`);
         } else {

package/src/code/launcher/ucode.js

@@ -224,8 +224,10 @@ function readLastArgValue(args = [], flag = "") {
     if (!item) continue;
     if (item === flag) {
       const next = String(args[i + 1] || "").trim();
-      if (next) value = next;
-      i += 1;
+      if (next && !next.startsWith("--")) {
+        value = next;
+        i += 1;
+      }
       continue;
     }
     if (item.startsWith(`${flag}=`)) {
@@ -342,7 +344,7 @@ function resolveUcodeLaunch({
   const promptFile = String(
     env.UFOO_UCODE_PROMPT_FILE
       || config.ucodePromptFile
-      || defaultBundledPromptFile()
+      || ""
   ).trim();
   const bootstrapFile = String(
     env.UFOO_UCODE_BOOTSTRAP_FILE

package/src/code/launcher/ucodeDoctor.js

@@ -3,7 +3,6 @@ const path = require("path");
 const { loadConfig } = require("../../config");
 const {
   resolveNativeFallbackCommand,
-  defaultBundledPromptFile,
 } = require("./ucode");
 const { inspectUcodeBuildSetup } = require("./ucodeBuild");
 const { inspectUcodeRuntimeConfig } = require("./ucodeRuntimeConfig");
@@ -30,7 +29,7 @@ function inspectUcodeSetup({
   const promptFile = String(
     env.UFOO_UCODE_PROMPT_FILE
       || config.ucodePromptFile
-      || defaultBundledPromptFile()
+      || ""
   ).trim();
   const bootstrapFile = String(
     env.UFOO_UCODE_BOOTSTRAP_FILE
@@ -130,7 +129,7 @@ function formatUcodeDoctor(result = {}) {
   if (result.configuredCommand) {
     lines.push(`configured command override (ignored in native-only mode): ${result.configuredCommand}`);
   }
-  lines.push(`prompt: ${result.promptFile || "(none)"}${result.promptExists ? "" : " (missing)"}`);
+  lines.push(`prompt: ${result.promptFile || "(none)"}${result.promptFile && !result.promptExists ? " (missing)" : ""}`);
   lines.push(`bootstrap: ${result.bootstrapFile || "(none)"}`);
   if (result.build && result.build.coreRoot) {
     lines.push(`build: ${result.build.distCliExists ? "ready" : "missing dist"}`);
@@ -170,6 +169,10 @@ function prepareAndInspectUcode({
     projectRoot: inspection.projectRoot,
     promptFile: inspection.promptFile,
     targetFile: inspection.bootstrapFile,
+    // The native core already injects the ufoo protocol via the modular
+    // prompt (src/agents/prompts/native/ufoo.js); inlining it into the
+    // bootstrap file would append the same protocol text a second time.
+    includeDefaultProtocol: false,
   });
   return {
     ...inspection,

package/src/code/nativeRunner.js

@@ -14,6 +14,11 @@ const DEFAULT_ANTHROPIC_BASE_URL = "https://api.anthropic.com/v1";
 // for non-trivial tasks while still catching runaway loops. Override via env.
 const DEFAULT_MAX_NATIVE_TOOL_CALLS = 100;
 const DEFAULT_MAX_NATIVE_TOOL_ERRORS = 5;
+// Anthropic Messages rejects max_tokens above the model's real cap (64K on
+// current models), so the transports use different defaults. Override either
+// via UFOO_UCODE_MAX_TOKENS (positive integer).
+const DEFAULT_OPENAI_MAX_TOKENS = 131072;
+const DEFAULT_ANTHROPIC_MAX_TOKENS = 64000;
 
 function nowMs() {
   return Date.now();
@@ -38,6 +43,10 @@ function resolveNativeToolBudget(env = process.env) {
   };
 }
 
+function resolveMaxTokens(fallback) {
+  return normalizePositiveInt(process.env.UFOO_UCODE_MAX_TOKENS, fallback);
+}
+
 function enforceNativeToolBudget({
   toolCallsExecuted = 0,
   toolErrors = 0,
@@ -46,7 +55,7 @@ function enforceNativeToolBudget({
   lastTool = "",
   lastError = "",
 } = {}) {
-  if (toolCallsExecuted > maxToolCalls) {
+  if (toolCallsExecuted >= maxToolCalls) {
     throw new Error(`tool call budget exceeded (${maxToolCalls})`);
   }
   if (toolErrors >= maxToolErrors) {
@@ -534,7 +543,7 @@ async function runOpenAiLikeTurn({
 } = {}) {
   const payload = {
     model,
-    max_tokens: 131072,
+    max_tokens: resolveMaxTokens(DEFAULT_OPENAI_MAX_TOKENS),
     messages,
     tools: buildCoreToolSpecs(),
     tool_choice: "auto",
@@ -588,6 +597,8 @@ async function runOpenAiLikeTurn({
     let rawBuffer = "";
     let responseText = "";
     const announcedToolNames = new Set();
+    let nextSyntheticIndex = 0;
+    let lastSyntheticIndex = -1;
 
     while (true) {
       const { done, value } = await reader.read();
@@ -633,7 +644,23 @@ async function runOpenAiLikeTurn({
 
         if (Array.isArray(delta.tool_calls)) {
           for (const callPart of delta.tool_calls) {
-            const index = Number.isFinite(callPart.index) ? callPart.index : 0;
+            let index;
+            if (Number.isFinite(callPart.index)) {
+              index = callPart.index;
+            } else if (typeof callPart.id === "string" && callPart.id) {
+              // Provider omitted index: a chunk carrying an id starts a new
+              // call, so give it its own synthetic index instead of
+              // collapsing every call into slot 0.
+              while (toolCallMap.has(nextSyntheticIndex)) nextSyntheticIndex += 1;
+              index = nextSyntheticIndex;
+              nextSyntheticIndex += 1;
+              lastSyntheticIndex = index;
+            } else if (lastSyntheticIndex >= 0) {
+              // No index and no id: continuation of the latest synthetic call.
+              index = lastSyntheticIndex;
+            } else {
+              index = 0;
+            }
             const previous = toolCallMap.get(index) || {
               id: "",
               type: "function",
@@ -755,7 +782,7 @@ async function runAnthropicTurn({
 } = {}) {
   const payload = {
     model,
-    max_tokens: 131072,
+    max_tokens: resolveMaxTokens(DEFAULT_ANTHROPIC_MAX_TOKENS),
     messages,
     tools: buildAnthropicToolSpecs(),
     stream: true,

package/src/code/taskDecomposer.js

@@ -280,6 +280,15 @@ function compileSummary(results) {
   return summaryParts.join("\n\n");
 }
 
+/**
+ * Quote a value for safe inclusion in a shell command (single-quote style).
+ * Kept local to avoid a circular dependency with agent.js.
+ */
+function shellQuote(value = "") {
+  const text = String(value == null ? "" : value);
+  return `'${text.replace(/'/g, `'\"'\"'`)}'`;
+}
+
 /**
  * Create a progress reporter that sends updates via bus
  */
@@ -297,10 +306,10 @@ function createBusProgressReporter(shell, publisher) {
 
     if (progress.type === "step_start") {
       const message = `⏳ ${progress.name} (${progress.current}/${progress.total})`;
-      shell(`ufoo bus send ${publisher} ${JSON.stringify(message)}`);
+      shell(`ufoo bus send ${shellQuote(publisher)} ${shellQuote(JSON.stringify(message))}`);
     } else if (progress.type === "step_complete" && progress.success) {
       const message = `✅ ${progress.name} completed`;
-      shell(`ufoo bus send ${publisher} ${JSON.stringify(message)}`);
+      shell(`ufoo bus send ${shellQuote(publisher)} ${shellQuote(JSON.stringify(message))}`);
     }
   };
 }

package/src/code/tools/bash.js

@@ -1,6 +1,8 @@
 const { spawnSync } = require("child_process");
 const { normalizeWorkspaceRoot } = require("./common");
 
+const MAX_TIMEOUT_MS = 600000;
+
 function runBashTool(input = {}, options = {}) {
   try {
     const command = String(input.command || "").trim();
@@ -11,7 +13,9 @@ function runBashTool(input = {}, options = {}) {
       };
     }
     const workspaceRoot = normalizeWorkspaceRoot(options.workspaceRoot, options.cwd);
-    const timeoutMs = Number.isFinite(input.timeoutMs) ? Math.max(100, Math.floor(input.timeoutMs)) : 60000;
+    const timeoutMs = Number.isFinite(input.timeoutMs)
+      ? Math.min(MAX_TIMEOUT_MS, Math.max(100, Math.floor(input.timeoutMs)))
+      : 60000;
     const result = spawnSync(command, {
       cwd: workspaceRoot,
       shell: true,
@@ -25,13 +29,26 @@ function runBashTool(input = {}, options = {}) {
         ok: false,
         workspaceRoot,
         code: typeof result.status === "number" ? result.status : -1,
+        signal: result.signal || "",
         stdout: String(result.stdout || ""),
         stderr: String(result.stderr || ""),
         error: result.error.message || "bash failed",
       };
     }
 
-    const code = typeof result.status === "number" ? result.status : 0;
+    if (typeof result.status !== "number") {
+      return {
+        ok: false,
+        workspaceRoot,
+        code: -1,
+        signal: result.signal || "",
+        stdout: String(result.stdout || ""),
+        stderr: String(result.stderr || ""),
+        error: `command killed by signal ${result.signal || "unknown"}`,
+      };
+    }
+
+    const code = result.status;
     return {
       ok: code === 0,
       workspaceRoot,

package/src/code/tools/read.js

@@ -1,6 +1,23 @@
 const fs = require("fs");
 const { resolveWorkspacePath } = require("./common");
 
+const MAX_FULL_READ_BYTES = 4 * 1024 * 1024;
+
+function readFileBounded(resolved) {
+  const stat = fs.statSync(resolved);
+  if (stat.size <= MAX_FULL_READ_BYTES) {
+    return { raw: fs.readFileSync(resolved, "utf8"), partial: false };
+  }
+  const fd = fs.openSync(resolved, "r");
+  try {
+    const buffer = Buffer.alloc(MAX_FULL_READ_BYTES);
+    const bytesRead = fs.readSync(fd, buffer, 0, MAX_FULL_READ_BYTES, 0);
+    return { raw: buffer.slice(0, bytesRead).toString("utf8"), partial: true };
+  } finally {
+    fs.closeSync(fd);
+  }
+}
+
 function runReadTool(input = {}, options = {}) {
   try {
     const filePath = String(input.path || input.file || "").trim();
@@ -9,13 +26,13 @@ function runReadTool(input = {}, options = {}) {
     const endLine = Number.isFinite(input.endLine) ? Math.max(startLine, Math.floor(input.endLine)) : 0;
     const maxBytes = Number.isFinite(input.maxBytes) ? Math.max(256, Math.floor(input.maxBytes)) : 200000;
 
-    const raw = fs.readFileSync(resolved, "utf8");
+    const { raw, partial } = readFileBounded(resolved);
     const lines = raw.split(/\r?\n/);
     const from = startLine - 1;
     const to = endLine > 0 ? endLine : lines.length;
     const selected = lines.slice(from, to);
     let content = selected.join("\n");
-    let truncated = false;
+    let truncated = partial;
     if (Buffer.byteLength(content, "utf8") > maxBytes) {
       content = Buffer.from(content, "utf8").slice(0, maxBytes).toString("utf8");
       truncated = true;
@@ -41,4 +58,5 @@ function runReadTool(input = {}, options = {}) {
 
 module.exports = {
   runReadTool,
+  MAX_FULL_READ_BYTES,
 };