typo3-typescript-sources 13.4.32 → 13.4.34

package/.last-synced-tag

@@ -1 +1 @@
-v13.4.32
+v13.4.34

package/README.md

@@ -16,7 +16,7 @@ npm install typo3-typescript-sources
 
 - **Original Repository:** [TYPO3/typo3](https://github.com/TYPO3/typo3)
 - **Source Path:** `Build/Sources/TypeScript/`
-- **Current TYPO3 Version:** `v13.4.32`
+- **Current TYPO3 Version:** `v13.4.34`
 
 ## 🌿 Branches
 

package/backend/form-engine/element/slug-element.ts

@@ -88,7 +88,7 @@ class SlugElement {
   }
 
   private registerEvents(): void {
-    const fieldsToListenOnList = Object.values(this.getAvailableFieldsForProposalGeneration()).map((field: HTMLElement) => `[id="${field.id}"]`);
+    const fieldsToListenOnList = Object.values(this.getAvailableFieldsForProposalGeneration()).map((field: HTMLElement) => field.dataset.slugSelector);
     const recreateButton: HTMLButtonElement = this.fullElement.querySelector(Selectors.recreateButton);
 
     // Listen on 'listenerFieldNames' for new pages. This is typically the 'title' field
@@ -217,12 +217,20 @@ class SlugElement {
   private getAvailableFieldsForProposalGeneration(): { [key: string]: HTMLElement } {
     const availableFields: { [key: string]: HTMLElement } = {};
     for (const [fieldName, selector] of Object.entries(this.fieldsToListenOn)) {
-      let field = document.querySelector('[data-formengine-input-name="' + selector + '"]') as HTMLElement;
-      if (field === null) {
+      const selectorCandidates = [
+        '[data-formengine-input-name="' + selector + '"]',
         // Also check for fields, which do not point to a hidden input field (e.g. "input type=hidden", readOnly, or select fields)
-        field = document.querySelector('[name="' + selector + '"]') as HTMLElement;
-      }
+        '[name="' + selector + '"]'
+      ];
+      let field: HTMLElement;
+      let usedSelector = '';
+      selectorCandidates.some((testSelector: string) => {
+        field = document.querySelector(testSelector) as HTMLElement;
+        usedSelector = testSelector;
+        return field !== null;
+      });
       if (field !== null) {
+        field.dataset.slugSelector = usedSelector;
         availableFields[fieldName] = field;
       }
     }

package/backend/settings/type/stringlist.ts

@@ -66,6 +66,13 @@ export class StringlistTypeElement extends BaseElement<string[]> {
 
   protected override render(): TemplateResult {
     const value = this.value || [];
+    if (value.length === 0) {
+      return html`
+        <button id=${this.formid} class="btn btn-default" type="button" ?disabled=${this.readonly} @click=${() => this.addValue(0)}>
+          <typo3-backend-icon identifier="actions-plus" size="small"></typo3-backend-icon>
+        </button>
+      `;
+    }
     return html`
       <div class="form-control-wrap">
         <div class="table-fit">

package/backend/tests/settings/type/stringlist-test.ts

@@ -0,0 +1,90 @@
+/*
+ * This file is part of the TYPO3 CMS project.
+ *
+ * It is free software; you can redistribute it and/or modify it under
+ * the terms of the GNU General Public License, either version 2
+ * of the License, or any later version.
+ *
+ * For the full copyright and license information, please read the
+ * LICENSE.txt file that was distributed with this source code.
+ *
+ * The TYPO3 project - inspiring people to share!
+ */
+
+import { StringlistTypeElement } from '@typo3/backend/settings/type/stringlist.js';
+import { expect } from '@open-wc/testing';
+import type { } from 'mocha';
+
+describe('@typo3/backend/settings/type/stringlist', () => {
+  let root: HTMLElement;
+
+  beforeEach((): void => {
+    root = document.createElement('div');
+    document.body.appendChild(root);
+  });
+
+  afterEach((): void => {
+    root.remove();
+    root = null;
+  });
+
+  it('renders one button when the value list is empty', async () => {
+    const element = new StringlistTypeElement;
+    element.formid = 'setting-test';
+    element.value = [];
+    root.appendChild(element);
+    await new Promise((resolve) => setTimeout(resolve, 100));
+
+    const inputs = element.querySelectorAll<HTMLInputElement>('input[type="text"]');
+    expect(inputs).to.have.lengthOf(0);
+
+    const buttons = element.querySelectorAll<HTMLButtonElement>('button');
+    expect(buttons).to.have.lengthOf(1);
+  });
+
+  it('renders one empty input when the value list is a single empty string', async () => {
+    const element = new StringlistTypeElement;
+    element.formid = 'setting-test';
+    element.value = [''];
+    root.appendChild(element);
+    await new Promise((resolve) => setTimeout(resolve, 100));
+
+    const inputs = element.querySelectorAll<HTMLInputElement>('input[type="text"]');
+    expect(inputs).to.have.lengthOf(1);
+    expect(inputs[0].id).to.equal('setting-test');
+  });
+
+  it('hides the remove button when only one row is shown', async () => {
+    const element = new StringlistTypeElement;
+    element.value = [];
+    root.appendChild(element);
+    await new Promise((resolve) => setTimeout(resolve, 100));
+
+    expect(element.querySelectorAll('button')).to.have.lengthOf(1);
+  });
+
+  it('adds a row when the add button is clicked on an empty list', async () => {
+    const element = new StringlistTypeElement;
+    element.value = [];
+    root.appendChild(element);
+    await new Promise((resolve) => setTimeout(resolve, 100));
+
+    const addButton = element.querySelectorAll<HTMLButtonElement>('button:not([disabled])')[0];
+    addButton.click();
+    await new Promise((resolve) => setTimeout(resolve, 100));
+
+    expect(element.value).to.deep.equal(['']);
+    expect(element.querySelectorAll('input[type="text"]')).to.have.lengthOf(1);
+  });
+
+  it('renders per-row controls for each entry when value has multiple entries', async () => {
+    const element = new StringlistTypeElement;
+    element.value = ['/typo3', '/fileadmin'];
+    root.appendChild(element);
+    await new Promise((resolve) => setTimeout(resolve, 100));
+
+    expect(element.querySelectorAll('input[type="text"]')).to.have.lengthOf(2);
+    // Two rows, each with + and - buttons.
+    expect(element.querySelectorAll('button')).to.have.lengthOf(4);
+  });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "typo3-typescript-sources",
-  "version": "13.4.32",
+  "version": "13.4.34",
   "description": "TYPO3 Core TypeScript Sources - Extracted from TYPO3/typo3 repository",
   "main": "index.js",
   "types": "index.d.ts",
@@ -28,7 +28,7 @@
   },
   "typo3": {
     "sourceRepository": "https://github.com/TYPO3/typo3",
-    "sourceTag": "v13.4.32",
+    "sourceTag": "v13.4.34",
     "sourcePath": "Build/Sources/TypeScript"
   }
 }

package/redirects/event-handler.ts

@@ -86,9 +86,9 @@ class EventHandler {
   }
 
   private revert(correlationIds: string[]): Promise<AjaxResponse> {
-    const request = new AjaxRequest(TYPO3.settings.ajaxUrls.redirects_revert_correlation).withQueryArguments({
-      correlation_ids: correlationIds
-    }).get();
+    const request = new AjaxRequest(TYPO3.settings.ajaxUrls.redirects_revert_correlation).post({
+      correlation_ids: correlationIds,
+    });
 
     request.then(async (response: AjaxResponse): Promise<void> => {
       const json = await response.resolve();