typescript 5.4.0-dev.20231114 → 5.4.0-dev.20231116

package/lib/tsc.js

@@ -18,7 +18,7 @@ and limitations under the License.
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.4";
-var version = `${versionMajorMinor}.0-dev.20231114`;
+var version = `${versionMajorMinor}.0-dev.20231116`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -4521,6 +4521,7 @@ function createSystemWatchFunctions({
   useNonPollingWatchers,
   tscWatchDirectory,
   inodeWatching,
+  fsWatchWithTimestamp,
   sysLog: sysLog2
 }) {
   const pollingWatches = /* @__PURE__ */ new Map();
@@ -4759,7 +4760,7 @@ function createSystemWatchFunctions({
         return watchPresentFileSystemEntryWithFsWatchFile();
       }
       try {
-        const presentWatcher = fsWatchWorker(
+        const presentWatcher = (!fsWatchWithTimestamp ? fsWatchWorker : fsWatchWorkerHandlingTimestamp)(
           fileOrDirectory,
           recursive,
           inodeWatching ? callbackChangingToMissingFileSystemEntry : callback
@@ -4822,6 +4823,18 @@ function createSystemWatchFunctions({
       );
     }
   }
+  function fsWatchWorkerHandlingTimestamp(fileOrDirectory, recursive, callback) {
+    let modifiedTime = getModifiedTime3(fileOrDirectory) || missingFileModifiedTime;
+    return fsWatchWorker(fileOrDirectory, recursive, (eventName, relativeFileName, currentModifiedTime) => {
+      if (eventName === "change") {
+        currentModifiedTime || (currentModifiedTime = getModifiedTime3(fileOrDirectory) || missingFileModifiedTime);
+        if (currentModifiedTime.getTime() === modifiedTime.getTime())
+          return;
+      }
+      modifiedTime = currentModifiedTime || getModifiedTime3(fileOrDirectory) || missingFileModifiedTime;
+      callback(eventName, relativeFileName, modifiedTime);
+    });
+  }
 }
 function patchWriteFileEnsuringDirectory(sys2) {
   const originalWriteFile = sys2.writeFile;
@@ -4850,12 +4863,13 @@ var sys = (() => {
     let activeSession;
     let profilePath = "./profile.cpuprofile";
     const Buffer = require("buffer").Buffer;
-    const isLinuxOrMacOs = process.platform === "linux" || process.platform === "darwin";
+    const isMacOs = process.platform === "darwin";
+    const isLinuxOrMacOs = process.platform === "linux" || isMacOs;
     const platform = _os.platform();
     const useCaseSensitiveFileNames2 = isFileSystemCaseSensitive();
     const fsRealpath = !!_fs.realpathSync.native ? process.platform === "win32" ? fsRealPathHandlingLongPath : _fs.realpathSync.native : _fs.realpathSync;
     const executingFilePath = __filename.endsWith("sys.js") ? _path.join(_path.dirname(__dirname), "__fake__.js") : __filename;
-    const fsSupportsRecursiveFsWatch = process.platform === "win32" || process.platform === "darwin";
+    const fsSupportsRecursiveFsWatch = process.platform === "win32" || isMacOs;
     const getCurrentDirectory = memoize(() => process.cwd());
     const { watchFile: watchFile2, watchDirectory } = createSystemWatchFunctions({
       pollingWatchFileWorker: fsWatchFileWorker,
@@ -4875,6 +4889,7 @@ var sys = (() => {
       useNonPollingWatchers: !!process.env.TSC_NONPOLLING_WATCHER,
       tscWatchDirectory: process.env.TSC_WATCHDIRECTORY,
       inodeWatching: isLinuxOrMacOs,
+      fsWatchWithTimestamp: isMacOs,
       sysLog
     });
     const nodeSystem = {
@@ -6667,6 +6682,7 @@ var Diagnostics = {
   Type_0_is_generic_and_can_only_be_indexed_for_reading: diag(2862, 1 /* Error */, "Type_0_is_generic_and_can_only_be_indexed_for_reading_2862", "Type '{0}' is generic and can only be indexed for reading."),
   A_class_cannot_extend_a_primitive_type_like_0_Classes_can_only_extend_constructable_values: diag(2863, 1 /* Error */, "A_class_cannot_extend_a_primitive_type_like_0_Classes_can_only_extend_constructable_values_2863", "A class cannot extend a primitive type like '{0}'. Classes can only extend constructable values."),
   A_class_cannot_implement_a_primitive_type_like_0_It_can_only_implement_other_named_object_types: diag(2864, 1 /* Error */, "A_class_cannot_implement_a_primitive_type_like_0_It_can_only_implement_other_named_object_types_2864", "A class cannot implement a primitive type like '{0}'. It can only implement other named object types."),
+  Import_0_conflicts_with_local_value_so_must_be_declared_with_a_type_only_import_when_isolatedModules_is_enabled: diag(2865, 1 /* Error */, "Import_0_conflicts_with_local_value_so_must_be_declared_with_a_type_only_import_when_isolatedModules_2865", "Import '{0}' conflicts with local value, so must be declared with a type-only import when 'isolatedModules' is enabled."),
   Import_declaration_0_is_using_private_name_1: diag(4e3, 1 /* Error */, "Import_declaration_0_is_using_private_name_1_4000", "Import declaration '{0}' is using private name '{1}'."),
   Type_parameter_0_of_exported_class_has_or_is_using_private_name_1: diag(4002, 1 /* Error */, "Type_parameter_0_of_exported_class_has_or_is_using_private_name_1_4002", "Type parameter '{0}' of exported class has or is using private name '{1}'."),
   Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1: diag(4004, 1 /* Error */, "Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1_4004", "Type parameter '{0}' of exported interface has or is using private name '{1}'."),
@@ -10961,7 +10977,7 @@ function isPropertyAccessOrQualifiedNameOrImportTypeNode(node) {
   return kind === 211 /* PropertyAccessExpression */ || kind === 166 /* QualifiedName */ || kind === 205 /* ImportType */;
 }
 function isCallLikeOrFunctionLikeExpression(node) {
-  return isCallLikeExpression(node) || isFunctionLike(node);
+  return isCallLikeExpression(node) || isFunctionExpressionOrArrowFunction(node);
 }
 function isCallLikeExpression(node) {
   switch (node.kind) {
@@ -18823,10 +18839,8 @@ function createNodeFactory(flags, baseFactory2) {
     return update(updated, original);
   }
   function createNumericLiteral(value, numericLiteralFlags = 0 /* None */) {
-    const text = typeof value === "number" ? value + "" : value;
-    Debug.assert(text.charCodeAt(0) !== 45 /* minus */, "Negative numbers should be created in combination with createPrefixUnaryExpression");
     const node = createBaseDeclaration(9 /* NumericLiteral */);
-    node.text = text;
+    node.text = typeof value === "number" ? value + "" : value;
     node.numericLiteralFlags = numericLiteralFlags;
     if (numericLiteralFlags & 384 /* BinaryOrOctalSpecifier */)
       node.transformFlags |= 1024 /* ContainsES2015 */;
@@ -43692,7 +43706,7 @@ function createTypeChecker(host) {
         const nodeLinks2 = getNodeLinks(node);
         cachedResolvedSignatures.push([nodeLinks2, nodeLinks2.resolvedSignature]);
         nodeLinks2.resolvedSignature = void 0;
-        if (isFunctionLike(node)) {
+        if (isFunctionExpressionOrArrowFunction(node)) {
           const symbolLinks2 = getSymbolLinks(getSymbolOfDeclaration(node));
           const type = symbolLinks2.type;
           cachedTypes2.push([symbolLinks2, type]);
@@ -48254,6 +48268,8 @@ function createTypeChecker(host) {
           context.symbolDepth.set(id, depth + 1);
         }
         context.visitedTypes.add(typeId);
+        const prevTrackedSymbols = context.trackedSymbols;
+        context.trackedSymbols = void 0;
         const startLength = context.approximateLength;
         const result = transform(type2);
         const addedLength = context.approximateLength - startLength;
@@ -48269,6 +48285,7 @@ function createTypeChecker(host) {
         if (id) {
           context.symbolDepth.set(id, depth);
         }
+        context.trackedSymbols = prevTrackedSymbols;
         return result;
         function deepCloneOrReuseNode(node) {
           if (!nodeIsSynthesized(node) && getParseTreeNode(node) === node) {
@@ -48571,7 +48588,7 @@ function createTypeChecker(host) {
       context.approximateLength += symbolName(propertySymbol).length + 1;
       if (propertySymbol.flags & 98304 /* Accessor */) {
         const writeType = getWriteTypeOfSymbol(propertySymbol);
-        if (propertyType !== writeType) {
+        if (propertyType !== writeType && !isErrorType(propertyType) && !isErrorType(writeType)) {
           const getterDeclaration = getDeclarationOfKind(propertySymbol, 177 /* GetAccessor */);
           const getterSignature = getSignatureFromDeclaration(getterDeclaration);
           typeElements.push(
@@ -49520,7 +49537,7 @@ function createTypeChecker(host) {
             return factory.createStringLiteral(name, !!singleQuote);
           }
           if (isNumericLiteralName(name) && startsWith(name, "-")) {
-            return factory.createComputedPropertyName(factory.createPrefixUnaryExpression(41 /* MinusToken */, factory.createNumericLiteral(Math.abs(+name))));
+            return factory.createComputedPropertyName(factory.createNumericLiteral(+name));
           }
           return createPropertyNameNodeForIdentifierOrLiteral(name, getEmitScriptTarget(compilerOptions), singleQuote, stringNamed, isMethod);
         }
@@ -75403,14 +75420,9 @@ function createTypeChecker(host) {
       case 15 /* NoSubstitutionTemplateLiteral */:
       case 11 /* StringLiteral */:
         return hasSkipDirectInferenceFlag(node) ? blockedStringType : getFreshTypeOfLiteralType(getStringLiteralType(node.text));
-      case 9 /* NumericLiteral */: {
+      case 9 /* NumericLiteral */:
         checkGrammarNumericLiteral(node);
-        const value = +node.text;
-        if (!isFinite(value)) {
-          return numberType;
-        }
-        return getFreshTypeOfLiteralType(getNumberLiteralType(value));
-      }
+        return getFreshTypeOfLiteralType(getNumberLiteralType(+node.text));
       case 10 /* BigIntLiteral */:
         checkGrammarBigIntLiteral(node);
         return getFreshTypeOfLiteralType(getBigIntLiteralType({
@@ -80315,6 +80327,16 @@ function createTypeChecker(host) {
       if (targetFlags & excludedMeanings) {
         const message = node.kind === 281 /* ExportSpecifier */ ? Diagnostics.Export_declaration_conflicts_with_exported_declaration_of_0 : Diagnostics.Import_declaration_conflicts_with_local_declaration_of_0;
         error(node, message, symbolToString(symbol));
+      } else if (node.kind !== 281 /* ExportSpecifier */) {
+        const appearsValueyToTranspiler = compilerOptions.isolatedModules && !findAncestor(node, isTypeOnlyImportOrExportDeclaration);
+        if (appearsValueyToTranspiler && symbol.flags & (111551 /* Value */ | 1048576 /* ExportValue */)) {
+          error(
+            node,
+            Diagnostics.Import_0_conflicts_with_local_value_so_must_be_declared_with_a_type_only_import_when_isolatedModules_is_enabled,
+            symbolToString(symbol),
+            isolatedModulesLikeFlagName
+          );
+        }
       }
       if (getIsolatedModules(compilerOptions) && !isTypeOnlyImportOrExportDeclaration(node) && !(node.flags & 33554432 /* Ambient */)) {
         const typeOnlyAlias = getTypeOnlyAliasDeclaration(symbol);
@@ -82411,7 +82433,7 @@ function createTypeChecker(host) {
     if (enumResult)
       return enumResult;
     const literalValue = type.value;
-    return typeof literalValue === "object" ? factory.createBigIntLiteral(literalValue) : typeof literalValue === "string" ? factory.createStringLiteral(literalValue) : literalValue < 0 ? factory.createPrefixUnaryExpression(41 /* MinusToken */, factory.createNumericLiteral(Math.abs(literalValue))) : factory.createNumericLiteral(literalValue);
+    return typeof literalValue === "object" ? factory.createBigIntLiteral(literalValue) : typeof literalValue === "number" ? factory.createNumericLiteral(literalValue) : factory.createStringLiteral(literalValue);
   }
   function createLiteralConstValue(node, tracker) {
     const type = getTypeOfSymbol(getSymbolOfDeclaration(node));
@@ -88840,7 +88862,7 @@ function transformTypeScript(context) {
   function transformEnumMemberDeclarationValue(member) {
     const value = resolver.getConstantValue(member);
     if (value !== void 0) {
-      return typeof value === "string" ? factory2.createStringLiteral(value) : value < 0 ? factory2.createPrefixUnaryExpression(41 /* MinusToken */, factory2.createNumericLiteral(Math.abs(value))) : factory2.createNumericLiteral(value);
+      return typeof value === "string" ? factory2.createStringLiteral(value) : factory2.createNumericLiteral(value);
     } else {
       enableSubstitutionForNonQualifiedEnumMembers();
       if (member.initializer) {
@@ -103160,7 +103182,7 @@ function transformGenerators(context) {
       if (labelExpressions === void 0) {
         labelExpressions = [];
       }
-      const expression = factory2.createNumericLiteral(Number.MAX_SAFE_INTEGER);
+      const expression = factory2.createNumericLiteral(-1);
       if (labelExpressions[label] === void 0) {
         labelExpressions[label] = [expression];
       } else {
@@ -109035,8 +109057,7 @@ function transformDeclarations(context) {
             if (shouldStripInternal(m))
               return;
             const constValue = resolver.getConstantValue(m);
-            const newInitializer = constValue === void 0 ? void 0 : typeof constValue === "string" ? factory2.createStringLiteral(constValue) : constValue < 0 ? factory2.createPrefixUnaryExpression(41 /* MinusToken */, factory2.createNumericLiteral(Math.abs(constValue))) : factory2.createNumericLiteral(constValue);
-            return preserveJsDoc(factory2.updateEnumMember(m, m.name, newInitializer), m);
+            return preserveJsDoc(factory2.updateEnumMember(m, m.name, constValue !== void 0 ? typeof constValue === "string" ? factory2.createStringLiteral(constValue) : factory2.createNumericLiteral(constValue) : void 0), m);
           }))
         ));
       }