typescript 5.3.0-dev.20230822 → 5.3.0-dev.20230824

package/lib/tsc.js

@@ -18,7 +18,7 @@ and limitations under the License.
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.3";
-var version = `${versionMajorMinor}.0-dev.20230822`;
+var version = `${versionMajorMinor}.0-dev.20230824`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -11771,8 +11771,8 @@ function getInternalEmitFlags(node) {
   const emitNode = node.emitNode;
   return emitNode && emitNode.internalFlags || 0;
 }
-function getScriptTargetFeatures() {
-  return new Map(Object.entries({
+var getScriptTargetFeatures = /* @__PURE__ */ memoize(
+  () => new Map(Object.entries({
     Array: new Map(Object.entries({
       es2015: [
         "find",
@@ -11839,7 +11839,7 @@ function getScriptTargetFeatures() {
         "defineProperty",
         "deleteProperty",
         "get",
-        " getOwnPropertyDescriptor",
+        "getOwnPropertyDescriptor",
         "getPrototypeOf",
         "has",
         "isExtensible",
@@ -12165,8 +12165,8 @@ function getScriptTargetFeatures() {
         "cause"
       ]
     }))
-  }));
-}
+  }))
+);
 function getLiteralText(node, sourceFile, flags) {
   if (sourceFile && canUseOriginalText(node, flags)) {
     return getSourceTextOfNodeFromSourceFile(sourceFile, node);
@@ -48630,11 +48630,17 @@ function createTypeChecker(host) {
       const constraintNode = constraint && typeToTypeNodeHelper(constraint, context);
       return typeParameterToDeclarationWithConstraint(type, context, constraintNode);
     }
-    function symbolToParameterDeclaration(parameterSymbol, context, preserveModifierFlags, privateSymbolVisitor, bundledImports) {
-      let parameterDeclaration = getDeclarationOfKind(parameterSymbol, 169 /* Parameter */);
-      if (!parameterDeclaration && !isTransientSymbol(parameterSymbol)) {
-        parameterDeclaration = getDeclarationOfKind(parameterSymbol, 348 /* JSDocParameterTag */);
+    function getEffectiveParameterDeclaration(parameterSymbol) {
+      const parameterDeclaration = getDeclarationOfKind(parameterSymbol, 169 /* Parameter */);
+      if (parameterDeclaration) {
+        return parameterDeclaration;
+      }
+      if (!isTransientSymbol(parameterSymbol)) {
+        return getDeclarationOfKind(parameterSymbol, 348 /* JSDocParameterTag */);
       }
+    }
+    function symbolToParameterDeclaration(parameterSymbol, context, preserveModifierFlags, privateSymbolVisitor, bundledImports) {
+      const parameterDeclaration = getEffectiveParameterDeclaration(parameterSymbol);
       let parameterType = getTypeOfSymbol(parameterSymbol);
       if (parameterDeclaration && isRequiredInitializedParameter(parameterDeclaration)) {
         parameterType = getOptionalType(parameterType);
@@ -48643,7 +48649,7 @@ function createTypeChecker(host) {
       const modifiers = !(context.flags & 8192 /* OmitParameterModifiers */) && preserveModifierFlags && parameterDeclaration && canHaveModifiers(parameterDeclaration) ? map(getModifiers(parameterDeclaration), factory.cloneNode) : void 0;
       const isRest = parameterDeclaration && isRestParameter(parameterDeclaration) || getCheckFlags(parameterSymbol) & 32768 /* RestParameter */;
       const dotDotDotToken = isRest ? factory.createToken(26 /* DotDotDotToken */) : void 0;
-      const name = parameterDeclaration ? parameterDeclaration.name ? parameterDeclaration.name.kind === 80 /* Identifier */ ? setEmitFlags(factory.cloneNode(parameterDeclaration.name), 16777216 /* NoAsciiEscaping */) : parameterDeclaration.name.kind === 166 /* QualifiedName */ ? setEmitFlags(factory.cloneNode(parameterDeclaration.name.right), 16777216 /* NoAsciiEscaping */) : cloneBindingName(parameterDeclaration.name) : symbolName(parameterSymbol) : symbolName(parameterSymbol);
+      const name = parameterToParameterDeclarationName(parameterSymbol, parameterDeclaration, context);
       const isOptional = parameterDeclaration && isOptionalParameter(parameterDeclaration) || getCheckFlags(parameterSymbol) & 16384 /* OptionalParameter */;
       const questionToken = isOptional ? factory.createToken(58 /* QuestionToken */) : void 0;
       const parameterNode = factory.createParameterDeclaration(
@@ -48657,6 +48663,9 @@ function createTypeChecker(host) {
       );
       context.approximateLength += symbolName(parameterSymbol).length + 3;
       return parameterNode;
+    }
+    function parameterToParameterDeclarationName(parameterSymbol, parameterDeclaration, context) {
+      return parameterDeclaration ? parameterDeclaration.name ? parameterDeclaration.name.kind === 80 /* Identifier */ ? setEmitFlags(factory.cloneNode(parameterDeclaration.name), 16777216 /* NoAsciiEscaping */) : parameterDeclaration.name.kind === 166 /* QualifiedName */ ? setEmitFlags(factory.cloneNode(parameterDeclaration.name.right), 16777216 /* NoAsciiEscaping */) : cloneBindingName(parameterDeclaration.name) : symbolName(parameterSymbol) : symbolName(parameterSymbol);
       function cloneBindingName(node) {
         return elideInitializerAndSetEmitFlags(node);
         function elideInitializerAndSetEmitFlags(node2) {
@@ -50637,6 +50646,21 @@ function createTypeChecker(host) {
           if (p.flags & 98304 /* Accessor */ && useAccessors) {
             const result = [];
             if (p.flags & 65536 /* SetAccessor */) {
+              const setter = p.declarations && forEach(p.declarations, (d) => {
+                if (d.kind === 178 /* SetAccessor */) {
+                  return d;
+                }
+                if (isCallExpression(d) && isBindableObjectDefinePropertyCall(d)) {
+                  return forEach(d.arguments[2].properties, (propDecl) => {
+                    const id = getNameOfDeclaration(propDecl);
+                    if (!!id && isIdentifier(id) && idText(id) === "set") {
+                      return propDecl;
+                    }
+                  });
+                }
+              });
+              Debug.assert(setter && isFunctionLikeDeclaration(setter));
+              const paramSymbol = getSignatureFromDeclaration(setter).parameters[0];
               result.push(setTextRange(
                 factory.createSetAccessorDeclaration(
                   factory.createModifiersFromModifierFlags(flag),
@@ -50646,7 +50670,7 @@ function createTypeChecker(host) {
                     void 0,
                     /*dotDotDotToken*/
                     void 0,
-                    "arg",
+                    paramSymbol ? parameterToParameterDeclarationName(paramSymbol, getEffectiveParameterDeclaration(paramSymbol), context) : "value",
                     /*questionToken*/
                     void 0,
                     isPrivate ? void 0 : serializeTypeForDeclaration(context, getTypeOfSymbol(p), p, enclosingDeclaration, includePrivateSymbol, bundled)
@@ -63996,12 +64020,14 @@ function createTypeChecker(host) {
     }
     function inferFromSignatures(source, target, kind) {
       const sourceSignatures = getSignaturesOfType(source, kind);
-      const targetSignatures = getSignaturesOfType(target, kind);
       const sourceLen = sourceSignatures.length;
-      const targetLen = targetSignatures.length;
-      const len = sourceLen < targetLen ? sourceLen : targetLen;
-      for (let i = 0; i < len; i++) {
-        inferFromSignature(getBaseSignature(sourceSignatures[sourceLen - len + i]), getErasedSignature(targetSignatures[targetLen - len + i]));
+      if (sourceLen > 0) {
+        const targetSignatures = getSignaturesOfType(target, kind);
+        const targetLen = targetSignatures.length;
+        for (let i = 0; i < targetLen; i++) {
+          const sourceIndex = Math.max(sourceLen - targetLen + i, 0);
+          inferFromSignature(getBaseSignature(sourceSignatures[sourceIndex]), getErasedSignature(targetSignatures[i]));
+        }
       }
     }
     function inferFromSignature(source, target) {
@@ -65537,7 +65563,7 @@ function createTypeChecker(host) {
       return void 0;
     }
     function getDiscriminantPropertyAccess(expr, computedType) {
-      const type = declaredType.flags & 1048576 /* Union */ ? declaredType : computedType;
+      const type = !(computedType.flags & 1048576 /* Union */) && declaredType.flags & 1048576 /* Union */ ? declaredType : computedType;
       if (type.flags & 1048576 /* Union */) {
         const access = getCandidateDiscriminantPropertyAccess(expr);
         if (access) {

package/lib/tsserver.js

@@ -2333,7 +2333,7 @@ module.exports = __toCommonJS(server_exports);
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.3";
-var version = `${versionMajorMinor}.0-dev.20230822`;
+var version = `${versionMajorMinor}.0-dev.20230824`;
 var Comparison = /* @__PURE__ */ ((Comparison3) => {
   Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
   Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -15541,8 +15541,8 @@ function getInternalEmitFlags(node) {
   const emitNode = node.emitNode;
   return emitNode && emitNode.internalFlags || 0;
 }
-function getScriptTargetFeatures() {
-  return new Map(Object.entries({
+var getScriptTargetFeatures = /* @__PURE__ */ memoize(
+  () => new Map(Object.entries({
     Array: new Map(Object.entries({
       es2015: [
         "find",
@@ -15609,7 +15609,7 @@ function getScriptTargetFeatures() {
         "defineProperty",
         "deleteProperty",
         "get",
-        " getOwnPropertyDescriptor",
+        "getOwnPropertyDescriptor",
         "getPrototypeOf",
         "has",
         "isExtensible",
@@ -15935,8 +15935,8 @@ function getScriptTargetFeatures() {
         "cause"
       ]
     }))
-  }));
-}
+  }))
+);
 var GetLiteralTextFlags = /* @__PURE__ */ ((GetLiteralTextFlags2) => {
   GetLiteralTextFlags2[GetLiteralTextFlags2["None"] = 0] = "None";
   GetLiteralTextFlags2[GetLiteralTextFlags2["NeverAsciiEscape"] = 1] = "NeverAsciiEscape";
@@ -53338,11 +53338,17 @@ function createTypeChecker(host) {
       const constraintNode = constraint && typeToTypeNodeHelper(constraint, context);
       return typeParameterToDeclarationWithConstraint(type, context, constraintNode);
     }
-    function symbolToParameterDeclaration(parameterSymbol, context, preserveModifierFlags, privateSymbolVisitor, bundledImports) {
-      let parameterDeclaration = getDeclarationOfKind(parameterSymbol, 169 /* Parameter */);
-      if (!parameterDeclaration && !isTransientSymbol(parameterSymbol)) {
-        parameterDeclaration = getDeclarationOfKind(parameterSymbol, 348 /* JSDocParameterTag */);
+    function getEffectiveParameterDeclaration(parameterSymbol) {
+      const parameterDeclaration = getDeclarationOfKind(parameterSymbol, 169 /* Parameter */);
+      if (parameterDeclaration) {
+        return parameterDeclaration;
+      }
+      if (!isTransientSymbol(parameterSymbol)) {
+        return getDeclarationOfKind(parameterSymbol, 348 /* JSDocParameterTag */);
       }
+    }
+    function symbolToParameterDeclaration(parameterSymbol, context, preserveModifierFlags, privateSymbolVisitor, bundledImports) {
+      const parameterDeclaration = getEffectiveParameterDeclaration(parameterSymbol);
       let parameterType = getTypeOfSymbol(parameterSymbol);
       if (parameterDeclaration && isRequiredInitializedParameter(parameterDeclaration)) {
         parameterType = getOptionalType(parameterType);
@@ -53351,7 +53357,7 @@ function createTypeChecker(host) {
       const modifiers = !(context.flags & 8192 /* OmitParameterModifiers */) && preserveModifierFlags && parameterDeclaration && canHaveModifiers(parameterDeclaration) ? map(getModifiers(parameterDeclaration), factory.cloneNode) : void 0;
       const isRest = parameterDeclaration && isRestParameter(parameterDeclaration) || getCheckFlags(parameterSymbol) & 32768 /* RestParameter */;
       const dotDotDotToken = isRest ? factory.createToken(26 /* DotDotDotToken */) : void 0;
-      const name = parameterDeclaration ? parameterDeclaration.name ? parameterDeclaration.name.kind === 80 /* Identifier */ ? setEmitFlags(factory.cloneNode(parameterDeclaration.name), 16777216 /* NoAsciiEscaping */) : parameterDeclaration.name.kind === 166 /* QualifiedName */ ? setEmitFlags(factory.cloneNode(parameterDeclaration.name.right), 16777216 /* NoAsciiEscaping */) : cloneBindingName(parameterDeclaration.name) : symbolName(parameterSymbol) : symbolName(parameterSymbol);
+      const name = parameterToParameterDeclarationName(parameterSymbol, parameterDeclaration, context);
       const isOptional = parameterDeclaration && isOptionalParameter(parameterDeclaration) || getCheckFlags(parameterSymbol) & 16384 /* OptionalParameter */;
       const questionToken = isOptional ? factory.createToken(58 /* QuestionToken */) : void 0;
       const parameterNode = factory.createParameterDeclaration(
@@ -53365,6 +53371,9 @@ function createTypeChecker(host) {
       );
       context.approximateLength += symbolName(parameterSymbol).length + 3;
       return parameterNode;
+    }
+    function parameterToParameterDeclarationName(parameterSymbol, parameterDeclaration, context) {
+      return parameterDeclaration ? parameterDeclaration.name ? parameterDeclaration.name.kind === 80 /* Identifier */ ? setEmitFlags(factory.cloneNode(parameterDeclaration.name), 16777216 /* NoAsciiEscaping */) : parameterDeclaration.name.kind === 166 /* QualifiedName */ ? setEmitFlags(factory.cloneNode(parameterDeclaration.name.right), 16777216 /* NoAsciiEscaping */) : cloneBindingName(parameterDeclaration.name) : symbolName(parameterSymbol) : symbolName(parameterSymbol);
       function cloneBindingName(node) {
         return elideInitializerAndSetEmitFlags(node);
         function elideInitializerAndSetEmitFlags(node2) {
@@ -55345,6 +55354,21 @@ function createTypeChecker(host) {
           if (p.flags & 98304 /* Accessor */ && useAccessors) {
             const result = [];
             if (p.flags & 65536 /* SetAccessor */) {
+              const setter = p.declarations && forEach(p.declarations, (d) => {
+                if (d.kind === 178 /* SetAccessor */) {
+                  return d;
+                }
+                if (isCallExpression(d) && isBindableObjectDefinePropertyCall(d)) {
+                  return forEach(d.arguments[2].properties, (propDecl) => {
+                    const id = getNameOfDeclaration(propDecl);
+                    if (!!id && isIdentifier(id) && idText(id) === "set") {
+                      return propDecl;
+                    }
+                  });
+                }
+              });
+              Debug.assert(setter && isFunctionLikeDeclaration(setter));
+              const paramSymbol = getSignatureFromDeclaration(setter).parameters[0];
               result.push(setTextRange(
                 factory.createSetAccessorDeclaration(
                   factory.createModifiersFromModifierFlags(flag),
@@ -55354,7 +55378,7 @@ function createTypeChecker(host) {
                     void 0,
                     /*dotDotDotToken*/
                     void 0,
-                    "arg",
+                    paramSymbol ? parameterToParameterDeclarationName(paramSymbol, getEffectiveParameterDeclaration(paramSymbol), context) : "value",
                     /*questionToken*/
                     void 0,
                     isPrivate ? void 0 : serializeTypeForDeclaration(context, getTypeOfSymbol(p), p, enclosingDeclaration, includePrivateSymbol, bundled)
@@ -68704,12 +68728,14 @@ function createTypeChecker(host) {
     }
     function inferFromSignatures(source, target, kind) {
       const sourceSignatures = getSignaturesOfType(source, kind);
-      const targetSignatures = getSignaturesOfType(target, kind);
       const sourceLen = sourceSignatures.length;
-      const targetLen = targetSignatures.length;
-      const len = sourceLen < targetLen ? sourceLen : targetLen;
-      for (let i = 0; i < len; i++) {
-        inferFromSignature(getBaseSignature(sourceSignatures[sourceLen - len + i]), getErasedSignature(targetSignatures[targetLen - len + i]));
+      if (sourceLen > 0) {
+        const targetSignatures = getSignaturesOfType(target, kind);
+        const targetLen = targetSignatures.length;
+        for (let i = 0; i < targetLen; i++) {
+          const sourceIndex = Math.max(sourceLen - targetLen + i, 0);
+          inferFromSignature(getBaseSignature(sourceSignatures[sourceIndex]), getErasedSignature(targetSignatures[i]));
+        }
       }
     }
     function inferFromSignature(source, target) {
@@ -70245,7 +70271,7 @@ function createTypeChecker(host) {
       return void 0;
     }
     function getDiscriminantPropertyAccess(expr, computedType) {
-      const type = declaredType.flags & 1048576 /* Union */ ? declaredType : computedType;
+      const type = !(computedType.flags & 1048576 /* Union */) && declaredType.flags & 1048576 /* Union */ ? declaredType : computedType;
       if (type.flags & 1048576 /* Union */) {
         const access = getCandidateDiscriminantPropertyAccess(expr);
         if (access) {
@@ -164642,11 +164668,11 @@ function provideInlayHints(context) {
   function isSignatureSupportingReturnAnnotation(node) {
     return isArrowFunction(node) || isFunctionExpression(node) || isFunctionDeclaration(node) || isMethodDeclaration(node) || isGetAccessorDeclaration(node);
   }
-  function addParameterHints(text, parameter, position, isFirstVariadicArgument, sourceFile) {
+  function addParameterHints(text, parameter, position, isFirstVariadicArgument) {
     let hintText = `${isFirstVariadicArgument ? "..." : ""}${text}`;
     let displayParts;
     if (shouldUseInteractiveInlayHints(preferences)) {
-      displayParts = [getNodeDisplayPart(hintText, parameter, sourceFile), { text: ":" }];
+      displayParts = [getNodeDisplayPart(hintText, parameter), { text: ":" }];
       hintText = "";
     } else {
       hintText += ":";
@@ -164718,7 +164744,6 @@ function provideInlayHints(context) {
     if (!signature || !candidates.length) {
       return;
     }
-    const sourceFile = shouldUseInteractiveInlayHints(preferences) ? expr.getSourceFile() : void 0;
     let signatureParamPos = 0;
     for (const originalArg of args) {
       const arg = skipParentheses(originalArg);
@@ -164753,7 +164778,7 @@ function provideInlayHints(context) {
         if (leadingCommentsContainsParameterName(arg, name)) {
           continue;
         }
-        addParameterHints(name, parameter, originalArg.getStart(), isFirstVariadicArgument, sourceFile);
+        addParameterHints(name, parameter, originalArg.getStart(), isFirstVariadicArgument);
       }
     }
   }
@@ -164889,7 +164914,8 @@ function provideInlayHints(context) {
     }
     return true;
   }
-  function getNodeDisplayPart(text, node, sourceFile) {
+  function getNodeDisplayPart(text, node) {
+    const sourceFile = node.getSourceFile();
     return {
       text,
       span: createTextSpanFromNode(node, sourceFile),
@@ -167688,11 +167714,12 @@ function getSymbolDisplayPartsDocumentationAndSymbolKindWorker(typeChecker, symb
   if (documentation.length === 0 && isIdentifier(location) && symbol.valueDeclaration && isBindingElement(symbol.valueDeclaration)) {
     const declaration = symbol.valueDeclaration;
     const parent2 = declaration.parent;
-    if (isIdentifier(declaration.name) && isObjectBindingPattern(parent2)) {
-      const name = getTextOfIdentifierOrLiteral(declaration.name);
+    const name = declaration.propertyName || declaration.name;
+    if (isIdentifier(name) && isObjectBindingPattern(parent2)) {
+      const propertyName = getTextOfIdentifierOrLiteral(name);
       const objectType = typeChecker.getTypeAtLocation(parent2);
       documentation = firstDefined(objectType.isUnion() ? objectType.types : [objectType], (t) => {
-        const prop = t.getProperty(name);
+        const prop = t.getProperty(propertyName);
         return prop ? prop.getDocumentationComment(typeChecker) : void 0;
       }) || emptyArray;
     }
@@ -183575,14 +183602,22 @@ Project '${project.projectName}' (${ProjectKind[project.projectKind]}) ${counter
       return {
         ...hint,
         position: scriptInfo.positionToLineOffset(position),
-        displayParts: displayParts == null ? void 0 : displayParts.map(({ text, span, file: file2 }) => ({
-          text,
-          span: span && {
-            start: scriptInfo.positionToLineOffset(span.start),
-            end: scriptInfo.positionToLineOffset(span.start + span.length),
-            file: file2
+        displayParts: displayParts == null ? void 0 : displayParts.map(({ text, span, file: file2 }) => {
+          if (span) {
+            Debug.assertIsDefined(file2, "Target file should be defined together with its span.");
+            const scriptInfo2 = this.projectService.getScriptInfo(file2);
+            return {
+              text,
+              span: {
+                start: scriptInfo2.positionToLineOffset(span.start),
+                end: scriptInfo2.positionToLineOffset(span.start + span.length),
+                file: file2
+              }
+            };
+          } else {
+            return { text };
           }
-        }))
+        })
       };
     });
   }