typescript 5.1.0-dev.20230308 → 5.1.0-dev.20230310

package/lib/lib.webworker.iterable.d.ts

@@ -20,6 +20,27 @@ and limitations under the License.
 /// Worker Iterable APIs
 /////////////////////////////
 
+interface CSSNumericArray {
+    [Symbol.iterator](): IterableIterator<CSSNumericValue>;
+    entries(): IterableIterator<[number, CSSNumericValue]>;
+    keys(): IterableIterator<number>;
+    values(): IterableIterator<CSSNumericValue>;
+}
+
+interface CSSTransformValue {
+    [Symbol.iterator](): IterableIterator<CSSTransformComponent>;
+    entries(): IterableIterator<[number, CSSTransformComponent]>;
+    keys(): IterableIterator<number>;
+    values(): IterableIterator<CSSTransformComponent>;
+}
+
+interface CSSUnparsedValue {
+    [Symbol.iterator](): IterableIterator<CSSUnparsedSegment>;
+    entries(): IterableIterator<[number, CSSUnparsedSegment]>;
+    keys(): IterableIterator<number>;
+    values(): IterableIterator<CSSUnparsedSegment>;
+}
+
 interface Cache {
     addAll(requests: Iterable<RequestInfo>): Promise<void>;
 }
@@ -82,6 +103,13 @@ interface MessageEvent<T = any> {
     initMessageEvent(type: string, bubbles?: boolean, cancelable?: boolean, data?: any, origin?: string, lastEventId?: string, source?: MessageEventSource | null, ports?: Iterable<MessagePort>): void;
 }
 
+interface StylePropertyMapReadOnly {
+    [Symbol.iterator](): IterableIterator<[string, Iterable<CSSStyleValue>]>;
+    entries(): IterableIterator<[string, Iterable<CSSStyleValue>]>;
+    keys(): IterableIterator<string>;
+    values(): IterableIterator<Iterable<CSSStyleValue>>;
+}
+
 interface SubtleCrypto {
     deriveKey(algorithm: AlgorithmIdentifier | EcdhKeyDeriveParams | HkdfParams | Pbkdf2Params, baseKey: CryptoKey, derivedKeyType: AlgorithmIdentifier | AesDerivedKeyParams | HmacImportParams | HkdfParams | Pbkdf2Params, extractable: boolean, keyUsages: Iterable<KeyUsage>): Promise<CryptoKey>;
     generateKey(algorithm: RsaHashedKeyGenParams | EcKeyGenParams, extractable: boolean, keyUsages: ReadonlyArray<KeyUsage>): Promise<CryptoKeyPair>;

package/lib/tsc.js

@@ -23,7 +23,7 @@ var __export = (target, all) => {
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.1";
-var version = `${versionMajorMinor}.0-dev.20230308`;
+var version = `${versionMajorMinor}.0-dev.20230310`;
 
 // src/compiler/core.ts
 var emptyArray = [];
@@ -4876,20 +4876,6 @@ function patchWriteFileEnsuringDirectory(sys2) {
     (path2) => sys2.directoryExists(path2)
   );
 }
-function getNodeMajorVersion() {
-  if (typeof process === "undefined") {
-    return void 0;
-  }
-  const version2 = process.version;
-  if (!version2) {
-    return void 0;
-  }
-  const dot = version2.indexOf(".");
-  if (dot === -1) {
-    return void 0;
-  }
-  return parseInt(version2.substring(1, dot));
-}
 var sys = (() => {
   const byteOrderMarkIndicator = "\uFEFF";
   function getNodeSystem() {
@@ -4906,14 +4892,12 @@ var sys = (() => {
     let activeSession;
     let profilePath = "./profile.cpuprofile";
     const Buffer2 = require("buffer").Buffer;
-    const nodeVersion = getNodeMajorVersion();
-    const isNode4OrLater = nodeVersion >= 4;
     const isLinuxOrMacOs = process.platform === "linux" || process.platform === "darwin";
     const platform = _os.platform();
     const useCaseSensitiveFileNames = isFileSystemCaseSensitive();
     const fsRealpath = !!_fs.realpathSync.native ? process.platform === "win32" ? fsRealPathHandlingLongPath : _fs.realpathSync.native : _fs.realpathSync;
     const executingFilePath = __filename.endsWith("sys.js") ? _path.join(_path.dirname(__dirname), "__fake__.js") : __filename;
-    const fsSupportsRecursiveFsWatch = isNode4OrLater && (process.platform === "win32" || process.platform === "darwin");
+    const fsSupportsRecursiveFsWatch = process.platform === "win32" || process.platform === "darwin";
     const getCurrentDirectory = memoize(() => process.cwd());
     const { watchFile: watchFile2, watchDirectory } = createSystemWatchFunctions({
       pollingWatchFileWorker: fsWatchFileWorker,
@@ -41107,6 +41091,8 @@ function createBinder() {
           declareSymbolAndAddToSymbolTable(node, 1 /* FunctionScopedVariable */, 111550 /* FunctionScopedVariableExcludes */);
         }
         break;
+      case 265 /* ModuleDeclaration */:
+        break;
       default:
         Debug.failBadSyntaxKind(thisContainer);
     }
@@ -52677,10 +52663,9 @@ function createTypeChecker(host) {
     return [sig.parameters];
     function expandSignatureParametersWithTupleMembers(restType, restIndex) {
       const elementTypes = getTypeArguments(restType);
-      const associatedNames = restType.target.labeledElementDeclarations;
+      const associatedNames = getUniqAssociatedNamesFromTupleType(restType);
       const restParams = map(elementTypes, (t, i) => {
-        const tupleLabelName = !!associatedNames && getTupleElementLabel(associatedNames[i]);
-        const name = tupleLabelName || getParameterNameAtPosition(sig, restIndex + i, restType);
+        const name = associatedNames && associatedNames[i] ? associatedNames[i] : getParameterNameAtPosition(sig, restIndex + i, restType);
         const flags = restType.target.elementFlags[i];
         const checkFlags = flags & 12 /* Variable */ ? 32768 /* RestParameter */ : flags & 2 /* Optional */ ? 16384 /* OptionalParameter */ : 0;
         const symbol = createSymbol(1 /* FunctionScopedVariable */, name, checkFlags);
@@ -52689,6 +52674,20 @@ function createTypeChecker(host) {
       });
       return concatenate(sig.parameters.slice(0, restIndex), restParams);
     }
+    function getUniqAssociatedNamesFromTupleType(type) {
+      const associatedNamesMap = /* @__PURE__ */ new Map();
+      return map(type.target.labeledElementDeclarations, (labeledElement) => {
+        const name = getTupleElementLabel(labeledElement);
+        const prevCounter = associatedNamesMap.get(name);
+        if (prevCounter === void 0) {
+          associatedNamesMap.set(name, 1);
+          return name;
+        } else {
+          associatedNamesMap.set(name, prevCounter + 1);
+          return `${name}_${prevCounter}`;
+        }
+      });
+    }
   }
   function getDefaultConstructSignatures(classType) {
     const baseConstructorType = getBaseConstructorTypeOfClass(classType);
@@ -67268,13 +67267,14 @@ function createTypeChecker(host) {
     const elementFlags = [];
     pushCachedContextualType(node);
     const inDestructuringPattern = isAssignmentTarget(node);
-    const inConstContext = isConstContext(node);
+    const isSpreadIntoCallOrNew = isSpreadElement(node.parent) && isCallOrNewExpression(node.parent.parent);
+    const inConstContext = isSpreadIntoCallOrNew || isConstContext(node);
     const contextualType = getApparentTypeOfContextualType(
       node,
       /*contextFlags*/
       void 0
     );
-    const inTupleContext = !!contextualType && someType(contextualType, isTupleLikeType);
+    const inTupleContext = isSpreadIntoCallOrNew || !!contextualType && someType(contextualType, isTupleLikeType);
     let hasOmittedExpression = false;
     for (let i = 0; i < elementCount; i++) {
       const e = elements[i];
@@ -74870,8 +74870,7 @@ function createTypeChecker(host) {
           const subsequentName = subsequentNode.name;
           if (node.name && subsequentName && // both are private identifiers
           (isPrivateIdentifier(node.name) && isPrivateIdentifier(subsequentName) && node.name.escapedText === subsequentName.escapedText || // Both are computed property names
-          // TODO: GH#17345: These are methods, so handle computed name case. (`Always allowing computed property names is *not* the correct behavior!)
-          isComputedPropertyName(node.name) && isComputedPropertyName(subsequentName) || // Both are literal property names that are the same.
+          isComputedPropertyName(node.name) && isComputedPropertyName(subsequentName) && isTypeIdenticalTo(checkComputedPropertyName(node.name), checkComputedPropertyName(subsequentName)) || // Both are literal property names that are the same.
           isPropertyNameLiteral(node.name) && isPropertyNameLiteral(subsequentName) && getEscapedTextOfIdentifierOrLiteral(node.name) === getEscapedTextOfIdentifierOrLiteral(subsequentName))) {
             const reportError = (node.kind === 172 /* MethodDeclaration */ || node.kind === 171 /* MethodSignature */) && isStatic(node) !== isStatic(subsequentNode);
             if (reportError) {

package/lib/tsserver.js

@@ -883,7 +883,6 @@ __export(server_exports, {
   getNodeForGeneratedName: () => getNodeForGeneratedName,
   getNodeId: () => getNodeId,
   getNodeKind: () => getNodeKind,
-  getNodeMajorVersion: () => getNodeMajorVersion,
   getNodeModifiers: () => getNodeModifiers,
   getNodeModulePathParts: () => getNodeModulePathParts,
   getNonAssignedNameOfDeclaration: () => getNonAssignedNameOfDeclaration,
@@ -2285,7 +2284,7 @@ module.exports = __toCommonJS(server_exports);
 
 // src/compiler/corePublic.ts
 var versionMajorMinor = "5.1";
-var version = `${versionMajorMinor}.0-dev.20230308`;
+var version = `${versionMajorMinor}.0-dev.20230310`;
 var Comparison = /* @__PURE__ */ ((Comparison3) => {
   Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
   Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -8315,20 +8314,6 @@ function patchWriteFileEnsuringDirectory(sys2) {
     (path2) => sys2.directoryExists(path2)
   );
 }
-function getNodeMajorVersion() {
-  if (typeof process === "undefined") {
-    return void 0;
-  }
-  const version2 = process.version;
-  if (!version2) {
-    return void 0;
-  }
-  const dot = version2.indexOf(".");
-  if (dot === -1) {
-    return void 0;
-  }
-  return parseInt(version2.substring(1, dot));
-}
 var sys = (() => {
   const byteOrderMarkIndicator = "\uFEFF";
   function getNodeSystem() {
@@ -8345,14 +8330,12 @@ var sys = (() => {
     let activeSession;
     let profilePath = "./profile.cpuprofile";
     const Buffer2 = require("buffer").Buffer;
-    const nodeVersion = getNodeMajorVersion();
-    const isNode4OrLater = nodeVersion >= 4;
     const isLinuxOrMacOs = process.platform === "linux" || process.platform === "darwin";
     const platform = _os.platform();
     const useCaseSensitiveFileNames = isFileSystemCaseSensitive();
     const fsRealpath = !!_fs.realpathSync.native ? process.platform === "win32" ? fsRealPathHandlingLongPath : _fs.realpathSync.native : _fs.realpathSync;
     const executingFilePath = __filename.endsWith("sys.js") ? _path.join(_path.dirname(__dirname), "__fake__.js") : __filename;
-    const fsSupportsRecursiveFsWatch = isNode4OrLater && (process.platform === "win32" || process.platform === "darwin");
+    const fsSupportsRecursiveFsWatch = process.platform === "win32" || process.platform === "darwin";
     const getCurrentDirectory = memoize(() => process.cwd());
     const { watchFile: watchFile2, watchDirectory } = createSystemWatchFunctions({
       pollingWatchFileWorker: fsWatchFileWorker,
@@ -45649,6 +45632,8 @@ function createBinder() {
           declareSymbolAndAddToSymbolTable(node, 1 /* FunctionScopedVariable */, 111550 /* FunctionScopedVariableExcludes */);
         }
         break;
+      case 265 /* ModuleDeclaration */:
+        break;
       default:
         Debug.failBadSyntaxKind(thisContainer);
     }
@@ -57267,10 +57252,9 @@ function createTypeChecker(host) {
     return [sig.parameters];
     function expandSignatureParametersWithTupleMembers(restType, restIndex) {
       const elementTypes = getTypeArguments(restType);
-      const associatedNames = restType.target.labeledElementDeclarations;
+      const associatedNames = getUniqAssociatedNamesFromTupleType(restType);
       const restParams = map(elementTypes, (t, i) => {
-        const tupleLabelName = !!associatedNames && getTupleElementLabel(associatedNames[i]);
-        const name = tupleLabelName || getParameterNameAtPosition(sig, restIndex + i, restType);
+        const name = associatedNames && associatedNames[i] ? associatedNames[i] : getParameterNameAtPosition(sig, restIndex + i, restType);
         const flags = restType.target.elementFlags[i];
         const checkFlags = flags & 12 /* Variable */ ? 32768 /* RestParameter */ : flags & 2 /* Optional */ ? 16384 /* OptionalParameter */ : 0;
         const symbol = createSymbol(1 /* FunctionScopedVariable */, name, checkFlags);
@@ -57279,6 +57263,20 @@ function createTypeChecker(host) {
       });
       return concatenate(sig.parameters.slice(0, restIndex), restParams);
     }
+    function getUniqAssociatedNamesFromTupleType(type) {
+      const associatedNamesMap = /* @__PURE__ */ new Map();
+      return map(type.target.labeledElementDeclarations, (labeledElement) => {
+        const name = getTupleElementLabel(labeledElement);
+        const prevCounter = associatedNamesMap.get(name);
+        if (prevCounter === void 0) {
+          associatedNamesMap.set(name, 1);
+          return name;
+        } else {
+          associatedNamesMap.set(name, prevCounter + 1);
+          return `${name}_${prevCounter}`;
+        }
+      });
+    }
   }
   function getDefaultConstructSignatures(classType) {
     const baseConstructorType = getBaseConstructorTypeOfClass(classType);
@@ -71858,13 +71856,14 @@ function createTypeChecker(host) {
     const elementFlags = [];
     pushCachedContextualType(node);
     const inDestructuringPattern = isAssignmentTarget(node);
-    const inConstContext = isConstContext(node);
+    const isSpreadIntoCallOrNew = isSpreadElement(node.parent) && isCallOrNewExpression(node.parent.parent);
+    const inConstContext = isSpreadIntoCallOrNew || isConstContext(node);
     const contextualType = getApparentTypeOfContextualType(
       node,
       /*contextFlags*/
       void 0
     );
-    const inTupleContext = !!contextualType && someType(contextualType, isTupleLikeType);
+    const inTupleContext = isSpreadIntoCallOrNew || !!contextualType && someType(contextualType, isTupleLikeType);
     let hasOmittedExpression = false;
     for (let i = 0; i < elementCount; i++) {
       const e = elements[i];
@@ -79460,8 +79459,7 @@ function createTypeChecker(host) {
           const subsequentName = subsequentNode.name;
           if (node.name && subsequentName && // both are private identifiers
           (isPrivateIdentifier(node.name) && isPrivateIdentifier(subsequentName) && node.name.escapedText === subsequentName.escapedText || // Both are computed property names
-          // TODO: GH#17345: These are methods, so handle computed name case. (`Always allowing computed property names is *not* the correct behavior!)
-          isComputedPropertyName(node.name) && isComputedPropertyName(subsequentName) || // Both are literal property names that are the same.
+          isComputedPropertyName(node.name) && isComputedPropertyName(subsequentName) && isTypeIdenticalTo(checkComputedPropertyName(node.name), checkComputedPropertyName(subsequentName)) || // Both are literal property names that are the same.
           isPropertyNameLiteral(node.name) && isPropertyNameLiteral(subsequentName) && getEscapedTextOfIdentifierOrLiteral(node.name) === getEscapedTextOfIdentifierOrLiteral(subsequentName))) {
             const reportError = (node.kind === 172 /* MethodDeclaration */ || node.kind === 171 /* MethodSignature */) && isStatic(node) !== isStatic(subsequentNode);
             if (reportError) {
@@ -143983,9 +143981,10 @@ function getInfo7(sourceFile, tokenPos, errorCode, checker, program) {
   if (!isMemberName(token))
     return void 0;
   if (isIdentifier(token) && hasInitializer(parent2) && parent2.initializer && isObjectLiteralExpression(parent2.initializer)) {
+    const targetType = checker.getContextualType(token) || checker.getTypeAtLocation(token);
     const properties = arrayFrom(checker.getUnmatchedProperties(
       checker.getTypeAtLocation(parent2.initializer),
-      checker.getTypeAtLocation(token),
+      targetType,
       /* requireOptionalProperties */
       false,
       /* matchDiscriminantProperties */
@@ -168865,7 +168864,6 @@ __export(ts_exports3, {
   getNodeForGeneratedName: () => getNodeForGeneratedName,
   getNodeId: () => getNodeId,
   getNodeKind: () => getNodeKind,
-  getNodeMajorVersion: () => getNodeMajorVersion,
   getNodeModifiers: () => getNodeModifiers,
   getNodeModulePathParts: () => getNodeModulePathParts,
   getNonAssignedNameOfDeclaration: () => getNonAssignedNameOfDeclaration,
@@ -181391,8 +181389,7 @@ function initializeNodeSystem() {
     }
   }
   const libDirectory = getDirectoryPath(normalizePath(sys2.getExecutingFilePath()));
-  const nodeVersion = getNodeMajorVersion();
-  const useWatchGuard = process.platform === "win32" && nodeVersion >= 4;
+  const useWatchGuard = process.platform === "win32";
   const originalWatchDirectory = sys2.watchDirectory.bind(sys2);
   const logger = createLogger();
   Debug.loggingHost = {
@@ -181947,7 +181944,7 @@ function start({ args, logger, cancellationToken, serverMode, unknownServerMode,
   logger.info(`Starting TS Server`);
   logger.info(`Version: ${version}`);
   logger.info(`Arguments: ${args.join(" ")}`);
-  logger.info(`Platform: ${platform} NodeVersion: ${getNodeMajorVersion()} CaseSensitive: ${sys.useCaseSensitiveFileNames}`);
+  logger.info(`Platform: ${platform} NodeVersion: ${process.version} CaseSensitive: ${sys.useCaseSensitiveFileNames}`);
   logger.info(`ServerMode: ${serverMode} hasUnknownServerMode: ${unknownServerMode}`);
   setStackTraceLimit();
   if (Debug.isDebugging) {
@@ -182825,7 +182822,6 @@ start(initializeNodeSystem(), require("os").platform());
   getNodeForGeneratedName,
   getNodeId,
   getNodeKind,
-  getNodeMajorVersion,
   getNodeModifiers,
   getNodeModulePathParts,
   getNonAssignedNameOfDeclaration,

package/lib/tsserverlibrary.d.ts

@@ -8285,7 +8285,6 @@ declare namespace ts {
         negative: boolean;
         base10Value: string;
     }
-    function getNodeMajorVersion(): number | undefined;
     enum FileWatcherEventKind {
         Created = 0,
         Changed = 1,

package/lib/tsserverlibrary.js

@@ -35,7 +35,7 @@ var ts = (() => {
     "src/compiler/corePublic.ts"() {
       "use strict";
       versionMajorMinor = "5.1";
-      version = `${versionMajorMinor}.0-dev.20230308`;
+      version = `${versionMajorMinor}.0-dev.20230310`;
       Comparison = /* @__PURE__ */ ((Comparison3) => {
         Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
         Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -6098,20 +6098,6 @@ ${lanes.join("\n")}
       (path2) => sys2.directoryExists(path2)
     );
   }
-  function getNodeMajorVersion() {
-    if (typeof process === "undefined") {
-      return void 0;
-    }
-    const version2 = process.version;
-    if (!version2) {
-      return void 0;
-    }
-    const dot = version2.indexOf(".");
-    if (dot === -1) {
-      return void 0;
-    }
-    return parseInt(version2.substring(1, dot));
-  }
   function setSys(s) {
     sys = s;
   }
@@ -6159,14 +6145,12 @@ ${lanes.join("\n")}
           let activeSession;
           let profilePath = "./profile.cpuprofile";
           const Buffer2 =   require("buffer").Buffer;
-          const nodeVersion = getNodeMajorVersion();
-          const isNode4OrLater = nodeVersion >= 4;
           const isLinuxOrMacOs = process.platform === "linux" || process.platform === "darwin";
           const platform = _os.platform();
           const useCaseSensitiveFileNames = isFileSystemCaseSensitive();
           const fsRealpath = !!_fs.realpathSync.native ? process.platform === "win32" ? fsRealPathHandlingLongPath : _fs.realpathSync.native : _fs.realpathSync;
           const executingFilePath = __filename.endsWith("sys.js") ? _path.join(_path.dirname(__dirname), "__fake__.js") : __filename;
-          const fsSupportsRecursiveFsWatch = isNode4OrLater && (process.platform === "win32" || process.platform === "darwin");
+          const fsSupportsRecursiveFsWatch = process.platform === "win32" || process.platform === "darwin";
           const getCurrentDirectory = memoize(() => process.cwd());
           const { watchFile: watchFile2, watchDirectory } = createSystemWatchFunctions({
             pollingWatchFileWorker: fsWatchFileWorker,
@@ -43552,6 +43536,8 @@ ${lanes.join("\n")}
             declareSymbolAndAddToSymbolTable(node, 1 /* FunctionScopedVariable */, 111550 /* FunctionScopedVariableExcludes */);
           }
           break;
+        case 265 /* ModuleDeclaration */:
+          break;
         default:
           Debug.failBadSyntaxKind(thisContainer);
       }
@@ -55078,10 +55064,9 @@ ${lanes.join("\n")}
       return [sig.parameters];
       function expandSignatureParametersWithTupleMembers(restType, restIndex) {
         const elementTypes = getTypeArguments(restType);
-        const associatedNames = restType.target.labeledElementDeclarations;
+        const associatedNames = getUniqAssociatedNamesFromTupleType(restType);
         const restParams = map(elementTypes, (t, i) => {
-          const tupleLabelName = !!associatedNames && getTupleElementLabel(associatedNames[i]);
-          const name = tupleLabelName || getParameterNameAtPosition(sig, restIndex + i, restType);
+          const name = associatedNames && associatedNames[i] ? associatedNames[i] : getParameterNameAtPosition(sig, restIndex + i, restType);
           const flags = restType.target.elementFlags[i];
           const checkFlags = flags & 12 /* Variable */ ? 32768 /* RestParameter */ : flags & 2 /* Optional */ ? 16384 /* OptionalParameter */ : 0;
           const symbol = createSymbol(1 /* FunctionScopedVariable */, name, checkFlags);
@@ -55090,6 +55075,20 @@ ${lanes.join("\n")}
         });
         return concatenate(sig.parameters.slice(0, restIndex), restParams);
       }
+      function getUniqAssociatedNamesFromTupleType(type) {
+        const associatedNamesMap = /* @__PURE__ */ new Map();
+        return map(type.target.labeledElementDeclarations, (labeledElement) => {
+          const name = getTupleElementLabel(labeledElement);
+          const prevCounter = associatedNamesMap.get(name);
+          if (prevCounter === void 0) {
+            associatedNamesMap.set(name, 1);
+            return name;
+          } else {
+            associatedNamesMap.set(name, prevCounter + 1);
+            return `${name}_${prevCounter}`;
+          }
+        });
+      }
     }
     function getDefaultConstructSignatures(classType) {
       const baseConstructorType = getBaseConstructorTypeOfClass(classType);
@@ -69669,13 +69668,14 @@ ${lanes.join("\n")}
       const elementFlags = [];
       pushCachedContextualType(node);
       const inDestructuringPattern = isAssignmentTarget(node);
-      const inConstContext = isConstContext(node);
+      const isSpreadIntoCallOrNew = isSpreadElement(node.parent) && isCallOrNewExpression(node.parent.parent);
+      const inConstContext = isSpreadIntoCallOrNew || isConstContext(node);
       const contextualType = getApparentTypeOfContextualType(
         node,
         /*contextFlags*/
         void 0
       );
-      const inTupleContext = !!contextualType && someType(contextualType, isTupleLikeType);
+      const inTupleContext = isSpreadIntoCallOrNew || !!contextualType && someType(contextualType, isTupleLikeType);
       let hasOmittedExpression = false;
       for (let i = 0; i < elementCount; i++) {
         const e = elements[i];
@@ -77271,8 +77271,7 @@ ${lanes.join("\n")}
             const subsequentName = subsequentNode.name;
             if (node.name && subsequentName && // both are private identifiers
             (isPrivateIdentifier(node.name) && isPrivateIdentifier(subsequentName) && node.name.escapedText === subsequentName.escapedText || // Both are computed property names
-            // TODO: GH#17345: These are methods, so handle computed name case. (`Always allowing computed property names is *not* the correct behavior!)
-            isComputedPropertyName(node.name) && isComputedPropertyName(subsequentName) || // Both are literal property names that are the same.
+            isComputedPropertyName(node.name) && isComputedPropertyName(subsequentName) && isTypeIdenticalTo(checkComputedPropertyName(node.name), checkComputedPropertyName(subsequentName)) || // Both are literal property names that are the same.
             isPropertyNameLiteral(node.name) && isPropertyNameLiteral(subsequentName) && getEscapedTextOfIdentifierOrLiteral(node.name) === getEscapedTextOfIdentifierOrLiteral(subsequentName))) {
               const reportError = (node.kind === 172 /* MethodDeclaration */ || node.kind === 171 /* MethodSignature */) && isStatic(node) !== isStatic(subsequentNode);
               if (reportError) {
@@ -142574,9 +142573,10 @@ ${lanes.join("\n")}
     if (!isMemberName(token))
       return void 0;
     if (isIdentifier(token) && hasInitializer(parent2) && parent2.initializer && isObjectLiteralExpression(parent2.initializer)) {
+      const targetType = checker.getContextualType(token) || checker.getTypeAtLocation(token);
       const properties = arrayFrom(checker.getUnmatchedProperties(
         checker.getTypeAtLocation(parent2.initializer),
-        checker.getTypeAtLocation(token),
+        targetType,
         /* requireOptionalProperties */
         false,
         /* matchDiscriminantProperties */
@@ -179474,7 +179474,6 @@ ${e.message}`;
     getNodeForGeneratedName: () => getNodeForGeneratedName,
     getNodeId: () => getNodeId,
     getNodeKind: () => getNodeKind,
-    getNodeMajorVersion: () => getNodeMajorVersion,
     getNodeModifiers: () => getNodeModifiers,
     getNodeModulePathParts: () => getNodeModulePathParts,
     getNonAssignedNameOfDeclaration: () => getNonAssignedNameOfDeclaration,
@@ -181831,7 +181830,6 @@ ${e.message}`;
     getNodeForGeneratedName: () => getNodeForGeneratedName,
     getNodeId: () => getNodeId,
     getNodeKind: () => getNodeKind,
-    getNodeMajorVersion: () => getNodeMajorVersion,
     getNodeModifiers: () => getNodeModifiers,
     getNodeModulePathParts: () => getNodeModulePathParts,
     getNonAssignedNameOfDeclaration: () => getNonAssignedNameOfDeclaration,

package/lib/typescript.d.ts

@@ -4342,7 +4342,6 @@ declare namespace ts {
         negative: boolean;
         base10Value: string;
     }
-    function getNodeMajorVersion(): number | undefined;
     enum FileWatcherEventKind {
         Created = 0,
         Changed = 1,

package/lib/typescript.js

@@ -35,7 +35,7 @@ var ts = (() => {
     "src/compiler/corePublic.ts"() {
       "use strict";
       versionMajorMinor = "5.1";
-      version = `${versionMajorMinor}.0-dev.20230308`;
+      version = `${versionMajorMinor}.0-dev.20230310`;
       Comparison = /* @__PURE__ */ ((Comparison3) => {
         Comparison3[Comparison3["LessThan"] = -1] = "LessThan";
         Comparison3[Comparison3["EqualTo"] = 0] = "EqualTo";
@@ -6098,20 +6098,6 @@ ${lanes.join("\n")}
       (path2) => sys2.directoryExists(path2)
     );
   }
-  function getNodeMajorVersion() {
-    if (typeof process === "undefined") {
-      return void 0;
-    }
-    const version2 = process.version;
-    if (!version2) {
-      return void 0;
-    }
-    const dot = version2.indexOf(".");
-    if (dot === -1) {
-      return void 0;
-    }
-    return parseInt(version2.substring(1, dot));
-  }
   function setSys(s) {
     sys = s;
   }
@@ -6159,14 +6145,12 @@ ${lanes.join("\n")}
           let activeSession;
           let profilePath = "./profile.cpuprofile";
           const Buffer2 =   require("buffer").Buffer;
-          const nodeVersion = getNodeMajorVersion();
-          const isNode4OrLater = nodeVersion >= 4;
           const isLinuxOrMacOs = process.platform === "linux" || process.platform === "darwin";
           const platform = _os.platform();
           const useCaseSensitiveFileNames = isFileSystemCaseSensitive();
           const fsRealpath = !!_fs.realpathSync.native ? process.platform === "win32" ? fsRealPathHandlingLongPath : _fs.realpathSync.native : _fs.realpathSync;
           const executingFilePath = __filename.endsWith("sys.js") ? _path.join(_path.dirname(__dirname), "__fake__.js") : __filename;
-          const fsSupportsRecursiveFsWatch = isNode4OrLater && (process.platform === "win32" || process.platform === "darwin");
+          const fsSupportsRecursiveFsWatch = process.platform === "win32" || process.platform === "darwin";
           const getCurrentDirectory = memoize(() => process.cwd());
           const { watchFile: watchFile2, watchDirectory } = createSystemWatchFunctions({
             pollingWatchFileWorker: fsWatchFileWorker,
@@ -43552,6 +43536,8 @@ ${lanes.join("\n")}
             declareSymbolAndAddToSymbolTable(node, 1 /* FunctionScopedVariable */, 111550 /* FunctionScopedVariableExcludes */);
           }
           break;
+        case 265 /* ModuleDeclaration */:
+          break;
         default:
           Debug.failBadSyntaxKind(thisContainer);
       }
@@ -55078,10 +55064,9 @@ ${lanes.join("\n")}
       return [sig.parameters];
       function expandSignatureParametersWithTupleMembers(restType, restIndex) {
         const elementTypes = getTypeArguments(restType);
-        const associatedNames = restType.target.labeledElementDeclarations;
+        const associatedNames = getUniqAssociatedNamesFromTupleType(restType);
         const restParams = map(elementTypes, (t, i) => {
-          const tupleLabelName = !!associatedNames && getTupleElementLabel(associatedNames[i]);
-          const name = tupleLabelName || getParameterNameAtPosition(sig, restIndex + i, restType);
+          const name = associatedNames && associatedNames[i] ? associatedNames[i] : getParameterNameAtPosition(sig, restIndex + i, restType);
           const flags = restType.target.elementFlags[i];
           const checkFlags = flags & 12 /* Variable */ ? 32768 /* RestParameter */ : flags & 2 /* Optional */ ? 16384 /* OptionalParameter */ : 0;
           const symbol = createSymbol(1 /* FunctionScopedVariable */, name, checkFlags);
@@ -55090,6 +55075,20 @@ ${lanes.join("\n")}
         });
         return concatenate(sig.parameters.slice(0, restIndex), restParams);
       }
+      function getUniqAssociatedNamesFromTupleType(type) {
+        const associatedNamesMap = /* @__PURE__ */ new Map();
+        return map(type.target.labeledElementDeclarations, (labeledElement) => {
+          const name = getTupleElementLabel(labeledElement);
+          const prevCounter = associatedNamesMap.get(name);
+          if (prevCounter === void 0) {
+            associatedNamesMap.set(name, 1);
+            return name;
+          } else {
+            associatedNamesMap.set(name, prevCounter + 1);
+            return `${name}_${prevCounter}`;
+          }
+        });
+      }
     }
     function getDefaultConstructSignatures(classType) {
       const baseConstructorType = getBaseConstructorTypeOfClass(classType);
@@ -69669,13 +69668,14 @@ ${lanes.join("\n")}
       const elementFlags = [];
       pushCachedContextualType(node);
       const inDestructuringPattern = isAssignmentTarget(node);
-      const inConstContext = isConstContext(node);
+      const isSpreadIntoCallOrNew = isSpreadElement(node.parent) && isCallOrNewExpression(node.parent.parent);
+      const inConstContext = isSpreadIntoCallOrNew || isConstContext(node);
       const contextualType = getApparentTypeOfContextualType(
         node,
         /*contextFlags*/
         void 0
       );
-      const inTupleContext = !!contextualType && someType(contextualType, isTupleLikeType);
+      const inTupleContext = isSpreadIntoCallOrNew || !!contextualType && someType(contextualType, isTupleLikeType);
       let hasOmittedExpression = false;
       for (let i = 0; i < elementCount; i++) {
         const e = elements[i];
@@ -77271,8 +77271,7 @@ ${lanes.join("\n")}
             const subsequentName = subsequentNode.name;
             if (node.name && subsequentName && // both are private identifiers
             (isPrivateIdentifier(node.name) && isPrivateIdentifier(subsequentName) && node.name.escapedText === subsequentName.escapedText || // Both are computed property names
-            // TODO: GH#17345: These are methods, so handle computed name case. (`Always allowing computed property names is *not* the correct behavior!)
-            isComputedPropertyName(node.name) && isComputedPropertyName(subsequentName) || // Both are literal property names that are the same.
+            isComputedPropertyName(node.name) && isComputedPropertyName(subsequentName) && isTypeIdenticalTo(checkComputedPropertyName(node.name), checkComputedPropertyName(subsequentName)) || // Both are literal property names that are the same.
             isPropertyNameLiteral(node.name) && isPropertyNameLiteral(subsequentName) && getEscapedTextOfIdentifierOrLiteral(node.name) === getEscapedTextOfIdentifierOrLiteral(subsequentName))) {
               const reportError = (node.kind === 172 /* MethodDeclaration */ || node.kind === 171 /* MethodSignature */) && isStatic(node) !== isStatic(subsequentNode);
               if (reportError) {
@@ -142588,9 +142587,10 @@ ${lanes.join("\n")}
     if (!isMemberName(token))
       return void 0;
     if (isIdentifier(token) && hasInitializer(parent2) && parent2.initializer && isObjectLiteralExpression(parent2.initializer)) {
+      const targetType = checker.getContextualType(token) || checker.getTypeAtLocation(token);
       const properties = arrayFrom(checker.getUnmatchedProperties(
         checker.getTypeAtLocation(parent2.initializer),
-        checker.getTypeAtLocation(token),
+        targetType,
         /* requireOptionalProperties */
         false,
         /* matchDiscriminantProperties */
@@ -168642,7 +168642,6 @@ ${options.prefix}` : "\n" : options.prefix
     getNodeForGeneratedName: () => getNodeForGeneratedName,
     getNodeId: () => getNodeId,
     getNodeKind: () => getNodeKind,
-    getNodeMajorVersion: () => getNodeMajorVersion,
     getNodeModifiers: () => getNodeModifiers,
     getNodeModulePathParts: () => getNodeModulePathParts,
     getNonAssignedNameOfDeclaration: () => getNonAssignedNameOfDeclaration,