typescript 4.7.0-dev.20220217 → 4.7.0-dev.20220221

package/lib/tsserverlibrary.js

@@ -294,7 +294,7 @@ var ts;
     // The following is baselined as a literal template type without intervention
     /** The version of the TypeScript compiler release */
     // eslint-disable-next-line @typescript-eslint/no-inferrable-types
-    ts.version = ts.versionMajorMinor + ".0-dev.20220217";
+    ts.version = ts.versionMajorMinor + ".0-dev.20220221";
     /* @internal */
     var Comparison;
     (function (Comparison) {
@@ -2617,7 +2617,7 @@ var ts;
         Debug.checkEachDefined = checkEachDefined;
         function assertNever(member, message, stackCrawlMark) {
             if (message === void 0) { message = "Illegal value:"; }
-            var detail = typeof member === "object" && ts.hasProperty(member, "kind") && ts.hasProperty(member, "pos") && formatSyntaxKind ? "SyntaxKind: " + formatSyntaxKind(member.kind) : JSON.stringify(member);
+            var detail = typeof member === "object" && ts.hasProperty(member, "kind") && ts.hasProperty(member, "pos") ? "SyntaxKind: " + formatSyntaxKind(member.kind) : JSON.stringify(member);
             return fail(message + " " + detail, stackCrawlMark || assertNever);
         }
         Debug.assertNever = assertNever;
@@ -9770,7 +9770,7 @@ var ts;
         Fix_all_implicit_this_errors: diag(95107, ts.DiagnosticCategory.Message, "Fix_all_implicit_this_errors_95107", "Fix all implicit-'this' errors"),
         Wrap_invalid_character_in_an_expression_container: diag(95108, ts.DiagnosticCategory.Message, "Wrap_invalid_character_in_an_expression_container_95108", "Wrap invalid character in an expression container"),
         Wrap_all_invalid_characters_in_an_expression_container: diag(95109, ts.DiagnosticCategory.Message, "Wrap_all_invalid_characters_in_an_expression_container_95109", "Wrap all invalid characters in an expression container"),
-        Visit_https_Colon_Slash_Slashaka_ms_Slashtsconfig_json_to_read_more_about_this_file: diag(95110, ts.DiagnosticCategory.Message, "Visit_https_Colon_Slash_Slashaka_ms_Slashtsconfig_json_to_read_more_about_this_file_95110", "Visit https://aka.ms/tsconfig.json to read more about this file"),
+        Visit_https_Colon_Slash_Slashaka_ms_Slashtsconfig_to_read_more_about_this_file: diag(95110, ts.DiagnosticCategory.Message, "Visit_https_Colon_Slash_Slashaka_ms_Slashtsconfig_to_read_more_about_this_file_95110", "Visit https://aka.ms/tsconfig to read more about this file"),
         Add_a_return_statement: diag(95111, ts.DiagnosticCategory.Message, "Add_a_return_statement_95111", "Add a return statement"),
         Remove_braces_from_arrow_function_body: diag(95112, ts.DiagnosticCategory.Message, "Remove_braces_from_arrow_function_body_95112", "Remove braces from arrow function body"),
         Wrap_the_following_body_with_parentheses_which_should_be_an_object_literal: diag(95113, ts.DiagnosticCategory.Message, "Wrap_the_following_body_with_parentheses_which_should_be_an_object_literal_95113", "Wrap the following body with parentheses which should be an object literal"),
@@ -40657,7 +40657,7 @@ var ts;
             var result = [];
             result.push("{");
             result.push(tab + "\"compilerOptions\": {");
-            result.push("" + tab + tab + "/* " + ts.getLocaleSpecificMessage(ts.Diagnostics.Visit_https_Colon_Slash_Slashaka_ms_Slashtsconfig_json_to_read_more_about_this_file) + " */");
+            result.push("" + tab + tab + "/* " + ts.getLocaleSpecificMessage(ts.Diagnostics.Visit_https_Colon_Slash_Slashaka_ms_Slashtsconfig_to_read_more_about_this_file) + " */");
             result.push("");
             // Print out each row, aligning all the descriptions on the same column.
             for (var _a = 0, entries_2 = entries; _a < entries_2.length; _a++) {
@@ -63189,10 +63189,6 @@ var ts;
             if (sourceRestType || targetRestType) {
                 void instantiateType(sourceRestType || targetRestType, reportUnreliableMarkers);
             }
-            if (sourceRestType && targetRestType && sourceCount !== targetCount) {
-                // We're not able to relate misaligned complex rest parameters
-                return 0 /* False */;
-            }
             var kind = target.declaration ? target.declaration.kind : 0 /* Unknown */;
             var strictVariance = !(checkMode & 3 /* Callback */) && strictFunctionTypes && kind !== 168 /* MethodDeclaration */ &&
                 kind !== 167 /* MethodSignature */ && kind !== 170 /* Constructor */;
@@ -70250,7 +70246,7 @@ var ts;
             var substituteConstraints = !(checkMode && checkMode & 2 /* Inferential */) &&
                 someType(type, isGenericTypeWithUnionConstraint) &&
                 (isConstraintPosition(type, reference) || hasContextualTypeWithNoGenericTypes(reference, checkMode));
-            return substituteConstraints ? mapType(type, function (t) { return t.flags & 465829888 /* Instantiable */ && !isMappedTypeGenericIndexedAccess(t) ? getBaseConstraintOrType(t) : t; }) : type;
+            return substituteConstraints ? mapType(type, function (t) { return t.flags & 465829888 /* Instantiable */ ? getBaseConstraintOrType(t) : t; }) : type;
         }
         function isExportOrExportExpression(location) {
             return !!ts.findAncestor(location, function (n) {
@@ -77571,7 +77567,7 @@ var ts;
                     if (operator === 55 /* AmpersandAmpersandToken */ || operator === 56 /* BarBarToken */ || operator === 60 /* QuestionQuestionToken */) {
                         if (operator === 55 /* AmpersandAmpersandToken */) {
                             var parent = ts.walkUpParenthesizedExpressions(node.parent);
-                            checkTestingKnownTruthyCallableOrAwaitableType(node.left, leftType, ts.isIfStatement(parent) ? parent.thenStatement : undefined);
+                            checkTestingKnownTruthyCallableOrAwaitableType(node.left, ts.isIfStatement(parent) ? parent.thenStatement : undefined);
                         }
                         checkTruthinessOfType(leftType, node.left);
                     }
@@ -78078,8 +78074,8 @@ var ts;
             return type;
         }
         function checkConditionalExpression(node, checkMode) {
-            var type = checkTruthinessExpression(node.condition);
-            checkTestingKnownTruthyCallableOrAwaitableType(node.condition, type, node.whenTrue);
+            checkTruthinessExpression(node.condition);
+            checkTestingKnownTruthyCallableOrAwaitableType(node.condition, node.whenTrue);
             var type1 = checkExpression(node.whenTrue, checkMode);
             var type2 = checkExpression(node.whenFalse, checkMode);
             return getUnionType([type1, type2], 2 /* Subtype */);
@@ -81235,50 +81231,59 @@ var ts;
         function checkIfStatement(node) {
             // Grammar checking
             checkGrammarStatementInAmbientContext(node);
-            var type = checkTruthinessExpression(node.expression);
-            checkTestingKnownTruthyCallableOrAwaitableType(node.expression, type, node.thenStatement);
+            checkTruthinessExpression(node.expression);
+            checkTestingKnownTruthyCallableOrAwaitableType(node.expression, node.thenStatement);
             checkSourceElement(node.thenStatement);
             if (node.thenStatement.kind === 235 /* EmptyStatement */) {
                 error(node.thenStatement, ts.Diagnostics.The_body_of_an_if_statement_cannot_be_the_empty_statement);
             }
             checkSourceElement(node.elseStatement);
         }
-        function checkTestingKnownTruthyCallableOrAwaitableType(condExpr, type, body) {
+        function checkTestingKnownTruthyCallableOrAwaitableType(condExpr, body) {
             if (!strictNullChecks)
                 return;
-            if (getFalsyFlags(type))
-                return;
-            var location = ts.isBinaryExpression(condExpr) ? condExpr.right : condExpr;
-            if (ts.isPropertyAccessExpression(location) && isTypeAssertion(location.expression)) {
-                return;
-            }
-            var testedNode = ts.isIdentifier(location) ? location
-                : ts.isPropertyAccessExpression(location) ? location.name
-                    : ts.isBinaryExpression(location) && ts.isIdentifier(location.right) ? location.right
-                        : undefined;
-            // While it technically should be invalid for any known-truthy value
-            // to be tested, we de-scope to functions and Promises unreferenced in
-            // the block as a heuristic to identify the most common bugs. There
-            // are too many false positives for values sourced from type
-            // definitions without strictNullChecks otherwise.
-            var callSignatures = getSignaturesOfType(type, 0 /* Call */);
-            var isPromise = !!getAwaitedTypeOfPromise(type);
-            if (callSignatures.length === 0 && !isPromise) {
-                return;
-            }
-            var testedSymbol = testedNode && getSymbolAtLocation(testedNode);
-            if (!testedSymbol && !isPromise) {
-                return;
-            }
-            var isUsed = testedSymbol && ts.isBinaryExpression(condExpr.parent) && isSymbolUsedInBinaryExpressionChain(condExpr.parent, testedSymbol)
-                || testedSymbol && body && isSymbolUsedInConditionBody(condExpr, body, testedNode, testedSymbol);
-            if (!isUsed) {
-                if (isPromise) {
-                    errorAndMaybeSuggestAwait(location, 
-                    /*maybeMissingAwait*/ true, ts.Diagnostics.This_condition_will_always_return_true_since_this_0_is_always_defined, getTypeNameForErrorDisplay(type));
+            helper(condExpr, body);
+            while (ts.isBinaryExpression(condExpr) && condExpr.operatorToken.kind === 56 /* BarBarToken */) {
+                condExpr = condExpr.left;
+                helper(condExpr, body);
+            }
+            function helper(condExpr, body) {
+                var location = ts.isBinaryExpression(condExpr) &&
+                    (condExpr.operatorToken.kind === 56 /* BarBarToken */ || condExpr.operatorToken.kind === 55 /* AmpersandAmpersandToken */)
+                    ? condExpr.right
+                    : condExpr;
+                var type = checkTruthinessExpression(location);
+                var isPropertyExpressionCast = ts.isPropertyAccessExpression(location) && isTypeAssertion(location.expression);
+                if (getFalsyFlags(type) || isPropertyExpressionCast)
+                    return;
+                // While it technically should be invalid for any known-truthy value
+                // to be tested, we de-scope to functions and Promises unreferenced in
+                // the block as a heuristic to identify the most common bugs. There
+                // are too many false positives for values sourced from type
+                // definitions without strictNullChecks otherwise.
+                var callSignatures = getSignaturesOfType(type, 0 /* Call */);
+                var isPromise = !!getAwaitedTypeOfPromise(type);
+                if (callSignatures.length === 0 && !isPromise) {
+                    return;
                 }
-                else {
-                    error(location, ts.Diagnostics.This_condition_will_always_return_true_since_this_function_is_always_defined_Did_you_mean_to_call_it_instead);
+                var testedNode = ts.isIdentifier(location) ? location
+                    : ts.isPropertyAccessExpression(location) ? location.name
+                        : ts.isBinaryExpression(location) && ts.isIdentifier(location.right) ? location.right
+                            : undefined;
+                var testedSymbol = testedNode && getSymbolAtLocation(testedNode);
+                if (!testedSymbol && !isPromise) {
+                    return;
+                }
+                var isUsed = testedSymbol && ts.isBinaryExpression(condExpr.parent) && isSymbolUsedInBinaryExpressionChain(condExpr.parent, testedSymbol)
+                    || testedSymbol && body && isSymbolUsedInConditionBody(condExpr, body, testedNode, testedSymbol);
+                if (!isUsed) {
+                    if (isPromise) {
+                        errorAndMaybeSuggestAwait(location, 
+                        /*maybeMissingAwait*/ true, ts.Diagnostics.This_condition_will_always_return_true_since_this_0_is_always_defined, getTypeNameForErrorDisplay(type));
+                    }
+                    else {
+                        error(location, ts.Diagnostics.This_condition_will_always_return_true_since_this_function_is_always_defined_Did_you_mean_to_call_it_instead);
+                    }
                 }
             }
         }
@@ -82467,9 +82472,9 @@ var ts;
             var containsArguments = containsArgumentsReference(node);
             if (containsArguments) {
                 var lastJSDocParam = ts.lastOrUndefined(jsdocParameters);
-                if (lastJSDocParam && ts.isIdentifier(lastJSDocParam.name) && lastJSDocParam.typeExpression &&
+                if (isJs && lastJSDocParam && ts.isIdentifier(lastJSDocParam.name) && lastJSDocParam.typeExpression &&
                     lastJSDocParam.typeExpression.type && !parameters.has(lastJSDocParam.name.escapedText) && !isArrayType(getTypeFromTypeNode(lastJSDocParam.typeExpression.type))) {
-                    errorOrSuggestion(isJs, lastJSDocParam.name, ts.Diagnostics.JSDoc_param_tag_has_name_0_but_there_is_no_parameter_with_that_name_It_would_match_arguments_if_it_had_an_array_type, ts.idText(lastJSDocParam.name));
+                    error(lastJSDocParam.name, ts.Diagnostics.JSDoc_param_tag_has_name_0_but_there_is_no_parameter_with_that_name_It_would_match_arguments_if_it_had_an_array_type, ts.idText(lastJSDocParam.name));
                 }
             }
             else {
@@ -82479,7 +82484,9 @@ var ts;
                         return;
                     }
                     if (ts.isQualifiedName(name)) {
-                        errorOrSuggestion(isJs, name, ts.Diagnostics.Qualified_name_0_is_not_allowed_without_a_leading_param_object_1, ts.entityNameToString(name), ts.entityNameToString(name.left));
+                        if (isJs) {
+                            error(name, ts.Diagnostics.Qualified_name_0_is_not_allowed_without_a_leading_param_object_1, ts.entityNameToString(name), ts.entityNameToString(name.left));
+                        }
                     }
                     else {
                         errorOrSuggestion(isJs, name, ts.Diagnostics.JSDoc_param_tag_has_name_0_but_there_is_no_parameter_with_that_name, ts.idText(name));
@@ -84072,10 +84079,10 @@ var ts;
                         }
                         // ECMA262: 15.2.1.1 It is a Syntax Error if the ExportedNames of ModuleItemList contains any duplicate entries.
                         // (TS Exceptions: namespaces, function overloads, enums, and interfaces)
-                        if (flags & (1920 /* Namespace */ | 64 /* Interface */ | 384 /* Enum */)) {
+                        if (flags & (1920 /* Namespace */ | 384 /* Enum */)) {
                             return;
                         }
-                        var exportedDeclarationsCount = ts.countWhere(declarations, isNotOverloadAndNotAccessor);
+                        var exportedDeclarationsCount = ts.countWhere(declarations, ts.and(isNotOverloadAndNotAccessor, ts.not(ts.isInterfaceDeclaration)));
                         if (flags & 524288 /* TypeAlias */ && exportedDeclarationsCount <= 2) {
                             // it is legal to merge type alias with other values
                             // so count should be either 1 (just type alias) or 2 (type alias + merged value)
@@ -126784,14 +126791,15 @@ var ts;
                 : "linkplain";
         var parts = [linkPart("{@" + prefix + " ")];
         if (!link.name) {
-            if (link.text)
+            if (link.text) {
                 parts.push(linkTextPart(link.text));
+            }
         }
         else {
             var symbol = checker === null || checker === void 0 ? void 0 : checker.getSymbolAtLocation(link.name);
             var suffix = findLinkNameEnd(link.text);
             var name = ts.getTextOfNode(link.name) + link.text.slice(0, suffix);
-            var text = link.text.slice(suffix);
+            var text = skipSeparatorFromLinkText(link.text.slice(suffix));
             var decl = (symbol === null || symbol === void 0 ? void 0 : symbol.valueDeclaration) || ((_a = symbol === null || symbol === void 0 ? void 0 : symbol.declarations) === null || _a === void 0 ? void 0 : _a[0]);
             if (decl) {
                 parts.push(linkNamePart(name, decl));
@@ -126806,6 +126814,15 @@ var ts;
         return parts;
     }
     ts.buildLinkParts = buildLinkParts;
+    function skipSeparatorFromLinkText(text) {
+        var pos = 0;
+        if (text.charCodeAt(pos++) === 124 /* bar */) {
+            while (pos < text.length && text.charCodeAt(pos) === 32 /* space */)
+                pos++;
+            return text.slice(pos);
+        }
+        return text;
+    }
     function findLinkNameEnd(text) {
         if (text.indexOf("()") === 0)
             return 2;
@@ -138042,9 +138059,18 @@ var ts;
         JsDoc.getJsDocTagsFromDeclarations = getJsDocTagsFromDeclarations;
         function getDisplayPartsFromComment(comment, checker) {
             if (typeof comment === "string") {
-                return [ts.textPart(comment)];
+                return [ts.textPart(skipSeparatorFromComment(comment))];
             }
-            return ts.flatMap(comment, function (node) { return node.kind === 319 /* JSDocText */ ? [ts.textPart(node.text)] : ts.buildLinkParts(node, checker); });
+            return ts.flatMap(comment, function (node) { return node.kind === 319 /* JSDocText */ ? [ts.textPart(skipSeparatorFromComment(node.text))] : ts.buildLinkParts(node, checker); });
+        }
+        function skipSeparatorFromComment(text) {
+            var pos = 0;
+            if (text.charCodeAt(pos++) === 45 /* minus */) {
+                while (pos < text.length && text.charCodeAt(pos) === 32 /* space */)
+                    pos++;
+                return text.slice(pos);
+            }
+            return text;
         }
         function getCommentDisplayParts(tag, checker) {
             var comment = tag.comment, kind = tag.kind;
@@ -155422,7 +155448,7 @@ var ts;
                 /*dotDotDotToken*/ undefined, 
                 /*name*/ names && names[i] || "arg" + i, 
                 /*questionToken*/ minArgumentCount !== undefined && i >= minArgumentCount ? ts.factory.createToken(57 /* QuestionToken */) : undefined, 
-                /*type*/ inJs ? undefined : types && types[i] || ts.factory.createKeywordTypeNode(130 /* AnyKeyword */), 
+                /*type*/ inJs ? undefined : types && types[i] || ts.factory.createKeywordTypeNode(154 /* UnknownKeyword */), 
                 /*initializer*/ undefined);
                 parameters.push(newParameter);
             }
@@ -155450,11 +155476,10 @@ var ts;
             var maxArgsParameterSymbolNames = maxArgsSignature.parameters.map(function (symbol) { return symbol.name; });
             var parameters = createDummyParameters(maxNonRestArgs, maxArgsParameterSymbolNames, /* types */ undefined, minArgumentCount, /*inJs*/ false);
             if (someSigHasRestParameter) {
-                var anyArrayType = ts.factory.createArrayTypeNode(ts.factory.createKeywordTypeNode(130 /* AnyKeyword */));
                 var restParameter = ts.factory.createParameterDeclaration(
                 /*decorators*/ undefined, 
                 /*modifiers*/ undefined, ts.factory.createToken(25 /* DotDotDotToken */), maxArgsParameterSymbolNames[maxNonRestArgs] || "rest", 
-                /*questionToken*/ maxNonRestArgs >= minArgumentCount ? ts.factory.createToken(57 /* QuestionToken */) : undefined, anyArrayType, 
+                /*questionToken*/ maxNonRestArgs >= minArgumentCount ? ts.factory.createToken(57 /* QuestionToken */) : undefined, ts.factory.createArrayTypeNode(ts.factory.createKeywordTypeNode(154 /* UnknownKeyword */)), 
                 /*initializer*/ undefined);
                 parameters.push(restParameter);
             }
@@ -157823,7 +157848,7 @@ var ts;
                     ts.Debug.assert(nodeToCheck.pos <= nodeToCheck.end, "This failure could trigger https://github.com/Microsoft/TypeScript/issues/20809 (1)");
                     // For understanding how skipTrivia functioned:
                     ts.Debug.assert(!ts.positionIsSynthesized(nodeToCheck.pos), "This failure could trigger https://github.com/Microsoft/TypeScript/issues/20809 (2)");
-                    if (!ts.isStatement(nodeToCheck) && !(ts.isExpressionNode(nodeToCheck) && isExtractableExpression(nodeToCheck))) {
+                    if (!ts.isStatement(nodeToCheck) && !(ts.isExpressionNode(nodeToCheck) && isExtractableExpression(nodeToCheck)) && !isStringLiteralJsxAttribute(nodeToCheck)) {
                         return [ts.createDiagnosticForNode(nodeToCheck, Messages.statementOrExpressionExpected)];
                     }
                     if (nodeToCheck.flags & 8388608 /* Ambient */) {
@@ -158003,13 +158028,16 @@ var ts;
                 if (ts.isStatement(node)) {
                     return [node];
                 }
-                else if (ts.isExpressionNode(node)) {
+                if (ts.isExpressionNode(node)) {
                     // If our selection is the expression in an ExpressionStatement, expand
                     // the selection to include the enclosing Statement (this stops us
                     // from trying to care about the return value of the extracted function
                     // and eliminates double semicolon insertion in certain scenarios)
                     return ts.isExpressionStatement(node.parent) ? [node.parent] : node;
                 }
+                if (isStringLiteralJsxAttribute(node)) {
+                    return node;
+                }
                 return undefined;
             }
             function isScope(node) {
@@ -158819,7 +158847,7 @@ var ts;
                 // Unfortunately, this code takes advantage of the knowledge that the generated method
                 // will use the contextual type of an expression as the return type of the extracted
                 // method (and will therefore "use" all the types involved).
-                if (inGenericContext && !isReadonlyArray(targetRange.range)) {
+                if (inGenericContext && !isReadonlyArray(targetRange.range) && !ts.isJsxAttribute(targetRange.range)) {
                     var contextualType = checker.getContextualType(targetRange.range); // TODO: GH#18217
                     recordTypeParameterUsages(contextualType);
                 }
@@ -159144,7 +159172,11 @@ var ts;
                 }
             }
             function isInJSXContent(node) {
-                return (ts.isJsxElement(node) || ts.isJsxSelfClosingElement(node) || ts.isJsxFragment(node)) && (ts.isJsxElement(node.parent) || ts.isJsxFragment(node.parent));
+                return isStringLiteralJsxAttribute(node) ||
+                    (ts.isJsxElement(node) || ts.isJsxSelfClosingElement(node) || ts.isJsxFragment(node)) && (ts.isJsxElement(node.parent) || ts.isJsxFragment(node.parent));
+            }
+            function isStringLiteralJsxAttribute(node) {
+                return ts.isStringLiteral(node) && node.parent && ts.isJsxAttribute(node.parent);
             }
         })(extractSymbol = refactor.extractSymbol || (refactor.extractSymbol = {}));
     })(refactor = ts.refactor || (ts.refactor = {}));