typescript-to-lua 1.8.2 → 1.9.0

package/dist/transformation/utils/diagnostics.d.ts

@@ -83,6 +83,9 @@ export declare const annotationRemoved: ((node: ts.Node, kind: AnnotationKind) =
 export declare const annotationDeprecated: ((node: ts.Node, kind: AnnotationKind) => ts.Diagnostic) & {
     code: number;
 };
+export declare const truthyOnlyConditionalValue: ((node: ts.Node, ...args: any[]) => ts.Diagnostic) & {
+    code: number;
+};
 export declare const notAllowedOptionalAssignment: ((node: ts.Node, ...args: any[]) => ts.Diagnostic) & {
     code: number;
 };

package/dist/transformation/utils/diagnostics.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.undefinedInArrayLiteral = exports.unsupportedOptionalCompileMembersOnly = exports.unsupportedBuiltinOptionalCall = exports.awaitMustBeInAsyncFunction = exports.notAllowedOptionalAssignment = exports.annotationDeprecated = exports.annotationRemoved = exports.invalidCallExtensionUse = exports.invalidMultiReturnAccess = exports.invalidMultiTypeToEmptyPatternOrArrayLiteral = exports.invalidMultiTypeToNonArrayLiteral = exports.invalidMultiFunctionReturnType = exports.invalidMultiFunctionUse = exports.unsupportedVarDeclaration = exports.invalidAmbientIdentifierName = exports.unsupportedProperty = exports.unsupportedForTargetButOverrideAvailable = exports.unsupportedForTarget = exports.unsupportedRightShiftOperator = exports.unsupportedAccessorInObjectLiteral = exports.invalidPairsIterableWithoutDestructuring = exports.invalidMultiIterableWithoutDestructuring = exports.invalidRangeControlVariable = exports.invalidVarargUse = exports.invalidRangeUse = exports.annotationInvalidArgumentCount = exports.decoratorInvalidContext = exports.unsupportedOverloadAssignment = exports.unsupportedSelfFunctionConversion = exports.unsupportedNoSelfFunctionConversion = exports.forbiddenForIn = exports.unsupportedNodeKind = void 0;
+exports.undefinedInArrayLiteral = exports.unsupportedOptionalCompileMembersOnly = exports.unsupportedBuiltinOptionalCall = exports.awaitMustBeInAsyncFunction = exports.notAllowedOptionalAssignment = exports.truthyOnlyConditionalValue = exports.annotationDeprecated = exports.annotationRemoved = exports.invalidCallExtensionUse = exports.invalidMultiReturnAccess = exports.invalidMultiTypeToEmptyPatternOrArrayLiteral = exports.invalidMultiTypeToNonArrayLiteral = exports.invalidMultiFunctionReturnType = exports.invalidMultiFunctionUse = exports.unsupportedVarDeclaration = exports.invalidAmbientIdentifierName = exports.unsupportedProperty = exports.unsupportedForTargetButOverrideAvailable = exports.unsupportedForTarget = exports.unsupportedRightShiftOperator = exports.unsupportedAccessorInObjectLiteral = exports.invalidPairsIterableWithoutDestructuring = exports.invalidMultiIterableWithoutDestructuring = exports.invalidRangeControlVariable = exports.invalidVarargUse = exports.invalidRangeUse = exports.annotationInvalidArgumentCount = exports.decoratorInvalidContext = exports.unsupportedOverloadAssignment = exports.unsupportedSelfFunctionConversion = exports.unsupportedNoSelfFunctionConversion = exports.forbiddenForIn = exports.unsupportedNodeKind = void 0;
 const ts = require("typescript");
 const CompilerOptions_1 = require("../../CompilerOptions");
 const utils_1 = require("../../utils");
@@ -57,6 +57,7 @@ exports.annotationRemoved = createErrorDiagnosticFactory((kind) => `'@${kind}' h
     `See https://typescripttolua.github.io/docs/advanced/compiler-annotations#${kind.toLowerCase()} for more information.`);
 exports.annotationDeprecated = createWarningDiagnosticFactory((kind) => `'@${kind}' is deprecated and will be removed in a future update. Please update your code before upgrading to the next release, otherwise your project will no longer compile. ` +
     `See https://typescripttolua.github.io/docs/advanced/compiler-annotations#${kind.toLowerCase()} for more information.`);
+exports.truthyOnlyConditionalValue = createWarningDiagnosticFactory("Numbers and strings will always evaluate to true in Lua. Explicitly check the value with ===.");
 exports.notAllowedOptionalAssignment = createErrorDiagnosticFactory("The left-hand side of an assignment expression may not be an optional property access.");
 exports.awaitMustBeInAsyncFunction = createErrorDiagnosticFactory("Await can only be used inside async functions.");
 exports.unsupportedBuiltinOptionalCall = createErrorDiagnosticFactory("Optional calls are not supported for builtin or language extension functions.");

package/dist/transformation/visitors/access.js

@@ -6,11 +6,13 @@ const lua = require("../../LuaAST");
 const builtins_1 = require("../builtins");
 const annotations_1 = require("../utils/annotations");
 const diagnostics_1 = require("../utils/diagnostics");
+const language_extensions_1 = require("../utils/language-extensions");
 const lua_ast_1 = require("../utils/lua-ast");
 const lualib_1 = require("../utils/lualib");
 const typescript_1 = require("../utils/typescript");
 const enum_1 = require("./enum");
 const expression_list_1 = require("./expression-list");
+const call_extension_1 = require("./language-extensions/call-extension");
 const multi_1 = require("./language-extensions/multi");
 const optional_chaining_1 = require("./optional-chaining");
 function addOneToArrayAccessArgument(context, node, index) {
@@ -108,6 +110,15 @@ function transformPropertyAccessExpressionWithCapture(context, node, thisValueCa
         // If this assumption is no longer true, this may need to be updated.
         return { expression: builtinResult };
     }
+    if (ts.isIdentifier(node.expression) &&
+        node.parent &&
+        (!ts.isCallExpression(node.parent) || node.parent.expression !== node)) {
+        // Check if this is a method call extension that is not used as a call
+        const extensionType = (0, language_extensions_1.getExtensionKindForNode)(context, node);
+        if (extensionType && call_extension_1.callExtensions.has(extensionType)) {
+            context.diagnostics.push((0, diagnostics_1.invalidCallExtensionUse)(node));
+        }
+    }
     const table = context.transformExpression(node.expression);
     if (thisValueCapture) {
         const thisValue = (0, optional_chaining_1.captureThisValue)(context, table, thisValueCapture, node.expression);

package/dist/transformation/visitors/conditional.d.ts

@@ -3,3 +3,4 @@ import * as lua from "../../LuaAST";
 import { FunctionVisitor, TransformationContext } from "../context";
 export declare const transformConditionalExpression: FunctionVisitor<ts.ConditionalExpression>;
 export declare function transformIfStatement(statement: ts.IfStatement, context: TransformationContext): lua.IfStatement;
+export declare function checkOnlyTruthyCondition(condition: ts.Expression, context: TransformationContext): void;

package/dist/transformation/visitors/conditional.js

@@ -1,12 +1,13 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.transformIfStatement = exports.transformConditionalExpression = void 0;
+exports.checkOnlyTruthyCondition = exports.transformIfStatement = exports.transformConditionalExpression = void 0;
 const ts = require("typescript");
 const lua = require("../../LuaAST");
 const preceding_statements_1 = require("../utils/preceding-statements");
 const scope_1 = require("../utils/scope");
 const block_1 = require("./block");
 const typescript_1 = require("../utils/typescript");
+const diagnostics_1 = require("../utils/diagnostics");
 function transformProtectedConditionalExpression(context, expression, condition, whenTrue, whenFalse) {
     const tempVar = context.createTempNameForNode(expression.condition);
     const trueStatements = whenTrue[0].concat(lua.createAssignmentStatement(lua.cloneIdentifier(tempVar), whenTrue[1], expression.whenTrue));
@@ -19,6 +20,8 @@ function transformProtectedConditionalExpression(context, expression, condition,
     return lua.cloneIdentifier(tempVar);
 }
 const transformConditionalExpression = (expression, context) => {
+    // Check if we need to add diagnostic about Lua truthiness
+    checkOnlyTruthyCondition(expression.condition, context);
     const condition = (0, preceding_statements_1.transformInPrecedingStatementScope)(context, () => context.transformExpression(expression.condition));
     const whenTrue = (0, preceding_statements_1.transformInPrecedingStatementScope)(context, () => context.transformExpression(expression.whenTrue));
     const whenFalse = (0, preceding_statements_1.transformInPrecedingStatementScope)(context, () => context.transformExpression(expression.whenFalse));
@@ -35,6 +38,8 @@ const transformConditionalExpression = (expression, context) => {
 exports.transformConditionalExpression = transformConditionalExpression;
 function transformIfStatement(statement, context) {
     context.pushScope(scope_1.ScopeType.Conditional);
+    // Check if we need to add diagnostic about Lua truthiness
+    checkOnlyTruthyCondition(statement.expression, context);
     const condition = context.transformExpression(statement.expression);
     const statements = (0, scope_1.performHoisting)(context, (0, block_1.transformBlockOrStatement)(context, statement.thenStatement));
     context.popScope();
@@ -70,4 +75,10 @@ function transformIfStatement(statement, context) {
     return lua.createIfStatement(condition, ifBlock);
 }
 exports.transformIfStatement = transformIfStatement;
+function checkOnlyTruthyCondition(condition, context) {
+    if (!(0, typescript_1.canBeFalsy)(context, context.checker.getTypeAtLocation(condition))) {
+        context.diagnostics.push((0, diagnostics_1.truthyOnlyConditionalValue)(condition));
+    }
+}
+exports.checkOnlyTruthyCondition = checkOnlyTruthyCondition;
 //# sourceMappingURL=conditional.js.map

package/dist/transformation/visitors/identifier.js

@@ -28,7 +28,10 @@ function transformNonValueIdentifier(context, identifier, symbol) {
         : (0, language_extensions_1.getExtensionKindForNode)(context, identifier);
     if (extensionKind) {
         if (call_extension_1.callExtensions.has(extensionKind)) {
-            context.diagnostics.push((0, diagnostics_1.invalidCallExtensionUse)(identifier));
+            // Avoid putting duplicate diagnostic on the name of a variable declaration, due to the inferred type
+            if (!(ts.isVariableDeclaration(identifier.parent) && identifier.parent.name === identifier)) {
+                context.diagnostics.push((0, diagnostics_1.invalidCallExtensionUse)(identifier));
+            }
             // fall through
         }
         else if ((0, identifier_1.isIdentifierExtensionValue)(symbol, extensionKind)) {

package/dist/transformation/visitors/loops/do-while.js

@@ -3,8 +3,11 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.transformDoStatement = exports.transformWhileStatement = void 0;
 const lua = require("../../../LuaAST");
 const preceding_statements_1 = require("../../utils/preceding-statements");
+const conditional_1 = require("../conditional");
 const utils_1 = require("./utils");
 const transformWhileStatement = (statement, context) => {
+    // Check if we need to add diagnostic about Lua truthiness
+    (0, conditional_1.checkOnlyTruthyCondition)(statement.expression, context);
     const body = (0, utils_1.transformLoopBody)(context, statement);
     let [conditionPrecedingStatements, condition] = (0, preceding_statements_1.transformInPrecedingStatementScope)(context, () => context.transformExpression(statement.expression));
     // If condition has preceding statements, ensure they are executed every iteration by using the form:
@@ -25,6 +28,8 @@ const transformWhileStatement = (statement, context) => {
 };
 exports.transformWhileStatement = transformWhileStatement;
 const transformDoStatement = (statement, context) => {
+    // Check if we need to add diagnostic about Lua truthiness
+    (0, conditional_1.checkOnlyTruthyCondition)(statement.expression, context);
     const body = lua.createDoStatement((0, utils_1.transformLoopBody)(context, statement));
     let [conditionPrecedingStatements, condition] = (0, preceding_statements_1.transformInPrecedingStatementScope)(context, () => (0, utils_1.invertCondition)(context.transformExpression(statement.expression)));
     // If condition has preceding statements, ensure they are executed every iteration by using the form:

package/dist/transpilation/bundle.js

@@ -66,14 +66,16 @@ function printStackTraceBundleOverride(rootNode) {
 }
 exports.printStackTraceBundleOverride = printStackTraceBundleOverride;
 function getBundleResult(program, files) {
+    var _a, _b, _c;
     const diagnostics = [];
     const options = program.getCompilerOptions();
     const bundleFile = (0, utils_1.cast)(options.luaBundle, utils_1.isNonNull);
     const entryModule = (0, utils_1.cast)(options.luaBundleEntry, utils_1.isNonNull);
     // Resolve project settings relative to project file.
-    const resolvedEntryModule = path.resolve((0, transpiler_1.getSourceDir)(program), entryModule);
+    const resolvedEntryModule = path.resolve((0, transpiler_1.getProjectRoot)(program), entryModule);
     const outputPath = path.resolve((0, transpiler_1.getEmitOutDir)(program), bundleFile);
-    if (program.getSourceFile(resolvedEntryModule) === undefined && program.getSourceFile(entryModule) === undefined) {
+    const entryModuleFilePath = (_b = (_a = program.getSourceFile(entryModule)) === null || _a === void 0 ? void 0 : _a.fileName) !== null && _b !== void 0 ? _b : (_c = program.getSourceFile(resolvedEntryModule)) === null || _c === void 0 ? void 0 : _c.fileName;
+    if (entryModuleFilePath === undefined) {
         diagnostics.push((0, diagnostics_1.couldNotFindBundleEntryPoint)(entryModule));
     }
     // For each file: ["<module path>"] = function() <lua content> end,
@@ -81,7 +83,7 @@ function getBundleResult(program, files) {
     // Create ____modules table containing all entries from moduleTableEntries
     const moduleTable = createModuleTableNode(moduleTableEntries);
     // return require("<entry module path>")
-    const entryPoint = `return require(${createModulePath(entryModule, program)}, ...)\n`;
+    const entryPoint = `return require(${createModulePath(entryModuleFilePath !== null && entryModuleFilePath !== void 0 ? entryModuleFilePath : entryModule, program)}, ...)\n`;
     const footers = [];
     if (options.sourceMapTraceback) {
         // Generates SourceMapTraceback for the entire file

package/language-extensions/index.d.ts

@@ -631,7 +631,7 @@ declare const LuaMap: (new <K extends AnyNotNil = AnyNotNil, V = any>() => LuaMa
  * @param V The type of the values stored in the table.
  */
 declare interface ReadonlyLuaMap<K extends AnyNotNil = AnyNotNil, V = any> extends LuaPairsIterable<K, V> {
-    get: LuaTableGetMethod<K, V>;
+    get: LuaTableGetMethod<K, V | undefined>;
     has: LuaTableHasMethod<K>;
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "typescript-to-lua",
-    "version": "1.8.2",
+    "version": "1.9.0",
     "description": "A generic TypeScript to Lua transpiler. Write your code in TypeScript and publish Lua!",
     "repository": "https://github.com/TypeScriptToLua/TypeScriptToLua",
     "homepage": "https://typescripttolua.github.io/",