typescript-language-server 5.1.0 → 5.1.1

package/CHANGELOG.md

@@ -1,6 +1,13 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [5.1.1](https://github.com/typescript-language-server/typescript-language-server/compare/v5.1.0...v5.1.1) (2025-11-05)
+
+
+### Bug Fixes
+
+* don't override formatting options with undefined values ([#1041](https://github.com/typescript-language-server/typescript-language-server/issues/1041)) ([4645124](https://github.com/typescript-language-server/typescript-language-server/commit/464512454a1f68bb6f1e270cf5c0c2be13cdaa54))
+
 ## [5.1.0](https://github.com/typescript-language-server/typescript-language-server/compare/v5.0.1...v5.1.0) (2025-10-31)
 
 

package/README.md

@@ -156,7 +156,7 @@ Request:
 {
     command: '_typescript.organizeImports'
     arguments: [
-        string,  // file URI
+        string,  // file path
         // Optional options:
         {
             // @deprecated - use "mode". Supported from Typescript 4.4+.
@@ -305,7 +305,7 @@ The `$/typescriptVersion` notification params include two properties:
 
 ### Workspace Configuration request for formatting settings
 
-Server asks the client for file-specific configuration options (`tabSize` and `insertSpaces`) that are required by `tsserver` to properly format the file edits when for example using "Organize imports" or performing other file modifications. Those options have to be dynamically provided by the client/editor since the values can differ for each file. For this reason server sends a `workspace/configuration` request with `scopeUri` equal to file's URI and `section` equal to `formattingOptions`. The client is expected to return a configuration that includes the following properties:
+Server asks the client for file-specific configuration options (`tabSize` and `insertSpaces`) that are required by `tsserver` to properly format file edits when for example using "Organize imports" or performing other file modifications. Those options have to be dynamically provided by the client/editor since the values can differ for each file. For this reason server sends a `workspace/configuration` request with `scopeUri` equal to file's URI and `section` equal to `formattingOptions`. The client is expected to return a configuration that includes the following properties:
 
 ```js
 {

package/lib/cli.mjs

@@ -21494,10 +21494,14 @@ class FileConfigurationManager {
   }
   async getFormattingOptions(document) {
     const formatConfiguration = await this.lspClient.getWorkspaceConfiguration(document.uri.toString(), 'formattingOptions') || {};
-    return {
-      tabSize: typeof formatConfiguration.tabSize === 'number' ? formatConfiguration.tabSize : undefined,
-      insertSpaces: typeof formatConfiguration.insertSpaces === 'boolean' ? formatConfiguration.insertSpaces : undefined
-    };
+    const options = {};
+    if (typeof formatConfiguration.tabSize === 'number') {
+      options.tabSize = formatConfiguration.tabSize;
+    }
+    if (typeof formatConfiguration.insertSpaces === 'boolean') {
+      options.insertSpaces = formatConfiguration.insertSpaces;
+    }
+    return options;
   }
   async ensureConfigurationOptions(document, options, token) {
     const currentOptions = this.getFileOptions(document, options);
@@ -23580,7 +23584,6 @@ class LspServer {
         const uri = this.tsClient.toResourceUri(cachedData.file);
         document = this.tsClient.toOpenDocument(uri);
         if (document) {
-          await this.fileConfigurationManager.ensureConfigurationForDocument(document, token);
           const response = await this.tsClient.interruptGetErr(() => this.tsClient.execute(CommandTypes.CompletionDetails, cachedData, token));
           if (response.type !== 'response' || !response.body?.length) {
             return item;