typescript-language-server 4.4.0 → 4.4.1

package/CHANGELOG.md

@@ -1,6 +1,14 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [4.4.1](https://github.com/typescript-language-server/typescript-language-server/compare/v4.4.0...v4.4.1) (2025-09-12)
+
+
+### Bug Fixes
+
+* align completions code with upstream ([#992](https://github.com/typescript-language-server/typescript-language-server/issues/992)) ([f0eb0f5](https://github.com/typescript-language-server/typescript-language-server/commit/f0eb0f5abb981cbf496d5fc9e2b2e49150437c12))
+* don't filter out 'warning' TS completion kinds ([ab388a0](https://github.com/typescript-language-server/typescript-language-server/commit/ab388a010cbe8353af6c17964e9e2567fa73cce0))
+
 ## [4.4.0](https://github.com/typescript-language-server/typescript-language-server/compare/v4.3.4...v4.4.0) (2025-08-05)
 
 

package/README.md

@@ -4,14 +4,9 @@
 
 # TypeScript Language Server
 
-[Language Server Protocol](https://github.com/Microsoft/language-server-protocol) implementation for TypeScript wrapping `tsserver`.
-
-Originally based on concepts and ideas from https://github.com/prabirshrestha/typescript-language-server and maintained by [TypeFox](https://typefox.io). The core logic for interacting with `tsserver` is nowadays mostly based on the code of the `TypeScript Language Features` VSCode bundled extension maintained in https://github.com/microsoft/vscode.
-
-Maintained by a [community of contributors](https://github.com/typescript-language-server/typescript-language-server/graphs/contributors) like you.
-
 <!-- MarkdownTOC -->
 
+- [What is it, exactly?](#what-is-it-exactly)
 - [Installing](#installing)
 - [Running the language server](#running-the-language-server)
 - [CLI Options](#cli-options)
@@ -38,6 +33,16 @@ Maintained by a [community of contributors](https://github.com/typescript-langua
 
 <!-- /MarkdownTOC -->
 
+## What is it, exactly?
+
+The [TypeScript](https://github.com/microsoft/TypeScript) project/package includes a `tsserver` component which provides a custom API that can be used for gathering various intelligence about a typescript/javascript project. The [VSCode](https://github.com/microsoft/vscode) team has built a project called `Typescript Language Features` (and bundled it as an internal extension in VSCode) that provides code intelligence for your javascript and typescript projects by utilizing that `tsserver` API. Since that extension doesn't use the standardized [Language Server Protocol](https://microsoft.github.io/language-server-protocol/) to communicate with the editor, other editors that implement LSP can't directly utilize it. Here is where the `TypeScript Language Server` project comes in with the aim to provide a thin LSP interface on top of that extension's code base for the benefit of all other editors that implement the LSP protocol.
+
+Originally based on concepts and ideas from https://github.com/prabirshrestha/typescript-language-server and maintained by [TypeFox](https://typefox.io). Currently maintained by a [community of contributors](https://github.com/typescript-language-server/typescript-language-server/graphs/contributors) like you.
+
+This project is not directly associated with Microsoft and is not used in their [VSCode](https://github.com/microsoft/vscode) editor. If you have an issue with VSCode functionality, report it in their repository instead.
+
+Currently Microsoft is working on [TypeScript 7](https://github.com/microsoft/typescript-go) written natively in the go language that will include the LSP implementation and will hopefully supersede this project.
+
 ## Installing
 
 ```sh

package/lib/cli.mjs

@@ -14717,6 +14717,8 @@ KindModifiers.optional = 'optional';
 
 KindModifiers.deprecated = 'deprecated';
 
+KindModifiers.color = 'color';
+
 KindModifiers.dtsFile = '.d.ts';
 
 KindModifiers.tsFile = '.ts';
@@ -19919,13 +19921,10 @@ class CompletionDataCache {
   }
 }
 
-function asCompletionItems(entries, completionDataCache, file, position, document, filePathConverter, options, features, completionContext) {
+function asCompletionItems(entries, completionDataCache, file, position, document, filePathConverter, options, features, completionContext, defaultCommitCharacters) {
   const completions = [];
   for (const entry of entries) {
-    if (entry.kind === ScriptElementKind.warning) {
-      continue;
-    }
-    const completion = asCompletionItem(entry, completionDataCache, file, position, document, filePathConverter, options, features, completionContext);
+    const completion = asCompletionItem(entry, completionDataCache, file, position, document, filePathConverter, options, features, completionContext, defaultCommitCharacters);
     if (!completion) {
       continue;
     }
@@ -19934,7 +19933,7 @@ function asCompletionItems(entries, completionDataCache, file, position, documen
   return completions;
 }
 
-function asCompletionItem(entry, completionDataCache, file, position, document, filePathConverter, options, features, completionContext) {
+function asCompletionItem(entry, completionDataCache, file, position, document, filePathConverter, options, features, completionContext, defaultCommitCharacters) {
   const cacheId = completionDataCache.add({
     file: file,
     line: position.line + 1,
@@ -19946,7 +19945,7 @@ function asCompletionItem(entry, completionDataCache, file, position, document,
     } : entry.name ]
   });
   const item = {
-    label: entry.name,
+    label: entry.name || (entry.insertText ?? ''),
     kind: asCompletionItemKind(entry.kind),
     sortText: entry.sortText,
     preselect: entry.isRecommended,
@@ -19954,15 +19953,15 @@ function asCompletionItem(entry, completionDataCache, file, position, document,
       cacheId: cacheId
     }
   };
+  if (entry.source && entry.hasAction) {
+    item.sortText = `￿${entry.sortText}`;
+  }
   if (features.completionCommitCharactersSupport) {
-    item.commitCharacters = asCommitCharacters(entry.kind);
+    item.commitCharacters = asCommitCharacters(completionContext, entry, defaultCommitCharacters);
   }
   if (features.completionLabelDetails) {
     item.labelDetails = entry.labelDetails;
   }
-  if (entry.source && entry.hasAction) {
-    item.sortText = `￿${entry.sortText}`;
-  }
   const {isSnippet: isSnippet, replacementSpan: replacementSpan, sourceDisplay: sourceDisplay} = entry;
   if (isSnippet && !features.completionSnippets) {
     return null;
@@ -20012,6 +20011,9 @@ function asCompletionItem(entry, completionDataCache, file, position, document,
     if (kindModifiers.has(KindModifiers.deprecated)) {
       item.tags = [ mainExports$2.CompletionItemTag.Deprecated ];
     }
+    if (kindModifiers.has(KindModifiers.color)) {
+      item.kind = mainExports$2.CompletionItemKind.Color;
+    }
     if (entry.kind === ScriptElementKind.scriptElement) {
       for (const extModifier of KindModifiers.fileExtensionKindModifiers) {
         if (kindModifiers.has(extModifier)) {
@@ -20138,34 +20140,23 @@ function asCompletionItemKind(kind) {
   return mainExports$2.CompletionItemKind.Property;
 }
 
-function asCommitCharacters(kind) {
-  const commitCharacters = [];
-  switch (kind) {
-   case ScriptElementKind.memberGetAccessorElement:
-   case ScriptElementKind.memberSetAccessorElement:
-   case ScriptElementKind.constructSignatureElement:
-   case ScriptElementKind.callSignatureElement:
-   case ScriptElementKind.indexSignatureElement:
-   case ScriptElementKind.enumElement:
-   case ScriptElementKind.interfaceElement:
-    commitCharacters.push('.');
-    break;
-
-   case ScriptElementKind.moduleElement:
-   case ScriptElementKind.alias:
-   case ScriptElementKind.constElement:
-   case ScriptElementKind.letElement:
-   case ScriptElementKind.variableElement:
-   case ScriptElementKind.localVariableElement:
-   case ScriptElementKind.memberVariableElement:
-   case ScriptElementKind.classElement:
-   case ScriptElementKind.functionElement:
-   case ScriptElementKind.memberFunctionElement:
-    commitCharacters.push('.', ',');
+function asCommitCharacters(context, entry, defaultCommitCharacters) {
+  const kind = entry.kind;
+  let commitCharacters = entry.commitCharacters ?? (defaultCommitCharacters ? Array.from(defaultCommitCharacters) : undefined);
+  if (commitCharacters) {
+    if (context.enableCallCompletions && !context.isNewIdentifierLocation && kind !== ScriptElementKind.warning && kind !== ScriptElementKind.string) {
+      commitCharacters.push('(');
+    }
+    return commitCharacters;
+  }
+  if (kind === ScriptElementKind.warning || kind === ScriptElementKind.string) {
+    return undefined;
+  }
+  commitCharacters = [ '.', ',', ';' ];
+  if (context.enableCallCompletions) {
     commitCharacters.push('(');
-    break;
   }
-  return commitCharacters.length === 0 ? undefined : commitCharacters;
+  return commitCharacters;
 }
 
 async function asResolvedCompletionItem(item, details, document, client, options, features) {
@@ -22626,7 +22617,8 @@ class LspServer {
     if (!result) {
       return mainExports$2.CompletionList.create();
     }
-    const {entries: entries, isIncomplete: isIncomplete, optionalReplacementSpan: optionalReplacementSpan, isMemberCompletion: isMemberCompletion} = result;
+    const {entries: entries, isIncomplete: isIncomplete, optionalReplacementSpan: optionalReplacementSpan, isMemberCompletion: isMemberCompletion, isNewIdentifierLocation: isNewIdentifierLocation} = result;
+    const defaultCommitCharacters = Object.freeze(result.defaultCommitCharacters);
     const line = document.getLine(params.position.line);
     let dotAccessorContext;
     if (isMemberCompletion) {
@@ -22642,12 +22634,14 @@ class LspServer {
       }
     }
     const completionContext = {
+      enableCallCompletions: !completionOptions.completeFunctionCalls,
       isMemberCompletion: isMemberCompletion,
+      isNewIdentifierLocation: isNewIdentifierLocation,
       dotAccessorContext: dotAccessorContext,
       line: line,
       optionalReplacementRange: optionalReplacementSpan ? Range.fromTextSpan(optionalReplacementSpan) : undefined
     };
-    const completions = asCompletionItems(entries, this.completionDataCache, filepath, params.position, document, this.tsClient, completionOptions, this.features, completionContext);
+    const completions = asCompletionItems(entries, this.completionDataCache, filepath, params.position, document, this.tsClient, completionOptions, this.features, completionContext, defaultCommitCharacters);
     return mainExports$2.CompletionList.create(completions, isIncomplete);
   }
   async completionResolve(item, token) {