typeorm 1.0.0-beta.1 → 1.0.0-beta.2

package/browser/driver/cockroachdb/CockroachQueryRunner.js

@@ -21,6 +21,7 @@ const InstanceChecker_1 = require("../../util/InstanceChecker");
 const OrmUtils_1 = require("../../util/OrmUtils");
 const VersionUtils_1 = require("../../util/VersionUtils");
 const Query_1 = require("../Query");
+const validate_isolation_level_1 = require("../validate-isolation-level");
 const MetadataTableType_1 = require("../types/MetadataTableType");
 /**
  * Runs queries on a single postgres database connection.
@@ -96,6 +97,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     /**
      * Release a connection back to the pool, optionally specifying an Error to release with.
      * Per pg-pool documentation this will prevent the pool from re-using the broken connection.
+     *
      * @param err
      */
     async releaseConnection(err) {
@@ -121,9 +123,12 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Starts transaction.
+     *
      * @param isolationLevel
      */
     async startTransaction(isolationLevel) {
+        isolationLevel ??= this.dataSource.options.isolationLevel;
+        (0, validate_isolation_level_1.validateIsolationLevel)(this.driver.supportedIsolationLevels, isolationLevel);
         this.isTransactionActive = true;
         this.transactionRetries = 0;
         try {
@@ -193,6 +198,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Executes a given SQL query.
+     *
      * @param query
      * @param parameters
      * @param useStructuredResult
@@ -247,7 +253,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             if (err.code === "40001" &&
                 this.isTransactionActive &&
                 this.transactionRetries <
-                    (this.driver.options.maxTransactionRetries || 5)) {
+                    (this.driver.options.maxTransactionRetries ?? 5)) {
                 this.transactionRetries += 1;
                 this.storeQueries = false;
                 await this.query("ROLLBACK TO SAVEPOINT cockroach_restart");
@@ -277,6 +283,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Returns raw data stream.
+     *
      * @param query
      * @param parameters
      * @param onEnd
@@ -307,6 +314,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     /**
      * Returns all available schema names including system schemas.
      * If database parameter specified, returns schemas of that database.
+     *
      * @param database
      */
     async getSchemas(database) {
@@ -314,6 +322,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Checks if database with the given name exist.
+     *
      * @param database
      */
     async hasDatabase(database) {
@@ -329,6 +338,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Checks if schema with the given name exist.
+     *
      * @param schema
      */
     async hasSchema(schema) {
@@ -344,13 +354,12 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Checks if table with the given name exist in the database.
+     *
      * @param tableOrName
      */
     async hasTable(tableOrName) {
         const parsedTableName = this.driver.parseTableName(tableOrName);
-        if (!parsedTableName.schema) {
-            parsedTableName.schema = await this.getCurrentSchema();
-        }
+        parsedTableName.schema ??= await this.getCurrentSchema();
         const sql = `SELECT * FROM "information_schema"."tables" WHERE "table_schema" = $1 AND "table_name" = $2`;
         const result = await this.query(sql, [
             parsedTableName.schema,
@@ -360,14 +369,13 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Checks if column with the given name exist in the given table.
+     *
      * @param tableOrName
      * @param columnName
      */
     async hasColumn(tableOrName, columnName) {
         const parsedTableName = this.driver.parseTableName(tableOrName);
-        if (!parsedTableName.schema) {
-            parsedTableName.schema = await this.getCurrentSchema();
-        }
+        parsedTableName.schema ??= await this.getCurrentSchema();
         const sql = `SELECT * FROM "information_schema"."columns" WHERE "table_schema" = $1 AND "table_name" = $2 AND "column_name" = $3`;
         const result = await this.query(sql, [
             parsedTableName.schema,
@@ -378,6 +386,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new database.
+     *
      * @param database
      * @param ifNotExists
      */
@@ -388,6 +397,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops database.
+     *
      * @param database
      * @param ifExists
      */
@@ -398,6 +408,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new table schema.
+     *
      * @param schemaPath
      * @param ifNotExists
      */
@@ -414,6 +425,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops table schema.
+     *
      * @param schemaPath
      * @param ifExists
      * @param isCascade
@@ -431,6 +443,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new table.
+     *
      * @param table
      * @param ifNotExists
      * @param createForeignKeys
@@ -476,8 +489,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                 .filter((index) => !index.isUnique)
                 .forEach((index) => {
                 // new index may be passed without name. In this case we generate index name manually.
-                if (!index.name)
-                    index.name = this.dataSource.namingStrategy.indexName(table, index.columnNames, index.where);
+                index.name ??= this.dataSource.namingStrategy.indexName(table, index.columnNames, index.where);
                 upQueries.push(this.createIndexSql(table, index));
                 downQueries.push(this.dropIndexSql(table, index));
             });
@@ -487,9 +499,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         for (const column of generatedColumns) {
             const currentSchema = await this.getCurrentSchema();
             let { schema } = this.driver.parseTableName(table);
-            if (!schema) {
-                schema = currentSchema;
-            }
+            schema ??= currentSchema;
             const insertQuery = this.insertTypeormMetadataSql({
                 schema: schema,
                 table: table.name,
@@ -510,6 +520,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops the table.
+     *
      * @param target
      * @param ifExists
      * @param dropForeignKeys
@@ -552,9 +563,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         for (const column of generatedColumns) {
             const currentSchema = await this.getCurrentSchema();
             let { schema } = this.driver.parseTableName(table);
-            if (!schema) {
-                schema = currentSchema;
-            }
+            schema ??= currentSchema;
             const deleteQuery = this.deleteTypeormMetadataSql({
                 schema: schema,
                 table: table.name,
@@ -575,6 +584,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new view.
+     *
      * @param view
      * @param syncWithMetadata
      */
@@ -591,6 +601,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops the view.
+     *
      * @param target
      * @param ifExists
      */
@@ -609,6 +620,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Renames the given table.
+     *
      * @param oldTableOrName
      * @param newTableName
      */
@@ -697,6 +709,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new column from the column in the table.
+     *
      * @param tableOrName
      * @param column
      */
@@ -725,9 +738,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             // if table already have primary key, me must drop it and recreate again
             // todo: https://go.crdb.dev/issue-v/48026/v21.1
             if (primaryColumns.length > 0) {
-                const pkName = primaryColumns[0].primaryKeyConstraintName
-                    ? primaryColumns[0].primaryKeyConstraintName
-                    : this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
+                const pkName = primaryColumns[0].primaryKeyConstraintName ??
+                    this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
                 const columnNames = primaryColumns
                     .map((column) => `"${column.name}"`)
                     .join(", ");
@@ -735,9 +747,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                 downQueries.push(new Query_1.Query(`ALTER TABLE ${this.escapePath(table)} ADD CONSTRAINT "${pkName}" PRIMARY KEY (${columnNames})`));
             }
             primaryColumns.push(column);
-            const pkName = primaryColumns[0].primaryKeyConstraintName
-                ? primaryColumns[0].primaryKeyConstraintName
-                : this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
+            const pkName = primaryColumns[0].primaryKeyConstraintName ??
+                this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
             const columnNames = primaryColumns
                 .map((column) => `"${column.name}"`)
                 .join(", ");
@@ -747,9 +758,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         if (column.generatedType && column.asExpression) {
             const currentSchema = await this.getCurrentSchema();
             let { schema } = this.driver.parseTableName(table);
-            if (!schema) {
-                schema = currentSchema;
-            }
+            schema ??= currentSchema;
             const insertQuery = this.insertTypeormMetadataSql({
                 schema: schema,
                 table: table.name,
@@ -806,6 +815,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new columns from the column in the table.
+     *
      * @param tableOrName
      * @param columns
      */
@@ -816,6 +826,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Renames column in the given table.
+     *
      * @param tableOrName
      * @param oldTableColumnOrName
      * @param newTableColumnOrName
@@ -841,6 +852,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Changes a column in the table.
+     *
      * @param tableOrName
      * @param oldTableColumnOrName
      * @param newColumn
@@ -981,9 +993,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                 const primaryColumns = clonedTable.primaryColumns;
                 // if primary column state changed, we must always drop existed constraint.
                 if (primaryColumns.length > 0) {
-                    const pkName = primaryColumns[0].primaryKeyConstraintName
-                        ? primaryColumns[0].primaryKeyConstraintName
-                        : this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
+                    const pkName = primaryColumns[0].primaryKeyConstraintName ??
+                        this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
                     const columnNames = primaryColumns
                         .map((column) => `"${column.name}"`)
                         .join(", ");
@@ -995,9 +1006,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                     // update column in table
                     const column = clonedTable.columns.find((column) => column.name === newColumn.name);
                     column.isPrimary = true;
-                    const pkName = primaryColumns[0].primaryKeyConstraintName
-                        ? primaryColumns[0].primaryKeyConstraintName
-                        : this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
+                    const pkName = primaryColumns[0].primaryKeyConstraintName ??
+                        this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
                     const columnNames = primaryColumns
                         .map((column) => `"${column.name}"`)
                         .join(", ");
@@ -1012,10 +1022,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                     column.isPrimary = false;
                     // if we have another primary keys, we must recreate constraint.
                     if (primaryColumns.length > 0) {
-                        const pkName = primaryColumns[0]
-                            .primaryKeyConstraintName
-                            ? primaryColumns[0].primaryKeyConstraintName
-                            : this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
+                        const pkName = primaryColumns[0].primaryKeyConstraintName ??
+                            this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
                         const columnNames = primaryColumns
                             .map((column) => `"${column.name}"`)
                             .join(", ");
@@ -1135,8 +1143,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                 }
             }
         }
-        if ((newColumn.spatialFeatureType || "").toLowerCase() !==
-            (oldColumn.spatialFeatureType || "").toLowerCase() ||
+        if ((newColumn.spatialFeatureType ?? "").toLowerCase() !==
+            (oldColumn.spatialFeatureType ?? "").toLowerCase() ||
             newColumn.srid !== oldColumn.srid) {
             upQueries.push(new Query_1.Query(`ALTER TABLE ${this.escapePath(table)} ALTER COLUMN "${newColumn.name}" TYPE ${this.driver.createFullType(newColumn)}`));
             downQueries.push(new Query_1.Query(`ALTER TABLE ${this.escapePath(table)} ALTER COLUMN "${newColumn.name}" TYPE ${this.driver.createFullType(oldColumn)}`));
@@ -1146,6 +1154,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Changes a column in the table.
+     *
      * @param tableOrName
      * @param changedColumns
      */
@@ -1156,6 +1165,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops column in the table.
+     *
      * @param tableOrName
      * @param columnOrName
      * @param ifExists
@@ -1178,9 +1188,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         // drop primary key constraint
         // todo: https://go.crdb.dev/issue-v/48026/v21.1
         if (column.isPrimary) {
-            const pkName = column.primaryKeyConstraintName
-                ? column.primaryKeyConstraintName
-                : this.dataSource.namingStrategy.primaryKeyName(clonedTable, clonedTable.primaryColumns.map((column) => column.name));
+            const pkName = column.primaryKeyConstraintName ??
+                this.dataSource.namingStrategy.primaryKeyName(clonedTable, clonedTable.primaryColumns.map((column) => column.name));
             const columnNames = clonedTable.primaryColumns
                 .map((primaryColumn) => `"${primaryColumn.name}"`)
                 .join(", ");
@@ -1191,10 +1200,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             tableColumn.isPrimary = false;
             // if primary key have multiple columns, we must recreate it without dropped column
             if (clonedTable.primaryColumns.length > 0) {
-                const pkName = clonedTable.primaryColumns[0]
-                    .primaryKeyConstraintName
-                    ? clonedTable.primaryColumns[0].primaryKeyConstraintName
-                    : this.dataSource.namingStrategy.primaryKeyName(clonedTable, clonedTable.primaryColumns.map((column) => column.name));
+                const pkName = clonedTable.primaryColumns[0].primaryKeyConstraintName ??
+                    this.dataSource.namingStrategy.primaryKeyName(clonedTable, clonedTable.primaryColumns.map((column) => column.name));
                 const columnNames = clonedTable.primaryColumns
                     .map((primaryColumn) => `"${primaryColumn.name}"`)
                     .join(", ");
@@ -1236,9 +1243,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         if (column.generatedType && column.asExpression) {
             const currentSchema = await this.getCurrentSchema();
             let { schema } = this.driver.parseTableName(table);
-            if (!schema) {
-                schema = currentSchema;
-            }
+            schema ??= currentSchema;
             const deleteQuery = this.deleteTypeormMetadataSql({
                 schema: schema,
                 table: table.name,
@@ -1271,6 +1276,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops the columns in the table.
+     *
      * @param tableOrName
      * @param columns
      * @param ifExists
@@ -1282,6 +1288,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new primary key.
+     *
      * @param tableOrName
      * @param columnNames
      * @param constraintName
@@ -1303,6 +1310,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Updates composite primary keys.
+     *
      * @param tableOrName
      * @param columns
      */
@@ -1317,9 +1325,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         // if table already have primary columns, we must drop them.
         const primaryColumns = clonedTable.primaryColumns;
         if (primaryColumns.length > 0) {
-            const pkName = primaryColumns[0].primaryKeyConstraintName
-                ? primaryColumns[0].primaryKeyConstraintName
-                : this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
+            const pkName = primaryColumns[0].primaryKeyConstraintName ??
+                this.dataSource.namingStrategy.primaryKeyName(clonedTable, primaryColumns.map((column) => column.name));
             const columnNamesString = primaryColumns
                 .map((column) => `"${column.name}"`)
                 .join(", ");
@@ -1332,9 +1339,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             .forEach((column) => {
             column.isPrimary = true;
         });
-        const pkName = primaryColumns[0].primaryKeyConstraintName
-            ? primaryColumns[0].primaryKeyConstraintName
-            : this.dataSource.namingStrategy.primaryKeyName(clonedTable, columnNames);
+        const pkName = primaryColumns[0].primaryKeyConstraintName ??
+            this.dataSource.namingStrategy.primaryKeyName(clonedTable, columnNames);
         const columnNamesString = columnNames
             .map((columnName) => `"${columnName}"`)
             .join(", ");
@@ -1345,6 +1351,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops a primary key.
+     *
      * @param tableOrName
      * @param constraintName
      * @param ifExists
@@ -1362,6 +1369,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates new unique constraint.
+     *
      * @param tableOrName
      * @param uniqueConstraint
      */
@@ -1370,9 +1378,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             ? tableOrName
             : await this.getCachedTable(tableOrName);
         // new unique constraint may be passed without name. In this case we generate unique name manually.
-        if (!uniqueConstraint.name)
-            uniqueConstraint.name =
-                this.dataSource.namingStrategy.uniqueConstraintName(table, uniqueConstraint.columnNames);
+        uniqueConstraint.name ??=
+            this.dataSource.namingStrategy.uniqueConstraintName(table, uniqueConstraint.columnNames);
         const up = this.createUniqueConstraintSql(table, uniqueConstraint);
         // CockroachDB creates index for UNIQUE constraint.
         // We must use DROP INDEX ... CASCADE instead of DROP CONSTRAINT.
@@ -1382,6 +1389,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates new unique constraints.
+     *
      * @param tableOrName
      * @param uniqueConstraints
      */
@@ -1392,6 +1400,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops unique constraint.
+     *
      * @param tableOrName
      * @param uniqueOrName
      * @param ifExists
@@ -1417,6 +1426,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops unique constraints.
+     *
      * @param tableOrName
      * @param uniqueConstraints
      * @param ifExists
@@ -1428,6 +1438,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates new check constraint.
+     *
      * @param tableOrName
      * @param checkConstraint
      */
@@ -1436,9 +1447,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             ? tableOrName
             : await this.getCachedTable(tableOrName);
         // new unique constraint may be passed without name. In this case we generate unique name manually.
-        if (!checkConstraint.name)
-            checkConstraint.name =
-                this.dataSource.namingStrategy.checkConstraintName(table, checkConstraint.expression);
+        checkConstraint.name ??=
+            this.dataSource.namingStrategy.checkConstraintName(table, checkConstraint.expression);
         const up = this.createCheckConstraintSql(table, checkConstraint);
         const down = this.dropCheckConstraintSql(table, checkConstraint);
         await this.executeQueries(up, down);
@@ -1446,6 +1456,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates new check constraints.
+     *
      * @param tableOrName
      * @param checkConstraints
      */
@@ -1455,6 +1466,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops check constraint.
+     *
      * @param tableOrName
      * @param checkOrName
      * @param ifExists
@@ -1478,6 +1490,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops check constraints.
+     *
      * @param tableOrName
      * @param checkConstraints
      * @param ifExists
@@ -1488,6 +1501,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates new exclusion constraint.
+     *
      * @param tableOrName
      * @param exclusionConstraint
      */
@@ -1496,6 +1510,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates new exclusion constraints.
+     *
      * @param tableOrName
      * @param exclusionConstraints
      */
@@ -1504,6 +1519,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops exclusion constraint.
+     *
      * @param tableOrName
      * @param exclusionOrName
      * @param ifExists
@@ -1513,6 +1529,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops exclusion constraints.
+     *
      * @param tableOrName
      * @param exclusionConstraints
      * @param ifExists
@@ -1522,6 +1539,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new foreign key.
+     *
      * @param tableOrName
      * @param foreignKey
      */
@@ -1530,8 +1548,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             ? tableOrName
             : await this.getCachedTable(tableOrName);
         // new FK may be passed without name. In this case we generate FK name manually.
-        if (!foreignKey.name)
-            foreignKey.name = this.dataSource.namingStrategy.foreignKeyName(table, foreignKey.columnNames, this.getTablePath(foreignKey), foreignKey.referencedColumnNames);
+        foreignKey.name ??= this.dataSource.namingStrategy.foreignKeyName(table, foreignKey.columnNames, this.getTablePath(foreignKey), foreignKey.referencedColumnNames);
         const up = this.createForeignKeySql(table, foreignKey);
         const down = this.dropForeignKeySql(table, foreignKey);
         await this.executeQueries(up, down);
@@ -1539,6 +1556,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new foreign keys.
+     *
      * @param tableOrName
      * @param foreignKeys
      */
@@ -1549,6 +1567,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops a foreign key from the table.
+     *
      * @param tableOrName
      * @param foreignKeyOrName
      * @param ifExists
@@ -1565,9 +1584,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                 return;
             throw new error_1.TypeORMError(`Supplied foreign key was not found in table ${table.name}`);
         }
-        if (!foreignKey.name) {
-            foreignKey.name = this.dataSource.namingStrategy.foreignKeyName(table, foreignKey.columnNames, this.getTablePath(foreignKey), foreignKey.referencedColumnNames);
-        }
+        foreignKey.name ??= this.dataSource.namingStrategy.foreignKeyName(table, foreignKey.columnNames, this.getTablePath(foreignKey), foreignKey.referencedColumnNames);
         const up = this.dropForeignKeySql(table, foreignKey, ifExists);
         const down = this.createForeignKeySql(table, foreignKey);
         await this.executeQueries(up, down);
@@ -1575,6 +1592,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops a foreign keys from the table.
+     *
      * @param tableOrName
      * @param foreignKeys
      * @param ifExists
@@ -1586,6 +1604,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new index.
+     *
      * @param tableOrName
      * @param index
      */
@@ -1594,8 +1613,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             ? tableOrName
             : await this.getCachedTable(tableOrName);
         // new index may be passed without name. In this case we generate index name manually.
-        if (!index.name)
-            index.name = this.generateIndexName(table, index);
+        index.name ??= this.generateIndexName(table, index);
         // CockroachDB stores unique indices and UNIQUE constraints
         if (index.isUnique) {
             const unique = new TableUnique_1.TableUnique({
@@ -1618,6 +1636,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Creates a new indices
+     *
      * @param tableOrName
      * @param indices
      */
@@ -1628,6 +1647,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops an index from the table.
+     *
      * @param tableOrName
      * @param indexOrName
      * @param ifExists
@@ -1645,8 +1665,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             throw new error_1.TypeORMError(`Supplied index ${indexOrName} was not found in table ${table.name}`);
         }
         // old index may be passed without name. In this case we generate index name manually.
-        if (!index.name)
-            index.name = this.generateIndexName(table, index);
+        index.name ??= this.generateIndexName(table, index);
         const up = this.dropIndexSql(table, index, ifExists);
         const down = this.createIndexSql(table, index);
         await this.executeQueries(up, down);
@@ -1654,6 +1673,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops an indices from the table.
+     *
      * @param tableOrName
      * @param indices
      * @param ifExists
@@ -1666,6 +1686,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     /**
      * Clears all table contents.
      * Note: this operation uses SQL's TRUNCATE query which cannot be reverted in transactions.
+     *
      * @param tableName
      * @param options
      * @param options.cascade
@@ -1743,15 +1764,13 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         if (!hasTable) {
             return [];
         }
-        if (!viewNames) {
-            viewNames = [];
-        }
+        viewNames ??= [];
         const currentDatabase = await this.getCurrentDatabase();
         const currentSchema = await this.getCurrentSchema();
         const viewsCondition = viewNames
             .map((viewName) => {
             const { schema, tableName } = this.driver.parseTableName(viewName);
-            return `("t"."schema" = '${schema || currentSchema}' AND "t"."name" = '${tableName}')`;
+            return `("t"."schema" = '${schema ?? currentSchema}' AND "t"."name" = '${tableName}')`;
         })
             .join(" OR ");
         const query = `SELECT "t".*, "v"."check_option" FROM ${this.escapePath(this.getTypeormMetadataTableName())} "t" ` +
@@ -1772,11 +1791,12 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Loads all tables (with given names) from the database and creates a Table from them.
+     *
      * @param tableNames
      */
     async loadTables(tableNames) {
         // if no tables given then no need to proceed
-        if (tableNames && tableNames.length === 0) {
+        if (tableNames?.length === 0) {
             return [];
         }
         const currentSchema = await this.getCurrentSchema();
@@ -1790,7 +1810,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             const tablesCondition = tableNames
                 .map((tableName) => this.driver.parseTableName(tableName))
                 .map(({ schema, tableName }) => {
-                return `("table_schema" = '${schema || currentSchema}' AND "table_name" = '${tableName}')`;
+                return `("table_schema" = '${schema ?? currentSchema}' AND "table_name" = '${tableName}')`;
             })
                 .join(" OR ");
             const tablesSql = `SELECT "table_schema", "table_name" FROM "information_schema"."tables" WHERE ` +
@@ -1907,13 +1927,13 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                     dbColumn["crdb_sql_type"].toLowerCase();
                 if (dbColumn["crdb_sql_type"].indexOf("COLLATE") !==
                     -1) {
-                    tableColumn.collation = dbColumn["crdb_sql_type"].substr(dbColumn["crdb_sql_type"].indexOf("COLLATE") +
+                    tableColumn.collation = dbColumn["crdb_sql_type"].substring(dbColumn["crdb_sql_type"].indexOf("COLLATE") +
                         "COLLATE".length +
                         1, dbColumn["crdb_sql_type"].length);
-                    tableColumn.type = tableColumn.type.substr(0, dbColumn["crdb_sql_type"].indexOf("COLLATE") - 1);
+                    tableColumn.type = tableColumn.type.substring(0, dbColumn["crdb_sql_type"].indexOf("COLLATE") - 1);
                 }
                 if (tableColumn.type.indexOf("(") !== -1)
-                    tableColumn.type = tableColumn.type.substr(0, tableColumn.type.indexOf("("));
+                    tableColumn.type = tableColumn.type.substring(0, tableColumn.type.indexOf("("));
                 if (tableColumn.type === "numeric" ||
                     tableColumn.type === "decimal") {
                     if (dbColumn["numeric_precision"] !== null &&
@@ -1940,7 +1960,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                 // so, we must remove this underscore character from enum type name
                 let udtName = dbColumn["udt_name"];
                 if (udtName.indexOf("_") === 0) {
-                    udtName = udtName.substr(1, udtName.length);
+                    udtName = udtName.substring(1, udtName.length);
                 }
                 const enumType = dbEnums.find((dbEnum) => {
                     return dbEnum["name"] === udtName;
@@ -2055,7 +2075,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                         name: tableColumn.name,
                     });
                     const results = await this.query(asExpressionQuery.query, asExpressionQuery.parameters);
-                    if (results[0] && results[0].value) {
+                    if (results[0]?.value) {
                         tableColumn.asExpression = results[0].value;
                     }
                     else {
@@ -2063,9 +2083,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                     }
                 }
                 tableColumn.comment =
-                    dbColumn["description"] == null
-                        ? undefined
-                        : dbColumn["description"];
+                    dbColumn["description"] ?? undefined;
                 if (dbColumn["character_set_name"])
                     tableColumn.charset =
                         dbColumn["character_set_name"];
@@ -2183,6 +2201,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds create table sql.
+     *
      * @param table
      * @param createForeignKeys
      */
@@ -2213,9 +2232,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         if (table.uniques.length > 0) {
             const uniquesSql = table.uniques
                 .map((unique) => {
-                const uniqueName = unique.name
-                    ? unique.name
-                    : this.dataSource.namingStrategy.uniqueConstraintName(table, unique.columnNames);
+                const uniqueName = unique.name ??
+                    this.dataSource.namingStrategy.uniqueConstraintName(table, unique.columnNames);
                 const columnNames = unique.columnNames
                     .map((columnName) => `"${columnName}"`)
                     .join(", ");
@@ -2227,9 +2245,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         if (table.checks.length > 0) {
             const checksSql = table.checks
                 .map((check) => {
-                const checkName = check.name
-                    ? check.name
-                    : this.dataSource.namingStrategy.checkConstraintName(table, check.expression);
+                const checkName = check.name ??
+                    this.dataSource.namingStrategy.checkConstraintName(table, check.expression);
                 return `CONSTRAINT "${checkName}" CHECK (${check.expression})`;
             })
                 .join(", ");
@@ -2241,8 +2258,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                 const columnNames = fk.columnNames
                     .map((columnName) => `"${columnName}"`)
                     .join(", ");
-                if (!fk.name)
-                    fk.name = this.dataSource.namingStrategy.foreignKeyName(table, fk.columnNames, this.getTablePath(fk), fk.referencedColumnNames);
+                fk.name ??= this.dataSource.namingStrategy.foreignKeyName(table, fk.columnNames, this.getTablePath(fk), fk.referencedColumnNames);
                 const referencedColumnNames = fk.referencedColumnNames
                     .map((columnName) => `"${columnName}"`)
                     .join(", ");
@@ -2258,9 +2274,8 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         }
         const primaryColumns = table.columns.filter((column) => column.isPrimary);
         if (primaryColumns.length > 0) {
-            const primaryKeyName = primaryColumns[0].primaryKeyConstraintName
-                ? primaryColumns[0].primaryKeyConstraintName
-                : this.dataSource.namingStrategy.primaryKeyName(table, primaryColumns.map((column) => column.name));
+            const primaryKeyName = primaryColumns[0].primaryKeyConstraintName ??
+                this.dataSource.namingStrategy.primaryKeyName(table, primaryColumns.map((column) => column.name));
             const columnNames = primaryColumns
                 .map((column) => `"${column.name}"`)
                 .join(", ");
@@ -2284,6 +2299,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds drop table sql.
+     *
      * @param tableOrPath
      */
     dropTableSql(tableOrPath) {
@@ -2302,9 +2318,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     async insertViewDefinitionSql(view) {
         const currentSchema = await this.getCurrentSchema();
         let { schema, tableName: name } = this.driver.parseTableName(view);
-        if (!schema) {
-            schema = currentSchema;
-        }
+        schema ??= currentSchema;
         const expression = typeof view.expression === "string"
             ? view.expression.trim()
             : view.expression(this.dataSource).getQuery();
@@ -2317,6 +2331,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds drop view sql.
+     *
      * @param viewOrPath
      */
     dropViewSql(viewOrPath) {
@@ -2324,14 +2339,13 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds remove view sql.
+     *
      * @param viewOrPath
      */
     async deleteViewDefinitionSql(viewOrPath) {
         const currentSchema = await this.getCurrentSchema();
         let { schema, tableName: name } = this.driver.parseTableName(viewOrPath);
-        if (!schema) {
-            schema = currentSchema;
-        }
+        schema ??= currentSchema;
         return this.deleteTypeormMetadataSql({
             type: MetadataTableType_1.MetadataTableType.VIEW,
             schema,
@@ -2340,6 +2354,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Drops ENUM type from given schemas.
+     *
      * @param schemaNames
      */
     async dropEnumTypes(schemaNames) {
@@ -2353,14 +2368,13 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Checks if enum with the given name exist in the database.
+     *
      * @param table
      * @param column
      */
     async hasEnumType(table, column) {
         let { schema } = this.driver.parseTableName(table);
-        if (!schema) {
-            schema = await this.getCurrentSchema();
-        }
+        schema ??= await this.getCurrentSchema();
         const enumName = this.buildEnumName(table, column, false, true);
         const sql = `SELECT "n"."nspname", "t"."typname" FROM "pg_type" "t" ` +
             `INNER JOIN "pg_namespace" "n" ON "n"."oid" = "t"."typnamespace" ` +
@@ -2370,13 +2384,13 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds create ENUM type sql.
+     *
      * @param table
      * @param column
      * @param enumName
      */
     createEnumTypeSql(table, column, enumName) {
-        if (!enumName)
-            enumName = this.buildEnumName(table, column);
+        enumName ??= this.buildEnumName(table, column);
         const enumValues = column
             .enum.map((value) => `'${value.replaceAll("'", "''")}'`)
             .join(", ");
@@ -2384,18 +2398,19 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds create ENUM type sql.
+     *
      * @param table
      * @param column
      * @param enumName
      */
     dropEnumTypeSql(table, column, enumName) {
-        if (!enumName)
-            enumName = this.buildEnumName(table, column);
+        enumName ??= this.buildEnumName(table, column);
         return new Query_1.Query(`DROP TYPE ${enumName}`);
     }
     /**
      * Builds create index sql.
      * UNIQUE indices creates as UNIQUE constraints.
+     *
      * @param table
      * @param index
      */
@@ -2407,6 +2422,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds drop index sql.
+     *
      * @param table
      * @param indexOrName
      * @param ifExists
@@ -2420,14 +2436,14 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds create primary key sql.
+     *
      * @param table
      * @param columnNames
      * @param constraintName
      */
     createPrimaryKeySql(table, columnNames, constraintName) {
-        const primaryKeyName = constraintName
-            ? constraintName
-            : this.dataSource.namingStrategy.primaryKeyName(table, columnNames);
+        const primaryKeyName = constraintName ??
+            this.dataSource.namingStrategy.primaryKeyName(table, columnNames);
         const columnNamesString = columnNames
             .map((columnName) => `"${columnName}"`)
             .join(", ");
@@ -2435,6 +2451,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds drop primary key sql.
+     *
      * @param table
      * @param ifExists
      */
@@ -2443,13 +2460,13 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             throw new error_1.TypeORMError(`Table ${table} has no primary keys.`);
         const columnNames = table.primaryColumns.map((column) => column.name);
         const constraintName = table.primaryColumns[0].primaryKeyConstraintName;
-        const primaryKeyName = constraintName
-            ? constraintName
-            : this.dataSource.namingStrategy.primaryKeyName(table, columnNames);
+        const primaryKeyName = constraintName ??
+            this.dataSource.namingStrategy.primaryKeyName(table, columnNames);
         return new Query_1.Query(`ALTER TABLE ${this.escapePath(table)} DROP CONSTRAINT ${ifExists ? "IF EXISTS " : ""}"${primaryKeyName}"`);
     }
     /**
      * Builds create unique constraint sql.
+     *
      * @param table
      * @param uniqueConstraint
      */
@@ -2461,6 +2478,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds drop unique constraint sql.
+     *
      * @param table
      * @param uniqueOrName
      */
@@ -2472,6 +2490,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds create check constraint sql.
+     *
      * @param table
      * @param checkConstraint
      */
@@ -2480,6 +2499,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds drop check constraint sql.
+     *
      * @param table
      * @param checkOrName
      * @param ifExists
@@ -2492,6 +2512,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds create foreign key sql.
+     *
      * @param table
      * @param foreignKey
      */
@@ -2512,6 +2533,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds drop foreign key sql.
+     *
      * @param table
      * @param foreignKeyOrName
      * @param ifExists
@@ -2524,6 +2546,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds sequence name from given table and column.
+     *
      * @param table
      * @param columnOrName
      */
@@ -2542,6 +2565,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds ENUM type name from given table and column.
+     *
      * @param table
      * @param column
      * @param withSchema
@@ -2550,9 +2574,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
      */
     buildEnumName(table, column, withSchema = true, disableEscape, toOld) {
         const { schema, tableName } = this.driver.parseTableName(table);
-        let enumName = column.enumName
-            ? column.enumName
-            : `${tableName}_${column.name.toLowerCase()}_enum`;
+        let enumName = column.enumName ?? `${tableName}_${column.name.toLowerCase()}_enum`;
         if (schema && withSchema)
             enumName = `${schema}.${enumName}`;
         if (toOld)
@@ -2566,9 +2588,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     async getUserDefinedTypeName(table, column) {
         let { schema, tableName: name } = this.driver.parseTableName(table);
-        if (!schema) {
-            schema = await this.getCurrentSchema();
-        }
+        schema ??= await this.getCurrentSchema();
         const result = await this.query(`SELECT "udt_schema", "udt_name" ` +
             `FROM "information_schema"."columns" WHERE "table_schema" = '${schema}' AND "table_name" = '${name}' AND "column_name"='${column.name}'`);
         // docs: https://www.postgresql.org/docs/current/xtypes.html
@@ -2578,7 +2598,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         // so, we must remove this underscore character from enum type name
         let udtName = result[0]["udt_name"];
         if (udtName.indexOf("_") === 0) {
-            udtName = udtName.substr(1, udtName.length);
+            udtName = udtName.substring(1, udtName.length);
         }
         return {
             schema: result[0]["udt_schema"],
@@ -2587,6 +2607,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Escapes a given comment so it's safe to include in a query.
+     *
      * @param comment
      */
     escapeComment(comment) {
@@ -2598,6 +2619,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Escapes given table or view path.
+     *
      * @param target
      */
     escapePath(target) {
@@ -2609,6 +2631,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Builds a query for create column.
+     *
      * @param table
      * @param column
      */
@@ -2634,7 +2657,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             c += " " + this.dataSource.driver.createFullType(column);
         }
         if (column.asExpression) {
-            c += ` AS (${column.asExpression}) ${column.generatedType ? column.generatedType : "VIRTUAL"}`;
+            c += ` AS (${column.asExpression}) ${column.generatedType ?? "VIRTUAL"}`;
         }
         else {
             if (column.charset)
@@ -2652,6 +2675,7 @@ class CockroachQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
     }
     /**
      * Change table comment.
+     *
      * @param tableOrName
      * @param comment
      */