typeorm 0.3.27-dev.fa3cd43 → 0.3.28-dev.02e7b71

package/browser/driver/mysql/MysqlQueryRunner.d.ts

@@ -183,11 +183,11 @@ export declare class MysqlQueryRunner extends BaseQueryRunner implements QueryRu
      */
     createUniqueConstraints(tableOrName: Table | string, uniqueConstraints: TableUnique[]): Promise<void>;
     /**
-     * Drops an unique constraint.
+     * Drops a unique constraint.
      */
     dropUniqueConstraint(tableOrName: Table | string, uniqueOrName: TableUnique | string): Promise<void>;
     /**
-     * Drops an unique constraints.
+     * Drops a unique constraints.
      */
     dropUniqueConstraints(tableOrName: Table | string, uniqueConstraints: TableUnique[]): Promise<void>;
     /**
@@ -327,6 +327,7 @@ export declare class MysqlQueryRunner extends BaseQueryRunner implements QueryRu
     getVersion(): Promise<string>;
     /**
      * Checks if column display width is by default.
+     * @deprecated MySQL no longer supports column width in newer versions.
      */
     protected isDefaultColumnWidth(table: Table, column: TableColumn, width: number): boolean;
 }

package/browser/driver/mysql/MysqlQueryRunner.js

@@ -15,6 +15,7 @@ import { BroadcasterResult } from "../../subscriber/BroadcasterResult";
 import { InstanceChecker } from "../../util/InstanceChecker";
 import { OrmUtils } from "../../util/OrmUtils";
 import { VersionUtils } from "../../util/VersionUtils";
+import { DriverUtils } from "../DriverUtils";
 import { Query } from "../Query";
 import { MetadataTableType } from "../types/MetadataTableType";
 /**
@@ -1132,13 +1133,13 @@ export class MysqlQueryRunner extends BaseQueryRunner {
         throw new TypeORMError(`MySql does not support unique constraints. Use unique index instead.`);
     }
     /**
-     * Drops an unique constraint.
+     * Drops a unique constraint.
      */
     async dropUniqueConstraint(tableOrName, uniqueOrName) {
         throw new TypeORMError(`MySql does not support unique constraints. Use unique index instead.`);
     }
     /**
-     * Drops an unique constraints.
+     * Drops a unique constraints.
      */
     async dropUniqueConstraints(tableOrName, uniqueConstraints) {
         throw new TypeORMError(`MySql does not support unique constraints. Use unique index instead.`);
@@ -1600,12 +1601,11 @@ export class MysqlQueryRunner extends BaseQueryRunner {
                     tableColumn.type = "geometrycollection";
                 }
                 tableColumn.zerofill =
-                    dbColumn["COLUMN_TYPE"].indexOf("zerofill") !==
-                        -1;
-                tableColumn.unsigned = tableColumn.zerofill
-                    ? true
-                    : dbColumn["COLUMN_TYPE"].indexOf("unsigned") !== -1;
-                if (this.driver.withWidthColumnTypes.indexOf(tableColumn.type) !== -1) {
+                    dbColumn["COLUMN_TYPE"].includes("zerofill");
+                tableColumn.unsigned =
+                    tableColumn.zerofill ||
+                        dbColumn["COLUMN_TYPE"].includes("unsigned");
+                if (this.driver.unsignedColumnTypes.includes(tableColumn.type)) {
                     const width = dbColumn["COLUMN_TYPE"].substring(dbColumn["COLUMN_TYPE"].indexOf("(") + 1, dbColumn["COLUMN_TYPE"].indexOf(")"));
                     tableColumn.width =
                         width &&
@@ -2099,8 +2099,14 @@ export class MysqlQueryRunner extends BaseQueryRunner {
     }
     /**
      * Checks if column display width is by default.
+     * @deprecated MySQL no longer supports column width in newer versions.
      */
     isDefaultColumnWidth(table, column, width) {
+        // Skip the whole check on servers that no longer expose width metadata.
+        if (this.driver.options.type === "mysql" &&
+            DriverUtils.isReleaseVersionOrGreater(this.driver, "8.0.0")) {
+            return true;
+        }
         // if table have metadata, we check if length is specified in column metadata
         if (this.connection.hasMetadata(table.name)) {
             const metadata = this.connection.getMetadata(table.name);