typeorm 0.3.22-dev.72145b8 → 0.3.22-dev.72c6991

package/driver/postgres/PostgresQueryRunner.js

@@ -16,12 +16,12 @@ const TableIndex_1 = require("../../schema-builder/table/TableIndex");
 const TableUnique_1 = require("../../schema-builder/table/TableUnique");
 const View_1 = require("../../schema-builder/view/View");
 const Broadcaster_1 = require("../../subscriber/Broadcaster");
+const BroadcasterResult_1 = require("../../subscriber/BroadcasterResult");
 const InstanceChecker_1 = require("../../util/InstanceChecker");
 const OrmUtils_1 = require("../../util/OrmUtils");
-const VersionUtils_1 = require("../../util/VersionUtils");
+const DriverUtils_1 = require("../DriverUtils");
 const Query_1 = require("../Query");
 const MetadataTableType_1 = require("../types/MetadataTableType");
-const BroadcasterResult_1 = require("../../subscriber/BroadcasterResult");
 /**
  * Runs queries on a single postgres database connection.
  */
@@ -595,7 +595,7 @@ class PostgresQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         });
         // rename ENUM types
         const enumColumns = newTable.columns.filter((column) => column.type === "enum" || column.type === "simple-enum");
-        for (let column of enumColumns) {
+        for (const column of enumColumns) {
             // skip renaming for user-defined enum name
             if (column.enumName)
                 continue;
@@ -1606,7 +1606,6 @@ class PostgresQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         if (!isAnotherTransactionActive)
             await this.startTransaction();
         try {
-            const version = await this.getVersion();
             // drop views
             const selectViewDropsQuery = `SELECT 'DROP VIEW IF EXISTS "' || schemaname || '"."' || viewname || '" CASCADE;' as "query" ` +
                 `FROM "pg_views" WHERE "schemaname" IN (${schemaNamesString}) AND "viewname" NOT IN ('geography_columns', 'geometry_columns', 'raster_columns', 'raster_overviews')`;
@@ -1614,7 +1613,7 @@ class PostgresQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             await Promise.all(dropViewQueries.map((q) => this.query(q["query"])));
             // drop materialized views
             // Note: materialized views introduced in Postgres 9.3
-            if (VersionUtils_1.VersionUtils.isGreaterOrEqual(version, "9.3")) {
+            if (DriverUtils_1.DriverUtils.isReleaseVersionOrGreater(this.driver, "9.3")) {
                 const selectMatViewDropsQuery = `SELECT 'DROP MATERIALIZED VIEW IF EXISTS "' || schemaname || '"."' || matviewname || '" CASCADE;' as "query" ` +
                     `FROM "pg_matviews" WHERE "schemaname" IN (${schemaNamesString})`;
                 const dropMatViewQueries = await this.query(selectMatViewDropsQuery);
@@ -1639,7 +1638,9 @@ class PostgresQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
                     await this.rollbackTransaction();
                 }
             }
-            catch (rollbackError) { }
+            catch {
+                // no-op
+            }
             throw error;
         }
     }
@@ -2295,8 +2296,17 @@ class PostgresQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
      * Loads Postgres version.
      */
     async getVersion() {
+        // we use `SELECT version()` instead of `SHOW server_version` or `SHOW server_version_num`
+        // to maintain compatability with Amazon Redshift.
+        //
+        // see:
+        //  - https://github.com/typeorm/typeorm/pull/9319
+        //  - https://docs.aws.amazon.com/redshift/latest/dg/c_unsupported-postgresql-functions.html
         const result = await this.query(`SELECT version()`);
-        return result[0]["version"].replace(/^PostgreSQL ([\d.]+) .*$/, "$1");
+        // Examples:
+        // Postgres: "PostgreSQL 14.10 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-20), 64-bit"
+        // Yugabyte: "PostgreSQL 11.2-YB-2.18.1.0-b0 on x86_64-pc-linux-gnu, compiled by clang version 15.0.3 (https://github.com/yugabyte/llvm-project.git 0b8d1183745fd3998d8beffeec8cbe99c1b20529), 64-bit"
+        return result[0].version.replace(/^PostgreSQL ([\d.]+).*$/, "$1");
     }
     /**
      * Builds drop table sql.
@@ -2389,7 +2399,7 @@ class PostgresQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         if (!enumName)
             enumName = this.buildEnumName(table, column);
         const enumValues = column
-            .enum.map((value) => `'${value.replace("'", "''")}'`)
+            .enum.map((value) => `'${value.replaceAll("'", "''")}'`)
             .join(", ");
         return new Query_1.Query(`CREATE TYPE ${enumName} AS ENUM(${enumValues})`);
     }