typeorm 0.3.22-dev.206af0a → 0.3.22-dev.3d79786

package/browser/driver/postgres/PostgresQueryRunner.js

@@ -13,12 +13,12 @@ import { TableIndex } from "../../schema-builder/table/TableIndex";
 import { TableUnique } from "../../schema-builder/table/TableUnique";
 import { View } from "../../schema-builder/view/View";
 import { Broadcaster } from "../../subscriber/Broadcaster";
+import { BroadcasterResult } from "../../subscriber/BroadcasterResult";
 import { InstanceChecker } from "../../util/InstanceChecker";
 import { OrmUtils } from "../../util/OrmUtils";
-import { VersionUtils } from "../../util/VersionUtils";
+import { DriverUtils } from "../DriverUtils";
 import { Query } from "../Query";
 import { MetadataTableType } from "../types/MetadataTableType";
-import { BroadcasterResult } from "../../subscriber/BroadcasterResult";
 /**
  * Runs queries on a single postgres database connection.
  */
@@ -116,16 +116,15 @@ export class PostgresQueryRunner extends BaseQueryRunner {
             throw err;
         }
         if (this.transactionDepth === 0) {
-            this.transactionDepth += 1;
             await this.query("START TRANSACTION");
             if (isolationLevel) {
                 await this.query("SET TRANSACTION ISOLATION LEVEL " + isolationLevel);
             }
         }
         else {
-            this.transactionDepth += 1;
-            await this.query(`SAVEPOINT typeorm_${this.transactionDepth - 1}`);
+            await this.query(`SAVEPOINT typeorm_${this.transactionDepth}`);
         }
+        this.transactionDepth += 1;
         await this.broadcaster.broadcast("AfterTransactionStart");
     }
     /**
@@ -137,14 +136,13 @@ export class PostgresQueryRunner extends BaseQueryRunner {
             throw new TransactionNotStartedError();
         await this.broadcaster.broadcast("BeforeTransactionCommit");
         if (this.transactionDepth > 1) {
-            this.transactionDepth -= 1;
-            await this.query(`RELEASE SAVEPOINT typeorm_${this.transactionDepth}`);
+            await this.query(`RELEASE SAVEPOINT typeorm_${this.transactionDepth - 1}`);
         }
         else {
-            this.transactionDepth -= 1;
             await this.query("COMMIT");
             this.isTransactionActive = false;
         }
+        this.transactionDepth -= 1;
         await this.broadcaster.broadcast("AfterTransactionCommit");
     }
     /**
@@ -156,14 +154,13 @@ export class PostgresQueryRunner extends BaseQueryRunner {
             throw new TransactionNotStartedError();
         await this.broadcaster.broadcast("BeforeTransactionRollback");
         if (this.transactionDepth > 1) {
-            this.transactionDepth -= 1;
-            await this.query(`ROLLBACK TO SAVEPOINT typeorm_${this.transactionDepth}`);
+            await this.query(`ROLLBACK TO SAVEPOINT typeorm_${this.transactionDepth - 1}`);
         }
         else {
-            this.transactionDepth -= 1;
             await this.query("ROLLBACK");
             this.isTransactionActive = false;
         }
+        this.transactionDepth -= 1;
         await this.broadcaster.broadcast("AfterTransactionRollback");
     }
     /**
@@ -595,7 +592,7 @@ export class PostgresQueryRunner extends BaseQueryRunner {
         });
         // rename ENUM types
         const enumColumns = newTable.columns.filter((column) => column.type === "enum" || column.type === "simple-enum");
-        for (let column of enumColumns) {
+        for (const column of enumColumns) {
             // skip renaming for user-defined enum name
             if (column.enumName)
                 continue;
@@ -1606,7 +1603,6 @@ export class PostgresQueryRunner extends BaseQueryRunner {
         if (!isAnotherTransactionActive)
             await this.startTransaction();
         try {
-            const version = await this.getVersion();
             // drop views
             const selectViewDropsQuery = `SELECT 'DROP VIEW IF EXISTS "' || schemaname || '"."' || viewname || '" CASCADE;' as "query" ` +
                 `FROM "pg_views" WHERE "schemaname" IN (${schemaNamesString}) AND "viewname" NOT IN ('geography_columns', 'geometry_columns', 'raster_columns', 'raster_overviews')`;
@@ -1614,7 +1610,7 @@ export class PostgresQueryRunner extends BaseQueryRunner {
             await Promise.all(dropViewQueries.map((q) => this.query(q["query"])));
             // drop materialized views
             // Note: materialized views introduced in Postgres 9.3
-            if (VersionUtils.isGreaterOrEqual(version, "9.3")) {
+            if (DriverUtils.isReleaseVersionOrGreater(this.driver, "9.3")) {
                 const selectMatViewDropsQuery = `SELECT 'DROP MATERIALIZED VIEW IF EXISTS "' || schemaname || '"."' || matviewname || '" CASCADE;' as "query" ` +
                     `FROM "pg_matviews" WHERE "schemaname" IN (${schemaNamesString})`;
                 const dropMatViewQueries = await this.query(selectMatViewDropsQuery);
@@ -1639,7 +1635,9 @@ export class PostgresQueryRunner extends BaseQueryRunner {
                     await this.rollbackTransaction();
                 }
             }
-            catch (rollbackError) { }
+            catch {
+                // no-op
+            }
             throw error;
         }
     }
@@ -2296,7 +2294,10 @@ export class PostgresQueryRunner extends BaseQueryRunner {
      */
     async getVersion() {
         const result = await this.query(`SELECT version()`);
-        return result[0]["version"].replace(/^PostgreSQL ([\d.]+) .*$/, "$1");
+        // Examples:
+        // Postgres: "PostgreSQL 14.10 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-20), 64-bit"
+        // Yugabyte: "PostgreSQL 11.2-YB-2.18.1.0-b0 on x86_64-pc-linux-gnu, compiled by clang version 15.0.3 (https://github.com/yugabyte/llvm-project.git 0b8d1183745fd3998d8beffeec8cbe99c1b20529), 64-bit"
+        return result[0].version.replace(/^PostgreSQL ([\d.]+).*$/, "$1");
     }
     /**
      * Builds drop table sql.
@@ -2389,7 +2390,7 @@ export class PostgresQueryRunner extends BaseQueryRunner {
         if (!enumName)
             enumName = this.buildEnumName(table, column);
         const enumValues = column
-            .enum.map((value) => `'${value.replace("'", "''")}'`)
+            .enum.map((value) => `'${value.replaceAll("'", "''")}'`)
             .join(", ");
         return new Query(`CREATE TYPE ${enumName} AS ENUM(${enumValues})`);
     }