typeorm 0.3.18-dev.122c897 → 0.3.18-dev.15bc887

package/browser/driver/cockroachdb/CockroachQueryRunner.js

@@ -17,6 +17,7 @@ import { TableExclusion } from "../../schema-builder/table/TableExclusion";
 import { TypeORMError } from "../../error";
 import { MetadataTableType } from "../types/MetadataTableType";
 import { InstanceChecker } from "../../util/InstanceChecker";
+import { BroadcasterResult } from "../../subscriber/BroadcasterResult";
 import { VersionUtils } from "../../util/VersionUtils";
 /**
  * Runs queries on a single postgres database connection.
@@ -62,7 +63,12 @@ export class CockroachQueryRunner extends BaseQueryRunner {
                 .then(([connection, release]) => {
                 this.driver.connectedQueryRunners.push(this);
                 this.databaseConnection = connection;
-                this.releaseCallback = release;
+                const onErrorCallback = (err) => this.releaseConnection(err);
+                this.releaseCallback = (err) => {
+                    this.databaseConnection.removeListener("error", onErrorCallback);
+                    release(err);
+                };
+                this.databaseConnection.on("error", onErrorCallback);
                 return this.databaseConnection;
             });
         }
@@ -73,27 +79,41 @@ export class CockroachQueryRunner extends BaseQueryRunner {
                 .then(([connection, release]) => {
                 this.driver.connectedQueryRunners.push(this);
                 this.databaseConnection = connection;
-                this.releaseCallback = release;
+                const onErrorCallback = (err) => this.releaseConnection(err);
+                this.releaseCallback = (err) => {
+                    this.databaseConnection.removeListener("error", onErrorCallback);
+                    release(err);
+                };
+                this.databaseConnection.on("error", onErrorCallback);
                 return this.databaseConnection;
             });
         }
         return this.databaseConnectionPromise;
     }
     /**
-     * Releases used database connection.
-     * You cannot use query runner methods once its released.
+     * Release a connection back to the pool, optionally specifying an Error to release with.
+     * Per pg-pool documentation this will prevent the pool from re-using the broken connection.
      */
-    release() {
+    async releaseConnection(err) {
         if (this.isReleased) {
-            return Promise.resolve();
+            return;
         }
         this.isReleased = true;
-        if (this.releaseCallback)
-            this.releaseCallback();
+        if (this.releaseCallback) {
+            this.releaseCallback(err);
+            this.releaseCallback = undefined;
+        }
         const index = this.driver.connectedQueryRunners.indexOf(this);
-        if (index !== -1)
-            this.driver.connectedQueryRunners.splice(index);
-        return Promise.resolve();
+        if (index !== -1) {
+            this.driver.connectedQueryRunners.splice(index, 1);
+        }
+    }
+    /**
+     * Releases used database connection.
+     * You cannot use query runner methods once its released.
+     */
+    release() {
+        return this.releaseConnection();
     }
     /**
      * Starts transaction.
@@ -109,6 +129,7 @@ export class CockroachQueryRunner extends BaseQueryRunner {
             throw err;
         }
         if (this.transactionDepth === 0) {
+            this.transactionDepth += 1;
             await this.query("START TRANSACTION");
             await this.query("SAVEPOINT cockroach_restart");
             if (isolationLevel) {
@@ -116,9 +137,9 @@ export class CockroachQueryRunner extends BaseQueryRunner {
             }
         }
         else {
-            await this.query(`SAVEPOINT typeorm_${this.transactionDepth}`);
+            this.transactionDepth += 1;
+            await this.query(`SAVEPOINT typeorm_${this.transactionDepth - 1}`);
         }
-        this.transactionDepth += 1;
         this.storeQueries = true;
         await this.broadcaster.broadcast("AfterTransactionStart");
     }
@@ -131,17 +152,17 @@ export class CockroachQueryRunner extends BaseQueryRunner {
             throw new TransactionNotStartedError();
         await this.broadcaster.broadcast("BeforeTransactionCommit");
         if (this.transactionDepth > 1) {
-            await this.query(`RELEASE SAVEPOINT typeorm_${this.transactionDepth - 1}`);
             this.transactionDepth -= 1;
+            await this.query(`RELEASE SAVEPOINT typeorm_${this.transactionDepth}`);
         }
         else {
             this.storeQueries = false;
+            this.transactionDepth -= 1;
             await this.query("RELEASE SAVEPOINT cockroach_restart");
             await this.query("COMMIT");
             this.queries = [];
             this.isTransactionActive = false;
             this.transactionRetries = 0;
-            this.transactionDepth -= 1;
         }
         await this.broadcaster.broadcast("AfterTransactionCommit");
     }
@@ -154,16 +175,17 @@ export class CockroachQueryRunner extends BaseQueryRunner {
             throw new TransactionNotStartedError();
         await this.broadcaster.broadcast("BeforeTransactionRollback");
         if (this.transactionDepth > 1) {
-            await this.query(`ROLLBACK TO SAVEPOINT typeorm_${this.transactionDepth - 1}`);
+            this.transactionDepth -= 1;
+            await this.query(`ROLLBACK TO SAVEPOINT typeorm_${this.transactionDepth}`);
         }
         else {
             this.storeQueries = false;
+            this.transactionDepth -= 1;
             await this.query("ROLLBACK");
             this.queries = [];
             this.isTransactionActive = false;
             this.transactionRetries = 0;
         }
-        this.transactionDepth -= 1;
         await this.broadcaster.broadcast("AfterTransactionRollback");
     }
     /**
@@ -173,7 +195,9 @@ export class CockroachQueryRunner extends BaseQueryRunner {
         if (this.isReleased)
             throw new QueryRunnerAlreadyReleasedError();
         const databaseConnection = await this.connect();
+        const broadcasterResult = new BroadcasterResult();
         this.driver.connection.logger.logQuery(query, parameters, this);
+        this.broadcaster.broadcastBeforeQueryEvent(broadcasterResult, query, parameters);
         const queryStartTime = +new Date();
         if (this.isTransactionActive && this.storeQueries) {
             this.queries.push({ query, parameters });
@@ -205,6 +229,7 @@ export class CockroachQueryRunner extends BaseQueryRunner {
                 default:
                     result.raw = raw.rows;
             }
+            this.broadcaster.broadcastAfterQueryEvent(broadcasterResult, query, parameters, true, queryExecutionTime, raw, undefined);
             if (useStructuredResult) {
                 return result;
             }
@@ -236,9 +261,13 @@ export class CockroachQueryRunner extends BaseQueryRunner {
             }
             else {
                 this.driver.connection.logger.logQueryError(err, query, parameters, this);
+                this.broadcaster.broadcastAfterQueryEvent(broadcasterResult, query, parameters, false, undefined, undefined, err);
                 throw new QueryFailedError(query, parameters, err);
             }
         }
+        finally {
+            await broadcasterResult.wait();
+        }
     }
     /**
      * Returns raw data stream.
@@ -1851,14 +1880,15 @@ export class CockroachQueryRunner extends BaseQueryRunner {
                         }
                     }
                 }
-                if (dbColumn["is_generated"] === "YES" &&
+                if ((dbColumn["is_generated"] === "YES" ||
+                    dbColumn["is_generated"] === "ALWAYS") &&
                     dbColumn["generation_expression"]) {
                     tableColumn.generatedType =
                         dbColumn["generated_type"] === "s"
                             ? "STORED"
                             : "VIRTUAL";
                     // We cannot relay on information_schema.columns.generation_expression, because it is formatted different.
-                    const asExpressionQuery = await this.selectTypeormMetadataSql({
+                    const asExpressionQuery = this.selectTypeormMetadataSql({
                         schema: dbTable["table_schema"],
                         table: dbTable["table_name"],
                         type: MetadataTableType.GENERATED_COLUMN,