typeorm 0.2.40-dev.e80f97d → 0.2.41-dev.2d0abe7

package/browser/driver/sqlserver/SqlServerQueryRunner.js

@@ -18,6 +18,7 @@ import { Query } from "../Query";
 import { MssqlParameter } from "./MssqlParameter";
 import { TypeORMError } from "../../error";
 import { QueryLock } from "../../query-runner/QueryLock";
+import { MetadataTableType } from "../types/MetadataTableType";
 /**
  * Runs queries on a single SQL Server database connection.
  */
@@ -2138,7 +2139,7 @@ var SqlServerQueryRunner = /** @class */ (function (_super) {
                         }).join(" OR ");
                         query = dbNames.map(function (dbName) {
                             return "SELECT \"T\".*, \"V\".\"CHECK_OPTION\" FROM " + _this.escapePath(_this.getTypeormMetadataTableName()) + " \"t\" " +
-                                ("INNER JOIN \"" + dbName + "\".\"INFORMATION_SCHEMA\".\"VIEWS\" \"V\" ON \"V\".\"TABLE_SCHEMA\" = \"T\".\"SCHEMA\" AND \"v\".\"TABLE_NAME\" = \"T\".\"NAME\" WHERE \"T\".\"TYPE\" = 'VIEW' " + (viewsCondition ? "AND (" + viewsCondition + ")" : ""));
+                                ("INNER JOIN \"" + dbName + "\".\"INFORMATION_SCHEMA\".\"VIEWS\" \"V\" ON \"V\".\"TABLE_SCHEMA\" = \"T\".\"SCHEMA\" AND \"v\".\"TABLE_NAME\" = \"T\".\"NAME\" WHERE \"T\".\"TYPE\" = '" + MetadataTableType.VIEW + "' " + (viewsCondition ? "AND (" + viewsCondition + ")" : ""));
                         }).join(" UNION ALL ");
                         return [4 /*yield*/, this.query(query)];
                     case 4:
@@ -2349,14 +2350,14 @@ var SqlServerQueryRunner = /** @class */ (function (_super) {
                                             dbConstraint["TABLE_SCHEMA"] === dbColumn["TABLE_SCHEMA"] &&
                                             dbConstraint["TABLE_CATALOG"] === dbColumn["TABLE_CATALOG"] &&
                                             dbConstraint["COLUMN_NAME"] === dbColumn["COLUMN_NAME"]); });
-                                        var uniqueConstraint = columnConstraints.find(function (constraint) { return constraint["CONSTRAINT_TYPE"] === "UNIQUE"; });
-                                        var isConstraintComposite = uniqueConstraint
-                                            ? !!dbConstraints.find(function (dbConstraint) { return dbConstraint["CONSTRAINT_TYPE"] === "UNIQUE"
+                                        var uniqueConstraints = columnConstraints.filter(function (constraint) { return constraint["CONSTRAINT_TYPE"] === "UNIQUE"; });
+                                        var isConstraintComposite = uniqueConstraints.every(function (uniqueConstraint) {
+                                            return dbConstraints.some(function (dbConstraint) { return dbConstraint["CONSTRAINT_TYPE"] === "UNIQUE"
                                                 && dbConstraint["CONSTRAINT_NAME"] === uniqueConstraint["CONSTRAINT_NAME"]
                                                 && dbConstraint["TABLE_SCHEMA"] === dbColumn["TABLE_SCHEMA"]
                                                 && dbConstraint["TABLE_CATALOG"] === dbColumn["TABLE_CATALOG"]
-                                                && dbConstraint["COLUMN_NAME"] !== dbColumn["COLUMN_NAME"]; })
-                                            : false;
+                                                && dbConstraint["COLUMN_NAME"] !== dbColumn["COLUMN_NAME"]; });
+                                        });
                                         var isPrimary = !!columnConstraints.find(function (constraint) { return constraint["CONSTRAINT_TYPE"] === "PRIMARY KEY"; });
                                         var isGenerated = !!dbIdentityColumns.find(function (column) { return (column["TABLE_NAME"] === dbColumn["TABLE_NAME"] &&
                                             column["TABLE_SCHEMA"] === dbColumn["TABLE_SCHEMA"] &&
@@ -2416,7 +2417,7 @@ var SqlServerQueryRunner = /** @class */ (function (_super) {
                                             : undefined;
                                         tableColumn.isNullable = dbColumn["IS_NULLABLE"] === "YES";
                                         tableColumn.isPrimary = isPrimary;
-                                        tableColumn.isUnique = !!uniqueConstraint && !isConstraintComposite;
+                                        tableColumn.isUnique = uniqueConstraints.length > 0 && !isConstraintComposite;
                                         tableColumn.isGenerated = isGenerated;
                                         if (isGenerated)
                                             tableColumn.generationStrategy = "increment";
@@ -2583,25 +2584,26 @@ var SqlServerQueryRunner = /** @class */ (function (_super) {
     };
     SqlServerQueryRunner.prototype.insertViewDefinitionSql = function (view) {
         return __awaiter(this, void 0, void 0, function () {
-            var parsedTableName, _a, expression, _b, query, parameters;
-            return __generator(this, function (_c) {
-                switch (_c.label) {
+            var parsedTableName, _a, expression;
+            return __generator(this, function (_b) {
+                switch (_b.label) {
                     case 0:
                         parsedTableName = this.driver.parseTableName(view);
                         if (!!parsedTableName.schema) return [3 /*break*/, 2];
                         _a = parsedTableName;
                         return [4 /*yield*/, this.getCurrentSchema()];
                     case 1:
-                        _a.schema = _c.sent();
-                        _c.label = 2;
+                        _a.schema = _b.sent();
+                        _b.label = 2;
                     case 2:
                         expression = typeof view.expression === "string" ? view.expression.trim() : view.expression(this.connection).getQuery();
-                        _b = __read(this.connection.createQueryBuilder()
-                            .insert()
-                            .into(this.getTypeormMetadataTableName())
-                            .values({ type: "VIEW", database: parsedTableName.database, schema: parsedTableName.schema, name: parsedTableName.tableName, value: expression })
-                            .getQueryAndParameters(), 2), query = _b[0], parameters = _b[1];
-                        return [2 /*return*/, new Query(query, parameters)];
+                        return [2 /*return*/, this.insertTypeormMetadataSql({
+                                type: MetadataTableType.VIEW,
+                                database: parsedTableName.database,
+                                schema: parsedTableName.schema,
+                                name: parsedTableName.tableName,
+                                value: expression
+                            })];
                 }
             });
         });
@@ -2617,27 +2619,23 @@ var SqlServerQueryRunner = /** @class */ (function (_super) {
      */
     SqlServerQueryRunner.prototype.deleteViewDefinitionSql = function (viewOrPath) {
         return __awaiter(this, void 0, void 0, function () {
-            var parsedTableName, _a, qb, _b, query, parameters;
-            return __generator(this, function (_c) {
-                switch (_c.label) {
+            var parsedTableName, _a;
+            return __generator(this, function (_b) {
+                switch (_b.label) {
                     case 0:
                         parsedTableName = this.driver.parseTableName(viewOrPath);
                         if (!!parsedTableName.schema) return [3 /*break*/, 2];
                         _a = parsedTableName;
                         return [4 /*yield*/, this.getCurrentSchema()];
                     case 1:
-                        _a.schema = _c.sent();
-                        _c.label = 2;
-                    case 2:
-                        qb = this.connection.createQueryBuilder();
-                        _b = __read(qb.delete()
-                            .from(this.getTypeormMetadataTableName())
-                            .where(qb.escape("type") + " = 'VIEW'")
-                            .andWhere(qb.escape("database") + " = :database", { database: parsedTableName.database })
-                            .andWhere(qb.escape("schema") + " = :schema", { schema: parsedTableName.schema })
-                            .andWhere(qb.escape("name") + " = :name", { name: parsedTableName.tableName })
-                            .getQueryAndParameters(), 2), query = _b[0], parameters = _b[1];
-                        return [2 /*return*/, new Query(query, parameters)];
+                        _a.schema = _b.sent();
+                        _b.label = 2;
+                    case 2: return [2 /*return*/, this.deleteTypeormMetadataSql({
+                            type: MetadataTableType.VIEW,
+                            database: parsedTableName.database,
+                            schema: parsedTableName.schema,
+                            name: parsedTableName.tableName
+                        })];
                 }
             });
         });